1331 Commits

Author SHA1 Message Date
Maurice Parker
715671edad Rebuild the Feeds list when coming back to it from the Timeline while the root split is collapsed to filter read Feeds. 2020-03-28 01:43:54 -05:00
Maurice Parker
bd1c73c1d3 Automatically remove Feed items if they should be filtered. Issue #1949 2020-03-27 18:24:57 -05:00
Maurice Parker
a13f10441f Change pointer interaction to encompass the complete button. 2020-03-26 11:20:13 -05:00
Maurice Parker
6c06c7791c Add interaction to buttons that were missing it. Issue #1945 2020-03-25 08:55:02 -05:00
Maurice Parker
450ddbd364 Refactored new pointer interaction code to be more simple. 2020-03-24 18:27:54 -05:00
Maurice Parker
bd75df7294 Add pointer interaction for timeline header button. Issue #1943 2020-03-24 16:42:46 -05:00
Maurice Parker
d615a0a894 Fix bug where clean up shortcut wouldn't clear articles if wrong setting was off. 2020-03-24 16:00:01 -05:00
Maurice Parker
85cbd204b3 Fixed clean up keyboard shortcut 2020-03-22 10:23:31 -05:00
Maurice Parker
97226f543b Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842 2020-03-22 10:18:07 -05:00
Maurice Parker
9f516caa35 Don't use borders on nested tables. Issue #1936 2020-03-21 17:19:03 -05:00
Maurice Parker
e7436925ad Don't remove filtered feeds on article downloads. 2020-03-20 10:34:18 -05:00
Maurice Parker
316e4e62b2 Removed separator insets from layout code as they were no longer needed. 2020-03-20 06:58:11 -05:00
Maurice Parker
8a75defee9 Set row height when table is empty and set to automatic when articles are present. Issue #1919 2020-03-18 16:06:05 -05:00
Maurice Parker
1d26bc8c70
Revert "Set proper cell height for empty article array" 2020-03-18 15:55:33 -05:00
Maurice Parker
36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker
37cf7fae1d Fix regression that prevented Always Show Reader View from working. 2020-03-16 07:58:51 -05:00
Maurice Parker
07042b8a2a Implemented Clean Up keyboard shortcut. Issue #1915 2020-03-15 18:15:52 -05:00
Flowinho
47dc34db5d Fix Typo
This contains work related to issue #1910
2020-03-15 22:44:12 +01:00
Flowinho
2ade0140bc Set proper cell height for empty article array
Contains work related to #1800

This one took me a while to figure out since they amount of articles is tied to the coordinator.

- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.

Greetings from southern germany!
2020-03-15 22:31:54 +01:00
Maurice Parker
acaf3fac9f Add user agent to plist. Issue #1913 2020-03-15 11:48:07 -05:00
Maurice Parker
a620a20588 Add the option to select the user interface color palette. Issue #1900 2020-03-15 04:25:25 -05:00
Maurice Parker
07dc4f1f10 Don't start the article extractor if we only want to store the article. Issue #1494 2020-03-14 06:31:14 -05:00
Nate Weaver
e6af6ece42 Add top and bottom margins to figure elements 2020-03-13 22:01:07 -05:00
Nate Weaver
9a3fe5caa5 Add a max-width to body 2020-03-13 21:36:16 -05:00
Maurice Parker
66e7e425aa Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806 2020-03-13 17:06:53 -05:00
Maurice Parker
833c336f2f Only show the timeline next read button when the root split view controller is collapsed. Issue #1822 2020-03-13 16:03:42 -05:00
Maurice Parker
49257970af Removed testing code. Issue #1810 2020-03-13 15:35:33 -05:00
Maurice Parker
2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width
Bugfix progress indicator max width
2020-03-13 15:31:30 -05:00
Maurice Parker
7922efab1e
Merge pull request #1899 from flowinho/ios-release
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
Flowinho
ce428d2cc6 Hide articleExtractor and actionBarButtonItem 2020-03-13 20:21:18 +01:00
Maurice Parker
52be6e5743 Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731 2020-03-13 10:17:00 -05:00
Maurice Parker
d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
Add background to pure white icons
2020-03-13 10:04:56 -05:00
Flowinho
130691db34 Revert to old logic 2020-03-13 14:21:38 +01:00
Flowinho
ee86b1a148 Apply background if feed-icon is bright 2020-03-13 11:54:31 +01:00
Maurice Parker
77fd3020cc Correct font used to specify font size. Issue #1878 2020-03-12 19:01:10 -05:00
Nate Weaver
76dd3abff2 Properly style footnotes that have been absoluted 2020-03-12 18:32:42 -05:00
Maurice Parker
dfdf19e17f Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-03-12 18:07:49 -05:00
Maurice Parker
61a2e95d2b Manually specify the font size to work around a WKWebView resizing bug. Issue #1878 2020-03-12 18:07:40 -05:00
Maurice Parker
c19bf93586
Merge pull request #1890 from flowinho/ios-release
Align feedname and date correctly if there is no title or summary
2020-03-12 17:03:58 -05:00
Flowinho
0a3713e078 Align feedname and date correctly if there is no title or summary 2020-03-12 22:57:30 +01:00
Maurice Parker
47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Flowinho
da64f65c7b Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16 Adding dynamic width algorithm to the titleLabel
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
Flowinho
97c79202fc Added missing constraints to the UISwitch elements 2020-03-12 17:56:43 +01:00
Maurice Parker
22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker
27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker
76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker
38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker
9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00