Commit Graph

1406 Commits

Author SHA1 Message Date
Noelle Leigh 7f60b3d330 fix iOS/Settings/SettingsViewController.swift 2020-07-26 06:37:40 -05:00
Rizwan Mohamed Ibrahim 64a4d9bbe5
Fix localised comments 2020-07-14 22:04:20 +05:30
Rizwan Mohamed Ibrahim 1a3bbf7dbf
Add a11y label for starred status on master timeline 2020-07-14 18:08:07 +05:30
Rizwan Mohamed Ibrahim 1427e1d8c6
Add a11y label for expanded/collapsed status for Master Feed 2020-07-14 18:07:29 +05:30
Stuart Breckenridge 7183b853bd
#2256
Fixes #2256
2020-07-13 14:24:57 +08:00
Maurice Parker e1c8479515 Prevent Twitter embeds from cutting off. Issue #2166 2020-07-07 11:47:52 -05:00
Rizwan Mohamed Ibrahim 687b454cd7
fix mark all as read context menu on Accounts 2020-07-01 12:30:39 +05:30
Brent Simmons 4ed6ccd52b Fixed warning from Apple upload system — NSExtensionActivationSupportsText needed to be a boolean, not a string. 2020-06-27 18:15:26 -07:00
Maurice Parker 95704c7f3e Prefix accessibility label with unread when item is unread. Issue #2142 2020-06-20 11:05:54 -05:00
Maurice Parker d453a94330 Make unread and star animations cancel on cell reuse. Issue #2054 2020-06-18 17:37:29 -05:00
Maurice Parker b3c0fac5d3 Save the previous feed instead of relying on the currentFeedIndexPath which may have been reset. Issue #2139 2020-06-18 16:16:30 -05:00
Maurice Parker 5356189654 Optimize unread count look up 2020-06-16 08:32:01 -05:00
Maurice Parker 7dd20560c3 Remove reset of web view controller when returning to foreground. 2020-06-16 08:09:28 -05:00
Maurice Parker 4075da2ee8 Fix removal of tap zones when removing old web views 2020-06-16 08:07:54 -05:00
Maurice Parker 3b2fcb74fd
Merge pull request #2134 from Mackarous/master
Disable selection while applying snapshot
2020-06-15 17:23:23 -05:00
Andrew Mackarous 5cc2605add Fix issue #2132 2020-06-15 02:42:30 -04:00
Brian Sanders 6aa7b009f8 Tweaks the scroll behavior when space bar is pressed
The overlap is 2 lines of text at the standard system font size.
2020-06-13 19:17:17 -04:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Maurice Parker 3ce20e26ff
Merge pull request #2102 from stuartbreckenridge/issue-1932
Adds Title when sharing to Tweetbot and Buffer
2020-05-23 15:02:03 -05:00
Stuart Breckenridge 8b3e5d7cfd
Adds Title when sharing to Tweetbot and Buffer
Fixes #1932
2020-05-22 20:53:22 +08:00
Stuart Breckenridge 98c8ea6d9f
disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Stuart Breckenridge 2297d218c0
Uses selector syntax. 2020-05-18 09:23:42 +08:00
Stuart Breckenridge 6224dfad03
Notification Permission Requests
Fixes #2057

• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.

• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.

`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
Maurice Parker c2b749a74c Rebuild backing stores immediately when deselecting a Feed. Issue #2079 2020-05-15 17:06:49 -05:00
Maurice Parker 4e22489d97 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-05-15 10:45:22 -05:00
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Rizwan Mohamed Ibrahim 04458adee5
adds "Mark All Read" shortcut for feeds list 2020-05-14 18:13:41 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb
adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Maurice Parker 8fe746fabf
Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim bfef02e18f
adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker 46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Maurice Parker 211e44fff5 Remove flash when changing out the web view upon returning to the foreground 2020-05-06 17:35:38 -05:00
Maurice Parker d4cffa28f2 Rollback disclosure button reference hold since it does nothing to stop the crash 2020-05-06 14:58:47 -05:00
Maurice Parker 502ff3e019 Don't multiply by the device pixel ratio if that will put us over the canvas limit 2020-05-06 14:55:34 -05:00
Maurice Parker 5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Stuart Breckenridge f58ac4d160
Wraps Alert strings in `NSLocalizedString`
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
Stuart Breckenridge e825a5d516
Adds handling of `tel` url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge f901436211
mailto links now open on iOS
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
Maurice Parker e2267d14ee Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034 2020-05-01 16:34:19 -05:00
Maurice Parker d5a4f1625a Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032 2020-05-01 16:24:29 -05:00