Commit Graph

46 Commits

Author SHA1 Message Date
Brent Simmons 2d33de1205 Fix references to addOperation, which is now just add. 2020-02-05 21:18:29 -08:00
Kiel Gillard b87882a919 Log failures attempting to add new feeds to a Feedly account to help debug #1691 2020-01-31 17:00:30 +11:00
Kiel Gillard a339b05bf8 Santizes right to left div elements from Feedly content. 2020-01-31 07:55:50 +11:00
Kiel Gillard fb69a2bc54 Fix the logging of Feedly errors. #1628. 2020-01-21 18:31:41 +11:00
Brent Simmons a2bcdb1cfd Fix the progress indicator bug I had introduced in working on FeedlyOperation. Make sure FeedlyOperation calls downloadProgress.completeTask(), and make sure that all paths lead there. 2020-01-19 16:55:39 -08:00
Brent Simmons 6181f416a4 Revise FeedlyOperation to work with MainThreadOperation properly. We’re still using inheritance — FeedlyOperation is a base class. I tried and failed to come up with a better solution. Everything other solution resulted in a lot of boilerplate code being replicated. 2020-01-19 14:19:06 -08:00
Kiel Gillard 912a3acb35 Subscribing to a Feedly feed only downloads the first page worth of content, not each and every page. Maybe related to #1408. 2020-01-17 17:16:52 +11:00
Kiel Gillard c18575ea85 Let Feedly users add to the uncategorized collection/folder. 2020-01-17 15:25:57 +11:00
Brent Simmons 80542bee12 Add missing calls to super.run() in FeedlyOperation subclasses. 2020-01-15 22:51:00 -08:00
Brent Simmons 39db00c022 Use MainThreadOperationQueue with Feedly syncing. 2020-01-15 21:30:37 -08:00
Kiel Gillard 325f220181 Ignore the remote article status if the sync database contains a pending (and therefore more recent) status. Fixes #1516. 2020-01-13 18:04:58 +11:00
Kiel Gillard 745b5d8cb8 Fetch article contents from Feedly by ids rather than paging through streams up until the last successful sync date. Issues #1453 #1398 #1408 #1429 2020-01-11 10:45:45 +11:00
Kiel Gillard 6922b6ddec Use string-based key paths instead of Swift key paths for FeedlyOperation. #1481 2020-01-06 08:59:08 +11:00
Kiel Gillard 2ee50054dc Indicate FeedlyOperations are asynchronous. 2020-01-02 10:00:09 +11:00
Brent Simmons 51faf77e59 Update isExecuting and isFinished in a way that should make NSOperationQueue happy. Hopefully this fixes a mystery crash bug. 2019-12-31 15:40:05 -08:00
Kiel Gillard 3b47edfba7 Models the feed identifier of feedly articles as an optional since it seems the Feedly API will not always provide one (despite the API documentation).
Additional, more elegantly handle the failure to parse an article when Feedly does not provide a matching feed.
2019-12-31 08:47:27 +11:00
Kiel Gillard 40dacd6522 Update set starred articles operation to honour database errors. 2019-12-18 09:45:30 +11:00
Kiel Gillard 5a9b138a9d Update set unraed articles operation to honour database errors. 2019-12-18 09:42:08 +11:00
Kiel Gillard 6fb0e2e0d0 Honour the error case when ingesting read and star statuses 2019-12-18 09:32:58 +11:00
Kiel Gillard bd307cbb6c Give the FeedlySyncStarredArticlesOperation a delegate so that if the database becomes suspended, the remainder of the sync operation cancels. 2019-12-18 09:26:57 +11:00
Kiel Gillard 311f5b2e81 Check the account update error when update a Feedly account and finish with an error, indicating to its delegate that remaining operations should cancel. 2019-12-18 09:19:00 +11:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Brent Simmons 9516392c61 Make two more Feedly operations compatible with DatabaseQueue changes. 2019-12-16 17:03:05 -08:00
Brent Simmons 3883d24ebe Simplify FeedlySetUnreadArticlesOperation. 2019-12-16 16:26:35 -08:00
Brent Simmons 67f65545b3 Continue changes mandated by DatabaseQueue changes. 2019-12-16 15:55:37 -08:00
Brent Simmons 3981312d6f Update sync code to handle async selectForProcessing. 2019-12-16 12:49:07 -08:00
Maurice Parker 43bf65b7a6 Rename occurrences of completionHandler to completion. 2019-12-14 17:14:55 -07:00
Kiel Gillard 2401b0be1b Fix compilation issues with tests after Account API changes. 2019-12-09 18:54:29 +11:00
Brent Simmons 0b87531f2f Make fetchStarredArticles an async call. Also have it respect subscribed-to feed IDs. 2019-12-07 22:23:44 -08:00
Brent Simmons a561ea9484 Fetch unread article IDs async. Also: fetch only for feeds currently subscribed-to. Fix #1218. 2019-12-07 20:57:23 -08:00
Kiel Gillard f58bb38e8f Remove unused code. 2019-12-05 19:02:40 +11:00
Kiel Gillard 7563d1b2c6 Search Feedly for the best feed (and its identifier) for the URL entered when adding a new feed. #1300 2019-12-05 19:02:40 +11:00
Kiel Gillard 5cd90a9be7 Fix syncing of unread articles with Feedly when adding new or existing feeds to folders. #1289 #1332 2019-11-30 10:14:58 +11:00
Kiel Gillard 757c469e00 Improves the test coverage of syncing and progress reporting, identifying and fixing a bug when cancelling. #1328 2019-11-30 08:00:46 +11:00
Maurice Parker 991ecf2a71
Merge pull request #1363 from kielgillard/1326-missing-data
Adds public logging of the Feedly errors…
2019-11-27 09:55:22 -06:00
Kiel Gillard 1891523d0d Adds public logging of the Feedly errors to help identify the missing key in #1326. 2019-11-27 19:04:55 +11:00
Kiel Gillard 2f96e8b8a6 Feedly operations can optionally report their progress. #1328 2019-11-27 18:32:18 +11:00
Kiel Gillard 55faf550d7 Implements logout for Feedly accounts. 2019-11-15 19:09:14 +11:00
Maurice Parker afd9783711 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-11-14 20:11:50 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Kiel Gillard b317a99594 Fix failing Feedly tests. 2019-11-15 09:32:02 +11:00
Kiel Gillard 3ed5a43de3 Improves the behaviour and fixes some issues with cancelling of Feedly operations. 2019-11-15 07:59:44 +11:00
Kiel Gillard 6bef313937 Feedly accounts now refresh their access tokens on initialisation. 2019-11-07 18:55:05 +11:00
Kiel Gillard 434b11ed17 Ensures Feedly status operations finish at the right time. In part, this is achieved by adding and using completion handlers to the asynchronous ensure status API. 2019-11-06 13:26:12 +11:00
Kiel Gillard 1a1ee0fa17 Fixes an issue where sending article statuses to Feedly was finishing prematurely. 2019-11-06 11:22:10 +11:00
Kiel Gillard 4f70cb6040 Improves test coverage in Feedly. Adds callbacks to SyncDatabase. Content is paged from Feedly. Unread status is set before articles are ingested. 2019-11-02 10:29:34 +11:00