Commit Graph

1835 Commits

Author SHA1 Message Date
Stuart Breckenridge 25f9896832 Localized strings for errors 2021-09-24 09:28:32 +08:00
Stuart Breckenridge bd6095517b is missing instead of not found 2021-09-23 20:19:41 +08:00
Stuart Breckenridge 88674d2fc4 Consistent theme error messages on iOS 2021-09-23 20:16:09 +08:00
Stuart Breckenridge 82a62712ce
Better error messages for decoding issues 2021-09-21 10:43:12 +08:00
Stuart Breckenridge c29afd2677 try? changed to try with error handling 2021-09-21 09:22:45 +08:00
Stuart Breckenridge 78e0595708 Various ThemeDownloader Updates
- `try` added where applicable to ArticleTheme inits
- `ArticleThemePlist` has fixed spelling of theme identifier and conforms to Equatable
- `ArticleTheme` now uses `ArticleThemePlist`
-  `ArticleThemeDownloader` is now a class
- `ArticleThemeDownloader` will now download themes to Application Support/NetNewsWire/Downloads on macOS and iOS.
- `ArticleThemeDownloader` will remove downloaded themes from the Download folder when the application is closed.
- macOS app delegate now observes for theme download fails
- Error display code moved from SceneDelegate to SceneCoordinator so that it can use existing presentError on rootVC.
2021-09-21 09:10:56 +08:00
Stuart Breckenridge a1b01384d3 refactors downloader code for macOS & iOS
More consistent code across platforms.
2021-09-20 19:34:25 +08:00
Stuart Breckenridge eb8f27b457 Removes files if unzip is not successful 2021-09-20 09:48:31 +08:00
Stuart Breckenridge afd952fbc2 refactors iOS theme downloads 2021-09-20 09:36:09 +08:00
Stuart Breckenridge 105a78bc0f Merge remote-tracking branch 'origin/main' into nnwtheme-downloader 2021-09-20 06:24:32 +08:00
Stuart Breckenridge 4fab4ffa7c download themes using url scheme
this build enables iOS functionality only.
2021-09-19 20:31:45 +08:00
Maurice Parker 04d7ab188f Add import button to Themes listing scene 2021-09-18 10:49:30 -05:00
Maurice Parker 42bcaf7e55 Extract Theme Import logic so that it can be reused 2021-09-18 10:28:19 -05:00
Maurice Parker ee2e2f8fa6 Merge branch 'ios-release' 2021-09-15 05:22:18 -05:00
Maurice Parker 5299134e01 Fix regression that broke state restoration on the iPhone 2021-09-15 05:05:58 -05:00
Maurice Parker 3fdb4a94ae Move Sepia theme to correct location and clean up the header links 2021-09-15 04:16:35 -05:00
Maurice Parker f44308c0c5 Make state restoration work on both the iPad and the iPhone 2021-09-13 02:22:15 -05:00
Maurice Parker 5001d82355 Restore article scroll position on iOS 2021-09-13 01:11:23 -05:00
Maurice Parker 87700325cf Changed to use preferredURL incase we run into any malformed links 2021-09-12 21:34:47 -05:00
Maurice Parker fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285.
2021-09-12 21:17:50 -05:00
Maurice Parker 35b913f4a0 Add the ability to delete a theme on iOS 2021-09-12 16:40:59 -05:00
Maurice Parker 04ff96c60a Fix variable name 2021-09-12 16:35:49 -05:00
Maurice Parker 98999c0cc1 Add Theme selector to iOS 2021-09-12 16:18:55 -05:00
Maurice Parker 1eedc22149 Fix warning about opening files in place 2021-09-12 15:49:12 -05:00
Maurice Parker 7646029f2e Reload the web view when the Theme changes 2021-09-12 15:44:24 -05:00
Maurice Parker cad91d9415 Add the ability to import themes on iOS 2021-09-12 14:46:15 -05:00
Maurice Parker 9851629ec9 Implement a way to distribute themes with NetNewsWire 2021-09-12 11:53:34 -05:00
Maurice Parker 8633516cc6 Merge branch 'ios-release' 2021-09-11 14:28:20 -05:00
Maurice Parker 25946f3c5a Defer the selection of the feed and article on state restoration to avoid crashes on iPad's running iOS 15 in landscape mode as they restore article selected state. Fixes #3201 2021-09-11 14:28:00 -05:00
Maurice Parker b568f03edc Unify the stylesheets into a single one to make building themes easier 2021-09-08 04:58:26 -05:00
Maurice Parker e3245f1144 Fix some incorrectly named variables 2021-09-07 20:12:21 -05:00
Maurice Parker 491896e334 Change theme file extension from nnwstyle to nnwtheme 2021-09-07 17:06:41 -05:00
Maurice Parker 512e83d786 Refactor Styles to now be Themes 2021-09-07 16:58:06 -05:00
Maurice Parker cfd2db58c5 Remove references to nnwstyle.icns so that the system will generate a document icon for us. 2021-09-07 14:31:33 -05:00
Maurice Parker 09647be51b Merge branch 'ios-release' 2021-09-06 20:31:24 -05:00
Maurice Parker 45c47f3752 Add nnwstyle as an imported type 2021-09-06 20:29:40 -05:00
Maurice Parker 56bbfe713b Fix regression that prevented universal links from working 2021-09-01 14:13:04 -05:00
Maurice Parker 285e9a40fa
Merge pull request #3262 from stuartbreckenridge/ios-browser-behaviour
Adds option to open article links in NetNewsWire or in the default browser.
2021-08-26 17:48:30 -05:00
Stuart Breckenridge 5765a186a6 Fixes label when using larger text sizes. 2021-08-27 06:36:25 +08:00
Stuart Breckenridge 94624cecf4 Changes
Info.plist - removes unused query schemes

Settings.storyboard
- changes accentColor to primaryAccentColor
- fixes leading constraint on label
2021-08-27 06:21:51 +08:00
Stuart Breckenridge 2b6bd40179
Update Credits.rtf 2021-08-26 19:23:02 +08:00
Stuart Breckenridge 178e737040 Converts to a browser preference to a `Bool`. 2021-08-26 10:27:23 +08:00
Maurice Parker 0f0cf34ef8 Add nnwstyle bundle definitions 2021-08-25 20:22:58 -05:00
Stuart Breckenridge 3bc18e2891 Reduces Browsers to in-app and system default 2021-08-25 15:05:18 +08:00
Maurice Parker ba279d2a6e Make the Styles folder configurable so that it can be in different places on macOS and iOS. 2021-08-24 20:20:20 -05:00
Maurice Parker 2e7bb5b752 Remove optimization that was preventing selection changes from rebuilding the sidebar. 2021-08-24 17:56:36 -05:00
Maurice Parker 168020cba2 Always updates the tree controller when collapsing and expanding. Fixes #3040 2021-08-24 16:55:44 -05:00
Stuart Breckenridge 7a726e6d8a
removes unused preference 2021-08-23 23:12:38 +08:00
Stuart Breckenridge 08a1120e00
Adds app default option
Adds app defaults option for controlling link opening preferences.

Adds browser logic and images.

Browser Manager Updates

- Handles deletion of current browser
- Fixes detection of installed browsers by moving URL Types to LSApplicationQuery
- Updates icons to glyphs
- Context menus update

tidy up

- removes browser specific options and offers in-app or default browser options (can be enabled via a bool)
- adds 1Password as an option
- removes custom wording on context menus

Fixes

- makes sure browser options are available on iPad
- uses VibrantCell
- Changes Settings title to "Open Links In"
2021-08-23 23:01:48 +08:00
Maurice Parker b3773ad01b Implement the WKUIDelegate method that is reached when JavaScript in a web view invokes window.open(). This ensures that attempts to open links from code, such as from the YouTube embedded video player, work as expected. Fixes #3088. 2021-07-29 16:48:42 -05:00
Maurice Parker 9d6bfc87b0 Fix crash on iOS 15 2021-07-16 15:39:23 -05:00
Maurice Parker cc19b6b13e Fix crash on iOS 15 2021-07-16 14:28:56 -05:00
Maurice Parker 3ea427bd2d Fix open in browser when the article is selected. Fixes #3215 2021-07-06 18:50:48 -05:00
Maurice Parker c2413cda37 Restore alpha of the indicators to 1 incase the animation completion handler doesn't get called. Fixes #3156 2021-06-23 03:24:23 -05:00
Maurice Parker 86ca397221 Ignore key commands when the web view has focus. Fixes #3179 2021-06-23 02:44:34 -05:00
Maurice Parker f1dbc2de71 Merge branch 'ios-release' 2021-06-22 19:14:50 -05:00
Brent Simmons 8be9bf6861 Update Help book URL. 2021-06-20 16:03:54 -07:00
Maurice Parker cc176134ea Put in a slight delay to prevent the screen from flashing. Fixes #3038 2021-06-17 19:23:41 -05:00
Maurice Parker d6aa5f23ba Don't allow the creation of iCloud accounts if iCloud and iCloud Drive aren't enabled. Fixes #3106 2021-06-17 19:05:39 -05:00
Stuart Breckenridge 50327a97d3 Password Updates
• Removes LD_RUNPATH_SEARCH_PATHS which caused an issue when building for running on device
• Autofill enabled on macOS 11 +
• Adds sender for 1Password (for iPad)
2021-06-17 12:38:53 +08:00
Stuart Breckenridge a86f1d8a49 FreshRSS will use the entered API url 2021-06-16 14:55:11 +08:00
Stuart Breckenridge db9d326457 moved bridging header to iOS resources 2021-06-16 14:50:53 +08:00
Stuart Breckenridge 0e19a9d98a Adds 1Password Extension to UIKit. 2021-06-16 14:41:51 +08:00
Maurice Parker 29458fb03b Change to use destructive style on delete button. Fixes #3159 2021-06-15 21:33:23 -05:00
Maurice Parker b27be9c8ea Don't animate the Feeds rebuild when responding to the initial unread count initialization. Fixes #2985 2021-06-15 16:35:29 -05:00
Brent Simmons 0d0f1e4908 Replace “don't” with “don’t” everywhere. 2021-05-31 16:01:01 -07:00
Brent Simmons ae63d0feb7 Add a warning about iCloud sync being slow sometimes. Also: in user-facing text, change “subscriptions” to “feeds.” We want to use the word “feed” — a “subscription” makes people think of IAP. 2021-05-31 15:52:56 -07:00
Maurice Parker f9af3c786b Merge branch 'ios-candidate' 2021-05-25 20:12:50 -05:00
Stuart Breckenridge eb7860eeb9
Adds new Tweetbot share extension identifier.
Fixes #3123 on iOS.
2021-05-23 18:24:27 +08:00
Brent Simmons b83b4904e7 Update credits, dedication, and copyright on iOS. Fix #3005. 2021-05-22 21:50:32 -07:00
Brent Simmons 251b19d26c Tweak text for Feed Providers explanation. Now: “Feed Providers allow you to subscribe to some pages as if they were RSS feeds.” 2021-05-16 20:22:15 -07:00
Brent Simmons 5490e3ab49 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2021-05-08 12:42:52 -07:00
Brent Simmons 9d2c8f000f Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance. 2021-05-08 12:42:44 -07:00
Maurice Parker 9b53fcbe37 Fix regression that prevented the timeline and article from being cleared when the current feed is deleted. Fixes #3054 2021-05-06 20:07:49 -05:00
Maurice Parker 7e820c58e5 Reload the webview when rotating the device on an iPhone. Fixes #3041 2021-05-04 21:44:55 -05:00
Rob Mathers 8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Brent Simmons 28b00260e0 Cache IconImage for feeds on the Feeds screen.
Empty the cache, and reload visible cells, when the trait collection changes, so that we get the proper icons for light/dark mode. This caching provides a small-but-worthwhile performance increase for the Feeds screen.
2021-05-01 12:29:18 -07:00
Duncan Babbage bc056e4952 Mark as read just before display. Fixes #3037
Marking an article as read just before navigating to it prevents the read status from flashing unread/read on display when swiping to new unread articles, or navigating with the next article toolbar button.
2021-04-29 22:46:52 +12:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Duncan Babbage 7e71814011 Rename accessibility action labels as per #3072 2021-04-26 08:19:31 +12:00
Stuart Breckenridge 2023d59e5a
adds helper text
fixes #3055 on iOS
2021-04-25 16:46:24 +08:00
Brent Simmons 1d4ef582a7 Simplify iconImage:didSet. Move background color update to a private helper function. 2021-04-24 17:55:48 -07:00
Brent Simmons 954a676cbe
Merge pull request #3064 from stuartbreckenridge/fix/3035
Fixes #3035
2021-04-24 11:57:23 -07:00
Brent Simmons 9540316e6f
Merge pull request #3065 from stuartbreckenridge/fix/3062
Fixes #3062
2021-04-24 11:56:16 -07:00
Stuart Breckenridge 72e68a62f8
further typo fix 2021-04-24 19:11:53 +08:00
Stuart Breckenridge d0c3f05f0e
Delete change to Remove 2021-04-24 15:16:20 +08:00
Stuart Breckenridge 925bbadecb
Fixes #3062 2021-04-24 15:10:26 +08:00
Stuart Breckenridge 15fb5637ff
Fixes #3035
MarkAllAsReadAction will check for and handle SmartFeeds.
2021-04-24 15:05:11 +08:00
Stuart Breckenridge cde7bf9589
restores storyboard to previous commit 2021-04-22 09:00:06 +08:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker 6a4c761ed8 Merge branch 'ios-candidate' into main 2021-04-15 14:30:32 -05:00
Maurice Parker 0ac3ba0bbb Change force unwraps so that we just fail on the move instead of crashing 2021-04-13 07:38:41 -05:00
Maurice Parker d418835086 Merge branch 'ios-candidate' into main 2021-04-12 21:09:56 -05:00
Maurice Parker c47480614c Fix regression where marking all as unread wouldn't take you back to the sidebar 2021-04-12 21:09:34 -05:00
Maurice Parker 991297165b Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993 2021-04-12 19:42:05 -05:00
Maurice Parker c95daa208f Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993 2021-04-12 19:41:01 -05:00
Maurice Parker 11e2a3eca8 Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991 2021-04-12 13:48:54 -05:00
Maurice Parker 3a1b3f96bb Change so that sync accounts have a Remove button instead of a Delete button. Fixes #2991 2021-04-12 13:48:03 -05:00
Stuart Breckenridge 0a433b8573
Disables reader view in iOS for Feed Providers 2021-04-10 09:03:08 +08:00