Commit Graph

279 Commits

Author SHA1 Message Date
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Nate Weaver 5ac69a411e Remove the color parameter on iOS too 2020-05-01 02:02:44 -05:00
Nate Weaver 070981553d Make attributed titles work on iOS 2020-05-01 01:42:44 -05:00
Maurice Parker 86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver 6aff83481f Make attributed titles work on iOS 2020-04-24 16:20:41 -05:00
Maurice Parker b80270f65b Fix iOS timeline layout issue with truncated bylines 2020-04-19 17:28:00 -05:00
Maurice Parker 1778a270d6 Show byline in timeline for single feed timelines when available. 2020-04-18 07:53:56 -05:00
Brent Simmons 6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker 450ddbd364 Refactored new pointer interaction code to be more simple. 2020-03-24 18:27:54 -05:00
Maurice Parker bd75df7294 Add pointer interaction for timeline header button. Issue #1943 2020-03-24 16:42:46 -05:00
Maurice Parker 97226f543b Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842 2020-03-22 10:18:07 -05:00
Maurice Parker 316e4e62b2 Removed separator insets from layout code as they were no longer needed. 2020-03-20 06:58:11 -05:00
Maurice Parker 8a75defee9 Set row height when table is empty and set to automatic when articles are present. Issue #1919 2020-03-18 16:06:05 -05:00
Maurice Parker 1d26bc8c70
Revert "Set proper cell height for empty article array" 2020-03-18 15:55:33 -05:00
Flowinho 2ade0140bc Set proper cell height for empty article array
Contains work related to #1800

This one took me a while to figure out since they amount of articles is tied to the coordinator.

- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.

Greetings from southern germany!
2020-03-15 22:31:54 +01:00
Maurice Parker 833c336f2f Only show the timeline next read button when the root split view controller is collapsed. Issue #1822 2020-03-13 16:03:42 -05:00
Flowinho 0a3713e078 Align feedname and date correctly if there is no title or summary 2020-03-12 22:57:30 +01:00
Maurice Parker 9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker 03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Martin Hartl 83241cc329 Don’t show “Go to feed” action if already inside feed 2020-02-02 21:44:54 +01:00
Maurice Parker ef79005d67 Change it so that we have the unread indicator and star hidden by default. Issue #1724 2020-01-27 22:26:49 -07:00
Maurice Parker 6ac6136612 Make animations individually selectable and no longer animate navigation selections. Issue #1439 2020-01-27 21:57:52 -07:00
Maurice Parker 050434023e Fade out unread and star indicators when possible. Issue #1683 2020-01-21 11:41:03 -07:00
Maurice Parker deab8f8c6c Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570 2020-01-21 11:05:47 -07:00
Maurice Parker d68eccc55e Exit search if Go To Feed is selected. Issue #1557 2020-01-15 17:53:12 -07:00
Brent Simmons 2df78f3cf1
Merge pull request #1605 from hartlco/1590-sharing-item-to-omnifocus-adds-extra-newline
Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things
2020-01-11 11:17:30 -08:00
Maurice Parker 21cf8415d2 Add confirmation for Mark As Read actions. Issue #1603 2020-01-11 11:30:16 -07:00
Martin Hartl c739d77817 Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things 2020-01-11 09:12:41 +01:00
Maurice Parker e93b916c50 Implement Refresh to Clear Articles option. Issue #1601 2020-01-10 18:14:21 -07:00
Maurice Parker 0e3c837b66 Change accessibility ordering of labels to make it more hierarchical when spoken in VoiceOver. Issue #1584 2020-01-09 17:54:13 -07:00
Maurice Parker edd299a36d Indicate that the header is a button when it is tappable. Issue #1583 2020-01-09 17:22:37 -07:00
Maurice Parker 3115abc72e Enhance accessibility for toggle toolbar buttons. Issue #1581 2020-01-09 14:38:25 -07:00
Maurice Parker b468bcfe58
Revert "Previewing articles" 2020-01-07 16:36:32 -07:00
Mihael Cholakov 593a802d79 Merge branch 'upstream-ios-candidate' into previewing-articles 2020-01-07 09:47:00 +02:00
Maurice Parker 746d061dcf Refresh UI (including progress indicator) on Timeline when coming out of suspend. 2020-01-06 21:23:39 -07:00
Maurice Parker c0f76d0dbb Change Mark All as Read icon. Issue #1526 2020-01-06 18:07:04 -07:00
Mihael Cholakov 36230d930e Context menu now previews selected article 2020-01-06 14:52:18 +02:00
Maurice Parker 5cd163e1e4 Add refresh indicator to the Timeline. Issue #15 2020-01-03 14:23:37 -07:00
Maurice Parker 5a7863d447 Rollback pull to refresh on the timeline and modified pull to refresh control. Issue #1520 2020-01-03 08:42:43 -07:00
Martin Hartl 5ee491ebee Replace “Mark Older as Read” actions with “Mark Above/Below as Read” actions 2020-01-03 09:00:25 +01:00
Maurice Parker e26a00ddfe Enable pull to refresh on timeline and change refresh indicator to better show when it is successfully pulled. Issue #1520 2020-01-02 21:08:21 -07:00
Brent Simmons 26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Maurice Parker 61370dd04d Fix so that we don't try to scroll before the datasource has been fully applied to the table. Issue #1463 2019-12-24 17:34:47 -07:00
Brent Simmons 15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker 43bf65b7a6 Rename occurrences of completionHandler to completion. 2019-12-14 17:14:55 -07:00
Maurice Parker 7a6b818f57 Only reset the timeline under certain conditions. Issue #1422 2019-12-08 18:14:33 -07:00
Brent Simmons ebd7c68396 Merge mac-release — remove attachments. 2019-12-04 22:36:08 -08:00
Brent Simmons 3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00
Maurice Parker 81c4756f97 Persist article read filters across application launches. Issue #1349 2019-11-27 11:43:36 -06:00
Maurice Parker 5c4cd072ce Make next unread button work with new async feed functionality. 2019-11-24 13:37:56 -06:00
Maurice Parker a052bbe74e Fix title flashing in after navigation bar is shown. Issue #1336 2019-11-24 10:47:09 -06:00
Maurice Parker b5525e1a9e Restore back button items. Issue #1337 2019-11-24 10:33:13 -06:00
Maurice Parker 00094858fa Remove filter button from All Unread timeline. 2019-11-24 03:47:29 -06:00
Maurice Parker 4296c243ff Implement custom previews for context menus to crop cell separators. Issue #1221 2019-11-23 22:15:29 -06:00
Maurice Parker d8b324e3da Change nav bar so that if it is hidden and animating itself showing, you don't see the navbar items moving into place. 2019-11-23 18:00:51 -06:00
Maurice Parker dd7431d5cb Remove obsolete code. 2019-11-22 15:23:21 -06:00
Maurice Parker eea5d6f327 Change ReadFilter to ReadFilterType and differentiate the ReadFilter from the query filter. 2019-11-22 09:40:39 -06:00
Maurice Parker a5b4d570af Change ReadFilter case unavailable to alwaysRead 2019-11-22 09:32:27 -06:00
Maurice Parker 654f40a98e Add always on unread "filter" to Unread. 2019-11-21 20:31:58 -06:00
Maurice Parker 2d210a3f17 Delete dead code 2019-11-21 20:12:31 -06:00
Maurice Parker 6d8fca01ea Filter async requests based on ReadFilter. 2019-11-21 19:54:35 -06:00
Maurice Parker e8826130a4 Add timeline filter button 2019-11-21 18:22:43 -06:00
Maurice Parker d1af8a9f0a Increase height of timeline unread indicator. Issue #1320 2019-11-19 18:58:18 -06:00
Maurice Parker 985cef6b49 Remove title from timeline back button. Issue #1319 2019-11-19 18:16:03 -06:00
Maurice Parker 189995e6c7 Remove title from article back button. Issue #1318 2019-11-19 18:03:19 -06:00
Maurice Parker bdf9add8f1 Populate timeline asynchronously and restore timeline after search. Issues #1307 & #1308 2019-11-19 11:16:43 -06:00
Maurice Parker fc235a029e Remove toolbar autohiding and add optional fullscreen mode. 2019-11-18 19:12:24 -06:00
Maurice Parker 397d8e8ffa Update picker for Share Extension to be hierarchical and use icons. Issue #1269 2019-11-16 19:44:01 -06:00
Maurice Parker 5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 0c33f6c496 Animate disclosing the feed when using Go to Feed. 2019-11-13 15:41:41 -06:00
Maurice Parker 38535910ef Change Select Feed to Go to Feed. Issue #1240 2019-11-13 15:22:22 -06:00
Maurice Parker 315ac3ee12 Remove code that wasn't actually hiding the search bar 2019-11-13 09:36:05 -06:00
Maurice Parker d8b1b6c236 Stop adjusting the scroll position on every appearance. 2019-11-11 20:45:14 -06:00
Maurice Parker 766cd2f868 Save and restore scroll position when transitioning between three column mode and normal. Issue #1242 2019-11-11 16:59:42 -06:00
Maurice Parker 0df4498fa3 Add customize timeline layout setting 2019-11-08 17:16:09 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Maurice Parker 292e3789f4 Remove animation speed setting. Issue #1234 2019-11-04 14:19:13 -06:00
Maurice Parker f138c2d9aa Fix timeline secondary label coloring 2019-11-04 11:47:44 -06:00
Maurice Parker 44533399e6 Fix timeline bug where vibrancy could be lost 2019-11-03 16:34:57 -06:00
Maurice Parker 21d5c321b4 Hide search controller when no items are present. Related to Issue #1195 2019-11-03 08:36:14 -06:00
Brent Simmons bef824b02f Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-11-02 18:20:06 -07:00
Brent Simmons 1ac3c8fec7 Add just a little padding to timeline cells to help break up the BIG WALL O’ TEXT feeling. 2019-11-02 18:19:57 -07:00
Maurice Parker 3f46c0e939 Make unread indicator animatable 2019-11-02 20:15:48 -05:00
Maurice Parker 8fb87a7c87 Update label animations to match cell selection fading and changed table animation speeds to 1.5. Issue #1237 2019-11-02 19:57:01 -05:00
Maurice Parker 6a0c5ac31b Fix issue where search bar sometimes wouldn't appear. 2019-11-02 11:49:44 -05:00
Maurice Parker b78b996e88 Animate Select Feed context menu result. Issue #1220 2019-10-31 20:55:08 -05:00
Maurice Parker 51acc5972f Prevent the search bar from appearing on rotation. Issue #1171 2019-10-30 16:08:03 -05:00
Maurice Parker d63a743550 Rename MasterTimelineAvatarView to AvatarView 2019-10-29 19:23:29 -05:00
Maurice Parker 46cd259110 Use feed icon when available for timeline title image 2019-10-28 21:33:13 -05:00
Maurice Parker cee1d5dc4d Rollback change that caused the search to not appear. Issue #1199 2019-10-28 21:12:09 -05:00