Commit Graph

1633 Commits

Author SHA1 Message Date
Rizwan Mohamed Ibrahim 64a4d9bbe5
Fix localised comments 2020-07-14 22:04:20 +05:30
Rizwan Mohamed Ibrahim 1a3bbf7dbf
Add a11y label for starred status on master timeline 2020-07-14 18:08:07 +05:30
Rizwan Mohamed Ibrahim 1427e1d8c6
Add a11y label for expanded/collapsed status for Master Feed 2020-07-14 18:07:29 +05:30
Stuart Breckenridge 7183b853bd
#2256
Fixes #2256
2020-07-13 14:24:57 +08:00
Nate Weaver 059ebd5e27 Use parentContainerID when computing hash also 2020-07-12 07:44:43 -05:00
Maurice Parker 95a8f6d72d Merge branch 'swiftui' 2020-07-10 15:28:14 -05:00
Nate Weaver 82f7f99827 iOS: Make shift-space scroll up even when the detail view doesn't have focus 2020-07-10 13:57:35 -05:00
Maurice Parker 99820c1c2f Fix class name 2020-07-08 17:25:10 -05:00
Maurice Parker 526fe71cf1 Merge branch 'master' into swiftui 2020-07-08 13:23:23 -05:00
Maurice Parker 4ba2ab4baa Complete the dequeue operation even if the web view navigation fails 2020-07-08 13:22:19 -05:00
Maurice Parker e1c8479515 Prevent Twitter embeds from cutting off. Issue #2166 2020-07-07 11:47:52 -05:00
Maurice Parker 2e94ae9e8e Add basic support for Article view on iOS 2020-07-06 21:14:05 -05:00
Maurice Parker dd9dca57de Update design to more closely match the existing iOS design and Big Sur look and feel 2020-07-03 19:19:40 -05:00
Maurice Parker 88d03586ae Register AppDefaults. Issue #2190 2020-07-03 01:24:35 -05:00
Maurice Parker d15dbe18ef Change AppDefaults to be final classes on macOS and iOS 2020-07-02 05:36:23 -05:00
Stuart Breckenridge f92b219cdc NetNewsWire-iOS AppDefaults is now a singleton 2020-07-02 10:47:45 +08:00
Rizwan Mohamed Ibrahim 687b454cd7
fix mark all as read context menu on Accounts 2020-07-01 12:30:39 +05:30
Maurice Parker 72ef643a5f Remove commented code 2020-06-29 04:29:39 -05:00
Maurice Parker 403b859c31 Verify that the section exists before accessing it so that we don't crash on the new SDK 2020-06-28 03:14:53 -05:00
Brent Simmons 4ed6ccd52b Fixed warning from Apple upload system — NSExtensionActivationSupportsText needed to be a boolean, not a string. 2020-06-27 18:15:26 -07:00
Maurice Parker 05f259da51 Merge branch 'ios-release' 2020-06-21 17:55:33 -05:00
Maurice Parker 95704c7f3e Prefix accessibility label with unread when item is unread. Issue #2142 2020-06-20 11:05:54 -05:00
Maurice Parker 21e79250db Merge branch 'ios-release' 2020-06-18 17:45:12 -05:00
Maurice Parker d453a94330 Make unread and star animations cancel on cell reuse. Issue #2054 2020-06-18 17:37:29 -05:00
Maurice Parker b3c0fac5d3 Save the previous feed instead of relying on the currentFeedIndexPath which may have been reset. Issue #2139 2020-06-18 16:16:30 -05:00
Maurice Parker 5356189654 Optimize unread count look up 2020-06-16 08:32:01 -05:00
Maurice Parker d69b313525 Optimize unread count lookup 2020-06-16 08:27:59 -05:00
Maurice Parker 36e39705e7 Merge branch 'ios-release' 2020-06-16 08:10:31 -05:00
Maurice Parker 7dd20560c3 Remove reset of web view controller when returning to foreground. 2020-06-16 08:09:28 -05:00
Maurice Parker 4075da2ee8 Fix removal of tap zones when removing old web views 2020-06-16 08:07:54 -05:00
Maurice Parker 50508446bb Use immutable object for diffable datasource on Feeds. Issues #1901, #2031, #2124 2020-06-15 18:03:20 -05:00
Maurice Parker 95f6f80583 Merge branch 'ios-release' 2020-06-15 17:40:06 -05:00
Maurice Parker 3b2fcb74fd
Merge pull request #2134 from Mackarous/master
Disable selection while applying snapshot
2020-06-15 17:23:23 -05:00
Andrew Mackarous 5cc2605add Fix issue #2132 2020-06-15 02:42:30 -04:00
Brian Sanders 6aa7b009f8 Tweaks the scroll behavior when space bar is pressed
The overlap is 2 lines of text at the standard system font size.
2020-06-13 19:17:17 -04:00
Rizwan Mohamed Ibrahim f2cd09aae3
refactor open in app browser with global shortcuts 2020-05-29 20:39:04 +05:30
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Maurice Parker 9253222f96 Rollback change that incorrectly was stopping web activity on wrong controllers 2020-05-27 11:30:30 -05:00
Maurice Parker 809379038f Stop image zooming and video playback on page swipe 2020-05-27 10:12:20 -05:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Maurice Parker 3ce20e26ff
Merge pull request #2102 from stuartbreckenridge/issue-1932
Adds Title when sharing to Tweetbot and Buffer
2020-05-23 15:02:03 -05:00
Stuart Breckenridge 8b3e5d7cfd
Adds Title when sharing to Tweetbot and Buffer
Fixes #1932
2020-05-22 20:53:22 +08:00
Stuart Breckenridge 98c8ea6d9f
disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker b575d648dc
Merge pull request #2063 from bdougsand/find-in-article-ios
Adds "Find in Article" activity to the share sheet
2020-05-18 02:41:28 -05:00
Stuart Breckenridge 2297d218c0
Uses selector syntax. 2020-05-18 09:23:42 +08:00
Stuart Breckenridge 6224dfad03
Notification Permission Requests
Fixes #2057

• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.

• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.

`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
Brian Sanders d8dced6347 Adds a key command (ESC) to the article search bar 2020-05-15 21:41:14 -04:00
Brian Sanders b058f27064 Fixes bugs in article search
Placement of the article search bar is now always done with constraints.
Previously, I'd used inputAccessoryView when the keyboard appeared. That
approach, although ostensibly permitted, causes a hierarchy inconsistency error
when the device orientation changes.
2020-05-15 21:41:14 -04:00
Brian Sanders 62d04e8881 Adds stored inputAccessoryView to ArticleSearchBar
It should have been obvious that inputAccessoryView traverses the responder
chain
2020-05-15 21:41:14 -04:00
Brian Sanders 46ce824b98 Adds guard against empty search strings to Find in Article 2020-05-15 21:41:14 -04:00
Brian Sanders 96671df667 Adds keyboard shortcut for "Find in Article" (iOS) 2020-05-15 21:41:14 -04:00
Brian Sanders 2631f4f3f0 Alters search highlights so they don't intercept pointer events 2020-05-15 21:41:14 -04:00
Brian Sanders edb7c50cb3 Improves incremental search for "Find in Article"
Article search now maintains its position in the document, if possible.
2020-05-15 21:41:14 -04:00
Brian Sanders 98e0434077 Alters Find in Article to escape regex characters by default 2020-05-15 21:40:22 -04:00
Maurice Parker c2b749a74c Rebuild backing stores immediately when deselecting a Feed. Issue #2079 2020-05-15 17:06:49 -05:00
Maurice Parker 4e22489d97 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-05-15 10:45:22 -05:00
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Rizwan Mohamed Ibrahim 04458adee5
adds "Mark All Read" shortcut for feeds list 2020-05-14 18:13:41 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb
adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 8500324eb2
Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Maurice Parker 8fe746fabf
Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim bfef02e18f
adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker 775a69a295 Add iOS Reddit URL builder 2020-05-12 11:17:47 -05:00
Brian Sanders 737f4bfdf5 Adds "Find in Article" activity to the share sheet
addresses #1750
2020-05-11 17:08:44 -04:00
Maurice Parker ccb813f6ec Allow autoplay on iOS 2020-05-10 12:21:35 -05:00
Maurice Parker fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Maurice Parker 50e6e8e190
Merge pull request #2050 from jbennett/2049-add-folder-management-behavior
Adds an account behavior to disable folders
2020-05-08 15:36:16 -05:00
Maurice Parker 715804fe64 Merge branch 'ios-release' 2020-05-07 11:34:02 -05:00
Maurice Parker 46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Jonathan Bennett a37bfd5d74 Adds an account behavior to disable folders
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
2020-05-07 10:03:04 -04:00
Maurice Parker 9429f36095 Don't image zoom any previews that are just links out 2020-05-06 21:56:01 -05:00
Maurice Parker 2d8cbb8017 Merge branch 'ios-release' 2020-05-06 18:39:55 -05:00
Maurice Parker 211e44fff5 Remove flash when changing out the web view upon returning to the foreground 2020-05-06 17:35:38 -05:00
Maurice Parker be4691abd0 Use different assets for Snoo when in light vs dark mode 2020-05-06 15:32:05 -05:00
Maurice Parker 14d8e9af30 Merge branch 'ios-release' 2020-05-06 15:12:25 -05:00
Maurice Parker d4cffa28f2 Rollback disclosure button reference hold since it does nothing to stop the crash 2020-05-06 14:58:47 -05:00
Maurice Parker 502ff3e019 Don't multiply by the device pixel ratio if that will put us over the canvas limit 2020-05-06 14:55:34 -05:00
Maurice Parker 5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Maurice Parker 38f992d01d Degrade zoom image quality rather than failing 2020-05-06 11:43:50 -05:00
Stuart Breckenridge f58ac4d160
Wraps Alert strings in `NSLocalizedString`
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
Maurice Parker 78f72264fd Add oauth2 signon to iOS 2020-05-03 16:19:55 -05:00
Stuart Breckenridge e825a5d516
Adds handling of `tel` url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge f901436211
mailto links now open on iOS
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
Maurice Parker e681fd6402 Stub out Reddit Feed Provider / Extension Point 2020-05-02 19:38:57 -05:00
Maurice Parker 41a17dfb06 Restrict build button on iOS so that it only appears if Twitter is enabled 2020-05-02 17:21:01 -05:00
Maurice Parker 85f7adaa0a Use MainThreadOperation to prevent article status updates from interleaving 2020-05-02 10:02:58 -05:00
Maurice Parker 6bdcd941ae Fix typo 2020-05-02 09:01:53 -05:00
Maurice Parker a522ec67b3 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-05-01 17:43:33 -05:00
Maurice Parker 6d60053012 Merge branch 'ios-release' 2020-05-01 16:35:21 -05:00
Maurice Parker e2267d14ee Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034 2020-05-01 16:34:19 -05:00
Maurice Parker d5a4f1625a Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032 2020-05-01 16:24:29 -05:00
Nate Weaver 5ac69a411e Remove the color parameter on iOS too 2020-05-01 02:02:44 -05:00
Nate Weaver 070981553d Make attributed titles work on iOS 2020-05-01 01:42:44 -05:00
Maurice Parker 898681dfe6 Take device resolution into consideration when drawing image. Issue #2032 2020-04-30 15:34:17 -05:00
Maurice Parker 14e1dbe58e Merge branch 'ios-release' 2020-04-30 14:29:01 -05:00
Maurice Parker d30987ca0a Use main thread operation to only allow one remote notification at a time to run. 2020-04-29 15:46:29 -05:00
Maurice Parker d1c3d43018 Don't animate progress bar when initially added to the superview 2020-04-29 14:29:21 -05:00
Maurice Parker a48cbfe1ca Add code to show the Feed Inspector when the feed icon in the article view is pressed. Issue #1931 2020-04-28 21:26:57 -05:00
Maurice Parker 5e4ebb7298 Disallow the feed icon from the image zooming. 2020-04-28 21:03:21 -05:00
Maurice Parker c1bb75f21e Deleted dead code 2020-04-28 20:42:31 -05:00
Maurice Parker 37bbee9fcc Remove calls to dismiss delegate function on cancel. Issue #2010 2020-04-28 17:58:06 -05:00
Maurice Parker e77abf42c3
Revert "Removes AddAccountDismissDelegate" 2020-04-28 17:53:24 -05:00
Maurice Parker 31f3487d7a Reset focus when returning to the app from another app or the safari view controller. Issue #1963 2020-04-28 17:16:34 -05:00
Maurice Parker 31b04f626a Fix spelling of hashtag. Thanks Stephen! 2020-04-25 15:12:35 -05:00
Maurice Parker f0988d1b68 Add #hashtag to placeholder text 2020-04-25 14:31:07 -05:00
Maurice Parker 86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver 6aff83481f Make attributed titles work on iOS 2020-04-24 16:20:41 -05:00
Maurice Parker ee92cf69d2 Merge branch 'extension-point' 2020-04-24 13:34:13 -05:00
Maurice Parker 6f29b21ddc
Merge pull request #2013 from rizwankce/fix/missing-add-account-title
Add title for AddAccountViewController
2020-04-24 10:30:31 -05:00
Rizwan Mohamed Ibrahim 54fc60aa51
Add title for AddAccountViewController
view controller title via storyboard
2020-04-24 20:56:29 +05:30
Maurice Parker a46609b564
Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting
Deselect the cell row when selected for add account view controller
2020-04-24 09:11:28 -05:00
Rizwan Mohamed Ibrahim 43f175d71a
Removes AddAccountDismissDelegate
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
2020-04-24 18:49:49 +05:30
Rizwan Mohamed Ibrahim c7e3162c22
Deselect the cell row when selected for add account view controller
To avoid the highlighting even after the row is selected
2020-04-24 18:39:18 +05:30
Nate Weaver 37ae46ea4c Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
Also use :matches() to simplify some rules.

# Conflicts:
#	Mac/MainWindow/Detail/styleSheet.css
#	iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
Maurice Parker e741e8e1b4 Make detail entry more user friendly 2020-04-23 11:50:29 -05:00
Maurice Parker c451cb38d9 Add Twitter detail entry scene 2020-04-23 10:43:09 -05:00
Maurice Parker e1fc8d15d6 Update storyboard for dynamic type. 2020-04-23 10:01:26 -05:00
Maurice Parker 059b24c57b Add Twitter select account for URL builder 2020-04-23 09:50:19 -05:00
Maurice Parker e566d1493c Fix disclosure indicator 2020-04-23 09:10:40 -05:00
Maurice Parker 4ff273c3b5 Add single Home Timeline and Mentions URL builder. 2020-04-23 09:08:33 -05:00
Maurice Parker 7d2eba537b Change callback URL scheme to final scheme 2020-04-23 07:58:00 -05:00
Maurice Parker 1b48b09369 Fix hammer button compression bug 2020-04-23 06:55:57 -05:00
Maurice Parker 4461cf83cb Add select URL Builder dialog 2020-04-23 04:44:26 -05:00
Maurice Parker e11cf2ccf5 Rename to use common name for table view cell 2020-04-23 04:00:51 -05:00
Maurice Parker 62ca536717 Merge branch 'master' into extension-point 2020-04-22 22:06:16 -05:00
Maurice Parker 147d5c301c Merge branch 'ios-release' 2020-04-22 22:04:45 -05:00
Maurice Parker 947c4f04d7 Implement fix that prevents wiggling on both the timeline and the article views. 2020-04-22 22:03:15 -05:00
Maurice Parker a5583fc655 Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976 2020-04-22 18:18:20 -05:00
Maurice Parker 5d5093d26d Merge branch 'master' into extension-point 2020-04-21 20:25:50 -05:00
Maurice Parker f1357c0a23 Merge branch 'ios-release' 2020-04-21 20:25:14 -05:00
Maurice Parker 82e7d4eaf0 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-21 20:24:01 -05:00
Maurice Parker 2454b807bb Always update the status sync timer when returning to the foreground. Issue #2005 2020-04-21 20:23:46 -05:00
Rizwan Mohamed Ibrahim 108da4ccf4
Fix buttons a11y label for close and share button for image vc
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
Maurice Parker 575288b78e Merge branch 'master' into extension-point 2020-04-21 02:10:31 -05:00
Maurice Parker 7268dcdd77 Merge branch 'ios-release' 2020-04-21 02:06:19 -05:00
Maurice Parker f7bdf9d47c Correct text resizing issues in color palette settings. Issue #2000 2020-04-21 01:57:19 -05:00
Maurice Parker 7afcf681fe Stablize swipe back gesture for timeline. Issue #2002 2020-04-21 01:52:39 -05:00
Maurice Parker d0d29fd7da Merge branch 'master' into extension-point 2020-04-19 19:01:11 -05:00
Nate Weaver 2a6d9994ea Move shared CSS into its own file 2020-04-19 18:38:33 -05:00
Maurice Parker eeb7b518a8 Change how showIcons is determined to take into consideration empty bylines 2020-04-19 17:29:11 -05:00