Commit Graph

25 Commits

Author SHA1 Message Date
Jim Correia 5f11c42fc2 Use noContentHTML rather than noSelectionHTML for prepared web views.
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
Jim Correia 52ad2623a8 Limit the size of the queue maintained by DetailViewControllerWebViewProvider. 2019-08-31 13:16:46 -07:00
Jim Correia f7b53283d6 Maintain a queue of "prepared" web views for use in DetailWebViewController.
WKWebView has an awful behavior of a flash to white on first load when in
dark mode.

Keep a queue of WebViews where we've already done a trivial load so that by
the time we need them in the UI, they're past the flash-to-shite part of
their lifecycle.
2019-08-31 12:53:03 -07:00
Jim Correia a5b2c759ec Create the WKWebView instance at runtime.
Specify a container view in the storyboard and create+install the web view
at viewDidLoad time.

This lets us experiment with solutions for providing a web view that avoids
the flash-to-white problem.
2019-08-31 12:30:01 -07:00
Jim Correia e5782ca464 Removed the hide the webview workaround to expose the flash to white problem. 2019-08-31 11:27:59 -07:00
Maurice Parker 0b48c3893d Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications 2019-08-25 11:38:04 -05:00
Maurice Parker 5088878721 Hack around WKWebView's white flashing that it does while loading content 2019-08-22 12:10:50 -05:00
Maurice Parker b475f52871 Move show share dialog back to detail controller from coordinator 2019-08-19 18:13:21 -05:00
Maurice Parker a30b03bcea Remove obsolete code 2019-08-03 11:43:21 -05:00
Maurice Parker d543b979ac Move more logic out of the DetailViewController and into the AppCoordinator 2019-07-06 11:49:53 -05:00
Maurice Parker 4884aebbfd Encapsulate more of the AppCoordinate API 2019-07-06 11:32:19 -05:00
Maurice Parker 15754684a4 Move more navigation responsibilities into the AppCoordinator 2019-07-05 17:45:39 -05:00
Maurice Parker fcf2937394 Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern 2019-06-29 13:35:12 -05:00
Phil Viso 19881427c9 Fixed a crash that occurs when presenting the share sheet on iPad. Issue #639 2019-05-24 09:56:26 -05:00
Maurice Parker 8be54564e4 Enable dynamic type on detail view. 2019-04-27 10:49:54 -05:00
Maurice Parker bf1f02d084 Change the detail view back button when the timeline changes. 2019-04-23 09:52:49 -05:00
Maurice Parker 91e009932b Change progress indicator to be a progress bar instead of the activity indicator. 2019-04-23 07:26:35 -05:00
Maurice Parker e1b031e6db Make First Unread scroll to first unread in timeline.
Update Mark As Read and other unread dependent UI respond to unread count changing.
2019-04-23 04:35:48 -05:00
Maurice Parker b619b5f905 Implement next unread UI functionality. 2019-04-22 18:00:26 -05:00
Maurice Parker 0964ac67fa Change master to be driven by the NavigationStateController.
Remove ShowFeedNamesDidChange event.
Fix articleSelectionChange event name.
2019-04-22 16:25:16 -05:00
Maurice Parker 5b75add585 Move mark as read functionality to the detail view. 2019-04-22 07:08:54 -05:00
Maurice Parker e81defb934 Implement detail next and prev article buttons. 2019-04-21 17:42:26 -05:00
Maurice Parker e6feef5b11 Change detail to open in SFSafariViewController. Issue #611 2019-04-21 06:41:59 -05:00
Maurice Parker 59a30fdd34 Change iOS webview baseURL handling to match macOS version. 2019-04-19 07:37:47 -05:00
Maurice Parker 8526db8b4c Added initial POC version of NetNewsWire for iOS to use as a starting point for the actual app. 2019-04-15 15:03:05 -05:00