Commit Graph

2262 Commits

Author SHA1 Message Date
Brent Simmons 4a4fa6ed0e Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734. 2019-06-09 16:03:08 -07:00
Maurice Parker 941dd5fa08 upgraded to the latest RSWeb 2019-06-09 17:13:39 -05:00
Brent Simmons 2d96544933 NetNewsWire 5.0a2. 2019-06-08 16:29:07 -07:00
Brent Simmons 95b96b9df9 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-06-08 12:03:39 -07:00
Brent Simmons cd17e065f3 Fix typo in appcast. 2019-06-08 12:03:34 -07:00
Maurice Parker a087410177 escape title HTML in web view. Issue #722 2019-06-07 15:53:13 -05:00
Maurice Parker f4e0cfaf2b Fix folder renaming issue that occurs for Feedbin when the tag doesn't exist at Feedbin. Issue #724 2019-06-07 05:03:54 -05:00
Maurice Parker 8bd9cef7be
Merge pull request #727 from cparnot/fix-719
Fix issue with 'Mark as Read' menu item in the Article menu.
2019-06-07 03:58:09 -05:00
Charles Parnot 4f02fe7401 Fix issue with 'Mark as Read' menu item in the Article menu.
There were 2 issues: the title of the menu item did not toggle between 'Mark As Read' and 'Mark As Unread', and it was not invalidated where there is no article selected. All the code was already in place in `MainWindowController` as part of the interface item validation, but the menu item was using the wrong selector: `markRead` instead of `toggleRead`. Just changing the action in the menu item was needed to get the validation and menu item update happening correctly.
2019-06-07 09:06:18 +02:00
Maurice Parker eb71e88845 Resolved issue where local account feed finder could lock up the UI if an error was thrown. Issue #720 2019-06-06 19:46:42 -05:00
Maurice Parker e7ec59f31f
Merge pull request #725 from tgt/tgt/feedbin-fixes
Various Minor Feedbin Fixes
2019-06-06 15:27:06 -05:00
Maurice Parker 1cfc3bceef Fixed restore folder functionality for Feedbin. 2019-06-06 15:22:25 -05:00
Tom Grimwood-Taylor b0a24b6f17 Revert "Fix updating local feed list when no remote feeds."
cd85e52fdd
2019-06-06 14:23:06 +01:00
Tom Grimwood-Taylor 534da0bca6 Move call to sendArticleStatus to delegate. 2019-06-06 14:22:29 +01:00
Tom Grimwood-Taylor 0447694142 Fix feed selection when the max feed score is 0.
This occurs, for example, when searching for “macrumors.com” and adding
to the Feedbin account. All four feeds have a score of 0 since their
source is set as HTMLLink. This would also fix a case in which there are
two feeds: one with a negative score and one with a score of 0.

Since the method uses a Set the feed selected when there are multiple
feeds with an identical maximum score will be random.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor ac9057299a Remove edited name when remote feed name changes. 2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor f3505e4537 Fix posting name notifications when name changes. 2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor b4d7042a7b Ensure status changes are sent before refresh.
When the refresh button was manually clicked a full refresh would occur,
but locally changed statuses wouldn't be sent. This meant the statuses
of items in NetNewsWire would revert to their remote values until an
automatic status sync was triggered.
2019-06-06 10:31:00 +01:00
Tom Grimwood-Taylor 3c1b84dd73 Fix a Feedbin subscriptionID going out of sync.
If, for example, a user deleted a feed and recreated it on the server
without a sync in between, the subscription ID for the feed would update
on the server, but remain unchanged locally. If the user then wanted to
delete or rename the feed they'd get a 404 error.
2019-06-06 10:31:00 +01:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Tom Grimwood-Taylor cd85e52fdd Fix updating local feed list when no remote feeds.
When there were no remote feeds the logic to remove local
feeds was skipped.
2019-06-03 17:09:17 +01:00
Maurice Parker e428a4f785 Prevent add controllers from using the whole screen. Issue #710 2019-06-03 05:13:55 -05:00
Maurice Parker 6afd65858a Add the ability to update iOS account credentials 2019-06-03 05:04:03 -05:00
Maurice Parker a697f98228 Pop add controller to go back to settings after an account add 2019-06-03 04:22:58 -05:00
Maurice Parker fd02f8be11 Make about label uneditable 2019-06-03 04:13:58 -05:00
Brent Simmons c6a9078c68 Fix typo in appcast. 2019-05-31 21:07:21 -07:00
Brent Simmons c4296584d0 Update appcast for alpha one. 2019-05-31 21:06:34 -07:00
Brent Simmons 364fc2760f Bump version to 5.0a1. That’s right — it’s alpha now. W00t! 2019-05-31 20:21:08 -07:00
Maurice Parker 00ee775170 Made timeline layout tweaks to make indicator, avatar, and first line of text line up better. Issue #689 2019-05-31 17:58:39 -05:00
Maurice Parker 2d91e64148 Provide a better error message when encountering feed not found and already subscribed errors 2019-05-31 17:24:43 -05:00
Maurice Parker e348a1f9ed Remove layout caching that was causing seemly random layout issues. Issue #714 2019-05-31 16:59:02 -05:00
Maurice Parker 3593d1c5d8 Update to the new icon 2019-05-31 13:52:15 -05:00
Maurice Parker 8e0c857810 Update the extract page number function to make it more readable 2019-05-31 13:38:33 -05:00
Maurice Parker 88b2775076 Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated 2019-05-31 08:05:26 -05:00
Maurice Parker fec3c69f4a Remove Feedbin api workaround for unpropagated mode=extended parameter 2019-05-31 07:54:12 -05:00
Maurice Parker 10296a1b74 Clear the feed metadata on Feedbin feed delete 2019-05-31 07:47:05 -05:00
Maurice Parker d602f894f6 Fix link parsing bug that causes crash 2019-05-31 07:22:28 -05:00
Maurice Parker beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker e7c339fb09 Update iOS to work with the latest Account API 2019-05-30 17:41:56 -05:00
Maurice Parker 0ddb47aa32 Refactor feed finder to make it threadsafe 2019-05-30 17:35:08 -05:00
Maurice Parker a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker 30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker 1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Maurice Parker 7bec55c90b Add missing completion call that was causing restored feeds to not show 2019-05-29 21:39:53 -05:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker 527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00