Commit Graph

1146 Commits

Author SHA1 Message Date
Stuart Breckenridge 1bda0c3734 adds full width to extensions 2021-06-24 07:50:23 +08:00
Stuart Breckenridge 31af975174 applies fullWidth to accounts 2021-06-24 07:49:13 +08:00
Maurice Parker 2b9d3657e7
Merge pull request #3188 from stuartbreckenridge/3171
fullWidth added to extension table
2021-06-23 18:28:45 -05:00
Stuart Breckenridge 1971f1a5d8 fullWidth added to extension table 2021-06-24 07:27:14 +08:00
Maurice Parker e3f066aaf5
Merge pull request #3186 from danielpunkass/default-feed-handler
Hopefully finishing up the fixes for handling the "open in default browser" preference
2021-06-23 17:50:06 -05:00
Daniel Jalkut 258d7baa73 If we are reached by way of the new x-netnewswire-feed: scheme, replace that with standard feed: scheme before normalizing the URL. 2021-06-23 14:50:25 -04:00
Daniel Jalkut 8b447f6446 Adapt store of the openFeedsInDefaultBrowser preference to be stored/retrieved from app group shared defaults, so that the Safari App Extension can access it. 2021-06-23 14:39:02 -04:00
Stuart Breckenridge f86a327d8b Fixes #3171 2021-06-23 20:07:58 +08:00
Maurice Parker ba2d26dce9
Merge pull request #3180 from danielpunkass/default-feed-handler
Invert the semantics of the defaults key for whether to open Subscrib…
2021-06-22 21:20:12 -05:00
Daniel Jalkut d2157a7c08 Fix the x-netnewswire-feed: URL scheme replacement. 2021-06-22 22:16:10 -04:00
Daniel Jalkut 29af6dea1e Invert the semantics of the defaults key for whether to open Subscribe to Feed feeds in NNW or the user's configured default browser. This ensures the fallback behavior when no preference has been set will default as wanted to opening in NetNewsWire. 2021-06-22 22:14:11 -04:00
Maurice Parker f1dbc2de71 Merge branch 'ios-release' 2021-06-22 19:14:50 -05:00
Daniel Jalkut 8191f2476a Add x-netnewswire-feed to the list of scheme prefixes for adding a feed to NetNewsWire, and modify the behavior of the Safari App Extension plugin so that it consults the host app preference for opening in NetNewsWire or with the default feed handler, before choosing which scheme to prepend to the feed URL. 2021-06-22 12:35:09 -04:00
Daniel Jalkut 75fd9e1e13 Add new subscribeToFeedsInNetNewsWire boolean preference, to direct the behavior of the Subscribe to Feed app extension. 2021-06-21 17:51:04 -04:00
Maurice Parker d6aa5f23ba Don't allow the creation of iCloud accounts if iCloud and iCloud Drive aren't enabled. Fixes #3106 2021-06-17 19:05:39 -05:00
Maurice Parker 7fc29837a1
Merge pull request #3163 from stuartbreckenridge/main
Password Updates
2021-06-17 09:43:27 -05:00
Stuart Breckenridge 50327a97d3 Password Updates
• Removes LD_RUNPATH_SEARCH_PATHS which caused an issue when building for running on device
• Autofill enabled on macOS 11 +
• Adds sender for 1Password (for iPad)
2021-06-17 12:38:53 +08:00
Maurice Parker f26e0b8c81 Add hidden preference to suppress syncing on launch. Fixes #894 2021-06-16 20:21:44 -05:00
Brent Simmons 0d0f1e4908 Replace “don't” with “don’t” everywhere. 2021-05-31 16:01:01 -07:00
Brent Simmons ae63d0feb7 Add a warning about iCloud sync being slow sometimes. Also: in user-facing text, change “subscriptions” to “feeds.” We want to use the word “feed” — a “subscription” makes people think of IAP. 2021-05-31 15:52:56 -07:00
Maurice Parker 57815f0496 Merge branch 'mac-release' 2021-05-25 20:14:18 -05:00
Maurice Parker f9af3c786b Merge branch 'ios-candidate' 2021-05-25 20:12:50 -05:00
Brent Simmons 9d2c8f000f Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance. 2021-05-08 12:42:44 -07:00
Rob Mathers 8707a71313 Add Copy Article URL & Copy External URL Menu Items
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Chris Campbell 364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Brent Simmons 790218501b
Merge pull request #3079 from babbage/bugfix/3069
Handle links with unencoded spaces. Fixes #3069
2021-04-28 21:55:46 -07:00
Duncan Babbage 9092d075a0 Handle links with unencoded spaces. Fixes #3069 2021-04-28 22:49:32 +12:00
Duncan Babbage 2ea86c1e14 Incorporate closure from mac-release
Enables ios-candidate branch to build macOS target.
2021-04-27 13:07:09 +12:00
Stuart Breckenridge 858672fdaf
fix on release branch 2021-04-25 13:31:15 +08:00
Stuart Breckenridge 5af2643479
standardised naming 2021-04-19 11:21:00 +08:00
Stuart Breckenridge d4130e7c65
Corrects naming convention
[iOS]
Twitter: Notify about new tweets
Reddit: Notify about new posts
Default: Notify about new articles
+ Fixes alignment issues in the inspector view

[macOS]
Twitter: Show notifications for new tweets
Reddit: Show notifications for new posts
Default: Show notifications for new articles
2021-04-19 11:10:57 +08:00
Maurice Parker 77dd2e5e22 Merge branch 'mac-release' into main 2021-04-15 14:31:52 -05:00
Maurice Parker 3955151daf Make sure mark as read completes before searching for the next unread. Fixes #2952 2021-04-15 14:29:49 -05:00
Maurice Parker f0ab588c0f Update to latest Account API. 2021-04-12 19:46:59 -05:00
Stuart Breckenridge 4e517a6db4
Disable Reader View
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker b1a0b649a5
Merge pull request #2972 from j-f1/read-unread
Update swipe actions on macOS to match iOS
2021-04-07 03:47:27 -05:00
Jed Fox 76cf335af1
Use the star SF Symbols as well 2021-04-06 17:37:15 -04:00
Jed Fox 3609b6f977
Add labels to swipe actions to match iOS 2021-04-06 17:34:05 -04:00
Jed Fox 0c2f79f1b5
Update read/unread swipe images to be SF Symbols on Big Sur 2021-04-06 17:31:42 -04:00
Maurice Parker ea6cece955 Merge branch 'mac-release' into main 2021-04-03 09:30:42 -05:00
Maurice Parker 5663d8549e
Merge pull request #2958 from stuartbreckenridge/mac-candidate
Layout changes to reduce height of add account sheet
2021-04-01 18:00:09 -05:00
Stuart Breckenridge 8da7d2173f
Layout changes to reduce size of add account sheet 2021-04-02 06:53:20 +08:00
Maurice Parker 1ab727a128 Make symbol images images scale correctly. Fixes #2957 2021-04-01 11:12:48 -05:00
Jed Fox 4750e9b93a
Add dir=auto to page.html 2021-03-29 17:20:09 -04:00
Maurice Parker 95234706e1 Fix issue where next unread wasn't wrapping around. Fixes #2942 2021-03-29 14:33:08 -05:00
Maurice Parker fb9114538c Modified the Timeline so that it can handle duplicate articleIDs 2021-03-28 06:30:49 -05:00
Maurice Parker ab5421f533 Merge branch 'mac-release' into main 2021-03-27 17:21:49 -05:00
Brent Simmons b1d62d1bb7 Return to the normal test build appcast feed URL. 2021-03-26 18:16:08 -07:00
Brent Simmons 87de7c51b5 Update the link for the 6.0 Mac help book. 2021-03-25 17:17:43 -07:00
Maurice Parker e62cb4847b Only update the timer when the refreshInterval changes 2021-03-25 13:51:40 -05:00
Maurice Parker 84ddd75107 Change refresh behavior so that it doesn't rely on the debug menu. Fixes #2905 2021-03-22 17:20:40 -05:00
Maurice Parker 42e6e1397d Signal that the mouse exited the link when an article gets reloaded. Fixes #2877 2021-03-15 20:14:30 -05:00
Maurice Parker 78b9444274 Remove extra unused parameter in delegate signature 2021-03-15 20:10:42 -05:00
Maurice Parker 52f11ff538 Add validateFeed parameter to createWebFeed 2021-03-15 18:01:12 -05:00
Maurice Parker f1e4d70481 Simplify the folder copy logic 2021-03-15 17:47:53 -05:00
Maurice Parker d57cb7b21f Delete obsolete code 2021-03-15 17:35:23 -05:00
Maurice Parker 7e4e7091e2 Delete obsolete code 2021-03-15 17:33:12 -05:00
Maurice Parker c1a6c42bd3 Remove Hide Unread Count preference. Fixes #2881 2021-03-14 14:06:09 -05:00
Maurice Parker bf76cb810d Change to always copy between accounts. Fixes #2871 2021-03-11 19:43:05 -06:00
Stuart Breckenridge e2f21c15c2
formatting 2021-03-08 14:12:32 +08:00
Stuart Breckenridge f630cb16db
comments 2021-03-08 10:30:58 +08:00
Stuart Breckenridge a59df3e6fc
Moves frame tweaking to end of liveResize 2021-03-08 10:28:51 +08:00
Stuart Breckenridge 27b9326d07
fixes #2823 2021-03-08 10:06:30 +08:00
Stuart Breckenridge 2e12f5a078
removes code comment 2021-03-07 21:34:52 +08:00
Stuart Breckenridge 86981a0c5b
#2597
Fixes #2597: Toggles a small window height change to get webview to behave on macOS 11.
2021-03-07 16:47:39 +08:00
Stuart Breckenridge 7a653db1dd
typo 2021-03-07 15:51:43 +08:00
Stuart Breckenridge 8dc6e4e332
Contraint Changes
Fixes #2850
• #2634: resizing vertically downards (expanding) is smooth
2021-03-07 14:21:30 +08:00
Brent Simmons f8ae8d2821 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-06 14:52:24 -08:00
Brent Simmons 91a825343a Add Debug > Force Crash command. Also: let the test for crash report sending work in production. 2021-03-06 14:44:58 -08:00
Maurice Parker d0e3ec6d1c Fix variable name 2021-03-06 16:25:44 -06:00
Maurice Parker a7abde04ab Fix variable name 2021-03-06 16:25:10 -06:00
Maurice Parker fa4f3ea818 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-05 12:45:21 -06:00
Maurice Parker 2ca06eeae7 Remove containing box for web view. Fixes #2848 2021-03-05 12:45:15 -06:00
Brent Simmons 586e6ed706 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2021-03-02 22:08:21 -08:00
Brent Simmons bb5a0abb9a Update crash log URL to the new crash log catcher on our new services.netnewswire.com server. 2021-03-02 22:08:11 -08:00
Collin Donnell 035759947a Fix #2833: Titlebar is overlapped by toolbar in fullscreen
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 19:02:13 -06:00
Collin Donnell 593569175c Fix #2833: Titlebar is overlapped by toolbar in fullscreen
Fix issue where detail web view would be overlapped by the toolbar in full screen by setting web view constraints to use the `safeAreaLayoutGuide` in macOS 11+.
2021-02-27 16:32:57 -08:00
Maurice Parker 74298e7cde Add hidden GruberFeedDoubleClickMarkAsRead preference 2021-02-26 17:38:26 -06:00
Maurice Parker 1f159a5bff Change drag-n-drop behavior to default to copy when dragging between accounts 2021-02-22 18:50:29 -06:00
Maurice Parker afd9a47abd Change so that we only show one error dialog when folder moves/copies can't find one or more feeds. 2021-02-22 17:50:30 -06:00
Maurice Parker 931b1f9afd Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-22 17:14:41 -06:00
Maurice Parker 25ee970562 Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791 2021-02-22 12:17:43 -06:00
Brent Simmons b0a1183e11 Update URLs to use netnewswire.com where appropriate. 2021-02-21 20:21:01 -06:00
Brent Simmons 649e3e86ef Update URLs to use netnewswire.com where appropriate. 2021-02-21 18:00:40 -08:00
Maurice Parker 731d0d0d88 Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-16 14:24:21 -06:00
Maurice Parker ca294c7528 Remove async call since the Big Sur bug that it was working around appears to be fixed. Fixes #2791 2021-02-15 17:49:28 -06:00
Maurice Parker 00c947fd05
Merge pull request #2790 from stuartbreckenridge/future-proofing
: class changed to : AnyObject for protocols
2021-02-10 16:38:12 -06:00
Stuart Breckenridge 207e30239e
tidies up add account sheets 2021-02-07 20:22:45 +08:00
Stuart Breckenridge 1e578828e9
: class chnaged to : AnyObject for protocols 2021-02-06 07:06:45 +08:00
Stuart Breckenridge f3b1597ff4
Fixes 2782 2021-02-05 21:17:07 +08:00
Maurice Parker f22c3c644c
Merge pull request #2776 from stuartbreckenridge/2674
Adds sidebar toggles for notifications/reader
2021-02-04 16:08:33 -06:00
J-rg fd89f56c82 Replace extension preferences template image with symbol 2021-02-04 04:02:10 +01:00
Stuart Breckenridge e88327be78
You can’t toggle an optional Bool 2021-02-02 13:25:06 +08:00
Stuart Breckenridge aa0a5d2269
Checks for notification permissions
If notifications are authorised, the toggle will work.

Otherwise, an alert is shown giving the user required information to enable notifications.
2021-02-02 11:54:47 +08:00
Stuart Breckenridge 62ed7492eb
Adds checkmarks
Also adds notification to keep Inspector in sync.
2021-02-02 10:26:34 +08:00
Stuart Breckenridge 6b1ad170ca
Adds sidebar toggles for notifications/reader 2021-02-02 08:16:45 +08:00
Maurice Parker 73ba42fa1a Use the correct font for the preferred sidebar icon size. Fixes #2761 2021-01-24 10:34:27 -06:00
Maurice C Parker b51c47d4c3 Change rowSizeStyle so that we resize the outline view again. (Catalina fix) Fixes: #2755 2021-01-23 14:14:48 -06:00
Maurice Parker 3b1fdf8d35 Change rowSizeStyle to system default so that we resize again. Fixes #2755 2021-01-23 14:11:08 -06:00