Nate Weaver
f67b7df5a9
Add row swipe action for Mark/Unmark Starred
2019-10-02 11:16:01 -05:00
Nate Weaver
bc32fc1cb9
Add row swipe action for Mark Read/Unread
2019-10-02 11:16:01 -05:00
Brent Simmons
27478b0f6f
Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match.
2019-09-29 22:44:32 -07:00
Brent Simmons
b62a7afa10
Add keyboard shortcut for toggling starred status — s key. Fix #875 .
2019-09-29 22:34:31 -07:00
Maurice Parker
6536dbf2a5
Use correct account method for adding folders
2019-09-27 06:38:43 -05:00
Maurice Parker
d961a73f28
Removed inadvertent code change
2019-09-26 15:30:38 -05:00
Maurice Parker
0a2cbfde22
Knock the corner off the inner image when it is visible
2019-09-26 14:31:43 -05:00
Andrew Brehaut
f25c0e0b57
Original implementation was only aware of multimarkdown style footnote markup.
...
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
Andrew Brehaut
a381361b56
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-09-25 12:18:28 +12:00
Maurice Parker
98befac78c
Animate reader view button
2019-09-24 16:34:11 -05:00
Andrew Brehaut
0d99136961
544 Simple darkmode style for popovers
2019-09-23 20:38:46 +12:00
Andrew Brehaut
4c54d2c4ff
544 adds and positions the arrow on the popover bubble
...
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.
Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
Andrew Brehaut
af5d510c80
#544 Better handling of the footnote reverse links
...
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
Andrew Brehaut
5fea81971b
#554 newsfoot.js and css are included in the page
...
These changes are the bare minimum required to get footnotes to appear and function on the article page.
* The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
* Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors
Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
Maurice Parker
9d54a1de74
Enable always on Reader View for feeds
2019-09-21 15:03:42 -05:00
Maurice Parker
b49aeca577
Moved page.html location information to ArticleRenderer
2019-09-21 12:36:35 -05:00
Maurice Parker
0c00150849
Externalize javascript code into separate main.js file
2019-09-21 04:34:11 -05:00
Maurice Parker
ba45144c2a
Merge branch 'mac-release'
2019-09-21 03:57:41 -05:00
Maurice Parker
3decd23c45
Convert iOS to use Javascript rendering
2019-09-20 20:33:28 -05:00
Maurice Parker
710abf30c7
Make stylesheet external to page.html
2019-09-20 19:28:13 -05:00
Ben Ubois
cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
Maurice Parker
9c6d47eaa1
Merge branch 'pr/1033'
2019-09-20 17:51:27 -05:00
Maurice Parker
1bcc1eda44
Implement disallowing feeds in the root folder for specified accounts
2019-09-20 15:37:10 -05:00
Maurice Parker
af0d6c9022
Implement AccountBehaviors so that we don't have to keep adding boolean flags to account
2019-09-20 11:34:31 -05:00
Maurice Parker
567d762ea4
Fix button animation resets
2019-09-19 17:30:54 -05:00
Maurice Parker
76056e4fef
Add menu and keyboard shortcut to Reader
2019-09-19 17:25:36 -05:00
Maurice Parker
6a7d1df423
Change image references to use AppAsserts per our standard
2019-09-19 15:44:31 -05:00
Maurice Parker
d3a5bdf6d3
Merge branch 'mac-release'
2019-09-19 11:59:01 -05:00
Nate Weaver
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Ben Ubois
0b6683d073
Render with evaluateJavaScript.
...
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker
3b5a6f2576
Don't allow the article extraction button to toggle if it isn't working.
2019-09-18 20:03:01 -05:00
Maurice Parker
8cd6f107e5
Add basic Article Content extraction
2019-09-18 18:15:55 -05:00
Maurice Parker
786a4e48c4
Merge branch 'mac-release'
2019-09-17 15:01:01 -05:00
Nate Weaver
0c89bc43c1
Use a bridging header for the Web Inspector API instead of KVC
2019-09-17 06:55:55 -05:00
Nate Weaver
4f405009f5
Use a selector instead of a block for the notification observation
2019-09-17 05:04:05 -05:00
Nate Weaver
e39fa31bf7
Add a menu item to the Debug menu to enable the Web Inspector
...
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons
b075226685
Merge mac-release.
2019-09-16 22:32:08 -07:00
Brent Simmons
66d9333999
Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code.
2019-09-16 22:27:17 -07:00
Brent Simmons
d16acfcca8
Merge branch 'mac-release'
2019-09-16 22:10:17 -07:00
Brent Simmons
f7c9cc1dbd
Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes.
2019-09-16 22:09:58 -07:00
Brent Simmons
1ece325112
Merge mac-release.
2019-09-16 20:09:04 -07:00
Brent Simmons
a05fd61085
Merge branch 'imagecache' into mac-release
2019-09-16 20:07:31 -07:00
Brent Simmons
a225d52ba3
Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView.
2019-09-16 20:01:30 -07:00
Brent Simmons
506b621e5d
Draw the avatar background in TimelineAvatarView only if the icon is too short vertically.
2019-09-16 20:00:32 -07:00
Maurice Parker
444771dfae
Merge branch 'mac-release'
2019-09-16 18:16:13 -05:00
Maurice Parker
1d7cbe5596
Fix super wide div's. Issue #1010
2019-09-16 18:12:56 -05:00
Brent Simmons
8a2d1f5f6a
Create TimelineAvatarView, which draws the background for images that need it.
2019-09-15 23:02:13 -07:00
Phil Viso
cc6767e0f6
Removed duplicate sort parameter change handling functions
2019-09-13 08:29:56 -05:00
Phil Viso
8a6e3c9f37
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
...
# Conflicts:
# Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
Maurice Parker
57542592cb
Correct which view should become the first responder. Issue #1014
2019-09-11 17:47:02 -05:00
Brent Simmons
3b501e9f4e
Merge branch 'mac-release'
2019-09-10 20:28:42 -07:00
Brent Simmons
7ad0b6b604
Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923 .
2019-09-10 20:28:16 -07:00
Maurice Parker
8dda681409
Add accessibility labels to Sidebar, Timeline, and Article. Issue #934
2019-09-10 11:09:17 -05:00
Phil Viso
32d6678fdd
Added group by feed menu item
2019-09-08 17:09:26 -05:00
Maurice Parker
0961753357
Merge pull request #998 from hisaac/mac-release
...
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson
8b635fc04c
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 12:54:26 -05:00
Maurice Parker
e61efbe47a
Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS
2019-09-08 09:43:51 -05:00
Brent Simmons
0d25f2331a
Merge branch 'mac-release'
2019-09-06 19:28:31 -07:00
Brent Simmons
58c2fad2fd
Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976 .
2019-09-06 19:28:06 -07:00
Maurice Parker
a4b01fda35
Merge branch 'mac-release'
2019-09-06 17:03:38 -05:00
Maurice Parker
0e7d971e65
Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995
2019-09-06 16:52:31 -05:00
Maurice Parker
00b2756526
Merge branch 'mac-release'
2019-09-05 13:15:04 -05:00
Brian Warren
ce3ec10c95
Enforcing automatic height for images in the template
2019-09-05 10:59:16 -07:00
Maurice Parker
da8250ac5a
Merge branch 'mac-release'
2019-09-04 17:42:30 -05:00
Maurice Parker
7a8d23958b
Restrict iframe width to be at most 100%
2019-09-04 17:41:58 -05:00
Maurice Parker
dabb78cde4
Merge branch 'mac-release'
2019-09-04 17:20:37 -05:00
Thomas Pritchard
d3ad4b52a3
Set a sensible line height for figure captions
2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23
Add figures to Mac detail stylesheet
2019-09-04 19:58:29 +01:00
Maurice Parker
fa5840811a
Change the view that gets made the first responder so that keyboard shortcuts work again
2019-09-04 03:12:50 -05:00
Maurice Parker
722d486018
Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app
2019-09-04 03:11:55 -05:00
Maurice Parker
a59f223043
Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS
2019-09-04 02:40:35 -05:00
Brent Simmons
2ec55e6587
Merge branch 'mac-release'
2019-09-03 22:59:29 -07:00
Brent Simmons
0ba8f3b4e1
Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898 .
2019-09-03 22:58:17 -07:00
Brent Simmons
ed91776097
Merge branch 'mac-release'
2019-09-03 21:24:52 -07:00
Jim Correia
c8920ca5a6
Added optional separators in the timeline view.
...
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker
1a9acdcc50
Remove TreeController from Delete command as it is no longer used there
2019-09-01 14:56:27 -05:00
Maurice Parker
6cf1e4539d
Merge branch 'mac-release'
2019-09-01 10:51:22 -05:00
Jim Correia
e7e77d362c
Fix for bug #901 — first web view load flashes white in dark mode
...
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.
Instead, use a modification of the original solution used for iOS:
- wrap the web view in a box with an appropriate background color
- hide the web view at creation
- show the web view after* the first load
This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.
[*] Showing the view immediately after the first load still causes the flash
to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker
ecec048716
Merge branch 'mac-release'
2019-08-31 18:31:10 -05:00
Jim Correia
cdfdc06142
Only enable "Open in Browser" when a single article is selected.
...
Fixes bug #921 .
2019-08-31 16:02:21 -07:00
Maurice Parker
3c86bf0614
Merge pull request #871 from mbernson/master
...
Simplify sharing delegate logic
2019-08-27 11:13:00 -05:00
Maurice Parker
8de9b355c7
Merge branch 'mac-release'
2019-08-26 12:54:53 -05:00
Maurice Parker
1a3e2784ae
Optimize table cell reloading when feed images are made available
2019-08-26 12:54:23 -05:00
Maurice Parker
f8c01107d5
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-08-24 15:01:40 -05:00
Maurice Parker
ea55aa5bef
Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS
2019-08-24 15:01:28 -05:00
Brent Simmons
ed56376d03
Merge branch 'mac-candidate'
2019-08-23 18:55:09 -07:00
Brent Simmons
3447ebcec0
Reload data after a batch update. Fix #872 .
2019-08-23 15:52:07 -07:00
Mathijs Bernson
9214e3d65e
Simplify sharing item subject logic
2019-08-23 13:05:20 +02:00
Brent Simmons
1ab0f7c25c
Merge mac-candidate.
2019-08-21 21:44:07 -07:00
Brent Simmons
849830f494
Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838 .
2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb
Start work on filtering timeline so that articles from deleted feeds never show up.
2019-08-21 13:23:46 -07:00
Brent Simmons
7b3c08f521
Merge branch 'mac-candidate'
2019-08-13 21:07:59 -07:00
Brent Simmons
2bbd135c9e
Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829 .
2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e
Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected.
2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee
Add a SmartFeedType to smart feeds so the sidebar can tell them apart.
2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8
Add Ryan’s word-wrap change to mac-candidate.
2019-08-13 20:07:42 -07:00
Ryan Dotson
6eb27abc13
Break long words or URLs to prevent horizontal overflow
2019-08-13 09:27:36 +09:00
Ryan Dotson
c8f5a24b95
Use proper quotes in timeline contextual menu
2019-08-13 07:41:14 +09:00
Brent Simmons
34326863ea
Merge branch 'mac-candidate'
2019-07-28 16:01:12 -07:00
Brent Simmons
887f8e0b53
Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching.
2019-07-28 16:00:43 -07:00