6f29b21ddc
Merge pull request #2013 from rizwankce/fix/missing-add-account-title
...
Add title for AddAccountViewController
2020-04-24 10:30:31 -05:00
54fc60aa51
Add title for AddAccountViewController
...
view controller title via storyboard
2020-04-24 20:56:29 +05:30
a46609b564
Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting
...
Deselect the cell row when selected for add account view controller
2020-04-24 09:11:28 -05:00
43f175d71a
Removes AddAccountDismissDelegate
...
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
2020-04-24 18:49:49 +05:30
c7e3162c22
Deselect the cell row when selected for add account view controller
...
To avoid the highlighting even after the row is selected
2020-04-24 18:39:18 +05:30
37ae46ea4c
Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
...
Also use :matches() to simplify some rules.
# Conflicts:
# Mac/MainWindow/Detail/styleSheet.css
# iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
e741e8e1b4
Make detail entry more user friendly
2020-04-23 11:50:29 -05:00
c451cb38d9
Add Twitter detail entry scene
2020-04-23 10:43:09 -05:00
e1fc8d15d6
Update storyboard for dynamic type.
2020-04-23 10:01:26 -05:00
059b24c57b
Add Twitter select account for URL builder
2020-04-23 09:50:19 -05:00
e566d1493c
Fix disclosure indicator
2020-04-23 09:10:40 -05:00
4ff273c3b5
Add single Home Timeline and Mentions URL builder.
2020-04-23 09:08:33 -05:00
7d2eba537b
Change callback URL scheme to final scheme
2020-04-23 07:58:00 -05:00
1b48b09369
Fix hammer button compression bug
2020-04-23 06:55:57 -05:00
4461cf83cb
Add select URL Builder dialog
2020-04-23 04:44:26 -05:00
e11cf2ccf5
Rename to use common name for table view cell
2020-04-23 04:00:51 -05:00
62ca536717
Merge branch 'master' into extension-point
2020-04-22 22:06:16 -05:00
147d5c301c
Merge branch 'ios-release'
2020-04-22 22:04:45 -05:00
947c4f04d7
Implement fix that prevents wiggling on both the timeline and the article views.
2020-04-22 22:03:15 -05:00
a5583fc655
Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976
2020-04-22 18:18:20 -05:00
5d5093d26d
Merge branch 'master' into extension-point
2020-04-21 20:25:50 -05:00
f1357c0a23
Merge branch 'ios-release'
2020-04-21 20:25:14 -05:00
82e7d4eaf0
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-04-21 20:24:01 -05:00
2454b807bb
Always update the status sync timer when returning to the foreground. Issue #2005
2020-04-21 20:23:46 -05:00
108da4ccf4
Fix buttons a11y label for close and share button for image vc
...
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30
575288b78e
Merge branch 'master' into extension-point
2020-04-21 02:10:31 -05:00
7268dcdd77
Merge branch 'ios-release'
2020-04-21 02:06:19 -05:00
f7bdf9d47c
Correct text resizing issues in color palette settings. Issue #2000
2020-04-21 01:57:19 -05:00
7afcf681fe
Stablize swipe back gesture for timeline. Issue #2002
2020-04-21 01:52:39 -05:00
d0d29fd7da
Merge branch 'master' into extension-point
2020-04-19 19:01:11 -05:00
2a6d9994ea
Move shared CSS into its own file
2020-04-19 18:38:33 -05:00
eeb7b518a8
Change how showIcons is determined to take into consideration empty bylines
2020-04-19 17:29:11 -05:00
b80270f65b
Fix iOS timeline layout issue with truncated bylines
2020-04-19 17:28:00 -05:00
ac41c7af69
Added timestamp to retweets
2020-04-18 16:27:19 -05:00
ad95cef6bb
Add iOS twitter stylings
2020-04-18 15:17:56 -05:00
1778a270d6
Show byline in timeline for single feed timelines when available.
2020-04-18 07:53:56 -05:00
9b39165018
Merge branch 'master' into extension-point
2020-04-16 16:37:18 -05:00
afdfe5fe71
Merge branch 'ios-release'
2020-04-16 16:36:53 -05:00
a4c672bb46
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-04-16 16:27:04 -05:00
928e93c074
Remove web view recycling as this seems to contribute to the blank article problem on iPadOS
2020-04-16 16:26:53 -05:00
f9a11198f0
Remove Omni from credits and about text.
2020-04-16 13:24:20 -07:00
d4b5d7bde4
Add FeedProviderManager
2020-04-16 15:06:56 -05:00
d168658e05
Add Extension Point maintenance to the iOS app.
2020-04-16 08:25:40 -05:00
1321f0b9ff
Loop through through rows using the count of rows in that section, rather than the count of rows in the initial indexPath’s section. Fix #1987 .
2020-04-12 18:23:20 -07:00
6d9eda442f
Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature.
2020-04-12 17:12:36 -07:00
46f614e960
Merge branch 'ios-release'
2020-04-12 11:50:11 -05:00
7064d5d8f5
Fix regression where navigating back and paging back from an article happened at the same time.
2020-04-12 11:48:14 -05:00
e6c5d2f199
Merge branch 'ios-release'
2020-04-11 15:59:37 -05:00
7c266d65ee
Force the frame to center when displaying. Issue #1983
2020-04-11 15:58:48 -05:00
02f62bbb61
Fix image cropping. Issue #1967
2020-04-11 15:11:12 -05:00
6a9620e4de
Add NewsBlur and CloudKit to addable account types on production builds.
2020-04-06 15:37:26 -05:00
6ad4eeb280
Merge branch 'ios-release'
2020-04-06 08:47:56 -05:00
f0ec7c5e19
Fix problem where back swiping wouldn't work anymore for full screen. Issue #1970
2020-04-06 08:47:01 -05:00
bcfd75ff68
Replace the `firstElementPassingTest` function come from RSCore with the native function `first(where:)`.
2020-04-06 02:06:24 +08:00
40ea5243c6
Removed notification we no longer needed to use to refresh the Feeds and Sidebar.
2020-04-01 20:31:32 -05:00
ea78b5683d
Fix background notification processing of CloudKit changes.
2020-04-01 20:21:14 -05:00
def48546a3
Change how initial refresh is triggered.
2020-04-01 16:45:29 -05:00
4941d60c1a
Put add accounts list into alphabetical order
2020-04-01 07:50:11 -05:00
b664ae2609
Merge pull request #1959 from quanganhdo/mac-newsblur
...
Add NewsBlur support to Mac version
2020-03-30 17:37:08 -05:00
c3506e9329
Add NewsBlur to Preferences
2020-03-30 17:45:47 -04:00
41acb716bd
Remove activity donation for next unread. Issue #1957
2020-03-30 15:42:42 -05:00
d9e5350804
Hide credentials section for iCloud.
2020-03-30 03:00:52 -05:00
187121298e
Added support for CloudKit push notifications (subscriptions).
2020-03-30 02:48:25 -05:00
4f425c9c86
Implement web feed sync between devices.
2020-03-29 17:12:34 -05:00
ecc20ad9e3
Enabled adding a CloudKit account on iOS.
2020-03-28 17:51:14 -05:00
532db0b640
Merge branch 'ios-release'
2020-03-28 16:51:50 -05:00
649972f57f
Created the Developer build which has some functionality disabled for those without access to the API keys needed.
2020-03-28 16:51:41 -05:00
715671edad
Rebuild the Feeds list when coming back to it from the Timeline while the root split is collapsed to filter read Feeds.
2020-03-28 01:43:54 -05:00
6d085fdacf
Inline videos and enable player controls for both Mac and iOS. Issue #1952
2020-03-28 00:56:29 -05:00
bd1c73c1d3
Automatically remove Feed items if they should be filtered. Issue #1949
2020-03-27 18:24:57 -05:00
a13f10441f
Change pointer interaction to encompass the complete button.
2020-03-26 11:20:13 -05:00
53b00c5414
Don't show add account option for CloudKit when the entitlement isn't present.
2020-03-25 16:09:01 -05:00
6c06c7791c
Add interaction to buttons that were missing it. Issue #1945
2020-03-25 08:55:02 -05:00
450ddbd364
Refactored new pointer interaction code to be more simple.
2020-03-24 18:27:54 -05:00
bd75df7294
Add pointer interaction for timeline header button. Issue #1943
2020-03-24 16:42:46 -05:00
25882f69c8
Merge branch 'ios-release'
2020-03-24 16:00:53 -05:00
d615a0a894
Fix bug where clean up shortcut wouldn't clear articles if wrong setting was off.
2020-03-24 16:00:01 -05:00
d0680bcc73
Merge branch 'ios-release'
2020-03-24 12:21:32 -05:00
2d56971c45
Added missing dev files
2020-03-23 07:26:44 -05:00
8105756ccb
Add some work in progress for CloudKit syncing
2020-03-22 16:35:03 -05:00
85cbd204b3
Fixed clean up keyboard shortcut
2020-03-22 10:23:31 -05:00
97226f543b
Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842
2020-03-22 10:18:07 -05:00
b7fe991b7b
Retrieve session id for later requests
2020-03-22 00:47:27 -04:00
034aabbfff
Add login/logout support
2020-03-22 00:47:26 -04:00
8f5f856e49
Add NewsBlur account prototype
2020-03-22 00:47:26 -04:00
960af2a8df
Parameterize the container so that each developer has their own
2020-03-21 20:53:21 -05:00
07cc89541c
Add iCloud.com.ranchero.NetNewsWire entitlement to Mac and iOS targets.
2020-03-21 17:43:33 -07:00
9f516caa35
Don't use borders on nested tables. Issue #1936
2020-03-21 17:19:03 -05:00
9315a00d19
Add CloudKit container entitlements.
2020-03-21 02:34:34 -05:00
e7436925ad
Don't remove filtered feeds on article downloads.
2020-03-20 10:34:18 -05:00
316e4e62b2
Removed separator insets from layout code as they were no longer needed.
2020-03-20 06:58:11 -05:00
8a75defee9
Set row height when table is empty and set to automatic when articles are present. Issue #1919
2020-03-18 16:06:05 -05:00
1d26bc8c70
Revert "Set proper cell height for empty article array"
2020-03-18 15:55:33 -05:00
770206df60
Merge branch 'ios-release'
2020-03-17 17:19:31 -05:00
36841602a5
Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923
2020-03-17 17:18:24 -05:00
37cf7fae1d
Fix regression that prevented Always Show Reader View from working.
2020-03-16 07:58:51 -05:00
07042b8a2a
Implemented Clean Up keyboard shortcut. Issue #1915
2020-03-15 18:15:52 -05:00
47dc34db5d
Fix Typo
...
This contains work related to issue #1910
2020-03-15 22:44:12 +01:00
2ade0140bc
Set proper cell height for empty article array
...
Contains work related to #1800
This one took me a while to figure out since they amount of articles is tied to the coordinator.
- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.
Greetings from southern germany!
2020-03-15 22:31:54 +01:00
acaf3fac9f
Add user agent to plist. Issue #1913
2020-03-15 11:48:07 -05:00
a620a20588
Add the option to select the user interface color palette. Issue #1900
2020-03-15 04:25:25 -05:00
5b5eaf6bb7
Merge branch 'ios-release'
2020-03-14 17:13:25 -05:00
07dc4f1f10
Don't start the article extractor if we only want to store the article. Issue #1494
2020-03-14 06:31:14 -05:00
e6af6ece42
Add top and bottom margins to figure elements
2020-03-13 22:01:07 -05:00
9a3fe5caa5
Add a max-width to body
2020-03-13 21:36:16 -05:00
66e7e425aa
Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806
2020-03-13 17:06:53 -05:00
833c336f2f
Only show the timeline next read button when the root split view controller is collapsed. Issue #1822
2020-03-13 16:03:42 -05:00
49257970af
Removed testing code. Issue #1810
2020-03-13 15:35:33 -05:00
2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width
...
Bugfix progress indicator max width
2020-03-13 15:31:30 -05:00
7922efab1e
Merge pull request #1899 from flowinho/ios-release
...
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
ce428d2cc6
Hide articleExtractor and actionBarButtonItem
2020-03-13 20:21:18 +01:00
52be6e5743
Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731
2020-03-13 10:17:00 -05:00
d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
...
Add background to pure white icons
2020-03-13 10:04:56 -05:00
130691db34
Revert to old logic
2020-03-13 14:21:38 +01:00
ee86b1a148
Apply background if feed-icon is bright
2020-03-13 11:54:31 +01:00
77fd3020cc
Correct font used to specify font size. Issue #1878
2020-03-12 19:01:10 -05:00
76dd3abff2
Properly style footnotes that have been absoluted
2020-03-12 18:32:42 -05:00
dfdf19e17f
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-03-12 18:07:49 -05:00
61a2e95d2b
Manually specify the font size to work around a WKWebView resizing bug. Issue #1878
2020-03-12 18:07:40 -05:00
c19bf93586
Merge pull request #1890 from flowinho/ios-release
...
Align feedname and date correctly if there is no title or summary
2020-03-12 17:03:58 -05:00
0a3713e078
Align feedname and date correctly if there is no title or summary
2020-03-12 22:57:30 +01:00
47e42fab0a
Removed old debugging statement.
2020-03-12 16:01:13 -05:00
da64f65c7b
Fixes close button icon distortion
...
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.
- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
feacda1c3b
HOTFIX silly me
2020-03-12 21:33:02 +01:00
91247b7f16
Adding dynamic width algorithm to the titleLabel
...
This commit adds multiple functionalities at once:
- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).
The title label now resizes itself depending on the devices it’s displazed on.
- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.
The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
97c79202fc
Added missing constraints to the UISwitch elements
2020-03-12 17:56:43 +01:00
22b9e7b54b
Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883
2020-03-11 19:45:45 -05:00
27b1443def
Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881
2020-03-11 18:17:09 -06:00
76d5f4a073
Remove flush and restore of web view queues. Issue #1882
2020-03-11 17:02:16 -06:00
38981d01bd
Don't remove items from Feeds list when batch update is performed. Issue #1879
2020-03-11 15:19:55 -06:00
9007ed4b06
Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834 , #1856 , and #1845
2020-03-11 14:47:00 -06:00
b178fe93af
Call action on return if password was added
...
This is an obvious change.
2020-03-11 14:02:06 +01:00
66fae15f64
Remove redundant code to lessen LOC
...
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
386efd632b
Changing UIContentType from username to email adress
...
Add responder switch to streamline login flow
This change achieves two things:
- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
ee0f982e93
Remove unneeded whitespaces
2020-03-02 22:33:59 +01:00
115405f1f0
Fix progress bar width, add contraints to progress label
2020-03-02 22:25:57 +01:00
94c6ca428f
Merge branch 'mac-release'
2020-03-01 16:32:31 -08:00
3a0f57e4da
Fixed toggle color. Issue #1838
2020-02-29 09:09:53 -08:00
cd5e491f00
Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression)
2020-02-26 16:02:36 -08:00
9e3f061fcb
Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808
2020-02-25 18:06:02 -08:00
5a5abb0b87
Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808
2020-02-25 15:10:51 -08:00
a4bbf65944
Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression)
2020-02-25 10:42:56 -08:00
d222a9f617
Change to not force unwrap the descriptor. Issue #1818
2020-02-24 08:42:19 -08:00
23b8af4634
Don't end the operation until the deselection animation has completed. (Regression)
2020-02-24 08:07:14 -08:00
afadadff69
Restore timeline selection when coming back into foreground. (Regression)
2020-02-23 17:12:02 -08:00
48e856fc04
Serialize access to the UITableView for scrolling and diffable datasource updates. Issue #1806
2020-02-23 10:57:20 -08:00
ad7dde8564
Merge branch 'ios-candidate'
2020-02-21 17:02:14 -08:00
fd0363aad2
Turn double space into single space after sentence in Settings.
2020-02-18 23:14:27 -08:00
3e93877362
Add instructions for full screen and fix some dynamic type problems. Issue #1799
2020-02-18 17:30:25 -08:00
28c2598cf6
Exempt the current article from the timeline read filter. Issue #1798
2020-02-18 14:14:18 -08:00
Maurice Parker
Rizwan Mohamed Ibrahim
Nate Weaver
Brent Simmons
zgjie
Anh Do
Flowinho
Flowinho
Michele Volpato