Commit Graph

575 Commits

Author SHA1 Message Date
Brent Simmons ad600884fc Skip drawing a light gray background for unloaded (or nonexistent) avatars in the timeline. 2018-02-17 22:29:40 -08:00
Brent Simmons 203637b30e Show a star in the timeline for starred articles. 2018-02-17 22:23:36 -08:00
Brent Simmons e789130248 Start work on laying out the star in the timeline cell. 2018-02-17 21:46:19 -08:00
Brent Simmons c0d7a87231 Do misc. minor cleanups in SidebarViewController. 2018-02-17 21:08:36 -08:00
Brent Simmons 39afef3db8 Darken the split view divider by just a smidge. 2018-02-17 21:01:32 -08:00
Brent Simmons b7e79b5aff Move some functions to where they actually belong in MainWindowController. 2018-02-17 20:58:30 -08:00
Brent Simmons 5e9ae73fcd Remove to unused functions from MainWindowController. 2018-02-17 20:46:33 -08:00
Brent Simmons 5ffe3bb948 Move existingToolbarItem function to NSToolbar category in RSCore. 2018-02-17 20:45:15 -08:00
Brent Simmons a633c49a6c Move toolbar and sharing service delegates from MainWindowController to separate objects. 2018-02-17 20:33:30 -08:00
Brent Simmons 054c7fb409 Remove unused references to AppNavigationKeyPressed. 2018-02-17 18:26:17 -08:00
Brent Simmons 2325e7edbc Move the isOpen property from specific window controllers to the NSWindowController extension in RSCore. 2018-02-17 18:22:57 -08:00
Brent Simmons 9d39ae2de4 Create and use AppImages.swift for widely-referenced images. 2018-02-17 18:19:25 -08:00
Brent Simmons 58a1a92481 Remove isDisplayingSheet property now that it’s part of an NSWindowController extension. 2018-02-17 18:14:51 -08:00
Brent Simmons 95268db09b Use CoalescingQueue with the refresh progress indicator in the sidebar. 2018-02-17 18:10:00 -08:00
Brent Simmons c5ed540194 Use CoalescingQueue.standard instead of one created by AppDelegate. 2018-02-17 17:45:05 -08:00
Brent Simmons c8fa1b71d9 Create and use a fetchAndMergeArticlesQueue (coalescing queue) for TimelineViewController. 2018-02-17 15:29:55 -08:00
Brent Simmons b3ea268807 Use appDelegate’s coalescing queue to update toolbar items. 2018-02-17 15:20:07 -08:00
Brent Simmons 7bcb8f7d12 Use appDelegate’s coalescing queue for reloading visible cells. 2018-02-17 15:16:30 -08:00
Brent Simmons d1137b7192 Use appDelegate’s coalescing queue for updating the dock badge. 2018-02-17 15:15:53 -08:00
Brent Simmons 1a5c9d130d Use appDelegate’s coalescing queue for fetching unread counts for smart feeds. 2018-02-17 15:15:26 -08:00
Brent Simmons 9e860321bd Add a short duration (0.05 seconds) coalescing queue to AppDelegate for the rest of the app to use. 2018-02-17 15:14:48 -08:00
Brent Simmons 8e18c85b58 Remove no-longer-valid comment. 2018-02-17 12:36:18 -08:00
Brent Simmons c048b6bea0 Delete now-unused data source methods from TimelineViewController.. 2018-02-17 12:29:57 -08:00
Brent Simmons 673686ca68 Create TimelineDataSource as part of making TimelineViewController less big. 2018-02-17 12:21:15 -08:00
Brent Simmons 21f262e953 Make mark-as-starred menu item work; make it validate; change its name as needed. 2018-02-17 12:01:14 -08:00
Brent Simmons ce5b60cfe8 Update mark-as-starred toolbar item tooltip during validation. 2018-02-17 10:32:32 -08:00
Brent Simmons 1603d0b3f2 Make progress on the star/unstar command and on updating its toolbar item. 2018-02-16 22:35:04 -08:00
Brent Simmons e1a51b8acd When updating a timeline that’s already displaying, merge articles by articleID, so that updated versions replace older versions. 2018-02-16 21:21:27 -08:00
Brent Simmons dbab809420 Hide the detail status bar view at first. Fix #348. 2018-02-16 21:08:34 -08:00
Brent Simmons d081f041f8 Skip group rows when going to next unread. Fix #273. 2018-02-15 17:50:31 -08:00
Brent Simmons 22d335d4ad Bump version number. 2018-02-14 13:21:40 -08:00
Brent Simmons 71e38bfb3b Update the copyright date in Info.plist, which fixes it in the About box. 2018-02-14 13:18:47 -08:00
Brent Simmons 2f21dbf6be Remove extraneous get { from a bunch of read-only accessors. 2018-02-14 13:14:25 -08:00
Brent Simmons 0762074e91 Support display of articles in the timeline from multiple items selected in the sidebar. As a side effect: fix #295. 2018-02-12 22:13:37 -08:00
Brent Simmons f2228120b5 Make SidebarOutlineDataSource a separate object. Move data source methods out of SidebarViewController. 2018-02-12 22:02:51 -08:00
Brent Simmons e773df33e3 Start work on saving main window state. 2018-02-12 13:31:43 -08:00
Brent Simmons 9adf047525 Add Donate to App Camp for Girls menu item to the Help menu. It opens the browser to https://appcamp4girls.com/contribute/
Fix #181.
2018-02-12 13:10:13 -08:00
Brent Simmons 09b8cd7811 Support the Copy command in the timeline. Fix #114. 2018-02-12 13:04:07 -08:00
Brent Simmons 81e56ba84b Implement and validate the Copy command for the sidebar. Fix #115. 2018-02-11 22:10:28 -08:00
Brent Simmons 1aac355418 Make all senders parameters for actions optional — Any? instead of AnyObject or Any. 2018-02-11 18:58:50 -08:00
Brent Simmons 84a8cb1a0e Punt font size till after 1.0. 2018-02-11 18:58:01 -08:00
Brent Simmons b43670b747 Disallow blurring behind the title bar, since it’s buggy. It doesn’t always update the blur when the content changes — it appears to wait for a scroll. This can lead to a blur of the selection color under the title bar when it doesn’t make sense. 2018-02-11 18:06:06 -08:00
Brent Simmons 46e0f781f8 Skip clearing undo stack when timeline view changes articles. Fix #341. 2018-02-11 17:45:02 -08:00
Brent Simmons 2495a882ee Make the buttons at the bottom of the Feed Directory not change their width on window resize. 2018-02-11 17:42:58 -08:00
Brent Simmons f72da562e0 Fix disclosure triangle padding in the Feed Directory. Implement the Open Home Page command. 2018-02-11 17:14:09 -08:00
Brent Simmons ddf57944be Remember the Feed Directory window’s frame between runs. 2018-02-11 17:13:34 -08:00
Brent Simmons 263fc50c38 Make progress on the Feed Directory window. 2018-02-11 16:20:46 -08:00
Brent Simmons 3262a7a8fc Skip downloading feeds for the Feed Directory, since feed previews have been punted to after 1.0. 2018-02-11 16:19:53 -08:00
Brent Simmons 8060f1ccd6 Remove feed preview view from Feed Directory. Punted that till after 1.0. Also: made the Feed Directory window vibrant dark. Gratuitously. 2018-02-11 15:15:52 -08:00
Brent Simmons f8e4fb4f1c Bump version number. 2018-02-11 14:30:48 -08:00
Brent Simmons c8d2fac9a6 Rename MarkReadOrUnreadCommand to MarkStatusCommand and make it handle starring/unstarring and deleting/undeleting. Also: add contextual menu for smart feeds in the sidebar. 2018-02-11 12:59:35 -08:00
Brent Simmons a13d21395e Fetch starred articles for the Starred smart feed. 2018-02-11 12:07:55 -08:00
Olof Hellman f563c2f78e Merge remote-tracking branch 'brentsimmons/master' 2018-02-11 01:20:38 -08:00
Olof Hellman 43cfb54437 support for permalink and external url
Consolidate GetURL AppleEvent handling into AppDelegate+Scriptability
file
Add scripting access groups to sdef
Add exists command
Add ‘permalink’ and ‘external url’ properties to the article scripting
object
Add a unit test to verify the behavior of ‘current article’
2018-02-11 01:20:30 -08:00
Brent Simmons 5aeb914ab6 Fetch articles for the Today smart feed. 2018-02-10 17:37:47 -08:00
Brent Simmons d6d2b8d26c Remove Action item from the toolbar. Fix #337. 2018-02-10 15:49:58 -08:00
Brent Simmons 3e60f929a2 Add stubs for fetching articles for starred and today feeds. 2018-02-10 13:22:02 -08:00
Brent Simmons f5bfadfb33 Make the UnreadFeed conform to ArticleFetcher. It now displays articles in the timeline when selected. 2018-02-10 13:00:53 -08:00
Brent Simmons 9ac2d7d033 Create a WKWebView subclass (ugh) in order to hide items in its contextual menu. Fix #120. 2018-02-10 11:16:09 -08:00
Brent Simmons d46ae4df33 Add contextual menu to timeline. 2018-02-09 23:16:12 -08:00
Brent Simmons 46cae22987 Use the menu.takeItems method. 2018-02-09 22:10:52 -08:00
Brent Simmons 68d81b7581 Rearrange toolbar to put search closer to timeline. 2018-02-09 21:58:42 -08:00
Brent Simmons 582fd62080 Start work on timeline contextual menus. 2018-02-08 13:24:43 -08:00
Olof Hellman dcd2ee94f9 Merge remote-tracking branch 'brentsimmons/master' 2018-02-08 00:12:33 -08:00
Olof Hellman 395af1420e implement 'current article' property of the application
Also, fix the unique-id based accessors (the four byte code  for id was
wrong in the sdef)
Add valueIn<Key>WithUniqueID accessors
Add a few protocols and protocol implementations for the AppDelegate
and MainWindowControllor so as to expose needed functionality for
scriptability
2018-02-08 00:11:52 -08:00
Brent Simmons 765a91dd34 Restore selection in timeline after reload due to font size change. 2018-02-07 21:48:51 -08:00
Brent Simmons 2797c607c3 Update row height in timeline when font setting changes. 2018-02-07 21:46:54 -08:00
Brent Simmons 78530dbb96 Change the name of the Show/Hide Sidebar command as needed. Fix #98. 2018-02-07 21:42:33 -08:00
Brent Simmons a3a9d467dc Show the contextual menu for all selected items in the sidebar when the clicked row is part of the selection. 2018-02-07 21:23:18 -08:00
Brent Simmons 4491c5f443 Make the sidebar contextual menu refer to the clicked row rather than the selected row. 2018-02-07 13:25:17 -08:00
Brent Simmons d59058c014 Show a contextual menu in the sidebar. Create and wire-up SidebarContextualMenuDelegate. 2018-02-07 13:17:28 -08:00
Brent Simmons 1f0123db36 Remove code setting the sidebarViewController on SidebarOutlineView, since it doesn’t use it. 2018-02-07 13:11:40 -08:00
Brent Simmons 03b1440045 Reorder UTI types in FeedPasteboardWriter to be like the order in ArticlePasteboardWriter. 2018-02-04 13:45:26 -08:00
Brent Simmons d6eb6e2f1d Bump version number. 2018-02-04 12:18:28 -08:00
Brent Simmons 6b14d6e8d3 Remove temporarily the Delete menu item from the sidebar gear menu. 2018-02-04 12:15:59 -08:00
Brent Simmons c26c705de0 Make Mark All as Read command in sidebar gear menu work. 2018-02-04 11:45:51 -08:00
Brent Simmons 2999641572 Move MainWindowController+ContextualMenus to SidebarViewController+ContextualMenus, where it always should have been. 2018-02-04 11:19:24 -08:00
Brent Simmons 27c5ffa5eb Add new-feed and new-folder commands to the sidebar gear menu when there’s no selection. 2018-02-03 21:30:30 -08:00
Brent Simmons 68d0885b0d Get rename sheet working, finally. 2018-02-03 21:04:28 -08:00
Brent Simmons ae840b31bc Continue progress on rename sheet. 2018-02-03 20:30:23 -08:00
Brent Simmons 01729378f3 Make further progress on rename sheet. 2018-02-03 18:49:29 -08:00
Brent Simmons a03562eee8 Make further progress on the rename sheet. 2018-02-03 16:05:59 -08:00
Brent Simmons e7ce12869c Disable commands to add a feed or add a folder if the window is already displaying a sheet. Fix #319. 2018-02-03 10:56:12 -08:00
Brent Simmons 9fce370967 Try again to check in the added outlets. 2018-02-02 23:01:12 -08:00
Brent Simmons 70a3e6cc89 Wire up outlets for the rename sheet. 2018-02-02 23:00:09 -08:00
Brent Simmons 50dcf436d9 Change Cocoa imports to AppKit imports, because we don’t need CoreData imported (which Cocoa imports). 2018-02-02 22:51:32 -08:00
Brent Simmons 07052c565c Layout rename sheet. 2018-02-02 22:39:59 -08:00
Brent Simmons 6347ac7888 Merge branch 'master' of https://github.com/brentsimmons/Evergreen 2018-02-02 21:56:52 -08:00
Brent Simmons 920be7b0d1 Start work on the sidebar gear menu. There are commands there now. They don’t all work. 2018-02-02 21:56:17 -08:00
Daniel Jalkut a291f1e93c Merge branch 'fix-toolbar-validation' into xcode9.3 2018-01-29 11:49:47 -05:00
Daniel Jalkut e4136c2165 Sender should be Any? to reflect the fact it may be nil. This nuance seems to make the difference on Xcode 9.3/Swift 4.1 between crashing or not. Without this change, refreshing crashes every time, presumably because Swift is making assumptions about the parameter being non-nil and refreshProgressDidChange calls it explicitly with a nil parameter. 2018-01-29 11:48:09 -05:00
Daniel Jalkut d7f13ca4be Change from flatMap to new compactMap rename in Xcode 9.3. 2018-01-29 11:19:54 -05:00
Brent Simmons 2d7d903bca Create and use a SidebarGearMenuDelegate to show a menu when the gear menu in the sidebar is clicked. 2018-01-28 16:09:18 -08:00
Brent Simmons 29fe1869aa Build contextual menus in MainWindowController extension. 2018-01-28 13:28:33 -08:00
Brent Simmons 199cfcb4eb Create ContextualMenuCreator. 2018-01-28 12:13:43 -08:00
Brent Simmons 285e3971d7 Re-sort the timeline when sort direction changes. Fix #65. 2018-01-28 11:45:18 -08:00
Brent Simmons 78e8823f23 Merge branch 'master' of https://github.com/brentsimmons/Evergreen 2018-01-28 11:33:58 -08:00
Brent Simmons ffd11b91ef Register for UserDefaults.didChangeNotification instead of using KVO on NSUserDefaultsController. 2018-01-28 11:33:45 -08:00
Brent Simmons 28c4ea82e5 Consider sort direction when sorting the Article array for the timeline. 2018-01-28 11:33:04 -08:00
Brent Simmons 144bccd45e
Merge pull request #305 from michaeljtsai/master
Share button now supports "EagleFiler Import" and "Add to Reading List".
2018-01-28 10:51:45 -08:00