Commit Graph

168 Commits

Author SHA1 Message Date
Nate Weaver 4a0bbeacc2 Disable Web Inspector for App Store builds
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Ben Ubois 1728f4d198 Made indents consistent. 2019-09-18 22:53:25 -07:00
Ben Ubois 1c9117ab8e Reset scroll position to top on render.
Prevents an issue where the next article would inherit the previous
article's scroll position.
2019-09-18 22:39:07 -07:00
Ben Ubois 0b6683d073 Render with evaluateJavaScript.
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker 8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker 372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker 786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Maurice Parker 9c9517d7d9
Merge pull request #1026 from Wevah/enable-inspector
Enable inspector
2019-09-17 14:44:06 -05:00
Maurice Parker 8a8dcde387 Add javascript to remove styling from articles. Issues ##499, #999, and #947 2019-09-17 14:32:18 -05:00
Nate Weaver e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons 1ece325112 Merge mac-release. 2019-09-16 20:09:04 -07:00
Brent Simmons a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons 2d22f061a5 Remove no-longer-needed functions for compositing the avatar on a background. 2019-09-16 20:07:07 -07:00
Maurice Parker 18d6a278c7 Merge branch 'mac-release' 2019-09-16 16:37:18 -05:00
Maurice Parker 0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons 8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker b0b3f58036 Merge branch 'mac-release' 2019-09-15 04:10:50 -05:00
Maurice Parker 7c3c78b796 Remove debug print statement 2019-09-15 04:08:10 -05:00
Maurice Parker 90cc8ffa6f Merge branch 'mac-release' 2019-09-15 04:06:52 -05:00
Maurice Parker 20dda3727b Change to use the scaled avatar version of the favicon. 2019-09-15 04:05:11 -05:00
Maurice Parker b07bf73f78 Revert "Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering."
This reverts commit c3e26ea307.
2019-09-15 04:00:24 -05:00
Brent Simmons 7d738baef3 Merge branch 'mac-release' 2019-09-14 22:41:44 -07:00
Brent Simmons c3e26ea307 Scale images, when needed, before generating inline HTML data in ArticleRenderer — this keeps us from getting huge amounts of data, which slows down rendering. 2019-09-14 22:41:13 -07:00
Phil Viso 8a6e3c9f37 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
# Conflicts:
#	Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
Phil Viso 61d3dae10e Re-wrote sorting code to be smaller and easier to understand 2019-09-13 08:03:56 -05:00
Phil Viso 269364a337 Re-worked sorting logic to handle multiple feeds having the same name 2019-09-13 07:43:28 -05:00
Maurice Parker 2737f07906 Add folder picker to share extension 2019-09-12 12:33:05 -05:00
Brent Simmons 2eccfbb90e Merge branch 'mac-release' 2019-09-08 21:44:28 -07:00
Brent Simmons 41c82eca15 Rename existingFeed(with:) to existingFeed(withFeedID:) to make it more clear. Make account.idToFeedDictionary private — callers should use existingFeed(withFeedID:). 2019-09-08 21:44:05 -07:00
Maurice Parker 77373c5bc0 Merge branch 'mac-release' 2019-09-08 18:56:53 -05:00
Phil Viso 00e009a82c Added ability to group sorted articles by feed 2019-09-08 16:48:50 -05:00
Brent Simmons ecc8854f59 Merge mac-release. 2019-09-07 20:59:19 -07:00
Brent Simmons 5b15285e8e Make sure that article.preferredLink doesn’t return an empty string. 2019-09-07 18:27:48 -07:00
Maurice Parker c9fd7d01d9 Add delete feed keyboard shortcut 2019-09-05 15:54:58 -05:00
Maurice Parker 8a5ae8c2a8 Remove the title from a couple of shortcuts. The shortcuts still work, they just don't show in the discovery view. 2019-09-05 11:29:49 -05:00
Maurice Parker 40ff8c3048 Add titles to keyboard configuration files for use on iOS 2019-09-04 04:37:03 -05:00
Maurice Parker 722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Maurice Parker a59f223043 Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS 2019-09-04 02:40:35 -05:00
Maurice Parker 5cb099aee6 Add next unread as a user activity and more aggressively invalidate user activities 2019-09-03 15:52:59 -05:00
Maurice Parker 189af8d816 Invalidate user activities when collapsed and returning to Feeds scene 2019-09-01 15:31:11 -05:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker 56c81bba1f Delete code that was doing an unnecessary rebuild of the treeController. This will be done by the controllers receiving the batch update notification. 2019-09-01 10:57:08 -05:00
Maurice Parker 87030a5921 Implement stateRestorationActivity to save most relevant current user activity 2019-08-31 19:30:21 -05:00
Jim Correia 5f11c42fc2 Use noContentHTML rather than noSelectionHTML for prepared web views.
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
Maurice Parker fe2e0155da Add scoped searching of articles 2019-08-31 15:53:47 -05:00
Maurice Parker 89a38fa2b5 Change Feeds to use diffable data sources 2019-08-28 18:06:27 -05:00
Maurice Parker d7ec92ef34 Delete unnecessary user activity property value 2019-08-28 11:46:03 -05:00
Maurice Parker 5aba61ea04 Update user activity if a feed has been selected and its best icon has been downloaded 2019-08-28 11:44:54 -05:00
Maurice Parker 9c66f6160e Clean activities when the associated data is deleted 2019-08-28 11:30:40 -05:00
Maurice Parker ba9f7ac426 Add navigation support for Folder and Feed view activities 2019-08-27 17:43:15 -05:00
Maurice Parker d641223536 Add Activities for viewing Feeds and Folders 2019-08-27 14:20:34 -05:00
Maurice Parker 17fef112d6 Merge branch 'mac-release' 2019-08-26 19:40:56 -05:00
Maurice Parker 3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker 8de9b355c7 Merge branch 'mac-release' 2019-08-26 12:54:53 -05:00
Maurice Parker 1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Maurice Parker a0636b8f47 Add Smart Feeds as User Activities 2019-08-25 17:04:15 -05:00
Maurice Parker dc6bf05ae4 Rename ActivityFactory to ActivityManager because it will also handle activity deletes in the future 2019-08-25 14:43:11 -05:00
Maurice Parker eb9c176f90 Add unique identifier to Spotlight attributes to prevent duplicate spotlight search results 2019-08-25 11:51:08 -05:00
Maurice Parker 313518698c add the ability to respond to NSActivityRequests 2019-08-24 19:31:29 -05:00
Maurice Parker 5b1c0485c5 Add NSUserActivity for reading articles 2019-08-24 14:57:51 -05:00
Brent Simmons 0c455c086d Merge branch 'mac-candidate' 2019-08-21 13:06:57 -07:00
Brent Simmons 98ec923c67 Replace, in default feeds for new users, Om Malik and Xcoders with Rose Orchard and Michael Tsai. 2019-08-21 13:06:26 -07:00
Brent Simmons 2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons 1a70d7797c Merge branch 'mac-candidate' 2019-08-04 23:02:38 -07:00
Brent Simmons 13797c6693 Remove no-longer-needed removal of that weird character Six Colors uses in some of their headlines. 2019-08-04 23:02:09 -07:00
Maurice Parker e263665a21 Merge branch 'mac-candidate' 2019-07-23 16:36:46 -05:00
Maurice Parker 4fc1998cf3 Make Account and AccountDelegate interfaces more consistent by requiring the container parameter on removeFeed. Resolves #802 2019-07-17 15:41:21 -05:00
Brent Simmons fe5570fbea Merge branch 'mac-candidate' 2019-07-06 11:54:14 -07:00
Brent Simmons fbb7b9961c Change an import Cocoa to import AppKit. 2019-07-06 11:52:15 -07:00
Brent Simmons 3999c7b3c5 Merge branch 'mac-candidate' 2019-07-05 22:42:01 -07:00
Brent Simmons 7a204ad6ed Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in. 2019-07-05 20:06:31 -07:00
Maurice Parker 5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker 2ee72125ba Support dark mode for small avatars on iOS 2019-06-20 11:58:26 -05:00
Maurice Parker d794240bd9 Merge branch 'mac-candidate' 2019-06-19 11:31:38 -05:00
Maurice Parker 40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker 46bc867241 Add additional sort criteria for when published date is equal. Issue #644 2019-06-13 15:51:28 -05:00
Maurice Parker e4ee311227 Revert "escape title HTML in web view. Issue #722"
This reverts commit a087410177.
2019-06-12 10:51:15 -05:00
Maurice Parker 902304c723 Convert Settings to use SwiftUI 2019-06-11 16:59:16 -05:00
Maurice Parker e8199ed0a6 Change to not show alert dialog on automatic refreshes. Issue #729 2019-06-10 15:21:17 -05:00
Maurice Parker a087410177 escape title HTML in web view. Issue #722 2019-06-07 15:53:13 -05:00
Maurice Parker e8992dac95 Fix issue where deletes were crashing the app. Issue #702 2019-06-05 17:42:35 -05:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker 527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker 493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Maurice Parker 5d1c7d08ac Remove strong reference to Account that was preventing Accounts from being deallocated 2019-05-22 15:08:22 -05:00
Maurice Parker 3207ebf6a5 Implement default timeline avatar. Issue #641 2019-05-21 05:42:40 -05:00
Maurice Parker 31cc3b609c Make delete animation correct for deletes and restores by wrapping them in BatchUpdates. Issue #667 2019-05-20 18:05:28 -05:00
Brent Simmons 1ee0ab5a73 Fix logic in FeedIconDownloader so that we check the home page metadata. (I had broken this recently.) 2019-05-17 23:02:18 -07:00
Maurice Parker 6882b152d9 Add timer to trigger article status sync process. 2019-05-15 17:21:58 -05:00
Brent Simmons f5f8d67411 Scale images always on a background queue. Fix #642. 2019-05-14 22:44:06 -07:00
Brent Simmons 7b40ca221b Use the articleID + accountID as a key for truncated summaries. This is *way* faster than using the entire body. It avoids a hash of a long string. (Note: we still need to toss the cache at the appropriate time.) 2019-05-13 22:16:44 -07:00
Brent Simmons 7c78d914be Speed up timeline scrolling by only going up to 150 characters with summary calculation. 2019-05-13 22:06:03 -07:00
Maurice Parker 6d5b3884fc Put folder pop up menu for add feed in the correct order 2019-05-13 11:31:04 -05:00
Brent Simmons b211eda05d Make the feed URL for inessential.com use the new https version. 2019-05-12 21:11:02 -07:00
Maurice Parker 6f92cd1a73 Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors 2019-05-11 12:26:23 -05:00
Maurice Parker 23b43ecc07 Add undo for feeds 2019-05-09 16:09:21 -05:00
Maurice Parker cda8acc66c Add the ability to move feeds between folders for Feedbin 2019-05-09 13:31:18 -05:00