Nate Weaver
aad1fc4a0c
Call the completion handler with nil if faviconURLs is nil
...
Fixes #1791 .
2020-02-15 08:53:56 -06:00
Nate Weaver
b3f736f899
Add a clarification comment
2020-02-15 08:22:59 -06:00
Nate Weaver
ee48f4baba
Remove redundant nil check for homePageURL
2020-02-15 08:22:51 -06:00
Nate Weaver
2ac4df4ee6
Use a single compactMap() instead of filter().compactMap()
2020-02-08 18:22:35 -06:00
Brent Simmons
2cdcddeefe
Handle possible nil favicon.urlString.
2020-02-05 22:43:18 -08:00
Nate Weaver
0d128c0c3c
Fix spacing
2020-02-02 17:53:46 -06:00
Nate Weaver
830db84c56
Explicitly import CoreServices
...
For UTType stuff; iOS doesn't implicitly import it.
2020-02-01 18:03:44 -06:00
Nate Weaver
e9a3764270
Documentation comment
2020-02-01 18:03:44 -06:00
Nate Weaver
101e140233
Make ignoredTypes a static property to avoid redundant lookups
2020-02-01 18:03:44 -06:00
Nate Weaver
f65bf63bb1
Add the ability to ignore types to FaviconURLFinder, and ignore SVG favicons
2020-02-01 18:03:44 -06:00
Nate Weaver
97049be067
Only add to the no-favicons cache if the only icon was the defaulted favicon.ico
2020-02-01 18:03:44 -06:00
Nate Weaver
b088cda5a5
Fix homePageURLsWithNoFaviconURLCache
2020-02-01 18:03:44 -06:00
Nate Weaver
7ee1f99962
Updates for Data+RSCore changes
2020-01-18 19:18:58 -06:00
Nate Weaver
b35215d03b
Update for pending RSCore String updates
2020-01-17 13:45:38 -06:00
Nate Weaver
0b404c294d
Update to newest RSCore
2020-01-09 18:22:06 -06:00
Maurice Parker
58b24f3349
Rename callback: to completion:
2019-12-14 18:01:34 -07:00
Nate Weaver
71bc1e5d8a
Return the app icon earlier so we never hit the favicon cache
2019-12-07 16:09:32 -06:00
Nate Weaver
bf4dd59d90
Use the app icon for the NNW feed
2019-12-07 15:45:33 -06:00
Nate Weaver
64af8840fe
Mark appropriate caches as dirty
2019-11-27 15:45:14 -06:00
Nate Weaver
f690bba775
Make sure self.postDidLoadFaviconNotification() is always called after a download attempt
...
Otherwise the rest of the favicon URLs won't be tried.
2019-11-27 15:40:35 -06:00
Maurice Parker
ef2222ad94
Merge branch 'mac-release'
2019-11-27 14:08:52 -06:00
Nate Weaver
9de27febf0
Fix favicon loading for sites with multiple/invalid favicons
...
Load the next favicon if a favicon is invalid
Iterate through multiple favicons and use the first that actually loads
- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.
Post notification even if the icon failed to load
Update RSParser
Remove single-favicon helper methods
Only load the next favicon if the current load failed
Update RSParser
Make sure to try the default favicon.ico
RSParser test fix update
Update RSParser
2019-11-27 13:02:49 -06:00
Maurice Parker
06bd5b3a6f
Renamed Feed and related classes/instances to WebFeed
2019-11-14 20:11:41 -06:00
Maurice Parker
560f36621f
Add IconImage to encapsulate our icon processing logic
2019-11-05 18:05:57 -06:00
Maurice Parker
8eb99b01c3
Increase default icon brightness
2019-10-31 14:25:09 -05:00
Maurice Parker
8ba15c6234
Cache favicon to homepage mappings
2019-10-31 14:04:34 -05:00
Maurice Parker
5717c84067
Make generated favicons a little bit brighter
2019-09-30 02:59:27 -05:00
Brent Simmons
fbb7b9961c
Change an import Cocoa to import AppKit.
2019-07-06 11:52:15 -07:00
Maurice Parker
40b9be6709
center smaller avatars on a solid color background image to make all avatars a consistent size
2019-06-14 15:33:13 -05:00
Maurice Parker
3207ebf6a5
Implement default timeline avatar. Issue #641
2019-05-21 05:42:40 -05:00
Maurice Parker
2dcde1ab8e
Create generic feed icon and timeline avatar
2019-04-29 07:07:57 -05:00
Maurice Parker
8526db8b4c
Added initial POC version of NetNewsWire for iOS to use as a starting point for the actual app.
2019-04-15 15:03:05 -05:00
Brent Simmons
70312aa75c
Major folder and project tree restructuring.
2019-04-13 16:18:54 -07:00