5f045706e4
Removed usaged of UIApplication.present
2019-06-27 14:21:07 -05:00
9653befb94
Retrieve credentials if necessary. On iOS credentials aren't always available when the delegate initializes.
2019-06-23 13:56:11 -05:00
1ac1144b2d
Reduce footprint of Account credentials API
2019-06-20 11:19:15 -05:00
2756e8f204
Ensure that invalid username/password combinations throw an error
2019-06-20 11:18:09 -05:00
fa62acb585
Rebrand Reader API to FreshRSS
2019-06-20 07:22:51 -05:00
74f84dc000
Restrict OPML import for Account types that don't support it
2019-06-19 17:50:32 -05:00
b4b80c51bc
Renamed google reader api to just reader api to make it consistent everywhere we use it
2019-06-19 15:40:03 -05:00
15ae97f7c9
Merge branch 'master' into google_reader_compatible_syncing
2019-06-19 13:53:30 -04:00
d794240bd9
Merge branch 'mac-candidate'
2019-06-19 11:31:38 -05:00
d87f68a006
Renamed GoogleReaderCompatible to just Reader
2019-06-19 12:25:37 -04:00
52cb066dd4
Cleanup unused objects
2019-06-19 07:56:25 -04:00
47a7fa420d
Fixed error caused by updating to the latest from RSWeb
2019-06-16 14:55:48 -05:00
f6677367ec
use refresh indicator to track all network activity. Issue #759
2019-06-16 14:48:50 -05:00
42203c0170
FIrst pass at OPML import. Broken.
2019-06-16 15:14:20 -04:00
adf53add3a
removed unused page number function.
2019-06-16 13:15:36 -04:00
17439c8c5e
Disbale and rename tags functional.
2019-06-16 13:14:23 -04:00
41af536212
Rename feeds
2019-06-15 16:13:08 -04:00
62afd312f0
Subscribing and loading initial articles functioning.
2019-06-15 15:46:13 -04:00
029bcbda96
Merge cleanup.
2019-06-15 13:30:12 -04:00
f54bc3569b
Merge branch 'master' into google_reader_compatible_syncing
...
# Conflicts:
# Frameworks/Account/Account.swift
# submodules/RSWeb
2019-06-15 12:34:50 -04:00
e5eb8df333
Add feed working on backend, thread crash inside account code.
2019-06-15 12:27:21 -04:00
5490dac86d
Need to use rawValue to properly mark starred/read
2019-06-15 08:21:13 -04:00
2128afd465
Refactor endpoints into an enum
2019-06-13 12:44:20 -04:00
dac166cf58
Refactor status change calls.
2019-06-13 09:35:01 -04:00
871dbbb752
moved dispatch group notify to background thread as it was deadlocked with the dispatch group wait on app exit
2019-06-12 17:28:54 -05:00
45c15c96aa
Marking read/unread functioning.
2019-06-12 16:41:44 -04:00
c1e89a2ae0
Updated to the latest RSWeb
2019-06-12 15:09:06 -05:00
69c947bd65
Mark read/unread structure.
2019-06-11 16:42:28 -04:00
dc60ebf1f8
Unread status is properly set when articles are downloaded from backend
2019-06-11 15:37:21 -04:00
17c04b2aef
Show the refresh progress bar when an OPML import starts. Issue #732
2019-06-10 16:17:54 -05:00
9144ee71e5
Request article IDs and content.
2019-06-10 16:53:35 -04:00
93fbbd4cc3
Make sure that FeedFinder and InitialDownloader are running on the main thread.
2019-06-10 08:21:03 -05:00
f4e0cfaf2b
Fix folder renaming issue that occurs for Feedbin when the tag doesn't exist at Feedbin. Issue #724
2019-06-07 05:03:54 -05:00
eb71e88845
Resolved issue where local account feed finder could lock up the UI if an error was thrown. Issue #720
2019-06-06 19:46:42 -05:00
e7ec59f31f
Merge pull request #725 from tgt/tgt/feedbin-fixes
...
Various Minor Feedbin Fixes
2019-06-06 15:27:06 -05:00
1cfc3bceef
Fixed restore folder functionality for Feedbin.
2019-06-06 15:22:25 -05:00
b0a24b6f17
Revert "Fix updating local feed list when no remote feeds."
...
cd85e52fdd
2019-06-06 14:23:06 +01:00
534da0bca6
Move call to sendArticleStatus to delegate.
2019-06-06 14:22:29 +01:00
0447694142
Fix feed selection when the max feed score is 0.
...
This occurs, for example, when searching for “macrumors.com” and adding
to the Feedbin account. All four feeds have a score of 0 since their
source is set as HTMLLink. This would also fix a case in which there are
two feeds: one with a negative score and one with a score of 0.
Since the method uses a Set the feed selected when there are multiple
feeds with an identical maximum score will be random.
2019-06-06 10:31:00 +01:00
ac9057299a
Remove edited name when remote feed name changes.
2019-06-06 10:31:00 +01:00
f3505e4537
Fix posting name notifications when name changes.
2019-06-06 10:31:00 +01:00
b4d7042a7b
Ensure status changes are sent before refresh.
...
When the refresh button was manually clicked a full refresh would occur,
but locally changed statuses wouldn't be sent. This meant the statuses
of items in NetNewsWire would revert to their remote values until an
automatic status sync was triggered.
2019-06-06 10:31:00 +01:00
3c1b84dd73
Fix a Feedbin subscriptionID going out of sync.
...
If, for example, a user deleted a feed and recreated it on the server
without a sync in between, the subscription ID for the feed would update
on the server, but remain unchanged locally. If the user then wanted to
delete or rename the feed they'd get a 404 error.
2019-06-06 10:31:00 +01:00
cd85e52fdd
Fix updating local feed list when no remote feeds.
...
When there were no remote feeds the logic to remove local
feeds was skipped.
2019-06-03 17:09:17 +01:00
6b147e7dc9
Add feeds to tags. Set iconURLs
...
remove unused functions.
2019-06-01 17:05:55 -04:00
a0efc7fda9
Cleanup tag names, fetch subscriptions
2019-06-01 08:08:19 -04:00
76d1daf122
Cleanup merge issues/API changes
2019-06-01 06:54:10 -04:00
2d91e64148
Provide a better error message when encountering feed not found and already subscribed errors
2019-05-31 17:24:43 -05:00
8e0c857810
Update the extract page number function to make it more readable
2019-05-31 13:38:33 -05:00
98c32b9987
Merge branch 'master' into google_reader_compatible_syncing
2019-05-31 09:54:25 -04:00
88b2775076
Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated
2019-05-31 08:05:26 -05:00
fec3c69f4a
Remove Feedbin api workaround for unpropagated mode=extended parameter
2019-05-31 07:54:12 -05:00
10296a1b74
Clear the feed metadata on Feedbin feed delete
2019-05-31 07:47:05 -05:00
d602f894f6
Fix link parsing bug that causes crash
2019-05-31 07:22:28 -05:00
0ddb47aa32
Refactor feed finder to make it threadsafe
2019-05-30 17:35:08 -05:00
46e21f57e8
Decoding of tags working.
2019-05-30 16:01:56 -04:00
30c21bb125
Enable folders to be dropped in a move or copy between accounts
2019-05-30 14:36:21 -05:00
1352dda8aa
Modify Feedbin feed deletes so that they emulate how the local account feed deletes work.
2019-05-30 10:12:34 -05:00
fdc0374c4f
Ensure credentials are available for use
...
Need to load metadad first
2019-05-30 07:48:34 -04:00
7bec55c90b
Add missing completion call that was causing restored feeds to not show
2019-05-29 21:39:53 -05:00
51284b5aa4
Rename deleteFeed to removeFeed to be more consistent with other API's
2019-05-29 21:04:44 -05:00
527e677934
Rename deleteFolder to removeFolder to make the API more consistent
2019-05-29 20:53:00 -05:00
f4bc17c8f1
Refactor addFeed and removeFeed usages to be more consistent
2019-05-29 20:47:52 -05:00
5e3fcfd955
Correct how feeds were deleted so that only the feed in the correct container was deleted
2019-05-29 17:56:26 -05:00
aa6dfe8a08
Rework to store endpoint URL in metadata
...
Endpoint URL did not belong with credentials. This breaks it out and stores it in the account metadata. Updates validation code to take it as a parameter.
2019-05-29 15:16:09 -04:00
0df86e5761
Authentication working
...
* Updates to use new API style per discussion with Maurice
* Credential validation functioning
2019-05-29 10:54:52 -04:00
0648053417
Enforce tag specific drop validation (can't copy to the account level)
2019-05-28 17:42:19 -05:00
cf016c5d7d
Prevent Feedbin in account copy from putting a feed in both the root account and a folder at the same time.
2019-05-28 13:38:40 -05:00
84dbdf25e2
Google Reader API Account Provider and initial integration
...
* Creation of account classes (based on FeedBin)
* Integration on Mac side into account dialog
* Initial authentication call works and extracts auth token, but no where to put it right now.
2019-05-28 13:08:15 -04:00
493abbb609
Refactor create feed functionality to increase code reuse and encapsulation
2019-05-28 09:45:02 -05:00
c7b61f7d87
Enable copy between local accounts.
2019-05-27 18:01:24 -05:00
61f9a66d74
Change so that we fire off status update immediately if the number of pending status changes exceeds 100. Issue #658
2019-05-27 12:03:12 -05:00
886b82f3bd
Fix issue where unread and unstar statuses were getting lost if there wasn't already an article. Issue #708
2019-05-26 21:05:05 -05:00
7e6db47956
Add extended mode for Feedbin entries to get avatar url. Issue #669
2019-05-26 18:35:54 -05:00
e974d788ff
Wrap OPML import in BatchUpdate. This makes it pretty much instant. Fix #653 .
2019-05-26 14:45:09 -07:00
32712533d1
Fixed duplicate adds for local account folder feed adds. Issue #701
2019-05-26 12:17:38 -05:00
c61949bc04
Add account name to network error messages and prevent background iOS errors from displaying alerts
2019-05-26 11:54:32 -05:00
5f98f0d2fc
Correct usage of weak self in completion handlers
2019-05-22 15:40:34 -05:00
a406fa9d4d
Enhance error handling to make syncing more resilient to network failures.
2019-05-21 19:15:24 -05:00
8816de4a0e
Fix issue where new Feeds added to a folder also got left in the account container.
2019-05-21 10:26:11 -05:00
d9458c8980
Make progress indicator more accurate
2019-05-21 08:34:05 -05:00
31cc3b609c
Make delete animation correct for deletes and restores by wrapping them in BatchUpdates. Issue #667
2019-05-20 18:05:28 -05:00
59ea5cadec
Add status syncing to iOS
2019-05-20 13:51:08 -05:00
1f8463d091
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into iPadPopover
...
# Conflicts:
# iOS/Settings/AddLocalAccountViewController.swift
# iOS/Settings/DetailAccountViewController.swift
# iOS/Settings/Settings.storyboard
2019-05-19 19:03:50 -05:00
48e19c23a7
Set content type for Feedbin OPML Import.
2019-05-19 18:19:08 -05:00
bce45d28e4
Updated all iOS references to default local account new to be device specific
2019-05-19 16:52:21 -05:00
80e1888244
Rename AccountsDidChangeNotification to AccountsDidChange to match other notification names.
2019-05-19 15:51:08 -05:00
7bd4520746
Remove unused weak self. (Was causing warning in Xcode.)
2019-05-19 11:33:48 -07:00
c7f02150f9
Make sure we go and get missing articles when we add a new feed.
2019-05-19 10:43:45 -05:00
9c159d21f6
Retrieve articles when we have a status but don't have an article on full refresh.
2019-05-17 14:56:27 -05:00
0a9bf2aef0
Prevent more than one OPML import from being run at the same time.
2019-05-17 10:44:22 -05:00
b89f088917
Switch to using the new OPML import service
2019-05-17 10:04:13 -05:00
87512a64a5
Removed old TODO and update to latest RSWeb
2019-05-16 11:01:44 -05:00
d8e6355b1e
Fix bug where restoring a feed in a folder could leave the feed in the account container
2019-05-16 10:33:58 -05:00
3986e00bf7
Fix bug where account unread counts weren't changing with async api calls
2019-05-16 09:54:19 -05:00
5f65fba9e2
Fix bug that prevented last unread or last unstrap from changing correctly.
2019-05-16 06:01:10 -05:00
6882b152d9
Add timer to trigger article status sync process.
2019-05-15 17:21:58 -05:00
6be6c6a682
Add send sync database contents to Feedbin
2019-05-15 11:52:56 -05:00
b1303661b2
Save article statuses to new sync database as they are created
2019-05-14 18:24:19 -05:00
f449ed9608
Make sure progress gets cleared incase the last page adjustment is inaccurate
2019-05-14 17:39:55 -05:00
30273795a8
Delegate article marking functionality to the account delegate
2019-05-14 15:34:05 -05:00
1984af4664
Add download progress for Feedbin accounts
2019-05-14 13:10:07 -05:00
e31e1a4d60
Save article statuses from articles we have not received yet
2019-05-14 10:06:29 -05:00
62d154d0f2
Add download syncing of article statuses
2019-05-14 06:20:53 -05:00
39a337d096
Stub out syncing article state
2019-05-13 17:04:12 -05:00
eede1cc7eb
Add initial feed download for Feedbin.
2019-05-13 11:18:54 -05:00
ccac456d77
Change to use the entries.json service for Feedbin instead of the per feed one
2019-05-13 10:29:34 -05:00
c4ce93e96a
Set default read state for Feedbin articles to read when syncing
2019-05-13 08:32:03 -05:00
c47fee2384
Delete unused parameters (dead code)
2019-05-13 07:17:50 -05:00
20388eff46
Change how completion handlers work for refreshArticles so that we can tell for sure when all the articles have been downloaded and updated in the database
2019-05-13 06:34:27 -05:00
2684b92a67
Added service calls for unread and starred entries
2019-05-13 03:13:06 -05:00
1b22abbbfc
Make sure a refresh happens after an OPML import.
2019-05-12 19:31:29 -05:00
f4510e57e5
store last article fetch time in account metadata
2019-05-12 19:17:16 -05:00
9c676f29f8
add articles download for Feedbin
2019-05-12 18:32:32 -05:00
4ed1b8a66a
Move ConditionalGetKeys as they are account type specific
2019-05-12 08:47:27 -05:00
60895fc7fa
Restrict Feedbin to a maximum of 1 concurrent connection to keep us under Feedbin's 250 requests per second rate limit
2019-05-12 07:22:33 -05:00
51c2527da2
Add OPML import for Feedbin.
2019-05-11 16:07:27 -05:00
6f92cd1a73
Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors
2019-05-11 12:26:23 -05:00
5200e49175
Capture 401 http status codes as already subscribed error when creating a Feedbin subscription
2019-05-10 10:40:02 -05:00
fd8a973084
Add already subscribed error to LocalAccountDelegate and updated iOS to work with latest Account API
2019-05-10 10:22:28 -05:00
fe70723eb4
Use best feed specifier code to determine which Feedbin option to use when creating a feed
2019-05-10 10:14:24 -05:00
75fbd9e3eb
Add folder delete undo support
2019-05-09 18:20:09 -05:00
23b43ecc07
Add undo for feeds
2019-05-09 16:09:21 -05:00
d4bfab2da6
Fix delete folder bug
2019-05-09 13:35:40 -05:00
cda8acc66c
Add the ability to move feeds between folders for Feedbin
2019-05-09 13:31:18 -05:00
50d3a5799c
added subscription delete
2019-05-09 07:25:45 -05:00
49116fd8e3
Add subscription id to Feed so that we can correctly rename Feedbin subscriptions
2019-05-08 18:13:54 -05:00
06626f10a7
Add feed rename
2019-05-08 17:55:53 -05:00
43d32b1281
Add create Feedbin feed
2019-05-08 17:41:19 -05:00
72c92587d2
Keep feedID and feedURL better separated
2019-05-08 09:54:55 -05:00
f12494cc31
Add some debug logging
2019-05-08 08:20:29 -05:00
e52dc84f13
added create subscription service
2019-05-08 06:56:15 -05:00
c5b0bfcd91
Save feed folder relationship identifier
2019-05-07 18:34:45 -05:00
52e5e43d10
Add download feed to folder relationships syncing
2019-05-07 17:41:32 -05:00
ae61d36c7d
Change FeedbinAccountDelegate to use BatchUpdate
2019-05-07 11:10:00 -05:00
7f9055fe78
Add download subscriptions and faviconURLs
2019-05-07 10:51:41 -05:00
d6ae740305
Added folder (tag) delete for Feedbin
2019-05-06 17:34:41 -05:00
b7e2df1a68
Add Folder rename for Feedbin
2019-05-06 10:53:20 -05:00
51a1562e4b
make slight change to how not modified responses are handled
2019-05-06 05:28:02 -05:00
18f2c7b723
Fix bug that prevented http caching from working
2019-05-05 17:46:53 -05:00
15a0ba89d7
Add folder syncing for Feedbin account
2019-05-05 15:41:20 -05:00
29f9cf83b1
Add HTTP Caching for Feedbin (conditional get)
2019-05-05 08:44:57 -05:00
35160aaf75
Rename AccountSettings to AccountMetadata to show that more than settings are stored in it and that it is analogous to FeedMetadata
2019-05-05 07:49:59 -05:00
6e7477fd89
Modify AccountSettings so that it works like FeedMetadata and can be leveraged by the AccountDelegates
2019-05-05 07:21:26 -05:00
d12a056ca3
Pass stored credentials to the delegate when updated
2019-05-05 06:02:28 -05:00
fc7b6f2c6b
refactor how Credentials work
2019-05-05 03:25:21 -05:00
aaa4342494
Add encrypted credential storage
2019-05-04 15:14:49 -05:00
595db517a7
change func signitures to use Credentials protocol from RSWeb instead of username/password
2019-05-04 11:48:48 -05:00
38202ece8d
Made credentials verification errors more descriptive.
2019-05-04 09:18:14 -05:00
bb42e46887
Update to use latest webservice network layer in RSWeb
2019-05-04 08:54:07 -05:00
5a852c1615
validate Feedbin account credentials and add Feedbin account
2019-05-02 18:17:52 -05:00
e0efcfa847
Update unread counts for activate/inactivate and delete account
2019-05-02 08:41:22 -05:00
137f061169
Prevent delete while refresh in progress
2019-05-02 06:50:35 -05:00
636468bbf0
Implement active account processing functionality
2019-05-02 06:01:30 -05:00
747079157b
Implement account state UI
2019-05-02 05:41:44 -05:00
f5523dd610
Add delete from disk
2019-05-01 19:22:07 -05:00
93630a7b72
Load accounts from disk
2019-05-01 13:13:53 -05:00
f4180424e1
Add multiple local accounts
2019-05-01 12:37:13 -05:00
4edffa488d
Rename classes to match naming convention
2019-05-01 11:05:55 -05:00
fe8e825c0d
Add account add UI
2019-05-01 10:28:13 -05:00
4bc7611721
Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts
2019-05-01 05:53:18 -05:00
ba57a27a35
Make local account display names changeable
2019-04-30 06:38:18 -05:00
ae63805479
Change property to have correct swift naming convention name
2019-04-27 16:16:46 -05:00
9400ea361e
Add notification for downloaded article(s).
2019-04-27 13:54:52 -05:00
e10bfde6d9
Rollback code created to support background downloads that are no longer needed
2019-04-26 14:21:17 -05:00
f5941fda64
Add AccountRefreshMode to be able to choose between background and foreground download sessions
2019-04-25 09:25:13 -05:00
f3c2d8c1f8
Updated to lastest RSWeb
2019-04-25 07:13:14 -05:00
f4c0fca6a8
Implement background downloading of feeds
2019-04-24 07:30:35 -05:00
17caa31ee5
Added device specific local account names.
2019-04-17 13:01:26 -05:00
b9f2a500a1
cleared the code signing identity
2019-04-15 17:14:47 -05:00
6b8524b70d
Made frameworks cross platform and got generated iOS app to compile.
2019-04-15 13:30:10 -05:00
0e44c135ae
Convert Account to Swift 5.
2019-03-31 16:12:17 -07:00
10cdc1553e
Post display name did change notification when an Account’s name changes.
2019-03-31 16:12:03 -07:00
2819403d62
Store the account name in a settings file. Set a default name based on the account type.
2019-03-27 22:10:14 -07:00
c84f273b92
Continue work on accounts UI in Preferences.
2019-03-20 22:10:22 -07:00
70bc4a7b45
Pay attention to the changed key when handling feed setting change notifications.
2019-03-17 13:54:30 -07:00
5f1bdb29ec
Give the .FeedSettingsDidChange notification a userInfo with the key of the setting that changed. This way observers can ignore changes they don’t care about.
2019-03-17 12:47:04 -07:00
80bee5b487
Do minor formatting changes in Feed.swift.
2019-03-17 11:24:21 -07:00
6a8ee9a2fb
Perform minor cleanups in Account.
2019-03-16 17:30:30 -07:00
908ae515c0
Remove unneeded import RSDatabase from Account.
2019-03-16 17:12:09 -07:00
cb45897256
Remove unused markEverywhereAsRead.
2019-03-16 16:48:14 -07:00
1d484220eb
Skip setting feed.editedName on OPML import. It’s not necessarily true that the name in the OPML file is an editedName.
2019-03-16 16:42:51 -07:00
e11fc1dfad
Make feed.init and FeedMetadata internal.
2019-03-16 16:39:16 -07:00
3e52bb9c24
Make feed.metadata no longer an optional.
2019-03-16 12:08:31 -07:00
4d727ce094
Continue removing old code for pre-OPML subscriptions.
2019-03-15 13:27:01 -07:00
8de36d8282
Start removing old code for pulling settings from a plist.
2019-03-15 13:17:37 -07:00
7335c65ecb
Remove last ODB stuff. Feed metadata is now entirely stored in FeedMetadata.plist.
2019-03-14 22:59:07 -07:00
1d52a1229b
Pull editedName from OPML when feed.editedName == nil.
2019-03-14 22:34:22 -07:00
79a6d5f761
Continue transition from ODB to FeedMetadata.plist. It’s simpler and uses less memory.
2019-03-13 23:41:43 -07:00
d498c3f19d
Create FeedMetadata. Not actually used just yet. (Soon.)
2019-03-12 22:40:11 -07:00
4c6d3807cb
Remove unused settingsTable.
2019-03-03 21:35:04 -08:00
0a45dda375
Create SearchFeedDelegate. Make searching synchronous, since it’s fast enough.
2019-02-24 19:22:16 -08:00
efe8a4ab15
Implement search — fetch articles matching a search string from the database.
2019-02-18 22:29:43 -08:00
ddb0ee21b6
Quiet warnings/errors from Xcode 10.2 about redundant public attributes on methods implemented inside public extensions.
2019-02-12 10:05:51 -05:00
6f41b2a728
Queue saving to disk, in Account, even during refresh.
2019-02-07 21:29:05 -08:00
eb3c69f4d0
Don’t write "Untitled" to Subscriptions.opml when a feed lacks a name or editedName — “Untitled” is a localizable, display-only string, not something to store in OPML. Fix #527 .
2019-02-06 21:18:22 -08:00
aadf4ec09f
Don’t set feed.editedName when importing OPML in Account.
2019-02-06 21:17:17 -08:00
ddccbdf610
Add addFeed and addFeeds to the Container protocol. This was confusing before. Now you can add directly to a Folder or Account.
2019-02-05 21:48:32 -08:00
448293a836
Set feed.title from the OPML — don’t just leave it blank.
2019-02-02 18:08:01 -08:00
30324c8ec0
Make sure that feed.editedName is never "". Treat it as nil.
2019-02-02 17:46:15 -08:00
f5d6e7e8fa
Fix bug where empty folders would be lost between runs of the app.
2019-01-27 21:42:58 -08:00
b900cbc0b7
Make Feed and Folder conform to Renewable.
2018-11-22 13:57:49 -08:00
485bde7ff2
Complete (probably) work on Feedbin sync data types.
2018-10-14 18:38:33 -07:00
cd6e6daf31
Continue work on Feedbin sync data types.
2018-10-14 18:10:07 -07:00
d69058c10c
Fix a couple first-run startup bugs.
2018-09-26 22:05:35 -07:00
7026eae899
Skip writing OPML file to disk during startup. Structure-changed notices happen during startup as the object graph is created, but it doesn’t mean that there’s a change that requires saving to disk.
2018-09-16 20:02:24 -07:00
1c3dca4d9b
Update unreadCount for an Account only when one of its feeds changes its unreadCount.
2018-09-16 19:07:07 -07:00
a914b3949b
Made launch performance *much* faster for large (thousands of feeds) subscriptions list. Also: split container.children in container.topLevelFeeds and container.folders. This simplifies a bunch of things, and makes some things faster.
2018-09-16 17:54:42 -07:00
6b6d393b3d
Delete some dead code.
2018-09-16 13:08:44 -07:00
3d45231494
Stop using urlToFeedDictionary. Feeds don’t have to be uniqued.
2018-09-16 13:04:42 -07:00
f8d6cb48dc
Remove instance where Feed equality was expected to be pointer equality, which is no longer true.
2018-09-16 12:46:50 -07:00
4010b4cb2a
On startup, import from AccountData.plist one last time, then rename it to AccountData-old.plist. On subsequent startups, import using Subscriptions.opml.
2018-09-16 12:42:46 -07:00
823d83c942
Write to disk on display-name-change only if it’s a Folder, since Feed names are stored in ODB.
2018-09-15 12:08:57 -07:00
d0df791b93
Skip writing to disk when feed setting changes, since we’re writing OPML now and storing feed settings in ODB.
2018-09-15 12:06:19 -07:00
abd8fb2236
Store feed.name and feed.editedName in ODB.
2018-09-15 11:45:01 -07:00
ce1fe6ed1f
Store feed.editedName in ODB.
2018-09-15 11:39:33 -07:00
0f59b904ef
Store feed.authors in ODB. Make Author Codable.
2018-09-15 11:16:05 -07:00
904feb9950
Store feed.homePageURL in ODB.
2018-09-14 22:23:30 -07:00
fb9590de98
Make feedID and accountID the things that determine hashing and equality for a Feed.
2018-09-14 22:15:22 -07:00
47cf018143
Store feed.unreadCount with the Account rather than the feed. This is part of making it so that feeds no longer have to be uniqued.
2018-09-14 22:06:03 -07:00
28d084e246
Store iconURL and faviconURL in ODB.
2018-09-14 21:51:05 -07:00
6d2bb123e3
Save conditional GET info in ODB.
2018-09-14 19:33:47 -07:00
3f1f4fd24c
Write Subscriptions.opml to disk.
2018-09-14 13:25:38 -07:00
b8546d8e8b
Don't store account.unreadCount in Settings.odb. Don’t rewrite AccountData.plist when feed.contentHash changes.
2018-09-14 13:12:55 -07:00
13fbad12a5
Store feed.contentHash in Settings.odb.
2018-09-13 22:52:34 -07:00
679e6f6c0b
Give Feed a weak account rather than accountID.
2018-09-13 22:37:40 -07:00
b5b42b8df6
Stop storing unreadCount for Feed and Folder objects on disk, since they’re fast to fetch at startup. Also, give Feed an ODBRawValueTable for metadata storage.
2018-09-13 22:25:10 -07:00
b7e9fbf2a6
Stop saving account’s unread count to disk — no need. It gets calculated at startup plenty fast enough.
2018-09-13 21:25:35 -07:00
4bc6c7d5db
Start using ODB code with Account. Store the unread count in the settings database.
2018-09-12 22:28:21 -07:00
25ff76e1e5
Fix a performance bug when fetching all unread articles. When validating unread counts, it was looping through the entire set of articles once per feed. Now it loops through articles just once, for a major performance boost with lots of feeds and/or lots of unread articles.
2018-09-10 22:08:38 -07:00
808715892f
Changed project and framework projects to default to using tabs per the coding guidelines. Also corrected previously committed files with spaces used incorrectly.
2018-09-07 13:46:00 -05:00
fdb159a61b
Normalize homePageURL in its setter. Fix #397 .
2018-09-02 12:14:04 -07:00
5d2a3e9142
Normalize homePageURL on init-ing Feed.
2018-09-02 12:08:35 -07:00
141ae5cc2f
Continue rename to NetNewsWire.
2018-08-28 22:18:24 -07:00
9263ffcb79
Use synthesized init.
2018-08-25 17:07:55 -07:00
cfb3bd706e
Use new hash-into function instead of calculating hashValue. WIP on #402 .
2018-08-25 11:54:58 -07:00
b16112ad56
Remove deleted frameworks from Account.
2018-07-28 17:30:12 -07:00
fc338d5371
Move Feed from Articles.framework to Account.framework.
2018-07-28 12:16:14 -07:00
b7575c687c
Rename Data.framework to Articles.framework. Rename Database.framework to ArticlesDatabase.framework.
2018-07-23 18:29:08 -07:00
c91f4621e1
Merge remote-tracking branch 'brentsimmons/master'
2018-03-04 18:43:49 -08:00
7def2ae8d0
Fix bug where deleting from the sidebar would not stick across runs of the app sometimes — whatever you deleted could come back.
2018-02-24 15:54:32 -08:00
71005b56af
support for "make new feed"
2018-02-20 00:26:46 -08:00
c80e3e86de
Don’t save an Account to disk during a refresh session. Wait till it’s over.
2018-02-17 18:02:40 -08:00
64647c73c6
Use a coalescing queue (instead of a Timer) in Account for saving to disk.
2018-02-17 15:38:54 -08:00
2f21dbf6be
Remove extraneous get { from a bunch of read-only accessors.
2018-02-14 13:14:25 -08:00
192439abe7
Make Folder watch for children-did-change notifications — when its own children change, update the unread count. Fix #322 .
2018-02-12 22:22:06 -08:00
a13d21395e
Fetch starred articles for the Starred smart feed.
2018-02-11 12:07:55 -08:00
5aeb914ab6
Fetch articles for the Today smart feed.
2018-02-10 17:37:47 -08:00
00cf3934e5
Add fetchUnreadArticles method to Account, which will be used by the All Unread smart feed.
2018-02-10 13:00:16 -08:00
a6db249ab6
Add ArticleFetcher protocol. Add Feed and Folder extensions for it.
2018-02-04 10:57:41 -08:00
e038fb0fb5
convert Evergreen frameworks projects to use .xcconfig files.
2018-02-02 03:24:13 -08:00
3507313f84
Accept Xcode 9.3 recommended build settings.
2018-01-29 11:20:30 -05:00
d7f13ca4be
Change from flatMap to new compactMap rename in Xcode 9.3.
2018-01-29 11:19:54 -05:00
cf0d5cdc51
Remove unwanted debugging print statement.
2018-01-24 21:48:20 -08:00
f109237bfa
Handle feed renames in the inspector. Handle multiple selection. Fix #137 .
2018-01-23 21:49:33 -08:00
2cf0dbd96e
Extend Notification.Name, not NSNotification.Name.
2018-01-22 22:00:01 -08:00
02ad70097e
Send a Notification when a Folder’s name changes.
2018-01-22 21:59:13 -08:00
6b059671f5
Make progress on reloading timeline when feed updates.
2018-01-17 17:28:09 -08:00
775dbf0852
basic readonly scripting support for account, feed, folder
2018-01-11 00:51:25 -08:00
8f9575ee84
Remove assertion that wasn’t valid in some situations. Fix #283 .
2017-12-29 10:13:11 -08:00
0b2d7c6733
Validate unread counts on fetching articles. Fix #274 .
2017-12-26 11:27:55 -08:00
23769bc391
Add AccountDelegate.accountDidInitialize method, so that the delegate can set the account’s nameForDisplay before anything else happens. Fix #247 .
2017-12-19 17:48:30 -08:00
5b01f04afe
Save to disk right after importing OPML. Fix #249 .
2017-12-18 21:46:35 -08:00
3eb95ce63d
Fix OPML import performance regression. Fix #238 .
2017-12-11 23:12:54 -08:00
0b4a9f143e
Parse Feedbin articles.
2017-12-11 13:36:16 -08:00
8160d8e38e
Create Feedbin, FeedbinAccountDelegate, and FeedbinGetSubscriptionsDelegate.
2017-12-10 14:05:01 -08:00
6e93cc2718
Create FeedbinSubscription struct.
2017-12-10 14:04:14 -08:00
89a74077d9
Create FeedbinSubscription struct.
2017-12-10 13:58:44 -08:00
a488683550
Refresh all after importing OPML. Fix #59 .
2017-12-03 12:54:51 -08:00
0c176eccd0
Fetch all unread counts at startup. This is done with a single SQL call, and it’s done in the background, so performance hit should not be noticeable. Fix #138 .
2017-12-03 11:57:53 -08:00
3da2521e8e
When adding a feed, update it right away rather than waiting for the next Refresh. Fix #147 . Fix #215 .
2017-12-02 17:47:08 -08:00
e71d763443
Save feed.authors.
2017-12-02 14:20:58 -08:00
f28d921aff
Avoid skipping parsing Dr. Drang’s JSON Feed, which can’t be detected that it’s a JSON Feed with only partial data, since it has the version element at the end. Add a test for this.
2017-12-01 13:19:30 -08:00
e026e159d1
Rebuild the feed dictionary at appropriate times. Fix #169 .
2017-11-25 18:05:20 -08:00
68c01491fc
Note when feed settings change and update the sidebar cells.
2017-11-25 13:48:14 -08:00
55166e0979
Update a Feed with settings taken from the raw feed. (Some Feeds had no homePageURL set, which meant, in most cases, no favicons.)
2017-11-25 12:17:49 -08:00
bd8b7c6ed9
Implement debugDropConditionalGetInfo command. Fix #197 .
2017-11-25 11:13:15 -08:00
1864f60e0b
Save iconURL and faviconURL in Feed when found in ParsedFeed.
2017-11-19 22:38:42 -08:00
ffaa55c50c
Implement mark-everywhere-as-read.
2017-11-19 16:28:26 -08:00
9c571271e6
Create SmartFeed class. It’s for Unread and Starred pseudo-feeds — and will also be used later on by predicate-based smart feeds.
2017-11-19 15:40:02 -08:00
83cee90929
Fix a couple bugs in PseudoFeed. Make callback for fetching unread count @escaping.
2017-11-19 12:45:35 -08:00
e681007bbe
Add TodayFeedDelegate. Start work on fetching unread count for Today pseudo-feed.
2017-11-19 12:12:43 -08:00
1e713e3bfd
Update Account unread count when BatchUpdate did perform.
2017-11-15 13:26:10 -08:00
9f56030b79
Calculate the Account’s unread count by looking at the set of flattened feeds — this way a given feed (which can occur more than once) is counted only once. Fix #101 .
2017-11-11 19:34:10 -08:00
9818278c9b
Make undo deleting feeds/folders work.
2017-11-05 12:14:36 -08:00
e16911b363
Make deleting work. Can’t undo yet. But now everything is messed-up because of an AnyHashable casting bug. Don’t run this build.
2017-11-04 22:51:14 -07:00
66c02a6fe1
Fix build errors.
2017-11-04 19:29:43 -07:00
ef303c0c38
Make progress on deleting and especially undoing delete.
2017-11-04 19:03:47 -07:00
c08bbaa970
Use AnyHashable instead of AnyObject as representedObject for tree nodes.
2017-11-04 15:27:32 -07:00
ef1d95341b
Show feeds in Feed Directory sidebar.
2017-11-04 14:53:21 -07:00
f9b3eeb4d7
Switch macOS deployment target to 10.13. Get MarkAllReadCommand working as an undoable command.
2017-10-29 11:14:10 -07:00
c101d9dd04
Maintain url-to-feed and feedID-to-feed dictionaries to make lookups faster. This makes OPML importing very fast.
2017-10-22 11:08:51 -07:00
649f62207f
Fix OPML importing.
2017-10-21 21:00:21 -07:00
8d5e568cde
Make folder.account weak and optional.
2017-10-21 16:37:40 -07:00
d512908b6f
Use @discardableResult with addFeed.
2017-10-21 16:32:29 -07:00
7bf1847588
Send notification on adding a feed to a folder. Also: Update ToDo.
2017-10-21 16:27:06 -07:00
da1b7a6c7b
Post children-did-change notification after adding a feed.
2017-10-21 16:06:25 -07:00
aca8acea7c
Update sidebar when adding a folder.
2017-10-19 13:27:59 -07:00
3812c216b2
Show unread count in window title.
2017-10-18 21:53:45 -07:00
2383ecd480
Implement ensureFolder — it actually creates and adds a folder and makes sure account is saved to disk.
2017-10-18 19:46:35 -07:00
Maurice Parker
Jeremy Beker
Tom Grimwood-Taylor
Brent Simmons
Phil Viso
Daniel Jalkut
Olof Hellman