Commit Graph

4318 Commits

Author SHA1 Message Date
Jonathan Bennett 88664bd3e6 use pre-build hooks to trigger gyb script 2019-11-27 17:20:56 -05:00
Nate Weaver 64af8840fe Mark appropriate caches as dirty 2019-11-27 15:45:14 -06:00
Nate Weaver f690bba775 Make sure self.postDidLoadFaviconNotification() is always called after a download attempt
Otherwise the rest of the favicon URLs won't be tried.
2019-11-27 15:40:35 -06:00
Maurice Parker 24634dfaaa Optimize the initial load so that a Filtered Feeds state restoration doesn't animate on startup 2019-11-27 15:21:39 -06:00
Maurice Parker 708c7de7fa Make sure the first build of the backing stores isn't filtered so that state restoration has something to work with. 2019-11-27 14:52:40 -06:00
Maurice Parker e9032c4a0f Add Slack link to Help. Issue #1365 2019-11-27 14:17:57 -06:00
Maurice Parker ef2222ad94 Merge branch 'mac-release' 2019-11-27 14:08:52 -06:00
Maurice Parker 18045f2e2b
Merge pull request #1359 from Wevah/favicon-fix
Fix favicons not loading for certain feeds
2019-11-27 13:27:29 -06:00
Jonathan Bennett a4f6adbd85 vendor the gyb dependency 2019-11-27 14:06:32 -05:00
Nate Weaver 9de27febf0 Fix favicon loading for sites with multiple/invalid favicons
Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser
2019-11-27 13:02:49 -06:00
Maurice Parker 81c4756f97 Persist article read filters across application launches. Issue #1349 2019-11-27 11:43:36 -06:00
Jonathan Bennett 69ebecaf40 display instructions if gyb is missing 2019-11-27 11:40:24 -05:00
Jonathan Bennett 544daf5756 handle missing secrets
Missing secrets will give a blank string instead of exploding.

Also, an example of a custom property
2019-11-27 11:30:27 -05:00
Jonathan Bennett d3dd7498e6 generate the secret property automatically 2019-11-27 11:20:43 -05:00
Jonathan Bennett eda98d166d remove FeedWrangler build scripts 2019-11-27 11:17:46 -05:00
Maurice Parker 991ecf2a71
Merge pull request #1363 from kielgillard/1326-missing-data
Adds public logging of the Feedly errors…
2019-11-27 09:55:22 -06:00
Maurice Parker 9a139d4cd9
Merge pull request #1362 from kielgillard/master
Feedly operations can optionally report their progress. #1328
2019-11-27 09:55:08 -06:00
Kiel Gillard 1891523d0d Adds public logging of the Feedly errors to help identify the missing key in #1326. 2019-11-27 19:04:55 +11:00
Kiel Gillard 2f96e8b8a6 Feedly operations can optionally report their progress. #1328 2019-11-27 18:32:18 +11:00
Maurice Parker ebd7f4904d Persist the Feeds Read filter across application launches. Issue #1349 2019-11-26 20:23:12 -06:00
Maurice Parker 8cb25e7c5e Move private functions to private extension 2019-11-26 17:32:30 -06:00
Maurice Parker 9de3caf3a0 Make persistentIdentifier iOS only for now. 2019-11-26 17:00:13 -06:00
Maurice Parker 4a9e79cd1e Persist and restore container expanded state across application launches. Issue #1361 2019-11-26 16:33:11 -06:00
Maurice Parker 3d1f68a877 Fix suggestion for upward dragging drop zones. Issue #1360 2019-11-26 13:42:25 -06:00
Maurice Parker 19336dd07e Fix folder drops that sometimes defaulted to the account. Issue #1356 2019-11-26 13:01:07 -06:00
Maurice Parker 59e512a263 Make section headers darker. Issue #1357 2019-11-26 12:48:36 -06:00
Maurice Parker 751dd0ae35 Correctly align the about page. Issue #1351 2019-11-26 11:30:38 -06:00
Maurice Parker 4cd705e14b Remove Acknowledgement section. Issue #1350 2019-11-26 11:12:24 -06:00
Maurice Parker e81d8f8ef9 Move accounts slightly to the left on Settings. Issue #1352 2019-11-26 10:58:00 -06:00
Maurice Parker 0723c55e2c Change Import Subscriptions action sheet title. Issue #1353 2019-11-26 10:23:33 -06:00
Maurice Parker f2b5d31d5e Change Export Subscriptions action sheet title. Issue #1354 2019-11-26 10:21:18 -06:00
Maurice Parker 291bc9b278 Align build number with rest of text. Issue #1355 2019-11-26 10:16:58 -06:00
Jonathan Bennett 9d0034576d start extracting secrets 2019-11-26 08:58:16 -05:00
Brent Simmons bfc5eadd91 Add credit to About window for Andrew Brehaut’s newsfoot. 2019-11-25 22:38:25 -08:00
Brent Simmons 7a628552d0 Edit the About screen. 2019-11-25 22:19:44 -08:00
Brent Simmons 603a459ed1 Bump build number to 10. 2019-11-25 21:47:25 -08:00
Maurice Parker 549bf3197c Show article extractor target state in context menu. 2019-11-25 20:36:15 -06:00
Maurice Parker 323b160b7f Add context menu for Fullscreen mode actions. Issue #1344 2019-11-25 19:43:43 -06:00
Maurice Parker b1471d4d20 Adjust section header for hidden section on iPad. 2019-11-25 17:05:27 -06:00
Maurice Parker c17999de76 Gate code to only show intended account types for add. 2019-11-25 09:30:14 -06:00
Maurice Parker 71f6917417 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-11-25 08:18:57 -06:00
Maurice Parker 964cdfcb55
Merge pull request #1347 from jbennett/add-feed-wrangler-ios
Allow Feed Wrangler accounts on iOS
2019-11-25 08:18:42 -06:00
Maurice Parker a85d266253 Auto expand newly activated accounts. 2019-11-25 08:14:33 -06:00
Jonathan Bennett a0b1c7aac6 localize button text 2019-11-25 05:16:20 -05:00
Jonathan Bennett 0539336fce Allow Feed Wrangler accounts on iOS 2019-11-25 00:26:03 -05:00
Maurice Parker ea064c1e2e
Merge pull request #1082 from jbennett/feature/feed-wrangler
[WIP] Feed wrangler support
2019-11-24 20:34:42 -06:00
Jonathan Bennett ce51e4e632 Merge branch 'master' into feature/feed-wrangler 2019-11-24 20:41:43 -05:00
Maurice Parker 6a56936850 Moved expanded state away from Node so that it won't get lost on rebuilds. Issue #1346 2019-11-24 18:29:00 -06:00
Maurice Parker cd493730b1 Hide bars when returning to the foreground so that they don't come back. 2019-11-24 14:49:44 -06:00
Maurice Parker 74297944e9 Clear current article so that wrapping occurs 2019-11-24 14:36:17 -06:00