180 Commits

Author SHA1 Message Date
Maurice Parker
722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Maurice Parker
a59f223043 Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS 2019-09-04 02:40:35 -05:00
Brent Simmons
2ec55e6587 Merge branch 'mac-release' 2019-09-03 22:59:29 -07:00
Brent Simmons
0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons
ed91776097 Merge branch 'mac-release' 2019-09-03 21:24:52 -07:00
Jim Correia
c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker
1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker
6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker
ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Jim Correia
cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker
3c86bf0614
Merge pull request #871 from mbernson/master
Simplify sharing delegate logic
2019-08-27 11:13:00 -05:00
Maurice Parker
8de9b355c7 Merge branch 'mac-release' 2019-08-26 12:54:53 -05:00
Maurice Parker
1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Maurice Parker
f8c01107d5 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-24 15:01:40 -05:00
Maurice Parker
ea55aa5bef Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS 2019-08-24 15:01:28 -05:00
Brent Simmons
ed56376d03 Merge branch 'mac-candidate' 2019-08-23 18:55:09 -07:00
Brent Simmons
3447ebcec0 Reload data after a batch update. Fix #872. 2019-08-23 15:52:07 -07:00
Mathijs Bernson
9214e3d65e Simplify sharing item subject logic 2019-08-23 13:05:20 +02:00
Brent Simmons
1ab0f7c25c Merge mac-candidate. 2019-08-21 21:44:07 -07:00
Brent Simmons
849830f494 Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838. 2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb Start work on filtering timeline so that articles from deleted feeds never show up. 2019-08-21 13:23:46 -07:00
Brent Simmons
7b3c08f521 Merge branch 'mac-candidate' 2019-08-13 21:07:59 -07:00
Brent Simmons
2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected. 2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8 Add Ryan’s word-wrap change to mac-candidate. 2019-08-13 20:07:42 -07:00
Ryan Dotson
6eb27abc13 Break long words or URLs to prevent horizontal overflow 2019-08-13 09:27:36 +09:00
Ryan Dotson
c8f5a24b95 Use proper quotes in timeline contextual menu 2019-08-13 07:41:14 +09:00
Brent Simmons
34326863ea Merge branch 'mac-candidate' 2019-07-28 16:01:12 -07:00
Brent Simmons
887f8e0b53 Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching. 2019-07-28 16:00:43 -07:00
Brent Simmons
2fcadf9748 Merge branch 'mac-candidate' 2019-07-28 15:31:45 -07:00
Brent Simmons
2441de960f Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791. 2019-07-28 15:31:17 -07:00
Brent Simmons
d8f1dcf23e Merge branch 'mac-candidate' 2019-07-27 22:53:53 -07:00
Brent Simmons
44ec6a026d Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.) 2019-07-27 22:53:27 -07:00
Brent Simmons
05faea53c4 Remove reference to NSCalendarDayChanged — it’s no longer necessary to update the Today feed unread count when the day changes. 2019-07-27 19:52:05 -07:00
Brent Simmons
314fd970d1 Merge branch 'mac-candidate' 2019-07-27 19:49:46 -07:00
Brent Simmons
8acab45cf9 Make formatting changes to SidebarViewController.swift so it conforms to current formatting thinking. 2019-07-27 19:49:33 -07:00
Brent Simmons
58a7e1bc7d Merge branch 'mac-candidate' 2019-07-27 15:44:34 -07:00
Brent Simmons
a41f7d8e68 Remove some unneeded drawing. This makes resizing the timeline faster. 2019-07-27 15:44:13 -07:00
Maurice Parker
125512f551 Merge branch 'mac-candidate' 2019-07-26 08:06:59 -05:00
Maurice Parker
8b0c8156df Remove refresh at midnight for Today smartfeed 2019-07-26 08:06:08 -05:00
Brent Simmons
3999c7b3c5 Merge branch 'mac-candidate' 2019-07-05 22:42:01 -07:00
Brent Simmons
7a204ad6ed Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in. 2019-07-05 20:06:31 -07:00
Maurice Parker
5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Maurice Parker
74f84dc000 Restrict OPML import for Account types that don't support it 2019-06-19 17:50:32 -05:00
Brent Simmons
6f16a2715e Skip downloading featured images, since we’re not displaying them anywhere. 2019-06-17 21:47:17 -07:00
Maurice Parker
40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker
6527ac852c Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 2019-06-13 14:50:41 -05:00
Maurice Parker
93fbbd4cc3 Make sure that FeedFinder and InitialDownloader are running on the main thread. 2019-06-10 08:21:03 -05:00