Maurice Parker
444771dfae
Merge branch 'mac-release'
2019-09-16 18:16:13 -05:00
Maurice Parker
1d7cbe5596
Fix super wide div's. Issue #1010
2019-09-16 18:12:56 -05:00
Brent Simmons
8a2d1f5f6a
Create TimelineAvatarView, which draws the background for images that need it.
2019-09-15 23:02:13 -07:00
Phil Viso
cc6767e0f6
Removed duplicate sort parameter change handling functions
2019-09-13 08:29:56 -05:00
Phil Viso
8a6e3c9f37
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
...
# Conflicts:
# Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
Maurice Parker
57542592cb
Correct which view should become the first responder. Issue #1014
2019-09-11 17:47:02 -05:00
Brent Simmons
3b501e9f4e
Merge branch 'mac-release'
2019-09-10 20:28:42 -07:00
Brent Simmons
7ad0b6b604
Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923 .
2019-09-10 20:28:16 -07:00
Maurice Parker
8dda681409
Add accessibility labels to Sidebar, Timeline, and Article. Issue #934
2019-09-10 11:09:17 -05:00
Phil Viso
32d6678fdd
Added group by feed menu item
2019-09-08 17:09:26 -05:00
Maurice Parker
0961753357
Merge pull request #998 from hisaac/mac-release
...
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson
8b635fc04c
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 12:54:26 -05:00
Maurice Parker
e61efbe47a
Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS
2019-09-08 09:43:51 -05:00
Brent Simmons
0d25f2331a
Merge branch 'mac-release'
2019-09-06 19:28:31 -07:00
Brent Simmons
58c2fad2fd
Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976 .
2019-09-06 19:28:06 -07:00
Maurice Parker
a4b01fda35
Merge branch 'mac-release'
2019-09-06 17:03:38 -05:00
Maurice Parker
0e7d971e65
Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995
2019-09-06 16:52:31 -05:00
Maurice Parker
00b2756526
Merge branch 'mac-release'
2019-09-05 13:15:04 -05:00
Brian Warren
ce3ec10c95
Enforcing automatic height for images in the template
2019-09-05 10:59:16 -07:00
Maurice Parker
da8250ac5a
Merge branch 'mac-release'
2019-09-04 17:42:30 -05:00
Maurice Parker
7a8d23958b
Restrict iframe width to be at most 100%
2019-09-04 17:41:58 -05:00
Maurice Parker
dabb78cde4
Merge branch 'mac-release'
2019-09-04 17:20:37 -05:00
Thomas Pritchard
d3ad4b52a3
Set a sensible line height for figure captions
2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23
Add figures to Mac detail stylesheet
2019-09-04 19:58:29 +01:00
Maurice Parker
fa5840811a
Change the view that gets made the first responder so that keyboard shortcuts work again
2019-09-04 03:12:50 -05:00
Maurice Parker
722d486018
Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app
2019-09-04 03:11:55 -05:00
Maurice Parker
a59f223043
Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS
2019-09-04 02:40:35 -05:00
Brent Simmons
2ec55e6587
Merge branch 'mac-release'
2019-09-03 22:59:29 -07:00
Brent Simmons
0ba8f3b4e1
Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898 .
2019-09-03 22:58:17 -07:00
Brent Simmons
ed91776097
Merge branch 'mac-release'
2019-09-03 21:24:52 -07:00
Jim Correia
c8920ca5a6
Added optional separators in the timeline view.
...
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker
1a9acdcc50
Remove TreeController from Delete command as it is no longer used there
2019-09-01 14:56:27 -05:00
Maurice Parker
6cf1e4539d
Merge branch 'mac-release'
2019-09-01 10:51:22 -05:00
Jim Correia
e7e77d362c
Fix for bug #901 — first web view load flashes white in dark mode
...
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.
Instead, use a modification of the original solution used for iOS:
- wrap the web view in a box with an appropriate background color
- hide the web view at creation
- show the web view after* the first load
This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.
[*] Showing the view immediately after the first load still causes the flash
to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker
ecec048716
Merge branch 'mac-release'
2019-08-31 18:31:10 -05:00
Jim Correia
cdfdc06142
Only enable "Open in Browser" when a single article is selected.
...
Fixes bug #921 .
2019-08-31 16:02:21 -07:00
Maurice Parker
3c86bf0614
Merge pull request #871 from mbernson/master
...
Simplify sharing delegate logic
2019-08-27 11:13:00 -05:00
Maurice Parker
8de9b355c7
Merge branch 'mac-release'
2019-08-26 12:54:53 -05:00
Maurice Parker
1a3e2784ae
Optimize table cell reloading when feed images are made available
2019-08-26 12:54:23 -05:00
Maurice Parker
f8c01107d5
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-08-24 15:01:40 -05:00
Maurice Parker
ea55aa5bef
Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS
2019-08-24 15:01:28 -05:00
Brent Simmons
ed56376d03
Merge branch 'mac-candidate'
2019-08-23 18:55:09 -07:00
Brent Simmons
3447ebcec0
Reload data after a batch update. Fix #872 .
2019-08-23 15:52:07 -07:00
Mathijs Bernson
9214e3d65e
Simplify sharing item subject logic
2019-08-23 13:05:20 +02:00
Brent Simmons
1ab0f7c25c
Merge mac-candidate.
2019-08-21 21:44:07 -07:00
Brent Simmons
849830f494
Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838 .
2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb
Start work on filtering timeline so that articles from deleted feeds never show up.
2019-08-21 13:23:46 -07:00
Brent Simmons
7b3c08f521
Merge branch 'mac-candidate'
2019-08-13 21:07:59 -07:00
Brent Simmons
2bbd135c9e
Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829 .
2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e
Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected.
2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee
Add a SmartFeedType to smart feeds so the sidebar can tell them apart.
2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8
Add Ryan’s word-wrap change to mac-candidate.
2019-08-13 20:07:42 -07:00
Ryan Dotson
6eb27abc13
Break long words or URLs to prevent horizontal overflow
2019-08-13 09:27:36 +09:00
Ryan Dotson
c8f5a24b95
Use proper quotes in timeline contextual menu
2019-08-13 07:41:14 +09:00
Brent Simmons
34326863ea
Merge branch 'mac-candidate'
2019-07-28 16:01:12 -07:00
Brent Simmons
887f8e0b53
Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching.
2019-07-28 16:00:43 -07:00
Brent Simmons
2fcadf9748
Merge branch 'mac-candidate'
2019-07-28 15:31:45 -07:00
Brent Simmons
2441de960f
Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791 .
2019-07-28 15:31:17 -07:00
Brent Simmons
d8f1dcf23e
Merge branch 'mac-candidate'
2019-07-27 22:53:53 -07:00
Brent Simmons
44ec6a026d
Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.)
2019-07-27 22:53:27 -07:00
Brent Simmons
05faea53c4
Remove reference to NSCalendarDayChanged — it’s no longer necessary to update the Today feed unread count when the day changes.
2019-07-27 19:52:05 -07:00
Brent Simmons
314fd970d1
Merge branch 'mac-candidate'
2019-07-27 19:49:46 -07:00
Brent Simmons
8acab45cf9
Make formatting changes to SidebarViewController.swift so it conforms to current formatting thinking.
2019-07-27 19:49:33 -07:00
Brent Simmons
58a7e1bc7d
Merge branch 'mac-candidate'
2019-07-27 15:44:34 -07:00
Brent Simmons
a41f7d8e68
Remove some unneeded drawing. This makes resizing the timeline faster.
2019-07-27 15:44:13 -07:00
Maurice Parker
125512f551
Merge branch 'mac-candidate'
2019-07-26 08:06:59 -05:00
Maurice Parker
8b0c8156df
Remove refresh at midnight for Today smartfeed
2019-07-26 08:06:08 -05:00
Brent Simmons
3999c7b3c5
Merge branch 'mac-candidate'
2019-07-05 22:42:01 -07:00
Brent Simmons
7a204ad6ed
Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in.
2019-07-05 20:06:31 -07:00
Maurice Parker
5f045706e4
Removed usaged of UIApplication.present
2019-06-27 14:21:07 -05:00
Maurice Parker
74f84dc000
Restrict OPML import for Account types that don't support it
2019-06-19 17:50:32 -05:00
Brent Simmons
6f16a2715e
Skip downloading featured images, since we’re not displaying them anywhere.
2019-06-17 21:47:17 -07:00
Maurice Parker
40b9be6709
center smaller avatars on a solid color background image to make all avatars a consistent size
2019-06-14 15:33:13 -05:00
Maurice Parker
6527ac852c
Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752
2019-06-13 14:50:41 -05:00
Maurice Parker
93fbbd4cc3
Make sure that FeedFinder and InitialDownloader are running on the main thread.
2019-06-10 08:21:03 -05:00
Brent Simmons
45f6d8043a
Add ellipsis where needed in import/export OPML sheets. Fix #731 .
2019-06-09 20:18:10 -07:00
Brent Simmons
4a4fa6ed0e
Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734 .
2019-06-09 16:03:08 -07:00
Maurice Parker
88b2775076
Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated
2019-05-31 08:05:26 -05:00
Maurice Parker
beacad1aeb
Validate folder drop to make sure no folders with the same name are already in the target account
2019-05-30 17:57:06 -05:00
Maurice Parker
a8f090656d
Handle when a feed in a folder being copied/moved already is subscribed in target account
2019-05-30 14:44:13 -05:00
Maurice Parker
30c21bb125
Enable folders to be dropped in a move or copy between accounts
2019-05-30 14:36:21 -05:00
Maurice Parker
1352dda8aa
Modify Feedbin feed deletes so that they emulate how the local account feed deletes work.
2019-05-30 10:12:34 -05:00
Maurice Parker
51284b5aa4
Rename deleteFeed to removeFeed to be more consistent with other API's
2019-05-29 21:04:44 -05:00
Maurice Parker
f4bc17c8f1
Refactor addFeed and removeFeed usages to be more consistent
2019-05-29 20:47:52 -05:00
Maurice Parker
5e3fcfd955
Correct how feeds were deleted so that only the feed in the correct container was deleted
2019-05-29 17:56:26 -05:00
Maurice Parker
bead6ae123
Remove now unnecessary call to account structureDidChange in drop
2019-05-29 17:14:50 -05:00
Maurice Parker
fa6b6a4769
Corrected move BatchUpdate usage to make move animation smoother
2019-05-29 17:08:41 -05:00
Maurice Parker
b1bd8d2d90
Enable folder dragging between accounts
2019-05-29 15:43:33 -05:00
Maurice Parker
8fc6e81ddf
Update the Today timeline and unread count when the day changes. Issue #627
2019-05-29 10:24:30 -05:00
Maurice Parker
0648053417
Enforce tag specific drop validation (can't copy to the account level)
2019-05-28 17:42:19 -05:00
Maurice Parker
83652c40de
Handle scenario where moved/copied feed already exists somewhere else in account
2019-05-28 16:46:16 -05:00
Maurice Parker
01d5a95241
Remove redundant private keyword usage
2019-05-28 16:31:03 -05:00
Maurice Parker
112702020b
Enable same account copying.
2019-05-28 13:11:29 -05:00
Maurice Parker
78c19bda43
Remove restriction on only moving and copying between local accounts.
2019-05-28 11:09:47 -05:00
Maurice Parker
b3c4c8de59
Correct how feeds were copied and moved between accounts to eliminate shared objects.
2019-05-28 10:59:06 -05:00
Maurice Parker
493abbb609
Refactor create feed functionality to increase code reuse and encapsulation
2019-05-28 09:45:02 -05:00
Maurice Parker
c7b61f7d87
Enable copy between local accounts.
2019-05-27 18:01:24 -05:00
Maurice Parker
659c9e5271
Allow dragged feeds between local accounts only
2019-05-27 15:11:16 -05:00
Brent Simmons
bfe41438fc
Make default exported OPML file name Subscriptions-[accountName].opml. Fix #683 .
2019-05-26 22:17:19 -07:00
Brent Simmons
9f6b2bc63f
Revise layout and add explanation for the import OPML choose-account sheet.
2019-05-26 16:29:46 -07:00