FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-14 18:35:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
7,096 Commits 12 Branches 0 Tags 59 MiB
3955151daf
Commit Graph

1669 Commits

Author SHA1 Message Date
Maurice Parker
7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018 
Key commands work with action sheets
 2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim
bfef02e18f
adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge
a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker
8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts 
Keyboard shortcuts
 2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim
32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim
a9aefd252e
adds keyboard shortcuts 
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
 2020-05-13 17:29:59 +05:30
Stuart Breckenridge
f153643273
Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge
58575331dd
Fixes #2018 
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
 2020-05-13 12:33:51 +08:00
Maurice Parker
775a69a295 Add iOS Reddit URL builder 2020-05-12 11:17:47 -05:00
Brian Sanders
737f4bfdf5 Adds "Find in Article" activity to the share sheet 
addresses #1750
 2020-05-11 17:08:44 -04:00
Maurice Parker
ccb813f6ec Allow autoplay on iOS 2020-05-10 12:21:35 -05:00
Maurice Parker
fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Maurice Parker
50e6e8e190
Merge pull request #2050 from jbennett/2049-add-folder-management-behavior 
Adds an account behavior to disable folders
 2020-05-08 15:36:16 -05:00
Maurice Parker
715804fe64 Merge branch 'ios-release' 2020-05-07 11:34:02 -05:00
Maurice Parker
46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Jonathan Bennett
a37bfd5d74 Adds an account behavior to disable folders 
Some sync services (Feed Wrangler) don't support folders. This behavior removes the account from the UI when adding new folders.
 2020-05-07 10:03:04 -04:00
Maurice Parker
9429f36095 Don't image zoom any previews that are just links out 2020-05-06 21:56:01 -05:00
Maurice Parker
2d8cbb8017 Merge branch 'ios-release' 2020-05-06 18:39:55 -05:00
Maurice Parker
211e44fff5 Remove flash when changing out the web view upon returning to the foreground 2020-05-06 17:35:38 -05:00
Maurice Parker
be4691abd0 Use different assets for Snoo when in light vs dark mode 2020-05-06 15:32:05 -05:00
Maurice Parker
14d8e9af30 Merge branch 'ios-release' 2020-05-06 15:12:25 -05:00
Maurice Parker
d4cffa28f2 Rollback disclosure button reference hold since it does nothing to stop the crash 2020-05-06 14:58:47 -05:00
Maurice Parker
502ff3e019 Don't multiply by the device pixel ratio if that will put us over the canvas limit 2020-05-06 14:55:34 -05:00
Maurice Parker
5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Maurice Parker
38f992d01d Degrade zoom image quality rather than failing 2020-05-06 11:43:50 -05:00
Stuart Breckenridge
f58ac4d160
Wraps Alert strings in NSLocalizedString 
Also removes `tel` scheme handling.
 2020-05-04 13:25:02 +08:00
Maurice Parker
78f72264fd Add oauth2 signon to iOS 2020-05-03 16:19:55 -05:00
Stuart Breckenridge
e825a5d516
Adds handling of tel url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge
f901436211
mailto links now open on iOS 
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
 2020-05-03 21:33:57 +08:00
Maurice Parker
e681fd6402 Stub out Reddit Feed Provider / Extension Point 2020-05-02 19:38:57 -05:00
Maurice Parker
41a17dfb06 Restrict build button on iOS so that it only appears if Twitter is enabled 2020-05-02 17:21:01 -05:00
Maurice Parker
85f7adaa0a Use MainThreadOperation to prevent article status updates from interleaving 2020-05-02 10:02:58 -05:00
Maurice Parker
6bdcd941ae Fix typo 2020-05-02 09:01:53 -05:00
Maurice Parker
a522ec67b3 Merge branch 'master' of https://github.com/Ranchero-Software/NetNewsWire 2020-05-01 17:43:33 -05:00
Maurice Parker
6d60053012 Merge branch 'ios-release' 2020-05-01 16:35:21 -05:00
Maurice Parker
e2267d14ee Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034 2020-05-01 16:34:19 -05:00
Maurice Parker
d5a4f1625a Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032 2020-05-01 16:24:29 -05:00
Nate Weaver
5ac69a411e Remove the color parameter on iOS too 2020-05-01 02:02:44 -05:00
Nate Weaver
070981553d Make attributed titles work on iOS 2020-05-01 01:42:44 -05:00
Maurice Parker
898681dfe6 Take device resolution into consideration when drawing image. Issue #2032 2020-04-30 15:34:17 -05:00
Maurice Parker
14e1dbe58e Merge branch 'ios-release' 2020-04-30 14:29:01 -05:00
Maurice Parker
d30987ca0a Use main thread operation to only allow one remote notification at a time to run. 2020-04-29 15:46:29 -05:00
Maurice Parker
d1c3d43018 Don't animate progress bar when initially added to the superview 2020-04-29 14:29:21 -05:00
Maurice Parker
a48cbfe1ca Add code to show the Feed Inspector when the feed icon in the article view is pressed. Issue #1931 2020-04-28 21:26:57 -05:00
Maurice Parker
5e4ebb7298 Disallow the feed icon from the image zooming. 2020-04-28 21:03:21 -05:00
Maurice Parker
c1bb75f21e Deleted dead code 2020-04-28 20:42:31 -05:00
Maurice Parker
37bbee9fcc Remove calls to dismiss delegate function on cancel. Issue #2010 2020-04-28 17:58:06 -05:00
Maurice Parker
e77abf42c3
Revert "Removes AddAccountDismissDelegate" 2020-04-28 17:53:24 -05:00
Maurice Parker
31f3487d7a Reset focus when returning to the app from another app or the safari view controller. Issue #1963 2020-04-28 17:16:34 -05:00
Maurice Parker
31b04f626a Fix spelling of hashtag. Thanks Stephen! 2020-04-25 15:12:35 -05:00
Maurice Parker
f0988d1b68 Add #hashtag to placeholder text 2020-04-25 14:31:07 -05:00
Maurice Parker
86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver
6aff83481f Make attributed titles work on iOS 2020-04-24 16:20:41 -05:00
Maurice Parker
ee92cf69d2 Merge branch 'extension-point' 2020-04-24 13:34:13 -05:00
Maurice Parker
6f29b21ddc
Merge pull request #2013 from rizwankce/fix/missing-add-account-title 
Add title for AddAccountViewController
 2020-04-24 10:30:31 -05:00
Rizwan Mohamed Ibrahim
54fc60aa51
Add title for AddAccountViewController 
view controller title via storyboard
 2020-04-24 20:56:29 +05:30
Maurice Parker
a46609b564
Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting 
Deselect the cell row when selected for add account view controller
 2020-04-24 09:11:28 -05:00
Rizwan Mohamed Ibrahim
43f175d71a
Removes AddAccountDismissDelegate 
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
 2020-04-24 18:49:49 +05:30
Rizwan Mohamed Ibrahim
c7e3162c22
Deselect the cell row when selected for add account view controller 
To avoid the highlighting even after the row is selected
 2020-04-24 18:39:18 +05:30
Nate Weaver
37ae46ea4c Merge more styles and fix styling of tables with explicit thead/tbody/tfoot 
Also use :matches() to simplify some rules.

# Conflicts:
#	Mac/MainWindow/Detail/styleSheet.css
#	iOS/Resources/styleSheet.css
 2020-04-23 23:21:22 -05:00
Maurice Parker
e741e8e1b4 Make detail entry more user friendly 2020-04-23 11:50:29 -05:00
Maurice Parker
c451cb38d9 Add Twitter detail entry scene 2020-04-23 10:43:09 -05:00
Maurice Parker
e1fc8d15d6 Update storyboard for dynamic type. 2020-04-23 10:01:26 -05:00
Maurice Parker
059b24c57b Add Twitter select account for URL builder 2020-04-23 09:50:19 -05:00
Maurice Parker
e566d1493c Fix disclosure indicator 2020-04-23 09:10:40 -05:00
Maurice Parker
4ff273c3b5 Add single Home Timeline and Mentions URL builder. 2020-04-23 09:08:33 -05:00
Maurice Parker
7d2eba537b Change callback URL scheme to final scheme 2020-04-23 07:58:00 -05:00
Maurice Parker
1b48b09369 Fix hammer button compression bug 2020-04-23 06:55:57 -05:00
Maurice Parker
4461cf83cb Add select URL Builder dialog 2020-04-23 04:44:26 -05:00
Maurice Parker
e11cf2ccf5 Rename to use common name for table view cell 2020-04-23 04:00:51 -05:00
Maurice Parker
62ca536717 Merge branch 'master' into extension-point 2020-04-22 22:06:16 -05:00
Maurice Parker
147d5c301c Merge branch 'ios-release' 2020-04-22 22:04:45 -05:00
Maurice Parker
947c4f04d7 Implement fix that prevents wiggling on both the timeline and the article views. 2020-04-22 22:03:15 -05:00
Maurice Parker
a5583fc655 Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976 2020-04-22 18:18:20 -05:00
Maurice Parker
5d5093d26d Merge branch 'master' into extension-point 2020-04-21 20:25:50 -05:00
Maurice Parker
f1357c0a23 Merge branch 'ios-release' 2020-04-21 20:25:14 -05:00
Maurice Parker
82e7d4eaf0 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-21 20:24:01 -05:00
Maurice Parker
2454b807bb Always update the status sync timer when returning to the foreground. Issue #2005 2020-04-21 20:23:46 -05:00
Rizwan Mohamed Ibrahim
108da4ccf4
Fix buttons a11y label for close and share button for image vc 
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
 2020-04-21 22:14:58 +05:30
Maurice Parker
575288b78e Merge branch 'master' into extension-point 2020-04-21 02:10:31 -05:00
Maurice Parker
7268dcdd77 Merge branch 'ios-release' 2020-04-21 02:06:19 -05:00
Maurice Parker
f7bdf9d47c Correct text resizing issues in color palette settings. Issue #2000 2020-04-21 01:57:19 -05:00
Maurice Parker
7afcf681fe Stablize swipe back gesture for timeline. Issue #2002 2020-04-21 01:52:39 -05:00
Maurice Parker
d0d29fd7da Merge branch 'master' into extension-point 2020-04-19 19:01:11 -05:00
Nate Weaver
2a6d9994ea Move shared CSS into its own file 2020-04-19 18:38:33 -05:00
Maurice Parker
eeb7b518a8 Change how showIcons is determined to take into consideration empty bylines 2020-04-19 17:29:11 -05:00
Maurice Parker
b80270f65b Fix iOS timeline layout issue with truncated bylines 2020-04-19 17:28:00 -05:00
Maurice Parker
ac41c7af69 Added timestamp to retweets 2020-04-18 16:27:19 -05:00
Maurice Parker
ad95cef6bb Add iOS twitter stylings 2020-04-18 15:17:56 -05:00
Maurice Parker
1778a270d6 Show byline in timeline for single feed timelines when available. 2020-04-18 07:53:56 -05:00
Maurice Parker
9b39165018 Merge branch 'master' into extension-point 2020-04-16 16:37:18 -05:00
Maurice Parker
afdfe5fe71 Merge branch 'ios-release' 2020-04-16 16:36:53 -05:00
Maurice Parker
a4c672bb46 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-16 16:27:04 -05:00
Maurice Parker
928e93c074 Remove web view recycling as this seems to contribute to the blank article problem on iPadOS 2020-04-16 16:26:53 -05:00
Brent Simmons
f9a11198f0 Remove Omni from credits and about text. 2020-04-16 13:24:20 -07:00
Maurice Parker
d4b5d7bde4 Add FeedProviderManager 2020-04-16 15:06:56 -05:00
Maurice Parker
d168658e05 Add Extension Point maintenance to the iOS app. 2020-04-16 08:25:40 -05:00
Brent Simmons
1321f0b9ff Loop through through rows using the count of rows in that section, rather than the count of rows in the initial indexPath’s section. Fix #1987. 2020-04-12 18:23:20 -07:00
Brent Simmons
6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker
46f614e960 Merge branch 'ios-release' 2020-04-12 11:50:11 -05:00
Maurice Parker
7064d5d8f5 Fix regression where navigating back and paging back from an article happened at the same time. 2020-04-12 11:48:14 -05:00
Maurice Parker
e6c5d2f199 Merge branch 'ios-release' 2020-04-11 15:59:37 -05:00
Maurice Parker
7c266d65ee Force the frame to center when displaying. Issue #1983 2020-04-11 15:58:48 -05:00
Maurice Parker
02f62bbb61 Fix image cropping. Issue #1967 2020-04-11 15:11:12 -05:00
Maurice Parker
6a9620e4de Add NewsBlur and CloudKit to addable account types on production builds. 2020-04-06 15:37:26 -05:00
Maurice Parker
6ad4eeb280 Merge branch 'ios-release' 2020-04-06 08:47:56 -05:00
Maurice Parker
f0ec7c5e19 Fix problem where back swiping wouldn't work anymore for full screen. Issue #1970 2020-04-06 08:47:01 -05:00
zgjie
bcfd75ff68 Replace the firstElementPassingTest function come from RSCore with the native function first(where:). 2020-04-06 02:06:24 +08:00
Maurice Parker
40ea5243c6 Removed notification we no longer needed to use to refresh the Feeds and Sidebar. 2020-04-01 20:31:32 -05:00
Maurice Parker
ea78b5683d Fix background notification processing of CloudKit changes. 2020-04-01 20:21:14 -05:00
Maurice Parker
def48546a3 Change how initial refresh is triggered. 2020-04-01 16:45:29 -05:00
Maurice Parker
4941d60c1a Put add accounts list into alphabetical order 2020-04-01 07:50:11 -05:00
Maurice Parker
b664ae2609
Merge pull request #1959 from quanganhdo/mac-newsblur 
Add NewsBlur support to Mac version
 2020-03-30 17:37:08 -05:00
Anh Do
c3506e9329
Add NewsBlur to Preferences 2020-03-30 17:45:47 -04:00
Maurice Parker
41acb716bd Remove activity donation for next unread. Issue #1957 2020-03-30 15:42:42 -05:00
Maurice Parker
d9e5350804 Hide credentials section for iCloud. 2020-03-30 03:00:52 -05:00
Maurice Parker
187121298e Added support for CloudKit push notifications (subscriptions). 2020-03-30 02:48:25 -05:00
Maurice Parker
4f425c9c86 Implement web feed sync between devices. 2020-03-29 17:12:34 -05:00
Maurice Parker
ecc20ad9e3 Enabled adding a CloudKit account on iOS. 2020-03-28 17:51:14 -05:00
Maurice Parker
532db0b640 Merge branch 'ios-release' 2020-03-28 16:51:50 -05:00
Maurice Parker
649972f57f Created the Developer build which has some functionality disabled for those without access to the API keys needed. 2020-03-28 16:51:41 -05:00
Maurice Parker
715671edad Rebuild the Feeds list when coming back to it from the Timeline while the root split is collapsed to filter read Feeds. 2020-03-28 01:43:54 -05:00
Maurice Parker
6d085fdacf Inline videos and enable player controls for both Mac and iOS. Issue #1952 2020-03-28 00:56:29 -05:00
Maurice Parker
bd1c73c1d3 Automatically remove Feed items if they should be filtered. Issue #1949 2020-03-27 18:24:57 -05:00
Maurice Parker
a13f10441f Change pointer interaction to encompass the complete button. 2020-03-26 11:20:13 -05:00
Maurice Parker
53b00c5414 Don't show add account option for CloudKit when the entitlement isn't present. 2020-03-25 16:09:01 -05:00
Maurice Parker
6c06c7791c Add interaction to buttons that were missing it. Issue #1945 2020-03-25 08:55:02 -05:00
Maurice Parker
450ddbd364 Refactored new pointer interaction code to be more simple. 2020-03-24 18:27:54 -05:00
Maurice Parker
bd75df7294 Add pointer interaction for timeline header button. Issue #1943 2020-03-24 16:42:46 -05:00
Maurice Parker
25882f69c8 Merge branch 'ios-release' 2020-03-24 16:00:53 -05:00
Maurice Parker
d615a0a894 Fix bug where clean up shortcut wouldn't clear articles if wrong setting was off. 2020-03-24 16:00:01 -05:00
Maurice Parker
d0680bcc73 Merge branch 'ios-release' 2020-03-24 12:21:32 -05:00
Maurice Parker
2d56971c45 Added missing dev files 2020-03-23 07:26:44 -05:00
Maurice Parker
8105756ccb Add some work in progress for CloudKit syncing 2020-03-22 16:35:03 -05:00
Maurice Parker
85cbd204b3 Fixed clean up keyboard shortcut 2020-03-22 10:23:31 -05:00
Maurice Parker
97226f543b Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842 2020-03-22 10:18:07 -05:00
Anh Do
b7fe991b7b
Retrieve session id for later requests 2020-03-22 00:47:27 -04:00
Anh Do
034aabbfff
Add login/logout support 2020-03-22 00:47:26 -04:00
Anh Do
8f5f856e49
Add NewsBlur account prototype 2020-03-22 00:47:26 -04:00
Maurice Parker
960af2a8df Parameterize the container so that each developer has their own 2020-03-21 20:53:21 -05:00
Brent Simmons
07cc89541c Add iCloud.com.ranchero.NetNewsWire entitlement to Mac and iOS targets. 2020-03-21 17:43:33 -07:00
Maurice Parker
9f516caa35 Don't use borders on nested tables. Issue #1936 2020-03-21 17:19:03 -05:00
Maurice Parker
9315a00d19 Add CloudKit container entitlements. 2020-03-21 02:34:34 -05:00
Maurice Parker
e7436925ad Don't remove filtered feeds on article downloads. 2020-03-20 10:34:18 -05:00
Maurice Parker
316e4e62b2 Removed separator insets from layout code as they were no longer needed. 2020-03-20 06:58:11 -05:00
Maurice Parker
8a75defee9 Set row height when table is empty and set to automatic when articles are present. Issue #1919 2020-03-18 16:06:05 -05:00
Maurice Parker
1d26bc8c70
Revert "Set proper cell height for empty article array" 2020-03-18 15:55:33 -05:00
Maurice Parker
770206df60 Merge branch 'ios-release' 2020-03-17 17:19:31 -05:00
Maurice Parker
36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker
37cf7fae1d Fix regression that prevented Always Show Reader View from working. 2020-03-16 07:58:51 -05:00
Maurice Parker
07042b8a2a Implemented Clean Up keyboard shortcut. Issue #1915 2020-03-15 18:15:52 -05:00
Flowinho
47dc34db5d Fix Typo 
This contains work related to issue #1910
 2020-03-15 22:44:12 +01:00
Flowinho
2ade0140bc Set proper cell height for empty article array 
Contains work related to #1800

This one took me a while to figure out since they amount of articles is tied to the coordinator.

- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.

Greetings from southern germany!
 2020-03-15 22:31:54 +01:00
Maurice Parker
acaf3fac9f Add user agent to plist. Issue #1913 2020-03-15 11:48:07 -05:00
Maurice Parker
a620a20588 Add the option to select the user interface color palette. Issue #1900 2020-03-15 04:25:25 -05:00
Maurice Parker
5b5eaf6bb7 Merge branch 'ios-release' 2020-03-14 17:13:25 -05:00
Maurice Parker
07dc4f1f10 Don't start the article extractor if we only want to store the article. Issue #1494 2020-03-14 06:31:14 -05:00
Nate Weaver
e6af6ece42 Add top and bottom margins to figure elements 2020-03-13 22:01:07 -05:00
Nate Weaver
9a3fe5caa5 Add a max-width to body 2020-03-13 21:36:16 -05:00
Maurice Parker
66e7e425aa Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806 2020-03-13 17:06:53 -05:00
Maurice Parker
833c336f2f Only show the timeline next read button when the root split view controller is collapsed. Issue #1822 2020-03-13 16:03:42 -05:00
Maurice Parker
49257970af Removed testing code. Issue #1810 2020-03-13 15:35:33 -05:00
Maurice Parker
2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width 
Bugfix progress indicator max width
 2020-03-13 15:31:30 -05:00
Maurice Parker
7922efab1e
Merge pull request #1899 from flowinho/ios-release 
Hide articleExtractor and actionBarButtonItem
 2020-03-13 15:13:33 -05:00
Flowinho
ce428d2cc6 Hide articleExtractor and actionBarButtonItem 2020-03-13 20:21:18 +01:00
Maurice Parker
52be6e5743 Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731 2020-03-13 10:17:00 -05:00
Maurice Parker
d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release 
Add background to pure white icons
 2020-03-13 10:04:56 -05:00
Flowinho
130691db34 Revert to old logic 2020-03-13 14:21:38 +01:00
Flowinho
ee86b1a148 Apply background if feed-icon is bright 2020-03-13 11:54:31 +01:00
Maurice Parker
77fd3020cc Correct font used to specify font size. Issue #1878 2020-03-12 19:01:10 -05:00
Nate Weaver
76dd3abff2 Properly style footnotes that have been absoluted 2020-03-12 18:32:42 -05:00
Maurice Parker
dfdf19e17f Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-03-12 18:07:49 -05:00
Maurice Parker
61a2e95d2b Manually specify the font size to work around a WKWebView resizing bug. Issue #1878 2020-03-12 18:07:40 -05:00
Maurice Parker
c19bf93586
Merge pull request #1890 from flowinho/ios-release 
Align feedname and date correctly if there is no title or summary
 2020-03-12 17:03:58 -05:00
Flowinho
0a3713e078 Align feedname and date correctly if there is no title or summary 2020-03-12 22:57:30 +01:00
Maurice Parker
47e42fab0a Removed old debugging statement. 2020-03-12 16:01:13 -05:00
Flowinho
da64f65c7b Fixes close button icon distortion 
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.

- Set content-mode of the buttons imageview to scaleAspectFit.
 2020-03-12 21:54:50 +01:00
Flowinho
feacda1c3b HOTFIX silly me 2020-03-12 21:33:02 +01:00
Flowinho
91247b7f16 Adding dynamic width algorithm to the titleLabel 
This commit adds multiple functionalities at once:

- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).

The title label now resizes itself depending on the devices it’s displazed on.

- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.

The numbers are derived from my personal preference when implementing it.
 2020-03-12 21:23:57 +01:00
Flowinho
97c79202fc Added missing constraints to the UISwitch elements 2020-03-12 17:56:43 +01:00
Maurice Parker
22b9e7b54b Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883 2020-03-11 19:45:45 -05:00
Maurice Parker
27b1443def Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881 2020-03-11 18:17:09 -06:00
Maurice Parker
76d5f4a073 Remove flush and restore of web view queues. Issue #1882 2020-03-11 17:02:16 -06:00
Maurice Parker
38981d01bd Don't remove items from Feeds list when batch update is performed. Issue #1879 2020-03-11 15:19:55 -06:00
Maurice Parker
9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Flowinho
b178fe93af Call action on return if password was added 
This is an obvious change.
 2020-03-11 14:02:06 +01:00
Flowinho
66fae15f64 Remove redundant code to lessen LOC 
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
 2020-03-11 13:43:02 +01:00
Flowinho
386efd632b Changing UIContentType from username to email adress 
Add responder switch to streamline login flow

This change achieves two things:

- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
 2020-03-11 13:43:02 +01:00
Michele Volpato
ee0f982e93 Remove unneeded whitespaces 2020-03-02 22:33:59 +01:00
Michele Volpato
115405f1f0 Fix progress bar width, add contraints to progress label 2020-03-02 22:25:57 +01:00
Maurice Parker
94c6ca428f Merge branch 'mac-release' 2020-03-01 16:32:31 -08:00
Maurice Parker
3a0f57e4da Fixed toggle color. Issue #1838 2020-02-29 09:09:53 -08:00
Maurice Parker
cd5e491f00 Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression) 2020-02-26 16:02:36 -08:00
Maurice Parker
9e3f061fcb Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808 2020-02-25 18:06:02 -08:00
Maurice Parker
5a5abb0b87 Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808 2020-02-25 15:10:51 -08:00
Maurice Parker
a4bbf65944 Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression) 2020-02-25 10:42:56 -08:00
Maurice Parker
d222a9f617 Change to not force unwrap the descriptor. Issue #1818 2020-02-24 08:42:19 -08:00
Maurice Parker
23b8af4634 Don't end the operation until the deselection animation has completed. (Regression) 2020-02-24 08:07:14 -08:00
Maurice Parker
afadadff69 Restore timeline selection when coming back into foreground. (Regression) 2020-02-23 17:12:02 -08:00
Maurice Parker
48e856fc04 Serialize access to the UITableView for scrolling and diffable datasource updates. Issue #1806 2020-02-23 10:57:20 -08:00
Maurice Parker
ad7dde8564 Merge branch 'ios-candidate' 2020-02-21 17:02:14 -08:00
Brent Simmons
fd0363aad2 Turn double space into single space after sentence in Settings. 2020-02-18 23:14:27 -08:00
Maurice Parker
3e93877362 Add instructions for full screen and fix some dynamic type problems. Issue #1799 2020-02-18 17:30:25 -08:00
Maurice Parker
28c2598cf6 Exempt the current article from the timeline read filter. Issue #1798 2020-02-18 14:14:18 -08:00
Maurice Parker
0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker
8acd6a039a Change event used to stop web view activity (video and image zooming) so that it doesn't interfere with the image zooming transition. 2020-02-18 11:08:38 -08:00
Maurice Parker
e3b32847f9 Stop image zooming on swipes and video playback on button presses. Issue #1801 2020-02-18 09:49:54 -08:00
Maurice Parker
f79eaf7c19 Avoid redundant shadow table rebuilds when auto-expanding containers. 2020-02-18 09:30:58 -08:00
Maurice Parker
03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Maurice Parker
58b8a9adb0 Render article on to be recycled web view and delay new web view showing to 0.3. Issue #1780 2020-02-13 17:35:34 -08:00
Maurice Parker
d01e9cef42 Remove unintended web view load when changing the article. 2020-02-13 16:08:44 -08:00
Maurice Parker
2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Maurice Parker
31b72221f8 Rollback delay that was causing blank articles to be shown. Issue #1780 2020-02-09 11:57:07 -08:00
Brent Simmons
eb770f4494 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 17:22:03 -08:00
Brent Simmons
cac67f8ac4 Use percent-encoding — via URLComponents — on the articleID in the nnwImageIcon URL scheme. 2020-02-08 17:21:55 -08:00
Maurice Parker
eed12e5347 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-08 16:56:06 -08:00
Maurice Parker
bdd79aead5 Delay swapping out the web view until the new web view has had a chance to render. Issue #1780 2020-02-08 16:55:16 -08:00
Brent Simmons
fe6fbd31a8 Edit the about NetNewsWire text. Add credit for Wevah; add thanks to Feedbin for Reader view hosting. 2020-02-08 16:14:45 -08:00
Maurice Parker
e5a9205747 Always reload the web view when the showing state changes. Issue #1775 2020-02-06 11:41:06 -08:00
Maurice Parker
268c20da56 Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777 2020-02-06 10:36:39 -08:00
Mihael Cholakov
936596f5d0 Shifting sections when one should be hidden 2020-02-06 15:27:49 +02:00
Brent Simmons
d40eaed1f5 Begin moving the MainThreadOperationQueue from Account to ArticlesDatabase. 2020-02-05 21:23:23 -08:00
Maurice Parker
d1f1ca22b6 Add a hack to prevent horizontal scrolling on iPad. Issue #1714 2020-02-05 13:46:59 -08:00
Maurice Parker
dfd6be5fa6 Flush are rebuild web view queue when suspending and restoring the app. Issue #1563 2020-02-04 16:00:26 -08:00
Maurice Parker
8ed9958631 Change full article setting to enable or disable the feature. Issue #1773 2020-02-04 11:24:06 -08:00
Maurice Parker
76bad13ae1 Rebuild the backing stores to except spotlight search result restoration. Issue #1759 2020-02-04 11:00:55 -08:00
Maurice Parker
e47e2d4ea0 Fetch any potential new articles and merge them when returning to the foreground. Issue #1761 & #1754 2020-02-03 14:05:22 -08:00
Maurice Parker
336c980243
Merge pull request #1769 from danmorrison/ios-candidate 
Fix Feed Select Folder Table View Cell horizontal alignment
 2020-02-03 10:11:00 -08:00
Nate Weaver
ba6315fa07 Set lastImageCacheFlushDate on launch in CacheCleaner instead of registerDefaults() 
So it's actually persisted to disk.
 2020-02-02 17:55:51 -06:00
Dan Morrison
da501cb39b Fix horizontal alignment #1768 2020-02-03 09:43:05 +11:00
Brent Simmons
782dfd688e
Merge pull request #1767 from hartlco/1766-Go-to-feed-visible-when-you-are-already-inside-the-feed 
Don’t show “Go to feed” action if already inside feed
 2020-02-02 12:51:21 -08:00
Martin Hartl
83241cc329 Don’t show “Go to feed” action if already inside feed 2020-02-02 21:44:54 +01:00
Brent Simmons
4fe2a3134f Suspend the databases sooner when suspending the application. 2020-02-02 12:11:39 -08:00
Maurice Parker
596575c0e8 Delay making the initial web view available to give it some time to load the DOM. Issue #1756 2020-02-01 16:41:10 -08:00
Maurice Parker
fcd7b88a62 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-02-01 16:38:26 -08:00
Brent Simmons
5d1ec3bff2
Merge pull request #1763 from Wevah/vertical-scroll-fix 
Don't block vertical pan gestures
 2020-02-01 15:21:40 -08:00
Brent Simmons
b50fabe325 Fix a crash that could happen when laying out the progress view while it’s not in the view hierarchy. Fix #1764. 2020-02-01 12:19:39 -08:00
Nate Weaver
b86341f44c Don't block vertical pan gestures 2020-02-01 01:12:54 -06:00
Maurice Parker
8cb28b63b8 Always swap out the web view to prevent white flashing between articles and make loading faster. 2020-01-31 21:07:08 -07:00
Maurice Parker
a0f429448f Call completions immediately if the previous WebViewController was deallocated because the iPad was rotated. Issue #1757 2020-01-30 18:48:51 -07:00
Maurice Parker
df3c78b1c6 Change next/prev feed searches so that they skip collapsed sections. Issue#1755 2020-01-30 18:37:22 -07:00
Maurice Parker
63e15d78c2 Fix max size phone landscape layout problems. Issue #1743 2020-01-30 17:39:21 -07:00
Maurice Parker
f9dea33375 Remove force unwraps of url and container. Issue #1721 2020-01-30 13:59:15 -07:00
Maurice Parker
13a1ef0605 Don't animate the disclosure icon until it has been added to the view hierarchy. Issue #1717 2020-01-30 13:44:31 -07:00
Maurice Parker
6454330c8b Add the subviews to the contentVIew (per the documentation). Issue #1717 2020-01-30 13:27:17 -07:00
Maurice Parker
ab8deab726 Correct object ownership to remove retain cycle 2020-01-30 12:53:27 -07:00
Nate Weaver
e6c2c32456 Standardize on tabs 2020-01-30 06:19:54 -06:00
Nate Weaver
447cc44b8e Put <title> and <base> in the <head> instead of <body> 
This also means renderHTML() is no longer needed.
 2020-01-30 06:15:14 -06:00
Maurice Parker
f9589faa59 Keep queued WKWebViews in a hidden view until they are needed. Issue #1563 2020-01-29 17:39:40 -07:00
Maurice Parker
fdde879910 Rest the currentFeedIndexPath if it has become invalidated by a shadow table rebuild. Issue #1741 2020-01-29 17:06:35 -07:00