316e4e62b2
Removed separator insets from layout code as they were no longer needed.
2020-03-20 06:58:11 -05:00
8a75defee9
Set row height when table is empty and set to automatic when articles are present. Issue #1919
2020-03-18 16:06:05 -05:00
1d26bc8c70
Revert "Set proper cell height for empty article array"
2020-03-18 15:55:33 -05:00
36841602a5
Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923
2020-03-17 17:18:24 -05:00
37cf7fae1d
Fix regression that prevented Always Show Reader View from working.
2020-03-16 07:58:51 -05:00
07042b8a2a
Implemented Clean Up keyboard shortcut. Issue #1915
2020-03-15 18:15:52 -05:00
47dc34db5d
Fix Typo
...
This contains work related to issue #1910
2020-03-15 22:44:12 +01:00
2ade0140bc
Set proper cell height for empty article array
...
Contains work related to #1800
This one took me a while to figure out since they amount of articles is tied to the coordinator.
- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.
Greetings from southern germany!
2020-03-15 22:31:54 +01:00
acaf3fac9f
Add user agent to plist. Issue #1913
2020-03-15 11:48:07 -05:00
a620a20588
Add the option to select the user interface color palette. Issue #1900
2020-03-15 04:25:25 -05:00
07dc4f1f10
Don't start the article extractor if we only want to store the article. Issue #1494
2020-03-14 06:31:14 -05:00
e6af6ece42
Add top and bottom margins to figure elements
2020-03-13 22:01:07 -05:00
9a3fe5caa5
Add a max-width to body
2020-03-13 21:36:16 -05:00
66e7e425aa
Remove obsolete code that could be causing the feed unread counts to not update. Issue #1806
2020-03-13 17:06:53 -05:00
833c336f2f
Only show the timeline next read button when the root split view controller is collapsed. Issue #1822
2020-03-13 16:03:42 -05:00
49257970af
Removed testing code. Issue #1810
2020-03-13 15:35:33 -05:00
2240058fe8
Merge pull request #1850 from mvolpato/bugfix-progress-indicator-max-width
...
Bugfix progress indicator max width
2020-03-13 15:31:30 -05:00
7922efab1e
Merge pull request #1899 from flowinho/ios-release
...
Hide articleExtractor and actionBarButtonItem
2020-03-13 15:13:33 -05:00
ce428d2cc6
Hide articleExtractor and actionBarButtonItem
2020-03-13 20:21:18 +01:00
52be6e5743
Darken light mode icon color so that it contrasts better against pure white icons. Issue #1731
2020-03-13 10:17:00 -05:00
d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
...
Add background to pure white icons
2020-03-13 10:04:56 -05:00
130691db34
Revert to old logic
2020-03-13 14:21:38 +01:00
ee86b1a148
Apply background if feed-icon is bright
2020-03-13 11:54:31 +01:00
77fd3020cc
Correct font used to specify font size. Issue #1878
2020-03-12 19:01:10 -05:00
76dd3abff2
Properly style footnotes that have been absoluted
2020-03-12 18:32:42 -05:00
dfdf19e17f
Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release
2020-03-12 18:07:49 -05:00
61a2e95d2b
Manually specify the font size to work around a WKWebView resizing bug. Issue #1878
2020-03-12 18:07:40 -05:00
c19bf93586
Merge pull request #1890 from flowinho/ios-release
...
Align feedname and date correctly if there is no title or summary
2020-03-12 17:03:58 -05:00
0a3713e078
Align feedname and date correctly if there is no title or summary
2020-03-12 22:57:30 +01:00
47e42fab0a
Removed old debugging statement.
2020-03-12 16:01:13 -05:00
da64f65c7b
Fixes close button icon distortion
...
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView.
- Set content-mode of the buttons imageview to scaleAspectFit.
2020-03-12 21:54:50 +01:00
feacda1c3b
HOTFIX silly me
2020-03-12 21:33:02 +01:00
91247b7f16
Adding dynamic width algorithm to the titleLabel
...
This commit adds multiple functionalities at once:
- The background of the image title now features rounded corners with a radius of 6 - which is consistent to iOS appearace.
- The background of the image title now is enlarged to make sure the letters do not touch the borders of the view. (This was a finding during implementation).
- The background of the image title is now removed when no title is present (memory optimization / prevention of unwanted optical glitches).
The title label now resizes itself depending on the devices it’s displazed on.
- On iPhone it will take 92% percent of available screen width.
- On iPhone it will 80% of available screen width.
- This works for all device orientations.
The numbers are derived from my personal preference when implementing it.
2020-03-12 21:23:57 +01:00
97c79202fc
Added missing constraints to the UISwitch elements
2020-03-12 17:56:43 +01:00
22b9e7b54b
Don't reset the windowScrollY position on every page render and don't set it if JavaScript returns it corrupted. Issue #1883
2020-03-11 19:45:45 -05:00
27b1443def
Remove dispatch code that didn't seem to help and caused us to not be able to find the correct view controller when setting the article. Issue #1881
2020-03-11 18:17:09 -06:00
76d5f4a073
Remove flush and restore of web view queues. Issue #1882
2020-03-11 17:02:16 -06:00
38981d01bd
Don't remove items from Feeds list when batch update is performed. Issue #1879
2020-03-11 15:19:55 -06:00
9007ed4b06
Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834 , #1856 , and #1845
2020-03-11 14:47:00 -06:00
b178fe93af
Call action on return if password was added
...
This is an obvious change.
2020-03-11 14:02:06 +01:00
66fae15f64
Remove redundant code to lessen LOC
...
- Less code - less bugs.
- Also resign the first responder when the user presses the action button
2020-03-11 13:43:02 +01:00
386efd632b
Changing UIContentType from username to email adress
...
Add responder switch to streamline login flow
This change achieves two things:
- When the user presses Return and the email field is selected, the cursor now switches to the password field (as expected by the user).
- It enables iOS to pick up login and password field and enables password autofill.
2020-03-11 13:43:02 +01:00
ee0f982e93
Remove unneeded whitespaces
2020-03-02 22:33:59 +01:00
115405f1f0
Fix progress bar width, add contraints to progress label
2020-03-02 22:25:57 +01:00
3a0f57e4da
Fixed toggle color. Issue #1838
2020-02-29 09:09:53 -08:00
cd5e491f00
Fix issue where full screen wouldn't come back after being engaged and moving to the timeline. (Regression)
2020-02-26 16:02:36 -08:00
9e3f061fcb
Dispatch the page controller setting since it is unreliable. Issue #1756 & Issue #1808
2020-02-25 18:06:02 -08:00
5a5abb0b87
Ensure that the dom is fully loaded on *all* web views before being made available to process JavaScript. Issue #1756 & Issue #1808
2020-02-25 15:10:51 -08:00
a4bbf65944
Coalesce unread count backing store rebuilds to prevent feeds list flickering while syncing and the feeds filter is engaged. (Regression)
2020-02-25 10:42:56 -08:00
d222a9f617
Change to not force unwrap the descriptor. Issue #1818
2020-02-24 08:42:19 -08:00
Maurice Parker
Flowinho
Nate Weaver
Flowinho
Michele Volpato