ac37443dbb
Stubbed out menu item keyboard shortcuts and implemented the numbered ones
2019-09-05 13:14:14 -05:00
efd17502e0
Stub out all the global shortcut functions and move global shortcuts to the RootSplitViewController
2019-09-05 11:29:04 -05:00
ac03992430
Fix bug in arrow key navigation where focus could get stolen from the timeline
2019-09-05 10:46:24 -05:00
7a452e2a3c
Add keyboard arrow key navigation
2019-09-04 21:06:29 -05:00
ae06544dd5
Add iframe to the list of max width elements to prevent youtube videos and others from being too large
2019-09-04 17:32:10 -05:00
dabb78cde4
Merge branch 'mac-release'
2019-09-04 17:20:37 -05:00
8758d28cd7
Implement keyboard shortcut infrastructure and first shortcuts
2019-09-04 16:24:48 -05:00
68143aa2c5
Implement keyboard shortcut infrastructure and first shortcuts
2019-09-04 16:24:16 -05:00
091b43a9fb
Apply figure styles to iOS as well
2019-09-04 19:58:30 +01:00
00a84ce6b5
Fix bug that prevented timeline from being restored after searching ends
2019-09-04 10:42:28 -05:00
a29f69c0cb
Create separate launch storyboard for iPad since we don't use large titles on iPad in three panel mode which is the only one you will see while launching
2019-09-04 04:46:13 -05:00
17a5d291f4
Remove become and resign first responder code in Feeds and Timeline
2019-09-03 20:39:00 -05:00
fc872cf88f
Add missing activity type
2019-09-03 19:58:48 -05:00
640faaa114
Simplify the article replacement logic
2019-09-03 16:07:02 -05:00
5cb099aee6
Add next unread as a user activity and more aggressively invalidate user activities
2019-09-03 15:52:59 -05:00
e6a4338a86
Restore the feed selection if an account containing the selection is expanded
2019-09-03 13:59:22 -05:00
b7ba2c809c
Use better function for looking up article index
2019-09-03 13:43:59 -05:00
bf572633f8
Enable drag and drop between accounts
2019-09-03 13:27:23 -05:00
960f09826b
Add separator line to section headers so that they don't look smooshed together when collapsed
2019-09-03 13:00:31 -05:00
4bce625f18
Clear search results when no timeline fetcher is specified
2019-09-03 12:25:27 -05:00
2a00c879f8
Change to animate search results changes
2019-09-03 12:12:42 -05:00
2e71cc573d
Cap the possible destination index used during Feed moves
2019-09-03 12:07:18 -05:00
d5adbccd5b
Merge pull request #949 from correia/issue-948
...
Fix for issue #948 — bad highlight state for table cell views in light mode.
2019-09-03 11:56:14 -05:00
061872b7ff
Simplified/corrected highlighted/selected appearance of feed and timeline cells.
...
- Set the highlighted text color on labels in table cells. This will be used
for both the highlight and selected states automatically. (And since it is
used for both states, we avoid anachronistic state where we have black
text on a dark blue background in light mode as we transition from none ->
highlighted -> selected.)
- Keep the selected/highlighted overrides to adjust colors for non-UIControl
subelements.
2019-09-02 22:39:01 -07:00
932f6fdd30
Added NNWTableViewCell; a base class for cells with the NNW selection color.
...
Defined a semantic color for the selection color which is identical to
netNewsWireBlue.
MasterFeedTableViewCell and MasterTimelineTableViewCell now subclass
NNWTableViewCell and no longer directly customize their selected background
view.
2019-09-02 22:38:42 -07:00
0d6dbb6df3
Fix broken select next where it wasn't going to the next available fetcher in the Feeds scene
2019-09-02 17:28:28 -05:00
613cea5c7a
Change next unread function so that it skips the current article even if that article is marked as unread
2019-09-02 17:24:20 -05:00
fafb7de868
Remove Refresh shortcut item
2019-09-02 16:05:55 -05:00
93b702f170
Automatically copy any url in the pasteboard to the feed field for feed adds
2019-09-02 15:54:49 -05:00
c5fed06581
Add refresh home screen shortcut.
2019-09-02 15:45:09 -05:00
2c4531f481
Add the Add scene as a home page quick action.
2019-09-02 15:14:26 -05:00
b768877e23
Use correct delegate methods to begin and end searching
2019-09-02 12:40:14 -05:00
746c06d147
Prevent automated scrolling when selecting an article in the timeline
2019-09-02 12:05:11 -05:00
c405fdf583
Implement search home page quick action
2019-09-01 17:41:46 -05:00
33882ab276
Add Home Page Quick Actions
2019-09-01 16:54:07 -05:00
189af8d816
Invalidate user activities when collapsed and returning to Feeds scene
2019-09-01 15:31:11 -05:00
1a9acdcc50
Remove TreeController from Delete command as it is no longer used there
2019-09-01 14:56:27 -05:00
dfc3046bf0
Clear the timeline when the user begins searching
2019-09-01 14:49:56 -05:00
a5298f0381
Refactor mark as read for articles to be in the SceneCoordinator instead of in the DetailViewController
2019-09-01 12:52:06 -05:00
858bdb7f21
Rename AppCoordinator to SceneCoordinator as that name better defines its purpose
2019-09-01 12:43:07 -05:00
43fb7dff9f
Fix bug that prevented new folders from appearing in the Feeds
2019-09-01 10:29:30 -05:00
397d75c6f6
Restore animation when adds and deletes happen to feed items
2019-09-01 10:11:03 -05:00
27883632d0
Fix bug that prevented reading article user activities from being restored
2019-08-31 20:23:14 -05:00
87030a5921
Implement stateRestorationActivity to save most relevant current user activity
2019-08-31 19:30:21 -05:00
407bd296db
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-08-31 17:37:49 -05:00
988ac1bbd8
Correct label color to specify correct platform
2019-08-31 17:37:42 -05:00
6caff148dd
Merge pull request #928 from correia/placeholder-content
...
Use noContentHTML rather than noSelectionHTML for prepared web views.
2019-08-31 17:20:52 -05:00
5f11c42fc2
Use noContentHTML rather than noSelectionHTML for prepared web views.
...
Added a noContentHTML to ArticleRenderer. Use that for the initial content
for queued web views so that we don't see a temporary flash of "No
Selection" when pushing to an article that doesn't load instantly.
2019-08-31 15:03:03 -07:00
c9858a0457
Show and hide scope bar based on editing state
2019-08-31 16:39:59 -05:00
fe2e0155da
Add scoped searching of articles
2019-08-31 15:53:47 -05:00
ba36572497
Merge pull request #927 from correia/correia/webview-layout
...
Added missing constraints to the web container view in the Detail scene.
2019-08-31 15:27:52 -05:00
77cf92ec13
Added missing constraints to the web container view in the Detail scene.
2019-08-31 13:20:23 -07:00
52ad2623a8
Limit the size of the queue maintained by DetailViewControllerWebViewProvider.
2019-08-31 13:16:46 -07:00
f7b53283d6
Maintain a queue of "prepared" web views for use in DetailWebViewController.
...
WKWebView has an awful behavior of a flash to white on first load when in
dark mode.
Keep a queue of WebViews where we've already done a trivial load so that by
the time we need them in the UI, they're past the flash-to-shite part of
their lifecycle.
2019-08-31 12:53:03 -07:00
a5b2c759ec
Create the WKWebView instance at runtime.
...
Specify a container view in the storyboard and create+install the web view
at viewDidLoad time.
This lets us experiment with solutions for providing a web view that avoids
the flash-to-white problem.
2019-08-31 12:30:01 -07:00
e5782ca464
Removed the hide the webview workaround to expose the flash to white problem.
2019-08-31 11:27:59 -07:00
67b9721a10
Made article search go fast
2019-08-31 12:12:50 -05:00
8002839941
Remove disclosure chevron from launch storyboard
2019-08-31 11:51:14 -05:00
d9ce01591f
Implement full article search
2019-08-31 11:50:34 -05:00
061dfe931b
Restrict access to rebuildShadowTable function
2019-08-31 11:38:03 -05:00
2cf6550226
Implemented launch storyboard. Issue #742
2019-08-30 17:39:39 -05:00
762710266d
Reload all cells when a batch update completes because we might be out of sync even though we called apply on the datasource. This can happen when moving a feed into and out of a folder.
2019-08-30 16:19:06 -05:00
ca0bdb3d35
Change to not animate on timeline fetcher changes
2019-08-30 14:42:33 -05:00
07ca61f7cf
Convert the timeline to use diffable datasources
2019-08-30 14:17:05 -05:00
3ab1412dc6
Preserve article selection when articles are downloaded (for iPad only)
2019-08-30 02:39:54 -05:00
86a302f787
Prevent selecting of items that may not show the current article selection as is done on the iPhone
2019-08-29 17:49:21 -05:00
6844762dfc
Refresh smart feeds when they are selected and articles are downloaded
2019-08-29 15:02:45 -05:00
b98877c7df
Fix bug where Feeds wasn't getting updated when adding/subtracting or activating/inactivating accounts
2019-08-29 14:46:51 -05:00
197fc0170e
Optimize and fix unread count updates
2019-08-29 14:35:18 -05:00
8e583c2fad
Prevent scrolling when reloading and reselecting a cell.
2019-08-29 14:04:15 -05:00
379ba49fd5
Fix select position getting lost on refreshes
2019-08-29 11:53:36 -05:00
be8c14bc65
Change to reload the individual row instead of just changing its contents
2019-08-28 20:21:50 -05:00
7062744758
Make sure we manually correct some state when using diffable datasources
2019-08-28 20:08:30 -05:00
89a38fa2b5
Change Feeds to use diffable data sources
2019-08-28 18:06:27 -05:00
9c66f6160e
Clean activities when the associated data is deleted
2019-08-28 11:30:40 -05:00
ba9f7ac426
Add navigation support for Folder and Feed view activities
2019-08-27 17:43:15 -05:00
d641223536
Add Activities for viewing Feeds and Folders
2019-08-27 14:20:34 -05:00
a1c74a03d1
Update to work with the enhanced FeedIconDownloader
2019-08-26 19:48:12 -05:00
6c98abb289
Fix image and favicon caching
2019-08-26 16:58:06 -05:00
d7c90106d1
Change to directly modify the avatar image instead of calling reload on the cells
2019-08-26 15:37:15 -05:00
c3e93f4b8c
Fix scenario where multiple timelines could get pushed onto the navigation stack
2019-08-26 09:07:41 -05:00
3d408d0b27
Prevent autolayout from messing around with our disclosure chevron
2019-08-25 20:06:45 -05:00
cf5fd4fa89
Invalidate content size correctly
2019-08-25 20:06:02 -05:00
a0b11da438
Prevent autolayout from messing with our manually set frames
2019-08-25 20:00:34 -05:00
31715ad4f0
Handle user activities on a cold launch
2019-08-25 17:49:09 -05:00
1e1208f54d
Update function name to match other like named functions
2019-08-25 17:08:39 -05:00
a0636b8f47
Add Smart Feeds as User Activities
2019-08-25 17:04:15 -05:00
dc6bf05ae4
Rename ActivityFactory to ActivityManager because it will also handle activity deletes in the future
2019-08-25 14:43:11 -05:00
0b48c3893d
Change AppCoordinator to directly call controller API's since that matches the Coordinator pattern better than sending them notifications
2019-08-25 11:38:04 -05:00
313518698c
add the ability to respond to NSActivityRequests
2019-08-24 19:31:29 -05:00
5b1c0485c5
Add NSUserActivity for reading articles
2019-08-24 14:57:51 -05:00
1ba60e2846
Fix bug that could cause a crash when an invalid indexPath was used to find a node in the shadow table
2019-08-23 13:23:13 -05:00
7f024586bb
Add navigation and toolbar theming for light mode. Issue #698
2019-08-23 12:27:45 -05:00
5a5a66d59f
Remove unneeded notifications
2019-08-22 16:50:20 -05:00
5088878721
Hack around WKWebView's white flashing that it does while loading content
2019-08-22 12:10:50 -05:00
d67b9193c5
Add large titles to Feeds controller (again)
2019-08-22 11:16:07 -05:00
c752d0b699
Optimize table cell loading so that we are no longer reloading all visible cells when an image is downloaded
2019-08-21 19:37:19 -05:00
af98311c63
Change to use async fetch for major account changes
2019-08-21 15:58:55 -05:00
2719772701
Port async timeline fetching from desktop NNW
2019-08-21 15:27:53 -05:00
b025b3ae46
fix typo in comment
2019-08-21 13:13:03 -05:00
c4e2420966
Change to get currently selected unread count item from total number of articles shown in timeline
2019-08-21 13:10:08 -05:00
eb8de035d7
Work around bug where cell tintColor isn't always correctly inherited from the window
2019-08-20 16:37:31 -05:00
9988847fba
Fix bug where mark older than caused all articles in the timeline to be marked as read
2019-08-20 05:46:44 -05:00
64fd5016a9
Commenting out feed context menus due to buggy implementation in Beta 6
2019-08-20 05:43:39 -05:00
b475f52871
Move show share dialog back to detail controller from coordinator
2019-08-19 18:13:21 -05:00
71343b9e72
Add Share context menu for timeline
2019-08-19 18:09:38 -05:00
badc2d3e25
Add open in browser context menu item
2019-08-19 17:38:30 -05:00
de7970314d
Add mark all as read for feed functionality
2019-08-19 17:26:09 -05:00
40a80356f1
Move business logic out of controller into coordinator where we typically keep it
2019-08-19 16:03:07 -05:00
6087951824
Remove context menu titles as they didn't provide any additional context
2019-08-19 15:49:42 -05:00
3245223b24
Add Select Feed context menu
2019-08-19 15:45:52 -05:00
eeebb30467
Implement Mark Older as Read for timeline
2019-08-18 17:34:53 -05:00
3cbf9f45a3
Add weak self usage in a couple needed places
2019-08-16 13:54:19 -05:00
066616b005
Add new images used in context menus to AppAssets where they belong
2019-08-16 13:27:41 -05:00
aabe950b2b
Add initial support for timeline context menus
2019-08-16 13:19:06 -05:00
2f5225163d
Center the pop over arrow in the button the same way that Apple does in Mail
2019-08-16 12:14:55 -05:00
7ac18029ea
Add additional swipe menu More to handle new actions
2019-08-15 19:46:31 -05:00
e8bbe9efbf
Add Folder context menu
2019-08-15 17:46:42 -05:00
e88210bbb7
Add copy url actions for feeds
2019-08-15 15:19:23 -05:00
c03c444997
Add initial context menu items for feeds.
2019-08-15 13:19:02 -05:00
1eb8da7749
Rearrange some code to put them in the correct sections
2019-08-15 12:42:25 -05:00
99e2a44eed
Fix crash that could happen on launch because the background task wasn't registered before it was triggered
2019-08-14 19:48:18 -05:00
659597e5e4
Fix about box for dark mode
2019-08-04 13:43:35 -05:00
f8eb750d56
Fix background color to respect dark mode
2019-08-04 13:23:34 -05:00
55da318503
Fix bug that was causing new feeds to be created with and empty string name
2019-08-04 13:20:37 -05:00
0b9522261e
Removed unused color for folders. This has been replaced with the tint color.
2019-08-03 17:28:45 -05:00
e39972bd64
Correct First Unread button to select the first unread in the timeline and show article in detail view. Issue #695
2019-08-03 17:07:43 -05:00
0269683b16
Reenable tinting now that at the beta OS releases don't crash when using them
2019-08-03 16:34:35 -05:00
02575c31fe
Change selected table row text to be white. Issue #693
2019-08-03 16:25:35 -05:00
4ece4173ba
Fix show back bar button bug introduced in last refactoring
2019-08-03 13:56:18 -05:00
9aa8ea7dc9
Refactor some common code and wrote copious comments
2019-08-03 13:53:30 -05:00
43d0d0c889
Reformat statement
2019-08-03 13:24:51 -05:00
9768d8ca55
Fix bugs in detail back button when transitioning from collapsed mode
2019-08-03 11:44:05 -05:00
a30b03bcea
Remove obsolete code
2019-08-03 11:43:21 -05:00
e4c3590111
Made code formatting more consistent
2019-08-03 11:09:12 -05:00
d5094dd103
Deleted obsolete code
2019-08-03 11:06:55 -05:00
0baf15b588
Fix root split view controller collapsing and splitting when no in all visible mode
2019-08-03 10:55:46 -05:00
e52b3531d9
Add missing shim controller
2019-08-02 18:14:49 -05:00
7acf77f572
Enable collapsing and splitting of root split view controller
2019-08-02 16:46:55 -05:00
8753790a19
Fix bug that lost detail view when transitioning to three panel mode
2019-08-02 10:34:32 -05:00
54f6607621
Keep table selections when root split isn't collapsed
2019-08-02 10:25:47 -05:00
52055d83f5
Made the detail panel slightly larger than the others in three panel mode
2019-08-02 09:12:15 -05:00
d7afc30ed3
Remove dead code
2019-08-02 04:42:48 -05:00
e0832260b8
Fix timeline selected transition to three panel mode
2019-08-02 04:29:42 -05:00
4f49a4bcf6
Fix code formatting
2019-08-02 04:23:41 -05:00
7da1aacf28
Fix transition to three panel mode
2019-08-02 04:22:47 -05:00
7b7fb7ef2a
Adjust font to silence dynamic type warning
2019-08-01 20:24:54 -05:00
9e0a4aed00
Correctly handle showing the detail view when the root view controller is collapsed
2019-08-01 20:06:55 -05:00
e22088b284
Implemented Shim Controller so that we can change out the secondary split view controller when the display mode changes
2019-08-01 19:59:56 -05:00
d16386d205
Add transitioning for three panel mode
2019-08-01 16:14:34 -05:00
2ab3ff76fb
Make settings button work second split controller is installed
2019-08-01 07:10:02 -05:00
88c6f2274b
Refactor how the No Selection message is displayed
2019-08-01 06:53:34 -05:00
ccd0385220
Prevent flicker when selected feed's unread count changes.
2019-07-30 13:08:58 -05:00
978aeeee80
Restore selection when currently select feed unread count changes
2019-07-27 15:05:21 -05:00
adb6309872
In Three Pane Mode only show the progress indicator on the Feeds controller
2019-07-27 14:49:07 -05:00
cf674d67b1
Show no selection when timeline is selected in Three Panel Mode
2019-07-27 14:36:01 -05:00
e009a31ed7
Rename isThreePane to isThreePanelMode
2019-07-27 14:25:10 -05:00
59537c5705
Automatically hide the overlay and only add the navigation controller to detail views when not collapsed
2019-07-26 16:26:22 -05:00
306af515ea
Remove duplicate split view controller initialization on launch
2019-07-26 09:58:46 -05:00
d2a09a92ae
Fix timeline selection in three pane mode
2019-07-19 17:27:56 -05:00
1ddf4189d3
Initial support for three pane mode
2019-07-19 15:59:46 -05:00
871ccbd728
Fix variable name
2019-07-19 14:47:25 -05:00
a47e4cab77
Show No Selection system message when selection is cleared by returning to the Feeds list
2019-07-19 12:29:17 -05:00
11d74372b1
Change how the AppCoordinator is initialized
2019-07-19 11:59:08 -05:00
dd8c70f558
Hook up initial detail view controller back button
2019-07-18 18:51:40 -05:00
b5411cde42
Fix detail navigation controller code
2019-07-18 18:49:27 -05:00
d01f356869
Add System Message view controller
2019-07-18 18:20:15 -05:00
c034aac385
Added system message view controller
2019-07-18 18:19:32 -05:00
b25e789aef
Prevent refresh errors from keeping the refreshControl visible when error dialogs are displayed.
2019-07-18 15:16:54 -05:00
5773e5b39c
Updated to use new fetchArticles API
2019-07-12 13:01:34 -05:00
8e278ea843
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-07-12 12:31:36 -05:00
304250e127
Use updated iOS app icon assets from Brad.
2019-07-10 22:53:45 -07:00
8b6e2fa517
Move more logic out of MasterTimelineViewController and into AppCoordinator
2019-07-06 12:31:07 -05:00
6e59c56515
Move more logic out of MasterFeedViewController and into AppCoordinator
2019-07-06 12:25:45 -05:00
d543b979ac
Move more logic out of the DetailViewController and into the AppCoordinator
2019-07-06 11:49:53 -05:00
4884aebbfd
Encapsulate more of the AppCoordinate API
2019-07-06 11:32:19 -05:00
6f669c2aba
Add new app icon resources.
2019-07-05 23:09:54 -07:00
15754684a4
Move more navigation responsibilities into the AppCoordinator
2019-07-05 17:45:39 -05:00
19f8f8bc97
Fix missing settings button on iPhone
2019-06-29 13:53:34 -05:00
fcf2937394
Rename NavStateController to AppCoordinator because we are redesigning it to be the Coordinator pattern
2019-06-29 13:35:12 -05:00
3fc3903758
Change to use helper property
2019-06-28 13:05:19 -05:00
178e89b1fb
Add basic multi window support to iOS
2019-06-28 10:28:02 -05:00
55ab50289c
Temporally comment out tint code because it is crashing on iPadOS 13 beta 2
2019-06-27 17:56:33 -05:00
188bacee25
Move nav state ownership to MasterFeedViewController
2019-06-27 16:30:24 -05:00
5f045706e4
Removed usaged of UIApplication.present
2019-06-27 14:21:07 -05:00
95d4395416
Fix feed / folder rename for iOS
2019-06-26 06:23:08 -05:00
19df44058b
Fix white flashing in WKWebView on iOS
2019-06-26 06:06:10 -05:00
975d17e32d
Correct colors for dark mode
2019-06-25 18:16:04 -05:00
0ac9abdd52
Navigate back to feeds after marking all as read
2019-06-25 17:39:07 -05:00
aff14b19ee
Force unread indicator to be redisplayed to get rid of missing unread indicators
2019-06-25 15:43:30 -05:00
b877e4dc83
Move NavState ownership to the AppDelegate
2019-06-25 12:10:07 -05:00
e8e0f3b8bd
Temporarily disabled SwiftUI compiling
2019-06-23 17:41:41 -05:00
d6ea5bd636
Deletes assets not required
2019-06-21 22:40:17 +08:00
5e5c0e0e3d
Rolls back low power changes.
2019-06-21 22:16:02 +08:00
183490d3b0
SF Symbols
...
SF Symbols
• Updates more of AppAssets to use SF Symbols and tints using `withTintColor` rather than `maskWithColor` to stop the aliasing appearing.
• Updates Storyboard to use SF Symbols where appropriate.
2019-06-21 15:29:20 +08:00
7d226c46a4
Merge remote-tracking branch 'upstream/master'
...
# Conflicts:
# iOS/AppAssets.swift
2019-06-21 15:27:44 +08:00
11961605d5
SF Symbols
...
• Updates more of AppAssets to use SF Symbols and tints using `withTintColor` rather than `maskWithColor` to stop the aliasing appearing.
• Updates Storyboard to use SF Symbols where appropriate.
2019-06-21 14:24:52 +08:00
fbf2da0ab5
Set bgtask to complete
2019-06-21 12:58:36 +08:00
d9a4d42ca0
Low Power: Stops background feed refresh
2019-06-21 10:54:53 +08:00
2ee72125ba
Support dark mode for small avatars on iOS
2019-06-20 11:58:26 -05:00
Maurice Parker
Thomas Pritchard
Jim Correia
Jim Correia
Brent Simmons
Stuart Breckenridge