Commit Graph

519 Commits

Author SHA1 Message Date
Maurice Parker 4393e54a5c Fix unread indicator color 2020-07-03 19:41:38 -05:00
Nate Weaver 014724e6a7 Don't force iframe height to auto
Prevents truncating of YouTube embeds without needing a wrapper div.

(master version of 82f8951c96).

This also sets max-width: 100%; on video instead of width: 100% !important;.
2020-07-02 04:45:08 -05:00
Nate Weaver dc57981376 Only wrap iframes that don't specify their own height
(master version of e183a5406c)
2020-07-02 04:32:58 -05:00
Stuart Breckenridge c2149579c9 Converts AppDefaults to singleton 2020-07-02 09:58:25 +08:00
Maurice Parker 67c0e00957 Make multiplatform compile shared app resources 2020-06-28 03:05:01 -05:00
Rizwan Mohamed Ibrahim f2cd09aae3
refactor open in app browser with global shortcuts 2020-05-29 20:39:04 +05:30
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Rizwan Mohamed Ibrahim eb7ac0f076
fix open in app browser for mac and iOS 2020-05-29 15:44:32 +05:30
Maurice Parker 2ad01885c1 Increase link brightness for darkmode to make links more easy to read 2020-05-27 10:37:50 -05:00
Martin Nash 425b48a4e5 Updated keyboard shortcut title to match title of other shortcuts performing the same action. 2020-05-26 22:12:05 -07:00
Martin Nash d38c58942c Fix issue where pressing the [return] key with an article highlighted would not open that article in the browser. KeyboardShortcut was calling a selector that didn't exist in the macOS app. 2020-05-26 22:11:33 -07:00
Martin Nash 3e48be050e Updated function name to openInBrowserUsingOppositeOfSettings 2020-05-21 22:28:30 -07:00
Martin Nash 834be9edff 2099 | Keyboard shortcut to open in browser in background/foreground contrary to user preference.
- Add openInBrowserAlternate() function
- Add shit-modified entries to to GlobalKeyboardShortcuts.plist to trigger new function
2020-05-20 22:15:00 -07:00
Nate Weaver 6723599ea0 Strip inline max-width and max-height from elements 2020-05-20 16:36:30 -05:00
Nate Weaver f5101d44a4 Strip inline max-width and max-height from elements 2020-05-20 16:15:04 -05:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker fd6736a897
Merge pull request #2077 from stuartbreckenridge/notifications
Notifications
2020-05-15 07:41:01 -05:00
Stuart Breckenridge fa51fa47b4
reorged the send notification code 2020-05-15 20:32:33 +08:00
Stuart Breckenridge 23ee6761ca
adds grouping and summaries to notifications 2020-05-15 19:53:44 +08:00
Maurice Parker 225c98a70e
Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75
adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb
adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 06e91aa8b7 Add the Add Reddit Feed dialog 2020-05-10 11:44:30 -05:00
Maurice Parker faab33ab2e Save and toggle full screen state. Issue #2053 2020-05-09 14:14:46 -05:00
Maurice Parker 80e9cdba5e Change H1 padding to take a little off the bottom 2020-05-09 11:35:10 -05:00
Maurice Parker 55cb4d5af8 Back out demo css change 2020-05-09 10:24:37 -05:00
Maurice Parker c16dbc125d Add support for pseudo subreddits 2020-05-09 10:23:37 -05:00
Maurice Parker 78cefecaad Make sure we are only going after a given URL once 2020-05-04 17:48:53 -05:00
Stuart Breckenridge f58ac4d160
Wraps Alert strings in `NSLocalizedString`
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
Maurice Parker 0344992cf4 Fix extension point id serialization bugs 2020-05-03 14:15:57 -05:00
Maurice Parker ccd600b880 Make authorize endpoint async 2020-05-03 13:23:36 -05:00
Stuart Breckenridge e825a5d516
Adds handling of `tel` url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge f901436211
mailto links now open on iOS
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
Maurice Parker e681fd6402 Stub out Reddit Feed Provider / Extension Point 2020-05-02 19:38:57 -05:00
Maurice Parker 41a17dfb06 Restrict build button on iOS so that it only appears if Twitter is enabled 2020-05-02 17:21:01 -05:00
Nate Weaver 688b24f18e Swap baseDescriptor and currentDescriptor to allow semibold to come through 2020-05-01 01:56:19 -05:00
Nate Weaver 37f1ebc025 Remove the color parameter as it's no longer needed 2020-05-01 01:45:12 -05:00
Nate Weaver cc0bfd95b2 Add a comment 2020-05-01 01:42:44 -05:00
Nate Weaver ae40172b7c Make superscript/subscript work again 2020-05-01 01:42:44 -05:00
Nate Weaver 5d8604714c Revert setting bold to heavy if the base font is semibold
- It was causing conflicts with nested bold + other styles.
- We don't want bold in titles anyway.
2020-05-01 01:42:44 -05:00
Nate Weaver 406a8e0cc0 Set weight for bold fonts 2020-05-01 01:42:44 -05:00
Nate Weaver d47767d8b4 Remove tagStack 2020-05-01 01:42:44 -05:00
Nate Weaver 951ffeb899 Move declaration/initialization of attributes dictionary closer to use 2020-05-01 01:42:44 -05:00
Nate Weaver cce4b56ee5 Fix building for iOS 2020-05-01 01:42:44 -05:00
Nate Weaver f38406e3ac Make the return type of CountedSet's subscript non-optional 2020-05-01 01:42:44 -05:00
Nate Weaver 62737bd94f Add <var> and <dfn> to italicized tags 2020-05-01 01:42:44 -05:00
Nate Weaver 7297bf837d Re-add use of custom initializer 2020-05-01 01:42:43 -05:00
Nate Weaver c555646fb2 Add attributed title support in the timeline 2020-05-01 01:42:43 -05:00
Nate Weaver ec49030081 Consolidate some repeated code 2020-05-01 01:42:43 -05:00
Nate Weaver 2672dbb8f1 Remove old comment 2020-05-01 01:42:43 -05:00
Nate Weaver 8006d816a9 Style(tag:) -> Style(forTag:) 2020-05-01 01:42:43 -05:00
Nate Weaver fcbfce4ace Move duplicated code outside of the if 2020-05-01 01:42:43 -05:00
Nate Weaver b7916f7d31 Convert to an if-let since currentStyles are being stored instead of a single style 2020-05-01 01:42:43 -05:00
Nate Weaver 7f3b77b760 Quote nested <q> tags with alternating quote marks 2020-05-01 01:42:43 -05:00
Nate Weaver e6cbdb5d23 Remove font parameter 2020-05-01 01:42:43 -05:00
Nate Weaver ee4830022e Mark some stuff private 2020-05-01 01:42:43 -05:00
Nate Weaver d06e7447f0 Call out to RSParser for entity decoding 2020-05-01 01:42:43 -05:00
Nate Weaver e8d39ded0d tagBuf -> tag 2020-05-01 01:42:43 -05:00
Nate Weaver bdd5796a10 Use a custom CountedSet for styles so nested tags work 2020-05-01 01:42:43 -05:00
Nate Weaver b722e75d9e Use a nested function for superscript/subscript features 2020-05-01 01:42:43 -05:00
Nate Weaver fd672c5ce6 Add a custom HTML -> NSAttributedString initializer 2020-05-01 01:42:43 -05:00
Maurice Parker 86fb98c17b
Revert "WIP: Title tags" 2020-04-24 20:24:24 -05:00
Nate Weaver b437ddab5c Move NSAttributedString+NetNewsWire into Shared/Extensions 2020-04-24 18:25:56 -05:00
Nate Weaver d84ed6068f Add a convenience initializer for attributed strings from an html string 2020-04-24 16:20:41 -05:00
Nate Weaver 06b3d2f8e1 Declare UTF-8 to avoid mojibake 2020-04-24 16:20:40 -05:00
Nate Weaver 3d509a94d4 Add attributed title support in the timeline 2020-04-24 16:20:40 -05:00
Maurice Parker ee92cf69d2 Merge branch 'extension-point' 2020-04-24 13:34:13 -05:00
Maurice Parker d1ca2cac79 Remove username from WebFeed and put it in the URL 2020-04-24 13:33:43 -05:00
Nate Weaver 37ae46ea4c Merge more styles and fix styling of tables with explicit thead/tbody/tfoot
Also use :matches() to simplify some rules.

# Conflicts:
#	Mac/MainWindow/Detail/styleSheet.css
#	iOS/Resources/styleSheet.css
2020-04-23 23:21:22 -05:00
Maurice Parker 530f06dfca Merge branch 'master' into extension-point 2020-04-23 16:40:41 -05:00
Maurice Parker ac45ba57a9 Merge branch 'ios-release' 2020-04-23 15:32:55 -05:00
Brent Simmons bc2d325022 Remove an error log that’s just noise. 2020-04-22 20:41:13 -07:00
Maurice Parker 0ac5a6dbca Disable Twitter Extension Point for Developer Build. 2020-04-22 14:16:50 -05:00
Maurice Parker d0d29fd7da Merge branch 'master' into extension-point 2020-04-19 19:01:11 -05:00
Nate Weaver 2a6d9994ea Move shared CSS into its own file 2020-04-19 18:38:33 -05:00
Nate Weaver 183d703fd3 Use classList instead of string manipulation 2020-04-17 07:09:49 -05:00
Maurice Parker 660cf29305 Add username storage on WebFeed 2020-04-16 18:19:49 -05:00
Maurice Parker 9b39165018 Merge branch 'master' into extension-point 2020-04-16 16:37:18 -05:00
Maurice Parker afdfe5fe71 Merge branch 'ios-release' 2020-04-16 16:36:53 -05:00
Maurice Parker d4b5d7bde4 Add FeedProviderManager 2020-04-16 15:06:56 -05:00
Maurice Parker 96dd4bb731 Merge branch 'master' into extension-point 2020-04-16 13:37:38 -05:00
Maurice Parker 5afda76134 Merge branch 'accent-color-experimental' 2020-04-16 13:35:12 -05:00
Maurice Parker eb02568409 Made Feed Providers part of the Account project 2020-04-16 11:15:39 -05:00
Maurice Parker d168658e05 Add Extension Point maintenance to the iOS app. 2020-04-16 08:25:40 -05:00
Maurice Parker f8a664d035 Cache the feed provider results to make it as fast as the other icon look up types. 2020-04-16 02:17:38 -05:00
Maurice Parker c44759fdb2 Add web feed icon downloader support for Feed Providers. 2020-04-15 20:17:33 -05:00
Maurice Parker c414d22666 Merge branch 'master' into extension-point 2020-04-15 19:02:20 -05:00
Nate Weaver 8bb249b1ad Fix typo 2020-04-15 16:39:58 -05:00
Maurice Parker 266e136787 Design and stub out FeedProvider protocol 2020-04-15 16:35:09 -05:00
Maurice Parker d883981afd Move oauth1 provider implementation fo main TwitterFeedProvider class. 2020-04-15 14:14:33 -05:00
Maurice Parker 42853fe487 Renamed source file to match usual conversions for extensions. 2020-04-15 14:12:31 -05:00
Maurice Parker e15462fd61 Persist twitter tokens in the keychain. 2020-04-14 23:19:06 -05:00
Maurice Parker 9e0248c494 Correctly save Twitter ExtensionPoints 2020-04-14 23:03:08 -05:00
Maurice Parker df79da291f Change how ExtensionPoint titles are handled. 2020-04-14 22:33:05 -05:00
Maurice Parker e206909237 Refactor ExtensionPoints to make them easier to create in the future. 2020-04-14 16:47:05 -05:00
Maurice Parker 266c28d9be Add new OAuth1 credential requirements for Twitter 2020-04-14 10:15:24 -05:00
Maurice Parker a168c2ce80 Merge branch 'master' into accent-color-experimental 2020-04-13 07:20:57 -05:00
Brent Simmons 6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker a131c01e77 Merge branch 'master' into extension-point 2020-04-11 18:14:30 -05:00
Maurice Parker e6c5d2f199 Merge branch 'ios-release' 2020-04-11 15:59:37 -05:00
Maurice Parker 3ba9ca8c8a Added new Secrets framework project 2020-04-09 21:07:56 -05:00
Brent Simmons f54f65781c Update some slightly-changed feed URLs in the defaults. Replace Omni’s blog with Craig Hockenberry’s. 2020-04-08 21:25:23 -07:00
Maurice Parker d49eabbcb3 Add extension management for our two SendToCommand implementations 2020-04-08 20:22:13 -05:00
Maurice Parker 61b755486a Flesh out the ExtensionPointManager a little 2020-04-08 13:46:15 -05:00
Maurice Parker 14189b19e9 Change extension point so that multiple of the same type can exist. 2020-04-08 10:12:06 -05:00
Maurice Parker 49cff8eb8e Add basic ExtensionPoint support. 2020-04-07 15:25:33 -05:00
Maurice Parker 3459f23461 Merge branch 'master' into accent-color-experimental 2020-04-06 09:20:44 -05:00
Maurice Parker f68d523a15 Merge branch 'ios-release' 2020-03-30 11:50:58 -05:00
Maurice Parker d0852d8954 Fix scenario where incorrect platform specific icon image could be returned. 2020-03-30 10:56:52 -05:00
Maurice Parker 2afdd26c9d Change function names using the find suffix to use the existing suffix to match precedent. 2020-03-29 12:00:02 -05:00
Maurice Parker e23cc4d8a6 Merge branch 'master' into accent-color-experimental 2020-03-28 00:56:53 -05:00
Maurice Parker 6d085fdacf Inline videos and enable player controls for both Mac and iOS. Issue #1952 2020-03-28 00:56:29 -05:00
Maurice Parker c6bd60eb1e Merge branch 'master' into accent-color-experimental 2020-03-24 12:24:59 -05:00
Maurice Parker d0680bcc73 Merge branch 'ios-release' 2020-03-24 12:21:32 -05:00
Maurice Parker a6e75df412 Send out an event if we found a cached favicon downloader for new homepage URL. Issue #1940 2020-03-24 12:21:08 -05:00
Maurice Parker 6a384d99e6 Darken and lighten the accent color for the article view. 2020-03-20 08:13:39 -05:00
Maurice Parker 1e1fce59da Use system accent color to tint the article view 2020-03-20 06:41:38 -05:00
Brent Simmons 910e14b441 Use a serial queue for RSImage.scaledForIcon, so we don’t end up having a ton of threads and doing too much at once, which hurts performance. Fix #1489. 2020-03-19 22:22:58 -07:00
Maurice Parker 4d18c34759 Update to the latest RSCore 2020-03-18 16:08:17 -05:00
Maurice Parker 770206df60 Merge branch 'ios-release' 2020-03-17 17:19:31 -05:00
Maurice Parker 36841602a5 Change article rendering to use loadHTMLString instead of JavaScript. Issue #1923 2020-03-17 17:18:24 -05:00
Maurice Parker 5b5eaf6bb7 Merge branch 'ios-release' 2020-03-14 17:13:25 -05:00
Maurice Parker dd3fde7812 Changed from using the main screen scale which might change to using the max screen scale. Issue #396 2020-03-14 15:40:40 -05:00
Maurice Parker 73e7fb40ed Fixed macOS compile error for new brightness code detection. 2020-03-13 10:51:49 -05:00
Maurice Parker e0f8f7c5eb Increase brightness threshold to reduce false positives. Issue #1731 2020-03-13 10:45:02 -05:00
Maurice Parker d0cf04bd4f
Merge pull request #1892 from flowinho/ios-release
Add background to pure white icons
2020-03-13 10:04:56 -05:00
Flowinho d282181269 Add isBright function to Shared Logic 2020-03-13 11:43:17 +01:00
Maurice Parker 77fd3020cc Correct font used to specify font size. Issue #1878 2020-03-12 19:01:10 -05:00
Nate Weaver 781dd2ff73 Fix null error in wrapTables() 2020-03-12 18:32:42 -05:00
Nate Weaver 5bbda2a68e "footnotes" -> ".footnotes"; use idFromHash() 2020-03-12 18:32:42 -05:00
Nate Weaver 76dd3abff2 Properly style footnotes that have been absoluted 2020-03-12 18:32:42 -05:00
Nate Weaver 509ef01213 URL-decode the ID to make it work with non-ASCII characters
Fixes #1812.
2020-03-12 18:32:42 -05:00
Maurice Parker 61a2e95d2b Manually specify the font size to work around a WKWebView resizing bug. Issue #1878 2020-03-12 18:07:40 -05:00
Maurice Parker 343f705cd7 Fix article read filter which wasn't persisting correctly. 2020-03-12 12:07:01 -05:00
Maurice Parker de38ba9f5b Added feed selection restoration. 2020-03-04 15:40:40 -07:00
Maurice Parker 5755dd0844 Finish merge of mac-release. 2020-03-01 16:33:05 -08:00
Maurice Parker 94c6ca428f Merge branch 'mac-release' 2020-03-01 16:32:31 -08:00
Maurice Parker 66054ca735 Deleted unused keys. 2020-03-01 15:06:23 -08:00
Maurice Parker 4b2f08e759 Refactor select web feed in sidebar to use the delegate pattern instead of a notification. 2020-02-29 15:50:13 -08:00
Maurice Parker c17ce1ceaa Make articles older than a specified period unable to be marked as unread. Issue #1407 2020-02-29 10:30:35 -08:00
Nate Weaver e183a5406c Only wrap iframes that don't specify their own height 2020-02-28 08:19:40 -06:00
Nate Weaver 65b508ffaa Port inline style stripping changes from master 2020-02-28 08:15:06 -06:00
Maurice Parker 85bd20ca80 Stop media playback when the main window is closed. Issue #1646 2020-02-27 12:15:41 -08:00
Maurice Parker 7c060bb068 Change so that the tree controller can't be rebuilt before all async deletes have completed. Issue #1002 2020-02-26 17:28:52 -08:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Brent Simmons e22489ce40
Merge pull request #1795 from Wevah/ios-candidate
Fix sites being added to the no-favicons cache if the homepage fails to load
2020-02-17 17:59:37 -08:00
Maurice Parker 03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Nate Weaver aad1fc4a0c Call the completion handler with nil if faviconURLs is nil
Fixes #1791.
2020-02-15 08:53:56 -06:00
Nate Weaver b3f736f899 Add a clarification comment 2020-02-15 08:22:59 -06:00
Nate Weaver ee48f4baba Remove redundant nil check for homePageURL 2020-02-15 08:22:51 -06:00