6583688e38
Fix errors in Feedly unread operations tests
...
Most fetch completion blocks took a parameter that was expected to be
some result data type, but is now a Result. Rename these parameters;
wrap their existing bodies in do/catch blocks; and recreate the original
underlying variable using the result of `Result.get()`.
Prepend a few synchronous calls that started throwing with `try` along
the way.
2019-12-31 19:06:10 -06:00
0d915333e6
Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate
2019-12-31 17:06:32 -07:00
f0a5309786
Fix bug that prevented first article from being selected on iPad.
2019-12-31 17:06:13 -07:00
af76e44c0f
Changed ArticleViewController to utilize UIPageViewController to provide gesture based navigation.
2019-12-31 16:55:39 -07:00
6d3cd0cc19
Update to build 24.
2019-12-31 15:40:31 -08:00
520ef3858a
Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate
2019-12-31 15:40:10 -08:00
51faf77e59
Update isExecuting and isFinished in a way that should make NSOperationQueue happy. Hopefully this fixes a mystery crash bug.
2019-12-31 15:40:05 -08:00
0a29535412
Merge pull request #1496 from Wevah/table-overflow-wrapper
...
Table overflow wrapper
2019-12-31 16:24:43 -07:00
ae1651fad1
Fix errors in Feedly update-feeds operation tests
...
Mark some throwing calls with `try`; mark the enclosing test functions
with `throws`, letting the XCTest framework handle error reporting for
us.
2019-12-31 15:55:59 -06:00
f82be27666
Resolve errors in Feedly statuses operation tests
...
Add `error` parameters to completion blocks which now pass them. Assert
these errors are always nil in the existing tests.
Flip calls to `selectPendingCount()` so they are async, with a
completion block that asserts about the results instead of asserting
about the return value. Since the closure takes a Result, unwrap it in a
do/catch block at each site; `XCTAssertNoThrow` doesn't help us bubble a
value out from `Result.get()`, and I'd rather not use `try!` here. There
might be a stylistic discussion to be had about this unwrapping, though.
2019-12-31 15:52:54 -06:00
73b9d03fac
Merge pull request #1497 from Wevah/allow-size-styles-ios
...
Only strip color/font inline styles
2019-12-31 13:50:37 -08:00
fa6c21f470
Remove .wp-smiley rule
2019-12-30 18:30:21 -06:00
fcea33d61f
Only strip out color, background, and font css properties
...
Prevents icon images from rendering super-huge.
2019-12-30 18:30:10 -06:00
792fcddaf6
Update comment
2019-12-30 17:35:47 -06:00
58ef7600fb
Avoid copying the table and use querySelector()
...
(Since there's only one .articleBody.)
2019-12-30 17:24:34 -06:00
7a61a6a5b4
Specify div explicitly
2019-12-30 17:24:34 -06:00
0800c77002
Remove now-unneeded style rule
2019-12-30 17:17:35 -06:00
c2d3e9213d
Strip spans from pre elements inside table cells
...
Works around a clipping issue.
2019-12-30 17:17:35 -06:00
bb0fffcec2
Move wrapTables() to just after wrapFrames()
2019-12-30 17:17:35 -06:00
cbbb46a776
Wrap tables in an overflow-x: auto; div
2019-12-30 17:17:35 -06:00
8a85b18d09
Merge pull request #1495 from kielgillard/ios-candidate
...
Models the feed identifier of feedly articles as an optional…
2019-12-30 14:55:30 -07:00
3b47edfba7
Models the feed identifier of feedly articles as an optional since it seems the Feedly API will not always provide one (despite the API documentation).
...
Additional, more elegantly handle the failure to parse an article when Feedly does not provide a matching feed.
2019-12-31 08:47:27 +11:00
c692d46cc8
Merge pull request #1493 from hartlco/1486-feedslist-contextmenu-mark-all-as-read
...
Include Mark All as Read in Feeds list context menu #1486
2019-12-30 13:37:38 -07:00
5cbfe3b071
Include Mark All as Read in Feeds list context menu
2019-12-30 21:16:50 +01:00
388886a355
Base our active articles window on dateArrived instead of datePublished. This reverses a recent change that led to some bugs.
2019-12-28 22:20:13 -08:00
ac519c5c90
Add new and updated articles to the in-memory cache when saving articles.
2019-12-28 21:19:02 -08:00
26bb2b8eaf
Remove references to Article.bannerImageURL. We can bring it back if/when we start using it.
2019-12-28 20:53:36 -08:00
a1b23edc8b
Delete obsolete code
2019-12-28 16:06:37 -07:00
f37ce4357e
Delete obsolete code
2019-12-28 16:04:24 -07:00
5c4d8aeba7
Verify that the parent node to be expanded is a Folder before trying to expand it.
2019-12-28 10:58:15 -07:00
0fbd376078
Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate
2019-12-28 10:23:43 -07:00
36521a1783
Don't crash if there isn't a folder or feed available.
2019-12-28 10:23:09 -07:00
aeaeac61fc
Get rid of DatabaseArticle entirely. Cache Article objects. This will make fetches faster *and* save memory.
2019-12-27 22:47:02 -08:00
4b361300f4
Fix the OPML export when there is only one exportable account. Issue #1457
2019-12-26 12:35:39 -07:00
1043b42472
Merge branch 'ios-candidate' of https://github.com/brentsimmons/NetNewsWire into ios-candidate
2019-12-26 12:22:10 -07:00
00ed368683
Change the full screen tap zone to be the center of the navigation bar instead of the whole navigation bar. Issue #1450 .
2019-12-26 12:21:56 -07:00
be2b7e6eef
Merge pull request #1465 from Wevah/ios-feed-sizing-fix
...
Make initial scale 100% and don't let WebKit increase text size
2019-12-26 11:24:49 -07:00
758fb1a1c0
Make initial scale 100% and don't let WebKit increase text size
...
Issue #1459 .
2019-12-24 20:15:53 -06:00
84d1ccadfd
Clear the saved middle position when emptying the timeline. Issue #1464
2019-12-24 17:55:56 -07:00
61370dd04d
Fix so that we don't try to scroll before the datasource has been fully applied to the table. Issue #1463
2019-12-24 17:34:47 -07:00
5eac0dc0b4
Merge pull request #1455 from Austinate/bugfix/add_folder_account_name_sync_issue
...
iOS, Add Folder: Make sure Account Name field is in sync with selecte…
2019-12-24 16:02:28 -07:00
f43e7880f7
iOS, Add Folder: Make sure Account Name field is in sync with selected account in picker
2019-12-23 17:20:52 +02:00
df642c128a
Bump version to 23.
2019-12-21 16:22:09 -08:00
a5272e0b49
Bump build to 22.
2019-12-20 21:18:31 -08:00
17ba716bb4
Update to latest RSParser.
2019-12-20 21:16:10 -08:00
8fb92e119a
Auto expand accounts that may have been suspended as collapsed when disclosing a feed. Issue #1440
2019-12-19 09:38:53 -07:00
3a33c38d5c
Use an inner function in FeedbinAccountDelegate.refreshMissingArticles. I like this pattern because 1) it keeps the switch statement and its cases near each other, and 2) it puts all the actual processing in a single function, which makes it easier to see where processing happens.
2019-12-17 21:24:17 -08:00
db564d9cf9
Remove all references to fetchArticleIDsForStatusesWithoutArticles. Use fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate instead.
2019-12-17 21:15:20 -08:00
6d499c8848
Bump version to 21. Lucky 21.
2019-12-17 19:19:32 -08:00
236f581d95
Update Feedbin to use fetchArticleIDsForStatusesWithoutArticlesNewerThanCutoffDate for missing articles.
2019-12-17 17:43:08 -07:00
Tim Ekl
Maurice Parker
Brent Simmons
Nate Weaver
Kiel Gillard
Martin Hartl
austinate