4523a28d67
Call completion if even it if we don't initialize the command. Fixes #3092
2021-05-12 20:10:16 -05:00
7b3921bcb1
Call completion if even it if we don't initialize the command. Fixes #3092
2021-05-12 20:06:46 -05:00
802dd503d6
If we can't find a feed, it must be deleted by another device, so consider it a success. Fixes #3042
2021-05-12 19:54:18 -05:00
5a31a90d0c
If we can't find a feed, it must be deleted by another device, so consider it a success. Fixes #3042
2021-05-12 19:53:34 -05:00
f9f5f09c60
Merge pull request #3112 from heckj/unsafe_os_unfair_lock
...
fixing name of lock
2021-05-10 12:29:23 -07:00
3409275a23
fixing name of lock
2021-05-10 11:55:24 -07:00
a6a641d1c5
Merge pull request #3111 from heckj/unsafe_os_unfair_lock
...
replacing os_unfair_lock with NSLock
2021-05-10 11:22:20 -07:00
8df105aad4
replacing os_unfair_lock with NSLock
...
learned that os_unfair_lock with & was quite unsafe when used within
swift. Apparently in swift, &foo in Swift means "make a copy of foo and
pass it inout to a function, then overwrite its value with whatever
the function did to it when that function returns."
And if you're using it within a struct, it's apparently even more
dangerous. because the address of self can change from call to call
— self might not even have an address, it might be contained in
registers only.
Using NSlock will be a smidge less performant, but notably more safe.
2021-05-10 11:14:04 -07:00
1e5091013d
Change variable name to make it compile with older versions of Xcode.
2021-05-09 19:37:25 -05:00
5490e3ab49
Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate
2021-05-08 12:42:52 -07:00
9d2c8f000f
Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance.
2021-05-08 12:42:44 -07:00
9b53fcbe37
Fix regression that prevented the timeline and article from being cleared when the current feed is deleted. Fixes #3054
2021-05-06 20:07:49 -05:00
d631d4d382
Initialize the author as nil if it is unparsable. Fixes #3034
2021-05-06 13:53:33 -05:00
92287d9bd5
Initialize the author as nil if it is unparsable. Fixes #3034
2021-05-06 13:52:50 -05:00
056b17703a
Move deep signing flag to xcconfig files
2021-05-06 06:38:51 -05:00
2f32a4b928
Move deep signing flag to xcconfig files
2021-05-06 06:36:11 -05:00
a03430a790
Retain existing feeds for folders that haven't been created yet. Fixes #3047
2021-05-05 21:25:06 -05:00
83332d1358
Retain existing feeds for folders that haven't been created yet. Fixes #3047
2021-05-05 21:24:27 -05:00
7e820c58e5
Reload the webview when rotating the device on an iPhone. Fixes #3041
2021-05-04 21:44:55 -05:00
8707a71313
Add Copy Article URL & Copy External URL Menu Items
...
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
28b00260e0
Cache IconImage for feeds on the Feeds screen.
...
Empty the cache, and reload visible cells, when the trait collection changes, so that we get the proper icons for light/dark mode. This caching provides a small-but-worthwhile performance increase for the Feeds screen.
2021-05-01 12:29:18 -07:00
fa0744ed2c
Merge pull request #3100 from greenbuffo/fix/2916
...
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
2021-05-01 11:16:50 -07:00
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
...
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
...
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
f73facdef7
Merge pull request #3099 from babbage/bugfix/3037-unread-onload
...
Mark as read just before display. Fixes #3037
2021-04-29 10:18:53 -07:00
ec3916f37b
Merge pull request #3097 from babbage/bugfix/3084-footnotes-pt2-mac
...
Capture fully resolved footnote backlinks. Extends #3084 for macOS
2021-04-29 10:18:10 -07:00
ec1b0f8bcd
Merge pull request #3095 from babbage/bugfix/3084-footnotes-pt2-ios
...
Capture fully resolved footnote backlinks. Extends #3084
2021-04-29 10:17:53 -07:00
bc056e4952
Mark as read just before display. Fixes #3037
...
Marking an article as read just before navigating to it prevents the read status from flashing unread/read on display when swiping to new unread articles, or navigating with the next article toolbar button.
2021-04-29 22:46:52 +12:00
00f1bdce97
Capture fully resolved footnote backlinks. Extends #3084
2021-04-29 20:04:59 +12:00
16a3a20156
Capture fully resolved footnote backlinks. Extends #3084
2021-04-29 19:57:08 +12:00
eddc763c52
Merge pull request #3089 from babbage/bugfix/3043-footnotes
...
Handle footnote backlinks that lack css classes and ids. Fixes #3084 for iOS
2021-04-28 21:56:56 -07:00
c89a7c3db7
Merge pull request #3091 from babbage/bugfix/3043-footnotes-mac
...
Handle footnote backlinks that lack css classes and ids. Fixes #3084 for macOS
2021-04-28 21:56:36 -07:00
790218501b
Merge pull request #3079 from babbage/bugfix/3069
...
Handle links with unencoded spaces. Fixes #3069
2021-04-28 21:55:46 -07:00
73bbb67d64
Handle footnote backlinks w/o css classes. Fixes #3084
2021-04-29 10:23:58 +12:00
e5a21cfee6
Handle footnote backlinks w/o css classes. Fixes #3084
2021-04-29 10:17:02 +12:00
9092d075a0
Handle links with unencoded spaces. Fixes #3069
2021-04-28 22:49:32 +12:00
6b77602694
Merge pull request #3087 from babbage/bugfix/macos-build
...
Add required closure to macOS AppDelegate
2021-04-27 18:02:36 -07:00
3d49fd8e76
Merge pull request #3086 from babbage/feature/mac-PersistentSmartFeeds
...
Always show Smart Feeds on macOS. Fixes #3052 on macOS
2021-04-27 18:02:00 -07:00
45d62ec20d
Merge pull request #3085 from babbage/feature/ios-PersistentSmartFeeds
...
Always show smart feeds on iOS. Fixes #3052 on iOS
2021-04-27 18:01:21 -07:00
8e34187821
Merge pull request #3083 from babbage/docs/spm
...
Minor technotes updates
2021-04-27 18:00:15 -07:00
336f3e7a17
Technotes: Swift Packages, AppDefaults not DB5
...
Revise additonal reference to Git submodules.
2021-04-27 16:50:05 +12:00
2ea86c1e14
Incorporate closure from mac-release
...
Enables ios-candidate branch to build macOS target.
2021-04-27 13:07:09 +12:00
a4d9f018f6
Always show Smart Feeds. Fixes #3052
...
Display Smart Feeds always, even when read articles are being hidden and all articles from a feed have been marked as read, and even when there are no items in a Smart Feed.
2021-04-27 12:28:06 +12:00
c84fe751e6
Always show Smart Feeds. Fixes #3052
...
Display Smart Feeds always, even when read articles are being hidden and all articles from a feed have been marked as read, and even when there are no items in a Smart Feed.
2021-04-27 12:27:42 +12:00
2fd7d8549e
Merge pull request #3078 from babbage/patch-1
...
Update Coding Guidelines
2021-04-25 20:04:00 -07:00
e0d5dd69a2
Update Coding Guidelines
...
Minor edit, as discussed in NNW Slack.
2021-04-26 14:36:07 +12:00
2e81c050dc
Merge pull request #3073 from babbage/feature/VoiceOverRead
...
Improve accessibility action labels for MasterTimelineCell in iOS
2021-04-25 19:00:25 -07:00
7e71814011
Rename accessibility action labels as per #3072
2021-04-26 08:19:31 +12:00
7f939f266b
Merge pull request #3075 from stuartbreckenridge/ios-fix-3055
...
Adds API URL example for FreshRSS on iOS
2021-04-25 12:25:32 -07:00
2779ac4d69
Merge pull request #3074 from stuartbreckenridge/mac-fix-3055
...
Adds API URL example for FreshRSS on macOS
2021-04-25 12:25:14 -07:00
Maurice Parker
Brent Simmons
Joe Heck
Rob Mathers
Chris Campbell
Duncan Babbage
Duncan Babbage