FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-11 17:06:46 +01:00
Code Issues Packages Projects Releases Wiki Activity
7,775 Commits 12 Branches 0 Tags 59 MiB
1e485f3e8d
Commit Graph

1167 Commits

Author SHA1 Message Date
Brent Simmons
26bb2b8eaf Remove references to Article.bannerImageURL. We can bring it back if/when we start using it. 2019-12-28 20:53:36 -08:00
Brent Simmons
15184aa3f1 Finish changes mandated by DatabaseQueue changes. 2019-12-16 22:45:59 -08:00
Maurice Parker
58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Maurice Parker
43bf65b7a6 Rename occurrences of completionHandler to completion. 2019-12-14 17:14:55 -07:00
Maurice Parker
e303d64c1d Refresh feeds and sidebar when downloaded articles update all their unread counts. Issue #1430 2019-12-10 18:17:54 -07:00
Ryan Dotson
1414754762
Removed double spaces after punctuation in user-facing strings 2019-12-08 11:10:32 +09:00
Ryan Dotson
ac9a9ff754
Updated some strings in iOS 2019-12-07 14:29:08 +09:00
Nate Weaver
c66ed35799 Add WordPress specific emoji style 2019-12-06 00:31:37 -06:00
Brent Simmons
ebd7c68396 Merge mac-release — remove attachments. 2019-12-04 22:36:08 -08:00
Brent Simmons
3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00
Nate Weaver
229f1604f0 Enable ShowDebugMenu on master 2019-11-28 14:59:45 -06:00
Jonathan Bennett
ce51e4e632 Merge branch 'master' into feature/feed-wrangler 2019-11-24 20:41:43 -05:00
Maurice Parker
e05fdc99dd Change to use show/hide verbiage in menu items instead of check marks 2019-11-24 04:29:15 -06:00
Maurice Parker
21648a498f Make selection restore when toggling read feeds. 2019-11-22 11:57:06 -06:00
Maurice Parker
5ac14fb910 Add read filter toggle for articles. Issue #130. 2019-11-22 11:47:03 -06:00
Maurice Parker
7667dbf60e Add hide read feeds menu option 2019-11-22 10:55:54 -06:00
Maurice Parker
387b867d71 Shim Mac interface to FeedRequestOperation until article filtering is enabled on the Mac. 2019-11-22 09:43:42 -06:00
Maurice Parker
6d8fca01ea Filter async requests based on ReadFilter. 2019-11-21 19:54:35 -06:00
Maurice Parker
68ff7378e7 Added FeedWrangler image assets 2019-11-21 11:28:08 -06:00
Maurice Parker
56d43f8f2d Do a full reload of the article when rearranging the UI to accommodate for split screen color changes. 2019-11-20 18:16:54 -06:00
Jonathan Bennett
b4a862d207 Merge branch 'master' into feature/feed-wrangler 
# Conflicts:
#	Frameworks/Account/Account.swift
#	Frameworks/Account/Account.xcodeproj/project.pbxproj
#	NetNewsWire.xcodeproj/project.pbxproj
#	submodules/RSCore
 2019-11-20 14:01:04 -05:00
Jonathan Bennett
e4cce9f7f2 setup credentials update button for mac 2019-11-20 10:21:24 -05:00
Maurice Parker
188c1f8d8e Reload article image on image load notifications. 2019-11-18 19:44:31 -06:00
Maurice Parker
991ef26a1f Change to remember last selected Folder when adding a Feed. Issue #1306 2019-11-16 19:57:05 -06:00
Maurice Parker
91a3e4fd73 Change Add Web Feed folder selection to be a separate controlling instead of the picker wheel. Issue #1270 2019-11-16 12:02:58 -06:00
Maurice Parker
d3e5985258 Update AppleScript to differentiate between WebFeeds and Feeds 2019-11-15 15:46:43 -06:00
Maurice Parker
5283d2efbe Implement Feed protocol. 2019-11-15 06:19:14 -06:00
Maurice Parker
afd9783711 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-11-14 20:11:50 -06:00
Maurice Parker
06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Kiel Gillard
bec80922ce Enables accounts and their delegates to prepare to be deleted. Provides a variation of the Account Inspector on iOS for Feedly. 2019-11-15 09:47:39 +11:00
Maurice Parker
15e62a0750 Update Mac app to work with latest ActivityManager. 2019-11-14 15:35:19 -06:00
Maurice Parker
ec2b23c9f0 Change Feed Inspector to use same IconView class as other places in code displaying feed icons. 2019-11-12 15:52:07 -06:00
Maurice Parker
c366a55cb5 Change to use Favicon generator. 2019-11-12 15:36:03 -06:00
Maurice Parker
0d2583948a Add additional assets for Article Extractor Button for when the app is inactive. 2019-11-12 13:05:52 -06:00
Maurice Parker
701070f2dd Make Article icons/avatars match Timeline icons/avatars. Issue #1273 2019-11-12 09:22:23 -06:00
Kiel Gillard
a4bcbf5c36 Automatically refreshes a new Feedly account after its creation. 2019-11-11 08:10:39 +11:00
Kiel Gillard
8c27187ad8 Make the OAuthAuthorizationClient an implementation detail the Account.framework. 2019-11-09 21:44:13 +11:00
Kiel Gillard
b8f7e3f519 Use ASWebAuthenticationSession to authenticate Feedly users and grant NNW access tokens. 2019-11-09 21:44:13 +11:00
Maurice Parker
62d7fe34f1 Unify the cache deletion code between iOS and Mac now that the Mac uses the caches directory. 2019-11-08 12:20:21 -06:00
Kiel Gillard
6bef313937 Feedly accounts now refresh their access tokens on initialisation. 2019-11-07 18:55:05 +11:00
Maurice Parker
560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Brent Simmons
14fbf612c1 Set up 5.1d1 testing things: new appcast URL, build # 3000. 2019-10-26 20:58:40 -07:00
Brent Simmons
4cb602f24a Merge mac-release. 2019-10-26 12:44:33 -07:00
Brent Simmons
759f89ec84
Merge pull request #1170 from Wevah/row-swipe-icons 
Use glyphs from SF Symbols for table row swipe actions
 2019-10-26 12:25:22 -07:00
Brent Simmons
f8c9f94ced
Merge pull request #1183 from danielpunkass/caches-directory 
Use the NSCachesDirectory default location, which for sandboxed build…
 2019-10-26 12:23:58 -07:00
Daniel Jalkut
030d86c1b7 Use the NSCachesDirectory default location, which for sandboxed builds will end up inside our sandbox container. 2019-10-26 14:42:11 -04:00
Daniel Jalkut
2903e4507b Remove references to WebKit preferences that are not pertinent in 10.15. 2019-10-26 14:23:44 -04:00
Daniel Jalkut
1fd55ab846 Remove an unused outlet for enableWebInspectorMenuItem 2019-10-26 14:21:00 -04:00
Brent Simmons
f8376b807a Restore two-step process for OPML exporting. 2019-10-24 21:12:58 -07:00
Brent Simmons
1c06eb27e8 Create separate private extension. Make misc. code formatting changes to match current thinking. 2019-10-23 22:33:21 -07:00
Brent Simmons
6f29497ec8 Move NSTextFieldDelegate conformance to separate extension. 
Handle the optional nil case in controlTextDidChange.
 2019-10-23 22:27:08 -07:00
Brent Simmons
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix 
Disable "Add Folder" button when the text field is empty
 2019-10-23 22:22:12 -07:00
Brent Simmons
06b0e35739 Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot. 
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.

Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.

Remove an internal access qualifier, since internal is default and implied.
 2019-10-23 22:00:14 -07:00
Jonathan Bennett
77fc1bd8fe Merge branch 'master' into feature/feed-wrangler 
# Conflicts:
#	submodules/RSCore
 2019-10-23 21:10:57 -04:00
Nate Weaver
4b1a19360c Use glyphs from SF Symbols for table row swipe actions 
(Thin font weight.)
 2019-10-23 15:05:12 -05:00
Maurice Parker
8c8ab39b0c Change the local account icon 2019-10-23 14:21:55 -05:00
Daniel Jalkut
8e37881ed8 Protect against unrecognized protocol errors when building for MAC_APP_STORE or TEST. 2019-10-22 19:44:06 -04:00
Daniel Jalkut
471c8ce667 Switch to SPUUpdater and establish our own single instance of this updater in the app delegate. If we're building for App Store or a TEST build, don't even initialize Sparkle. 2019-10-22 19:33:00 -04:00
Maurice Parker
e80a5f92bb Readd the SUUpdater code 2019-10-22 16:42:17 -05:00
Maurice Parker
d4816506f2 Disable sparkle for test builds 2019-10-22 16:13:08 -05:00
Nate Weaver
37e77a9596 Make delegate-less init() fail since a delegate is currently required 2019-10-22 12:14:38 -05:00
Nate Weaver
e7278017d9 Forgo notifications entirely, and use a delegate instead 2019-10-22 12:14:38 -05:00
Nate Weaver
a762052264 Don't use block-based notification observing 2019-10-22 12:14:38 -05:00
Nate Weaver
7e98869080 Use an accessory view instead of an intermediate sheet for OPML export 2019-10-22 12:14:38 -05:00
Ryan Dotson
48fb3ebc18 Curled some quotes 2019-10-22 19:58:05 +09:00
Daniel Jalkut
b8e1fb1ab4 Omit the Advanced preferences tab from MAS build. 2019-10-21 18:47:06 -04:00
Daniel Jalkut
d5c6ea253e Fix the sandbox migration script to properly reference NetNewsWire. 2019-10-21 11:16:01 -04:00
Daniel Jalkut
272af29031 First step towards supporting MAS and sandboxing. Add new targets for MAS variations of direct-distribution apps. Enable sandboxing in both targets. 2019-10-21 10:22:27 -04:00
Maurice Parker
00f100e3a3 Renamed TimelineStringFormatter to ArticleStringFormatter now that it is used for much more than the timelines 2019-10-20 02:28:00 -05:00
Nate Weaver
b5d7ce8e8c Disable "Add Folder" button when the text field is empty 2019-10-19 12:31:47 -05:00
Brent Simmons
74b1d56cbf Merge branch 'mac-release' 2019-10-18 17:38:22 -07:00
Brent Simmons
a11e900a93 Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.) 2019-10-18 17:37:56 -07:00
Brent Simmons
1d45796220 Merge mac-release. 2019-10-17 22:11:35 -07:00
Brent Simmons
56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Jonathan Bennett
f010f2693d disable Feed Wrangler account creation 2019-10-16 09:24:55 -04:00
Jonathan Bennett
86caa869fc Merge branch 'master' into feature/feed-wrangler 
# Conflicts:
#	Frameworks/Account/Account.xcodeproj/project.pbxproj
 2019-10-16 05:48:03 -04:00
Maurice Parker
51373885b4 Change javascript event handlers to use event.target.matches instead of walking the dom to install event handlers 2019-10-15 09:04:21 -05:00
Maurice Parker
9e18361043 Merge branch 'mac-release' 2019-10-14 20:59:26 -05:00
Maurice Parker
19145505c5 Add the ability to import NNW 3 Subscription plist files. Issue #1129 2019-10-14 20:45:58 -05:00
Brent Simmons
427c0da0d3 Fix build error in FetchRequestQueue. 2019-10-13 22:19:49 -07:00
Brent Simmons
31a2afb067 Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133. 2019-10-13 22:08:05 -07:00
Brent Simmons
c5e0d96adb Merge changes from mac-release, including performance fix. 2019-10-13 19:08:27 -07:00
Maurice Parker
a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Brent Simmons
099172d9d2 Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever. 2019-10-12 15:06:21 -07:00
Maurice Parker
ee1f26899c Add Test build configuration 2019-10-11 17:38:01 -05:00
Maurice Parker
a3a694333a Disable Sparke's check for updates on DEBUG builds 2019-10-11 15:07:41 -05:00
Brent Simmons
cc9a9435d7 Add provisioning profile. On Signing 7 Capabilities, import provisioning profile. 2019-10-09 21:51:13 -07:00
Phil Dokas
31c1dc40e3 Fix leading for super and subscript in the article view 2019-10-08 22:15:49 -07:00
Maurice Parker
f7e235a1fb Remove padding from code blocks that was causing weird indentation 2019-10-07 11:05:22 -05:00
Jim Correia
be89df884d The Debug menu can now be enabled in release builds. 
`defaults write com.ranchero.NetNewsWire-Evergreen ShowDebugMenu -bool YES`

Toggling the Web Inspector uses SPI, so it's always excluded from the Debug
menu when building for the Mac App Store.
 2019-10-06 17:56:53 -07:00
Brent Simmons
e4134c3256 Add iCloud capability. 2019-10-06 16:53:02 -07:00
Kiel Gillard
6707fdcbd1 Double clicking a feed in the side bar opens the feed's homepage in the browser. Issue #1099 2019-10-05 11:44:21 +10:00
Maurice Parker
c50ed3e44c Improve article extractor error graphic 2019-10-04 08:19:26 -05:00
Maurice Parker
c4b6cbe49e Allow article extractor to be tried again after Mercury parser failure 2019-10-04 07:55:42 -05:00
Maurice Parker
269b9315b2 Revert "Add iCloud entitlement to enable Handoff" 
This reverts commit 27bd9ba919.
 2019-10-04 07:11:44 -05:00
Maurice Parker
27bd9ba919 Add iCloud entitlement to enable Handoff 2019-10-04 07:03:39 -05:00
Maurice Parker
3d343eb91d Prevent pre tags from wrapping. Issue #1089 2019-10-03 18:27:48 -05:00
Maurice Parker
0000e03083 Add the ability to handoff from iOS to Mac 2019-10-03 15:49:27 -05:00
Maurice Parker
9203444552 Add deep linking to Mac app. 2019-10-03 11:39:48 -05:00
Kiel Gillard
56a92e7938 Adds unit testing and implements fixes for unread counts, icons, missing metadata and more. 2019-10-03 18:06:49 +10:00
Ramy Majouji
e3c50db7e8 Optimize PNG’s 2019-10-02 22:52:50 -04:00
Maurice Parker
cc187875d9 Add initial support for per feed notifications 2019-10-02 19:42:16 -05:00
Nate Weaver
ef29334a41 Use os_log() instead of NSLog() 2019-10-02 11:18:52 -05:00
Nate Weaver
f67b7df5a9 Add row swipe action for Mark/Unmark Starred 2019-10-02 11:16:01 -05:00
Nate Weaver
bc32fc1cb9 Add row swipe action for Mark Read/Unread 2019-10-02 11:16:01 -05:00
Brent Simmons
28dc85f4b0 Merge branch 'mac-release' 2019-09-29 22:47:02 -07:00
Brent Simmons
098128fd0a Use new Slack group URL with Help menu command. Fix #1087. 2019-09-29 22:46:40 -07:00
Brent Simmons
27478b0f6f Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match. 2019-09-29 22:44:32 -07:00
Brent Simmons
b62a7afa10 Add keyboard shortcut for toggling starred status — s key. Fix #875. 2019-09-29 22:34:31 -07:00
Maurice Parker
7c26921487 Change Feed Inspector Reader View setting layout 2019-09-28 06:20:06 -05:00
Jonathan Bennett
50428f3179 Allow adding Feed Wrangler accounts 2019-09-28 01:59:49 -04:00
Maurice Parker
6536dbf2a5 Use correct account method for adding folders 2019-09-27 06:38:43 -05:00
Kiel Gillard
465b6e789b Sends and receives unread statuses #1058. Also implements OMPL import #1043. 2019-09-27 08:26:18 +10:00
Maurice Parker
d961a73f28 Removed inadvertent code change 2019-09-26 15:30:38 -05:00
Maurice Parker
0a2cbfde22 Knock the corner off the inner image when it is visible 2019-09-26 14:31:43 -05:00
Andrew Brehaut
f25c0e0b57 Original implementation was only aware of multimarkdown style footnote markup. 
This commit includes support for DaringFireball style footnotes
 2019-09-26 20:20:53 +12:00
Maurice Parker
b721f74e17 Merge branch 'mac-release' 2019-09-25 17:09:21 -05:00
Maurice Parker
c4ee1edb69 Add externalID to Folder and persist it to OPML file. Issue #1060 2019-09-25 17:01:09 -05:00
Andrew Brehaut
a381361b56 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-25 12:18:28 +12:00
Maurice Parker
98befac78c Animate reader view button 2019-09-24 16:34:11 -05:00
Andrew Brehaut
0d99136961 544 Simple darkmode style for popovers 2019-09-23 20:38:46 +12:00
Andrew Brehaut
4c54d2c4ff 544 adds and positions the arrow on the popover bubble 
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.

Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
 2019-09-23 20:25:00 +12:00
Andrew Brehaut
af5d510c80 #544 Better handling of the footnote reverse links 
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
  and scrolls the document back to the source, rather than opening the document in a browser window.
 2019-09-23 19:56:58 +12:00
Nate Weaver
0c99a5f523 Remove enableWebInspectorMenuItem outlet 
Fixes a console warning about the removed property.
 2019-09-22 15:19:23 -05:00
Andrew Brehaut
5fea81971b #554 newsfoot.js and css are included in the page 
These changes are the bare minimum required to get footnotes to appear and function on the article page.
 * The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
 * Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors

Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
 2019-09-22 14:06:51 +12:00
Maurice Parker
548eaac5fa Maid Reader View button more legible 2019-09-21 15:16:55 -05:00
Maurice Parker
9d54a1de74 Enable always on Reader View for feeds 2019-09-21 15:03:42 -05:00
Maurice Parker
b49aeca577 Moved page.html location information to ArticleRenderer 2019-09-21 12:36:35 -05:00
Maurice Parker
0c00150849 Externalize javascript code into separate main.js file 2019-09-21 04:34:11 -05:00
Maurice Parker
ba45144c2a Merge branch 'mac-release' 2019-09-21 03:57:41 -05:00
Maurice Parker
3decd23c45 Convert iOS to use Javascript rendering 2019-09-20 20:33:28 -05:00
Maurice Parker
710abf30c7 Make stylesheet external to page.html 2019-09-20 19:28:13 -05:00
Ben Ubois
cdf643c2a6 Make iFrames responsive. 2019-09-20 17:21:01 -07:00
Maurice Parker
9c6d47eaa1 Merge branch 'pr/1033' 2019-09-20 17:51:27 -05:00
Maurice Parker
1bcc1eda44 Implement disallowing feeds in the root folder for specified accounts 2019-09-20 15:37:10 -05:00
Maurice Parker
a85df5bd09 Add Feedly icon. Issue #1031 2019-09-20 14:47:40 -05:00
Maurice Parker
af0d6c9022 Implement AccountBehaviors so that we don't have to keep adding boolean flags to account 2019-09-20 11:34:31 -05:00
Maurice Parker
d67c9144f5 Add Reader View is always on preference for Feeds 2019-09-19 19:49:11 -05:00
Maurice Parker
567d762ea4 Fix button animation resets 2019-09-19 17:30:54 -05:00
Maurice Parker
76056e4fef Add menu and keyboard shortcut to Reader 2019-09-19 17:25:36 -05:00
Maurice Parker
6a7d1df423 Change image references to use AppAsserts per our standard 2019-09-19 15:44:31 -05:00
Maurice Parker
d3a5bdf6d3 Merge branch 'mac-release' 2019-09-19 11:59:01 -05:00
Nate Weaver
502f5656b8 Don't hide the Web Inspector menu item since the entire Debug menu is removed for release builds 2019-09-19 11:27:04 -05:00
Nate Weaver
180cc39904 Negate MAC_APP_STORE 
Oops. (Was un-negated for testing.)
 2019-09-19 11:19:25 -05:00
Nate Weaver
4a0bbeacc2 Disable Web Inspector for App Store builds 
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
 2019-09-19 10:38:17 -05:00
Ben Ubois
0b6683d073 Render with evaluateJavaScript. 
Replaced loadHTMLString based rendering for improved performance.
 2019-09-18 22:03:23 -07:00
Maurice Parker
20ecba1649 Add tooltip to Reader button 2019-09-18 20:40:58 -05:00
Maurice Parker
3b5a6f2576 Don't allow the article extraction button to toggle if it isn't working. 2019-09-18 20:03:01 -05:00
Maurice Parker
7ec3160273 Made article extractor button brighter 2019-09-18 19:45:22 -05:00
Maurice Parker
1da17fc5a9 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-18 19:24:14 -05:00
Kiel Gillard
9cc5fa3608 Initial implementation allowing Feedly accounts to be added given the Feedly user's consent. 2019-09-19 10:11:53 +10:00
Maurice Parker
8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker
372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker
786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Nate Weaver
93f7972441 Add some spacing around a comment 2019-09-17 13:58:45 -05:00
Nate Weaver
1e840f3090 Move WebKit "inspector starts attached" user default to AppDefaults 2019-09-17 13:42:18 -05:00
Nate Weaver
4a2724bcc4 Fix comment capitalization 2019-09-17 13:27:11 -05:00
Nate Weaver
0c89bc43c1 Use a bridging header for the Web Inspector API instead of KVC 2019-09-17 06:55:55 -05:00
Nate Weaver
4f405009f5 Use a selector instead of a block for the notification observation 2019-09-17 05:04:05 -05:00
Nate Weaver
e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector 
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
 2019-09-17 05:04:05 -05:00
Brent Simmons
b075226685 Merge mac-release. 2019-09-16 22:32:08 -07:00
Brent Simmons
66d9333999 Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code. 2019-09-16 22:27:17 -07:00
Brent Simmons
d16acfcca8 Merge branch 'mac-release' 2019-09-16 22:10:17 -07:00
Brent Simmons
f7c9cc1dbd Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes. 2019-09-16 22:09:58 -07:00
Brent Simmons
1ece325112 Merge mac-release. 2019-09-16 20:09:04 -07:00
Brent Simmons
a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons
a225d52ba3 Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView. 2019-09-16 20:01:30 -07:00
Brent Simmons
506b621e5d Draw the avatar background in TimelineAvatarView only if the icon is too short vertically. 2019-09-16 20:00:32 -07:00
Brent Simmons
2f9f4e263c Restore color for light avatar background. 2019-09-16 19:59:33 -07:00
Maurice Parker
444771dfae Merge branch 'mac-release' 2019-09-16 18:16:13 -05:00
Maurice Parker
1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00
Maurice Parker
18d6a278c7 Merge branch 'mac-release' 2019-09-16 16:37:18 -05:00
Maurice Parker
0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons
8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker
8e939e9942 Change Credentials to be a struct instead of an enum 2019-09-15 10:03:47 -05:00
Phil Viso
cc6767e0f6 Removed duplicate sort parameter change handling functions 2019-09-13 08:29:56 -05:00
Phil Viso
8a6e3c9f37 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed 
# Conflicts:
#	Mac/MainWindow/Timeline/TimelineViewController.swift
 2019-09-13 08:23:31 -05:00
Maurice Parker
5985b00480 Inject the Accounts folder name so that it can be in different locations between the iOS and Mac Apps. 2019-09-12 10:59:26 -05:00
Maurice Parker
57542592cb Correct which view should become the first responder. Issue #1014 2019-09-11 17:47:02 -05:00
Brent Simmons
3b501e9f4e Merge branch 'mac-release' 2019-09-10 20:28:42 -07:00
Brent Simmons
7ad0b6b604 Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923. 2019-09-10 20:28:16 -07:00
Maurice Parker
8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Phil Viso
045bc61684 Renamed Sort By menu item to Sort Articles By 2019-09-08 17:12:18 -05:00
Phil Viso
32d6678fdd Added group by feed menu item 2019-09-08 17:09:26 -05:00
Maurice Parker
0961753357
Merge pull request #998 from hisaac/mac-release 
Add command arrow key shortcuts to sidebar shortcuts plist
 2019-09-08 13:02:58 -05:00
Isaac Halvorson
8b635fc04c Add command arrow key shortcuts to sidebar shortcuts plist 2019-09-08 12:54:26 -05:00
Maurice Parker
e61efbe47a Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS 2019-09-08 09:43:51 -05:00
Brent Simmons
0d25f2331a Merge branch 'mac-release' 2019-09-06 19:28:31 -07:00
Brent Simmons
58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Brent Simmons
d39d7a0fe4 Merge branch 'mac-release' 2019-09-06 19:12:03 -07:00
Brent Simmons
d49b212bc2 Delete unused EvergreenLarge.png. 2019-09-06 19:11:41 -07:00
Maurice Parker
a4b01fda35 Merge branch 'mac-release' 2019-09-06 17:03:38 -05:00
Maurice Parker
0e7d971e65 Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995 2019-09-06 16:52:31 -05:00
Daniel Jalkut
d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Daniel Jalkut
f3ce5116e7 Factor out the common build settings from Mac targets into a new shared xcconfig file, which includee the shared marketing version and bundle version for NetNewsWire and any extensions that may be built. 2019-09-06 14:52:03 -04:00
Maurice Parker
546917a866 Merge branch 'mac-release' 2019-09-06 08:38:58 -05:00
Daniel Jalkut
8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Maurice Parker
00b2756526 Merge branch 'mac-release' 2019-09-05 13:15:04 -05:00
Brian Warren
ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons
b4e5968025 Merge branch 'mac-release' 2019-09-04 21:33:08 -07:00
Brent Simmons
f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons
5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker
da8250ac5a Merge branch 'mac-release' 2019-09-04 17:42:30 -05:00
Maurice Parker
7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker
dabb78cde4 Merge branch 'mac-release' 2019-09-04 17:20:37 -05:00
Thomas Pritchard
d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard
5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Maurice Parker
fa5840811a Change the view that gets made the first responder so that keyboard shortcuts work again 2019-09-04 03:12:50 -05:00
Maurice Parker
722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Maurice Parker
a59f223043 Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS 2019-09-04 02:40:35 -05:00
Brent Simmons
2ec55e6587 Merge branch 'mac-release' 2019-09-03 22:59:29 -07:00
Brent Simmons
0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons
0bfafc2da3 Merge branch 'mac-release' 2019-09-03 22:18:00 -07:00
Brent Simmons
cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00
Brent Simmons
ed91776097 Merge branch 'mac-release' 2019-09-03 21:24:52 -07:00
Brent Simmons
5efbe6a4f0 Add NNW website link to top of About window text. 2019-09-03 21:24:17 -07:00
Jim Correia
c8920ca5a6 Added optional separators in the timeline view. 
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
 2019-09-02 09:13:21 -07:00
Maurice Parker
1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker
6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Jim Correia
e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode 
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
 2019-08-31 22:14:56 -07:00
Maurice Parker
ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Jim Correia
cdfdc06142 Only enable "Open in Browser" when a single article is selected. 
Fixes bug #921.
 2019-08-31 16:02:21 -07:00
Maurice Parker
3baca1d7c0 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-30 11:47:16 -05:00
Maurice Parker
ea1f21797c Merge branch 'mac-release' 2019-08-30 11:28:16 -05:00
Kiel Gillard
f27b7029de Explicity identify the addable account types, allowing for a contingent list given factors such as macOS API availability. 2019-08-30 15:17:25 +10:00
Brent Simmons
29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons
d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00
Maurice Parker
2b206e098a Move the location of the home page to feed icon cache to the cache directory instead of the temp directory 2019-08-27 13:29:34 -05:00
Daniel Jalkut
42168ed3b9 Revise the layout of new account xibs to reduce the distance between labels and text fields, standardize the distance from the service header to the first text field, and move the feedback error string field to beneath the input fields, configured to word-wrap and grow in height as needed. 2019-08-27 12:45:10 -04:00
Daniel Jalkut
526f21a26b Left-align the accounts in the Add Account UI. 2019-08-27 12:35:27 -04:00
Maurice Parker
3c86bf0614
Merge pull request #871 from mbernson/master 
Simplify sharing delegate logic
 2019-08-27 11:13:00 -05:00
Maurice Parker
17fef112d6 Merge branch 'mac-release' 2019-08-26 19:40:56 -05:00
Maurice Parker
3279a25581 Cache home page to feed icon relationship 2019-08-26 19:40:30 -05:00
Maurice Parker
8de9b355c7 Merge branch 'mac-release' 2019-08-26 12:54:53 -05:00
Maurice Parker
1a3e2784ae Optimize table cell reloading when feed images are made available 2019-08-26 12:54:23 -05:00
Maurice Parker
f8c01107d5 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-24 15:01:40 -05:00
Maurice Parker
ea55aa5bef Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS 2019-08-24 15:01:28 -05:00
Brent Simmons
d75f1ca73b Merge branch 'mac-candidate' 2019-08-23 22:03:27 -07:00
Brent Simmons
c3aebe7868 Bump version and build. 2019-08-23 21:59:44 -07:00
Brent Simmons
ed56376d03 Merge branch 'mac-candidate' 2019-08-23 18:55:09 -07:00
Brent Simmons
739eb5183e Bump version and build numbers. 2019-08-23 18:31:04 -07:00
Brent Simmons
dd62a3325a Center the main window on first run. 2019-08-23 18:30:28 -07:00
Brent Simmons
4bead42b5a Center prefs window after switching to the proper view. 2019-08-23 18:30:14 -07:00
Brent Simmons
cc7321e936 Center the preferences window. Fix #769. 2019-08-23 16:22:06 -07:00
Brent Simmons
3447ebcec0 Reload data after a batch update. Fix #872. 2019-08-23 15:52:07 -07:00
Mathijs Bernson
9214e3d65e Simplify sharing item subject logic 2019-08-23 13:05:20 +02:00
Brent Simmons
1ab0f7c25c Merge mac-candidate. 2019-08-21 21:44:07 -07:00
Brent Simmons
e140d51e4b Bump version and build number. 2019-08-21 21:42:48 -07:00
Brent Simmons
849830f494 Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838. 2019-08-21 21:41:56 -07:00
Brent Simmons
f513741ddb Start work on filtering timeline so that articles from deleted feeds never show up. 2019-08-21 13:23:46 -07:00
Brent Simmons
925aa5af70 Merge branch 'mac-candidate' 2019-08-19 14:38:38 -07:00
Brent Simmons
e524d48c1d Add credit to Joe Heck in the About window for difficult infrastructure. 2019-08-19 14:38:18 -07:00
Brent Simmons
2cc5e20fad Merge branch 'mac-candidate' 2019-08-18 16:08:04 -07:00
Brent Simmons
588dbb0ce5 Add prefs to Advanced prefs pane to 1) check for updates automatically, and 2) choose to download test or release builds. The default will be release builds only, since most people don’t want test builds. 2019-08-18 16:07:37 -07:00
Brent Simmons
5670989c29 Do initial layout of revised Advanced preferences (which now include updates preferences). 2019-08-17 16:58:39 -07:00
Brent Simmons
8d7e238386 Change default SUFeedURL to release builds appcast. Add FeedURLForTestBuilds to store the URL for test builds. 2019-08-17 11:04:54 -07:00
Brent Simmons
defa32708c Merge branch 'mac-candidate' 2019-08-14 00:33:07 -07:00
Brent Simmons
3aae7ad328 Now using manual build numbers, because I messed up and built from the wrong branch. I should be able to figure out how to get back to automated build numbers — but it can wait till after 5.0 ships. 2019-08-14 00:20:42 -07:00
Brent Simmons
9ff1e48d37 Merge branch 'mac-candidate' 2019-08-14 00:14:07 -07:00
Brent Simmons
f86c32b414 Bump version to b4. 2019-08-14 00:13:50 -07:00
Brent Simmons
9530ad7d58 Merge branch 'mac-candidate' 2019-08-13 21:24:28 -07:00
Brent Simmons
8cb9aefeec Bump version to 5.0b3. 2019-08-13 21:24:15 -07:00
Brent Simmons
7b3c08f521 Merge branch 'mac-candidate' 2019-08-13 21:07:59 -07:00
Brent Simmons
2bbd135c9e Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829. 2019-08-13 21:07:39 -07:00
Brent Simmons
fc0fc2055e Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected. 2019-08-13 20:29:04 -07:00
Brent Simmons
cf1b3843ee Add a SmartFeedType to smart feeds so the sidebar can tell them apart. 2019-08-13 20:28:28 -07:00
Brent Simmons
62258683c8 Add Ryan’s word-wrap change to mac-candidate. 2019-08-13 20:07:42 -07:00
Ryan Dotson
6eb27abc13 Break long words or URLs to prevent horizontal overflow 2019-08-13 09:27:36 +09:00
Ryan Dotson
c8f5a24b95 Use proper quotes in timeline contextual menu 2019-08-13 07:41:14 +09:00
Brent Simmons
27fed1cb60 Merge branch 'mac-candidate' 2019-08-12 09:54:05 -07:00
Brent Simmons
bfe3a15b9d Bump version to 5.0b2. Remove how-to-support thing from About box. 2019-08-12 09:53:47 -07:00
Brent Simmons
cb173d89cc Merge branch 'mac-candidate' 2019-08-11 22:09:26 -07:00
Brent Simmons
495662f888 Add, to About window, credit for Ryan Dotson for the Help Book. Also add a link to the How to Support NetNewsWire tech note. 2019-08-11 22:08:24 -07:00
Brent Simmons
316a1b22ff Merge branch 'mac-candidate' 2019-08-11 21:58:48 -07:00
Brent Simmons
bf3e26e827 Bump version to 5.0b1. 2019-08-11 21:58:27 -07:00
Brent Simmons
ef4c52169a Merge branch 'mac-candidate' 2019-08-10 14:27:16 -07:00
Brent Simmons
40369eaca0 Change the URL of the Help book to include a /mac/ directory, so we can have separate help books for Mac and iOS. 2019-08-10 14:26:51 -07:00
Brent Simmons
965ce4ebe1 Merge branch 'mac-candidate' 2019-08-03 11:05:41 -07:00
Brent Simmons
536ac205a0 Fix crash when making a feed via AppleScript and the feed already exists. 2019-08-03 11:04:52 -07:00
Brent Simmons
49f17e5d14 Merge branch 'mac-candidate' 2019-08-02 14:03:30 -07:00
Brent Simmons
4b5dd7cd17 Fix some AppleScript terminology conflicts. Change account.type too account.accountType. Change local account to onmymac. 2019-08-02 14:03:04 -07:00
Brent Simmons
03afab8e6d Merge branch 'mac-candidate' 2019-08-02 12:44:51 -07:00
Brent Simmons
ccd1d4bdc1 Wire up the account name for scripting. 2019-08-02 12:44:24 -07:00
Brent Simmons
2277e95a83 Merge branch 'mac-candidate' 2019-08-01 22:51:24 -07:00
Brent Simmons
5d97e89e91 Replace the contents property with allFeeds — which returns all the feeds, including those inside folders. This is distinct from the feeds element, which returns just top-level feeds. 2019-08-01 22:51:03 -07:00
Brent Simmons
8d80d2aed1 Merge branch 'mac-candidate' 2019-08-01 21:52:57 -07:00
Brent Simmons
e800b13f01 The accounts property returns all accounts. 2019-08-01 21:52:12 -07:00
Brent Simmons
e845e3bd35 Merge branch 'mac-candidate' 2019-07-29 19:56:49 -07:00
Brent Simmons
31e089fc1d Add an active property to the scripting definition for Account. 2019-07-29 19:56:22 -07:00
Brent Simmons
34326863ea Merge branch 'mac-candidate' 2019-07-28 16:01:12 -07:00
Brent Simmons
887f8e0b53 Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching. 2019-07-28 16:00:43 -07:00
Brent Simmons
2fcadf9748 Merge branch 'mac-candidate' 2019-07-28 15:31:45 -07:00
Brent Simmons
2441de960f Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791. 2019-07-28 15:31:17 -07:00
Brent Simmons
d8f1dcf23e Merge branch 'mac-candidate' 2019-07-27 22:53:53 -07:00
Brent Simmons
44ec6a026d Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.) 2019-07-27 22:53:27 -07:00
Brent Simmons
05faea53c4 Remove reference to NSCalendarDayChanged — it’s no longer necessary to update the Today feed unread count when the day changes. 2019-07-27 19:52:05 -07:00
Brent Simmons
314fd970d1 Merge branch 'mac-candidate' 2019-07-27 19:49:46 -07:00
Brent Simmons
8acab45cf9 Make formatting changes to SidebarViewController.swift so it conforms to current formatting thinking. 2019-07-27 19:49:33 -07:00
Brent Simmons
58a7e1bc7d Merge branch 'mac-candidate' 2019-07-27 15:44:34 -07:00
Brent Simmons
a41f7d8e68 Remove some unneeded drawing. This makes resizing the timeline faster. 2019-07-27 15:44:13 -07:00
Maurice Parker
125512f551 Merge branch 'mac-candidate' 2019-07-26 08:06:59 -05:00
Maurice Parker
8b0c8156df Remove refresh at midnight for Today smartfeed 2019-07-26 08:06:08 -05:00
Maurice Parker
e263665a21 Merge branch 'mac-candidate' 2019-07-23 16:36:46 -05:00
Maurice Parker
8a5730267b Add Fresh RSS to sdef file. 2019-07-18 14:12:50 -05:00
Maurice Parker
4fc1998cf3 Make Account and AccountDelegate interfaces more consistent by requiring the container parameter on removeFeed. Resolves #802 2019-07-17 15:41:21 -05:00
Brent Simmons
8e2fef072e
Merge pull request #798 from olofhellman/master 
First sample script -- Create an outgoing message in Mail with info about the current article
 2019-07-10 13:14:03 -07:00
Olof Hellman
9a730afb49 Add sample script for creating a new outgoing message in Mail, fix accessor for the 'name of author' 2019-07-10 00:02:20 -07:00
Brent Simmons
2e4d22675c Merge branch 'mac-candidate' 2019-07-09 21:45:34 -07:00
Brent Simmons
b1606ce20f Add thanks to GitHub, Slack, and CircleCI to about box. 2019-07-09 21:45:01 -07:00
Brent Simmons
3999c7b3c5 Merge branch 'mac-candidate' 2019-07-05 22:42:01 -07:00
Brent Simmons
7a204ad6ed Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in. 2019-07-05 20:06:31 -07:00
Maurice Parker
5f045706e4 Removed usaged of UIApplication.present 2019-06-27 14:21:07 -05:00
Jeremy Beker
3fb222f5c4
Implement Credential Update for FreshRSS 2019-06-23 09:31:04 -04:00
Maurice Parker
1ac1144b2d Reduce footprint of Account credentials API 2019-06-20 11:19:15 -05:00
Maurice Parker
fa62acb585 Rebrand Reader API to FreshRSS 2019-06-20 07:22:51 -05:00
Maurice Parker
74f84dc000 Restrict OPML import for Account types that don't support it 2019-06-19 17:50:32 -05:00
Maurice Parker
b4b80c51bc Renamed google reader api to just reader api to make it consistent everywhere we use it 2019-06-19 15:40:03 -05:00
Jeremy Beker
15ae97f7c9
Merge branch 'master' into google_reader_compatible_syncing 2019-06-19 13:53:30 -04:00
Jeremy Beker
d87f68a006
Renamed GoogleReaderCompatible to just Reader 2019-06-19 12:25:37 -04:00
Brent Simmons
6f16a2715e Skip downloading featured images, since we’re not displaying them anywhere. 2019-06-17 21:47:17 -07:00
Jeremy Beker
125ea59cd6
Wiring up iOS add account settings 2019-06-16 18:22:00 -04:00
Jeremy Beker
19395779c8
Change label from email -> login 2019-06-16 15:21:35 -04:00
Jeremy Beker
a6e0cae377
Merge branch 'master' into google_reader_compatible_syncing 2019-06-16 13:16:03 -04:00
Brent Simmons
6cf6df059f Update version to 5.0a4. 2019-06-15 17:20:43 -07:00
Brent Simmons
991c148494 Update version to 5.0a4. 2019-06-15 17:02:42 -07:00
Jeremy Beker
f54bc3569b
Merge branch 'master' into google_reader_compatible_syncing 
# Conflicts:
#	Frameworks/Account/Account.swift
#	submodules/RSWeb
 2019-06-15 12:34:50 -04:00
Maurice Parker
18b90ba93f Added How To Support NetNewsWire help menu item. Issue #753 2019-06-14 17:38:00 -05:00
Maurice Parker
ed6dd249c3 add missed file in last commit 2019-06-14 15:35:12 -05:00
Maurice Parker
40b9be6709 center smaller avatars on a solid color background image to make all avatars a consistent size 2019-06-14 15:33:13 -05:00
Maurice Parker
6527ac852c Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 2019-06-13 14:50:41 -05:00
Nate Weaver
3e8e7113c0 Make read/starred read/write via AppleScript 2019-06-11 19:17:50 -05:00
Brent Simmons
3e0f70f43e Update version to 5.0a3. Update appcast. 2019-06-10 21:52:13 -07:00
Maurice Parker
e8199ed0a6 Change to not show alert dialog on automatic refreshes. Issue #729 2019-06-10 15:21:17 -05:00
Maurice Parker
93fbbd4cc3 Make sure that FeedFinder and InitialDownloader are running on the main thread. 2019-06-10 08:21:03 -05:00
Brent Simmons
45f6d8043a Add ellipsis where needed in import/export OPML sheets. Fix #731. 2019-06-09 20:18:10 -07:00
Brent Simmons
4a4fa6ed0e Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734. 2019-06-09 16:03:08 -07:00
Brent Simmons
2d96544933 NetNewsWire 5.0a2. 2019-06-08 16:29:07 -07:00
Charles Parnot
4f02fe7401 Fix issue with 'Mark as Read' menu item in the Article menu. 
There were 2 issues: the title of the menu item did not toggle between 'Mark As Read' and 'Mark As Unread', and it was not invalidated where there is no article selected. All the code was already in place in `MainWindowController` as part of the interface item validation, but the menu item was using the wrong selector: `markRead` instead of `toggleRead`. Just changing the action in the menu item was needed to get the validation and menu item update happening correctly.
 2019-06-07 09:06:18 +02:00
Brent Simmons
364fc2760f Bump version to 5.0a1. That’s right — it’s alpha now. W00t! 2019-05-31 20:21:08 -07:00
Maurice Parker
3593d1c5d8 Update to the new icon 2019-05-31 13:52:15 -05:00
Jeremy Beker
98c32b9987
Merge branch 'master' into google_reader_compatible_syncing 2019-05-31 09:54:25 -04:00
Maurice Parker
88b2775076 Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated 2019-05-31 08:05:26 -05:00
Maurice Parker
beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker
a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker
30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker
1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Jeremy Beker
fdc0374c4f
Ensure credentials are available for use 
Need to load metadad first
 2019-05-30 07:48:34 -04:00
Maurice Parker
51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker
527e677934 Rename deleteFolder to removeFolder to make the API more consistent 2019-05-29 20:53:00 -05:00
Maurice Parker
f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker
5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker
bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker
fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00
Maurice Parker
b1bd8d2d90 Enable folder dragging between accounts 2019-05-29 15:43:33 -05:00
Jeremy Beker
aa6dfe8a08
Rework to store endpoint URL in metadata 
Endpoint URL did not belong with credentials. This breaks it out and stores it in the account metadata. Updates validation code to take it as a parameter.
 2019-05-29 15:16:09 -04:00
Maurice Parker
8fc6e81ddf Update the Today timeline and unread count when the day changes. Issue #627 2019-05-29 10:24:30 -05:00
Jeremy Beker
0df86e5761
Authentication working 
* Updates to use new API style per discussion with Maurice
* Credential validation functioning
 2019-05-29 10:54:52 -04:00
Maurice Parker
0648053417 Enforce tag specific drop validation (can't copy to the account level) 2019-05-28 17:42:19 -05:00
Maurice Parker
83652c40de Handle scenario where moved/copied feed already exists somewhere else in account 2019-05-28 16:46:16 -05:00
Maurice Parker
01d5a95241 Remove redundant private keyword usage 2019-05-28 16:31:03 -05:00
Maurice Parker
112702020b Enable same account copying. 2019-05-28 13:11:29 -05:00
Jeremy Beker
84dbdf25e2
Google Reader API Account Provider and initial integration 
* Creation of account classes (based on FeedBin)
* Integration on Mac side into account dialog
* Initial authentication call works and extracts auth token, but no where to put it right now.
 2019-05-28 13:08:15 -04:00
Maurice Parker
78c19bda43 Remove restriction on only moving and copying between local accounts. 2019-05-28 11:09:47 -05:00
Maurice Parker
b3c4c8de59 Correct how feeds were copied and moved between accounts to eliminate shared objects. 2019-05-28 10:59:06 -05:00
Maurice Parker
493abbb609 Refactor create feed functionality to increase code reuse and encapsulation 2019-05-28 09:45:02 -05:00
Maurice Parker
c7b61f7d87 Enable copy between local accounts. 2019-05-27 18:01:24 -05:00
Maurice Parker
659c9e5271 Allow dragged feeds between local accounts only 2019-05-27 15:11:16 -05:00
Brent Simmons
bfe41438fc Make default exported OPML file name Subscriptions-[accountName].opml. Fix #683. 2019-05-26 22:17:19 -07:00
Brent Simmons
e5e9538318 Change column spacing in the grid view so that we use standard space between labels and content. 2019-05-26 22:12:09 -07:00
Brent Simmons
8322ea4f31 Tweak the explanotext for the Name field in Account > Preferences. 2019-05-26 22:01:50 -07:00
Brent Simmons
6cd8f42597 Add layout constraints for the table cells in Account > Preferences sidebar. 2019-05-26 21:59:41 -07:00
Brent Simmons
9e0187ca55 Fix tableView frame in Preferences > Accounts sidebar. For some reason IB wants it wider than the clip view. This leads to unwanted horizontal scrolling. 2019-05-26 21:38:13 -07:00
Brent Simmons
9f6b2bc63f Revise layout and add explanation for the import OPML choose-account sheet. 2019-05-26 16:29:46 -07:00
Brent Simmons
810e5b9aee Tweak layout and add explanation text for OPML export sheet. 2019-05-26 16:12:38 -07:00
Brent Simmons
31f8348d11 Add explanation text to the Name field in Account Information preferences. 2019-05-26 12:12:29 -07:00
Brent Simmons
4de509326f Change OPML menu items to Import Subscriptions… and Export Subscriptions. Change Close menu item to Close Window. 2019-05-26 11:55:24 -07:00
Maurice Parker
c61949bc04 Add account name to network error messages and prevent background iOS errors from displaying alerts 2019-05-26 11:54:32 -05:00
Brent Simmons
68420bcfd1 Update Info.plist for new public build. 2019-05-25 10:33:23 -07:00
Brent Simmons
ad841ee41e Remove Donate to App Camp from Help menu, since the donation page no longer exists. 2019-05-25 10:27:05 -07:00
Brent Simmons
8f48d8a726 Add Slack Group command in Help menu — it takes you to the signup page. 2019-05-25 10:21:25 -07:00
Maurice Parker
c422b4b82c Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-05-22 10:08:01 -05:00
Maurice Parker
43f8e9880c Change to mark all as unread for the selected article feed. Issue #657 2019-05-22 10:07:00 -05:00
Brent Simmons
e05eb6e60c Use == instead of === when comparing feeds in the sidebar — you might have duplicate feeds. (Duplicate feeds are totally allowed.) 2019-05-21 22:23:26 -07:00
Maurice Parker
be81fdae0a Send article statuses to Feedbin on app terminate 2019-05-21 17:20:49 -05:00
Maurice Parker
98a262e34b Update pseudo feed timeline when and account is deleted. 2019-05-21 16:47:32 -05:00
Maurice Parker
918eb746d5 Update pseudo feeds when account states change. Issues #645, #663, & #664. 2019-05-21 16:36:47 -05:00
Maurice Parker
46cd477ee0 Make unread indicator white for selected and emphasized rows in timeline. Issue #655 2019-05-21 16:08:16 -05:00
Maurice Parker
4667035e61 Remember last OPML export account, suggest account name for OPML export file name, allow export of inactive accounts. Issue #659 & Issue #652 2019-05-21 15:15:26 -05:00
Maurice Parker
0da916fa68 Add Mark All as Read contextual menu item. Issue #657 2019-05-21 14:57:22 -05:00
Maurice Parker
af19b6dee0 Remember last selected account on OPML import. Issue #661 2019-05-21 14:56:41 -05:00
Maurice Parker
8816de4a0e Fix issue where new Feeds added to a folder also got left in the account container. 2019-05-21 10:26:11 -05:00
Maurice Parker
fb33008b36 Remember account selection for Add Feed and Add Folder dialogs. Issue #651 & Issue #654 2019-05-21 09:36:33 -05:00
Maurice Parker
e6680a23b9 Make move animation smoother by wrapping in a BatchUpdate 2019-05-21 09:03:28 -05:00
Maurice Parker
3207ebf6a5 Implement default timeline avatar. Issue #641 2019-05-21 05:42:40 -05:00
Brent Simmons
3ae9bdb74f Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-05-20 14:30:08 -07:00
Brent Simmons
74953601dd Increase the duration of TimelineViewController’s database fetch queue from 0.5 to 2.0. This will still allow updates to appear in a timely way, but will help prevent fetching too often during a refresh. 2019-05-19 22:26:08 -07:00
Brent Simmons
4d27e5a338 Simplify representedObjectsContainsAnyPseudoFeed. 2019-05-19 20:49:24 -07:00
Phil Viso
bce45d28e4 Updated all iOS references to default local account new to be device specific 2019-05-19 16:52:21 -05:00
Maurice Parker
80e1888244 Rename AccountsDidChangeNotification to AccountsDidChange to match other notification names. 2019-05-19 15:51:08 -05:00
Maurice Parker
07ac60cec3 Remove showAddFolderWindow and showAddFeedWindow functions from MainWindowController so that validations will run on AppDelegate. 2019-05-19 15:27:58 -05:00
Maurice Parker
10c5ca4e1a Disable refresh and add NNW app news when there are no active accounts. 2019-05-19 14:23:54 -05:00
Maurice Parker
86578775e0 Move menu validations to the app delegate. 2019-05-19 10:21:42 -05:00
Phil Viso
eb5c1a49f7 Disable adding a new folder if there are no active accounts 2019-05-19 09:14:40 -05:00
Phil Viso
5ded56fc28 Fixed a crash that occurs when trying to add a new feed with no active accounts 2019-05-19 09:10:19 -05:00
Brent Simmons
e98d28c770 Show favicon in the timeline, even though they look weird because they’re small. They’re still better than nothing. 2019-05-18 12:21:35 -07:00
Brent Simmons
36c6c70ba2 Scale avatar images down — they might be up to twice as large as expected. 2019-05-17 23:02:48 -07:00
Brent Simmons
3d253ce6d9 Align avatars to top in timeline. Fix #643. 2019-05-16 22:32:09 -07:00
Brent Simmons
6fc6850a79 Update URL for Help book. 2019-05-16 21:31:57 -07:00
Maurice Parker
b759237fc1 Fix issue where moving from account to folder and the network is unavailable caused feeds to be lost. 2019-05-16 11:19:44 -05:00
Maurice Parker
6882b152d9 Add timer to trigger article status sync process. 2019-05-15 17:21:58 -05:00
Maurice Parker
fb79309f95 Change import and export OPML so that they don't prompt to select an account if only one is active 2019-05-14 19:40:38 -05:00
Brent Simmons
51730d9b1c Set scaling to .scaleNone in the avatar image view in the timeline, since we’re pre-scaling the images. 2019-05-13 22:23:06 -07:00
Brent Simmons
5abe73331a Make TimelineTableView and TimelineTableRowView opaque in the interest of speeding up rendering during scrolling. 2019-05-13 21:42:47 -07:00
Brent Simmons
52b1ef2350 Place avatars on the left in the timeline. 2019-05-12 20:42:52 -07:00
Maurice Parker
521960a2c9 make sure that the account add view is shown after an account delete 2019-05-12 19:22:59 -05:00
Maurice Parker
6f92cd1a73 Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors 2019-05-11 12:26:23 -05:00
Maurice Parker
fe70723eb4 Use best feed specifier code to determine which Feedbin option to use when creating a feed 2019-05-10 10:14:24 -05:00
Maurice Parker
a7d1014d5b Change account delete to use a standard alert dialog. 2019-05-10 08:42:44 -05:00
Maurice Parker
23b43ecc07 Add undo for feeds 2019-05-09 16:09:21 -05:00
Maurice Parker
cda8acc66c Add the ability to move feeds between folders for Feedbin 2019-05-09 13:31:18 -05:00
Maurice Parker
50d3a5799c added subscription delete 2019-05-09 07:25:45 -05:00
Maurice Parker
06626f10a7 Add feed rename 2019-05-08 17:55:53 -05:00
Maurice Parker
43d32b1281 Add create Feedbin feed 2019-05-08 17:41:19 -05:00
Maurice Parker
7f9055fe78 Add download subscriptions and faviconURLs 2019-05-07 10:51:41 -05:00
Maurice Parker
d6ae740305 Added folder (tag) delete for Feedbin 2019-05-06 17:34:41 -05:00
Maurice Parker
b7e2df1a68 Add Folder rename for Feedbin 2019-05-06 10:53:20 -05:00
Maurice Parker
15a0ba89d7 Add folder syncing for Feedbin account 2019-05-05 15:41:20 -05:00
Maurice Parker
fc7b6f2c6b refactor how Credentials work 2019-05-05 03:25:21 -05:00
Maurice Parker
261e2a951a Add ability to update credentials 2019-05-04 16:10:58 -05:00
Maurice Parker
aaa4342494 Add encrypted credential storage 2019-05-04 15:14:49 -05:00
Maurice Parker
595db517a7 change func signitures to use Credentials protocol from RSWeb instead of username/password 2019-05-04 11:48:48 -05:00
Maurice Parker
38202ece8d Made credentials verification errors more descriptive. 2019-05-04 09:18:14 -05:00
Maurice Parker
bb42e46887 Update to use latest webservice network layer in RSWeb 2019-05-04 08:54:07 -05:00
Maurice Parker
5a852c1615 validate Feedbin account credentials and add Feedbin account 2019-05-02 18:17:52 -05:00
Maurice Parker
c25680ca5d Show add account after delete account 2019-05-02 06:57:45 -05:00
Maurice Parker
eb89ee7128 Expand new or newly active accounts so that they don't look broken 2019-05-02 06:45:56 -05:00
Maurice Parker
141ec961e9 Tweak account detail UI 2019-05-02 06:28:40 -05:00
Maurice Parker
636468bbf0 Implement active account processing functionality 2019-05-02 06:01:30 -05:00
Maurice Parker
747079157b Implement account state UI 2019-05-02 05:41:44 -05:00
Maurice Parker
f5523dd610 Add delete from disk 2019-05-01 19:22:07 -05:00
Maurice Parker
32eb6f6a17 Make the delete warning less comically large 2019-05-01 18:49:13 -05:00
Maurice Parker
1802f71572 Implement the delete UI 2019-05-01 18:26:23 -05:00
Maurice Parker
133398c240 Prevent dragging between accounts. 2019-05-01 17:49:25 -05:00
Maurice Parker
78e98e4c03 Make single non-local drops work with multiple accounts 2019-05-01 17:33:08 -05:00
Maurice Parker
73f035c5b7 Make OPML import and export respect multiple accounts 2019-05-01 16:04:56 -05:00
Maurice Parker
63eeeb55ca Refine visually the add local account dialog 2019-05-01 15:08:50 -05:00
Maurice Parker
f5dbe7117e Delete dead code 2019-05-01 14:56:26 -05:00
Maurice Parker
6ede5b7c3d Enable add feed for multiple accounts 2019-05-01 14:03:59 -05:00
Maurice Parker
f4180424e1 Add multiple local accounts 2019-05-01 12:37:13 -05:00
Maurice Parker
7cc4475596 Rename classes to match naming convention 2019-05-01 11:08:06 -05:00
Maurice Parker
4edffa488d Rename classes to match naming convention 2019-05-01 11:05:55 -05:00
Maurice Parker
68f5c1bfd1 Make account listing wider 2019-05-01 10:31:40 -05:00
Maurice Parker
fe8e825c0d Add account add UI 2019-05-01 10:28:13 -05:00
Maurice Parker
a845a96274 Add images to account table view 2019-05-01 06:49:50 -05:00
Maurice Parker
4bc7611721 Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts 2019-05-01 05:53:18 -05:00
Maurice Parker
ba57a27a35 Make local account display names changeable 2019-04-30 06:38:18 -05:00
Maurice Parker
476bd7ec56 Fix release build compile error caused by recent RefreshTimer refactoring. 2019-04-24 14:46:01 -05:00
Maurice Parker
66e4180a8c Refactor RefreshTimer code out into a separate class from AppDelegate so that it can be reused on iOS. 2019-04-23 11:20:44 -05:00
Maurice Parker
23c69a9223 Make RefreshInterval shared code 
Back out inadvertent macOS changes
 2019-04-23 08:47:58 -05:00
Maurice Parker
e81defb934 Implement detail next and prev article buttons. 2019-04-21 17:42:26 -05:00
Maurice Parker
c5a891234d implement model controller pattern 2019-04-21 13:57:23 -05:00
Maurice Parker
b01b45cf9c Renamed to DeleteCommand and implemented delete undo for iOS. 2019-04-18 08:54:48 -05:00
Maurice Parker
7083b5064b Refactored the TreeDelegates to be shared code. 2019-04-18 04:56:15 -05:00
Maurice Parker
615e183242 Combined all the "add"s into a single popover. 2019-04-16 13:38:07 -05:00
Maurice Parker
8526db8b4c Added initial POC version of NetNewsWire for iOS to use as a starting point for the actual app. 2019-04-15 15:03:05 -05:00
Brent Simmons
6c8481d805 Work around WKWebView latency that happens when specifying baseURL. Instead, make it nil, and add a base href tag to the actual HTML. 2019-04-14 12:54:17 -07:00
Brent Simmons
70312aa75c Major folder and project tree restructuring. 2019-04-13 16:18:54 -07:00