Commit Graph

490 Commits

Author SHA1 Message Date
Maurice Parker 9e18361043 Merge branch 'mac-release' 2019-10-14 20:59:26 -05:00
Maurice Parker 19145505c5 Add the ability to import NNW 3 Subscription plist files. Issue #1129 2019-10-14 20:45:58 -05:00
Brent Simmons 427c0da0d3 Fix build error in FetchRequestQueue. 2019-10-13 22:19:49 -07:00
Brent Simmons 31a2afb067 Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133. 2019-10-13 22:08:05 -07:00
Brent Simmons c5e0d96adb Merge changes from mac-release, including performance fix. 2019-10-13 19:08:27 -07:00
Maurice Parker a1f26898c8 Split Mac and iOS specific javascript into individual files. 2019-10-13 15:47:11 -05:00
Brent Simmons 099172d9d2 Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever. 2019-10-12 15:06:21 -07:00
Maurice Parker ee1f26899c Add Test build configuration 2019-10-11 17:38:01 -05:00
Maurice Parker a3a694333a Disable Sparke's check for updates on DEBUG builds 2019-10-11 15:07:41 -05:00
Brent Simmons cc9a9435d7 Add provisioning profile. On Signing 7 Capabilities, import provisioning profile. 2019-10-09 21:51:13 -07:00
Phil Dokas 31c1dc40e3 Fix leading for super and subscript in the article view 2019-10-08 22:15:49 -07:00
Maurice Parker f7e235a1fb Remove padding from code blocks that was causing weird indentation 2019-10-07 11:05:22 -05:00
Jim Correia be89df884d The Debug menu can now be enabled in release builds.
`defaults write com.ranchero.NetNewsWire-Evergreen ShowDebugMenu -bool YES`

Toggling the Web Inspector uses SPI, so it's always excluded from the Debug
menu when building for the Mac App Store.
2019-10-06 17:56:53 -07:00
Brent Simmons e4134c3256 Add iCloud capability. 2019-10-06 16:53:02 -07:00
Kiel Gillard 6707fdcbd1 Double clicking a feed in the side bar opens the feed's homepage in the browser. Issue #1099 2019-10-05 11:44:21 +10:00
Maurice Parker c50ed3e44c Improve article extractor error graphic 2019-10-04 08:19:26 -05:00
Maurice Parker c4b6cbe49e Allow article extractor to be tried again after Mercury parser failure 2019-10-04 07:55:42 -05:00
Maurice Parker 269b9315b2 Revert "Add iCloud entitlement to enable Handoff"
This reverts commit 27bd9ba919.
2019-10-04 07:11:44 -05:00
Maurice Parker 27bd9ba919 Add iCloud entitlement to enable Handoff 2019-10-04 07:03:39 -05:00
Maurice Parker 3d343eb91d Prevent pre tags from wrapping. Issue #1089 2019-10-03 18:27:48 -05:00
Maurice Parker 0000e03083 Add the ability to handoff from iOS to Mac 2019-10-03 15:49:27 -05:00
Maurice Parker 9203444552 Add deep linking to Mac app. 2019-10-03 11:39:48 -05:00
Kiel Gillard 56a92e7938 Adds unit testing and implements fixes for unread counts, icons, missing metadata and more. 2019-10-03 18:06:49 +10:00
Ramy Majouji e3c50db7e8 Optimize PNG’s 2019-10-02 22:52:50 -04:00
Maurice Parker cc187875d9 Add initial support for per feed notifications 2019-10-02 19:42:16 -05:00
Nate Weaver ef29334a41 Use os_log() instead of NSLog() 2019-10-02 11:18:52 -05:00
Nate Weaver f67b7df5a9 Add row swipe action for Mark/Unmark Starred 2019-10-02 11:16:01 -05:00
Nate Weaver bc32fc1cb9 Add row swipe action for Mark Read/Unread 2019-10-02 11:16:01 -05:00
Brent Simmons 28dc85f4b0 Merge branch 'mac-release' 2019-09-29 22:47:02 -07:00
Brent Simmons 098128fd0a Use new Slack group URL with Help menu command. Fix #1087. 2019-09-29 22:46:40 -07:00
Brent Simmons 27478b0f6f Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match. 2019-09-29 22:44:32 -07:00
Brent Simmons b62a7afa10 Add keyboard shortcut for toggling starred status — s key. Fix #875. 2019-09-29 22:34:31 -07:00
Maurice Parker 7c26921487 Change Feed Inspector Reader View setting layout 2019-09-28 06:20:06 -05:00
Jonathan Bennett 50428f3179 Allow adding Feed Wrangler accounts 2019-09-28 01:59:49 -04:00
Maurice Parker 6536dbf2a5 Use correct account method for adding folders 2019-09-27 06:38:43 -05:00
Kiel Gillard 465b6e789b Sends and receives unread statuses #1058. Also implements OMPL import #1043. 2019-09-27 08:26:18 +10:00
Maurice Parker d961a73f28 Removed inadvertent code change 2019-09-26 15:30:38 -05:00
Maurice Parker 0a2cbfde22 Knock the corner off the inner image when it is visible 2019-09-26 14:31:43 -05:00
Andrew Brehaut f25c0e0b57 Original implementation was only aware of multimarkdown style footnote markup.
This commit includes support for DaringFireball style footnotes
2019-09-26 20:20:53 +12:00
Maurice Parker b721f74e17 Merge branch 'mac-release' 2019-09-25 17:09:21 -05:00
Maurice Parker c4ee1edb69 Add externalID to Folder and persist it to OPML file. Issue #1060 2019-09-25 17:01:09 -05:00
Andrew Brehaut a381361b56 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-25 12:18:28 +12:00
Maurice Parker 98befac78c Animate reader view button 2019-09-24 16:34:11 -05:00
Andrew Brehaut 0d99136961 544 Simple darkmode style for popovers 2019-09-23 20:38:46 +12:00
Andrew Brehaut 4c54d2c4ff 544 adds and positions the arrow on the popover bubble
An arrow element is now inserted into the dom to orient the bubble to the fnref
element that opened it. This is offset in the opposite direction to the bubble
if the bubble overhangs one side or the other.

Additionally, if both sides overhang then no positioning takes place. This
is the first step towards supporting more narrow windows and mobile clients.
2019-09-23 20:25:00 +12:00
Andrew Brehaut af5d510c80 #544 Better handling of the footnote reverse links
* Uses a stylesheet to hide the reverse link in the popover rather than monkeying around with the dom in JS
* Javascript event handler catches clicks on the reverse buttons in the footnote list at the bottom of the page
  and scrolls the document back to the source, rather than opening the document in a browser window.
2019-09-23 19:56:58 +12:00
Nate Weaver 0c99a5f523 Remove enableWebInspectorMenuItem outlet
Fixes a console warning about the removed property.
2019-09-22 15:19:23 -05:00
Andrew Brehaut 5fea81971b #554 newsfoot.js and css are included in the page
These changes are the bare minimum required to get footnotes to appear and function on the article page.
 * The newsfoot.js script now wraps everything in an IIFE to prevent bleed to other scripts
 * Stylesheets are included in the main stylesheet, with the colors extracted out into separate selectors

Currently missing the arrow pointing to the footnote link, and no consideration exists for mobile presentation
beyond a max-width: 100vh on the footnote popover.
2019-09-22 14:06:51 +12:00
Maurice Parker 548eaac5fa Maid Reader View button more legible 2019-09-21 15:16:55 -05:00
Maurice Parker 9d54a1de74 Enable always on Reader View for feeds 2019-09-21 15:03:42 -05:00
Maurice Parker b49aeca577 Moved page.html location information to ArticleRenderer 2019-09-21 12:36:35 -05:00
Maurice Parker 0c00150849 Externalize javascript code into separate main.js file 2019-09-21 04:34:11 -05:00
Maurice Parker ba45144c2a Merge branch 'mac-release' 2019-09-21 03:57:41 -05:00
Maurice Parker 3decd23c45 Convert iOS to use Javascript rendering 2019-09-20 20:33:28 -05:00
Maurice Parker 710abf30c7 Make stylesheet external to page.html 2019-09-20 19:28:13 -05:00
Ben Ubois cdf643c2a6 Make iFrames responsive. 2019-09-20 17:21:01 -07:00
Maurice Parker 9c6d47eaa1 Merge branch 'pr/1033' 2019-09-20 17:51:27 -05:00
Maurice Parker 1bcc1eda44 Implement disallowing feeds in the root folder for specified accounts 2019-09-20 15:37:10 -05:00
Maurice Parker a85df5bd09 Add Feedly icon. Issue #1031 2019-09-20 14:47:40 -05:00
Maurice Parker af0d6c9022 Implement AccountBehaviors so that we don't have to keep adding boolean flags to account 2019-09-20 11:34:31 -05:00
Maurice Parker d67c9144f5 Add Reader View is always on preference for Feeds 2019-09-19 19:49:11 -05:00
Maurice Parker 567d762ea4 Fix button animation resets 2019-09-19 17:30:54 -05:00
Maurice Parker 76056e4fef Add menu and keyboard shortcut to Reader 2019-09-19 17:25:36 -05:00
Maurice Parker 6a7d1df423 Change image references to use AppAsserts per our standard 2019-09-19 15:44:31 -05:00
Maurice Parker d3a5bdf6d3 Merge branch 'mac-release' 2019-09-19 11:59:01 -05:00
Nate Weaver 502f5656b8 Don't hide the Web Inspector menu item since the entire Debug menu is removed for release builds 2019-09-19 11:27:04 -05:00
Nate Weaver 180cc39904 Negate MAC_APP_STORE
Oops. (Was un-negated for testing.)
2019-09-19 11:19:25 -05:00
Nate Weaver 4a0bbeacc2 Disable Web Inspector for App Store builds
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Ben Ubois 0b6683d073 Render with evaluateJavaScript.
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
Maurice Parker 20ecba1649 Add tooltip to Reader button 2019-09-18 20:40:58 -05:00
Maurice Parker 3b5a6f2576 Don't allow the article extraction button to toggle if it isn't working. 2019-09-18 20:03:01 -05:00
Maurice Parker 7ec3160273 Made article extractor button brighter 2019-09-18 19:45:22 -05:00
Maurice Parker 1da17fc5a9 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-09-18 19:24:14 -05:00
Kiel Gillard 9cc5fa3608 Initial implementation allowing Feedly accounts to be added given the Feedly user's consent. 2019-09-19 10:11:53 +10:00
Maurice Parker 8cd6f107e5 Add basic Article Content extraction 2019-09-18 18:15:55 -05:00
Maurice Parker 372fb06716 Implement different icons for each individual smartfeed 2019-09-17 20:26:49 -05:00
Maurice Parker 786a4e48c4 Merge branch 'mac-release' 2019-09-17 15:01:01 -05:00
Nate Weaver 93f7972441 Add some spacing around a comment 2019-09-17 13:58:45 -05:00
Nate Weaver 1e840f3090 Move WebKit "inspector starts attached" user default to AppDefaults 2019-09-17 13:42:18 -05:00
Nate Weaver 4a2724bcc4 Fix comment capitalization 2019-09-17 13:27:11 -05:00
Nate Weaver 0c89bc43c1 Use a bridging header for the Web Inspector API instead of KVC 2019-09-17 06:55:55 -05:00
Nate Weaver 4f405009f5 Use a selector instead of a block for the notification observation 2019-09-17 05:04:05 -05:00
Nate Weaver e39fa31bf7 Add a menu item to the Debug menu to enable the Web Inspector
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
Brent Simmons b075226685 Merge mac-release. 2019-09-16 22:32:08 -07:00
Brent Simmons 66d9333999 Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code. 2019-09-16 22:27:17 -07:00
Brent Simmons d16acfcca8 Merge branch 'mac-release' 2019-09-16 22:10:17 -07:00
Brent Simmons f7c9cc1dbd Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes. 2019-09-16 22:09:58 -07:00
Brent Simmons 1ece325112 Merge mac-release. 2019-09-16 20:09:04 -07:00
Brent Simmons a05fd61085 Merge branch 'imagecache' into mac-release 2019-09-16 20:07:31 -07:00
Brent Simmons a225d52ba3 Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView. 2019-09-16 20:01:30 -07:00
Brent Simmons 506b621e5d Draw the avatar background in TimelineAvatarView only if the icon is too short vertically. 2019-09-16 20:00:32 -07:00
Brent Simmons 2f9f4e263c Restore color for light avatar background. 2019-09-16 19:59:33 -07:00
Maurice Parker 444771dfae Merge branch 'mac-release' 2019-09-16 18:16:13 -05:00
Maurice Parker 1d7cbe5596 Fix super wide div's. Issue #1010 2019-09-16 18:12:56 -05:00
Maurice Parker 18d6a278c7 Merge branch 'mac-release' 2019-09-16 16:37:18 -05:00
Maurice Parker 0458fd3838 Delete avatar and favicon image caches every three days 2019-09-16 16:26:40 -05:00
Brent Simmons 8a2d1f5f6a Create TimelineAvatarView, which draws the background for images that need it. 2019-09-15 23:02:13 -07:00
Maurice Parker 8e939e9942 Change Credentials to be a struct instead of an enum 2019-09-15 10:03:47 -05:00
Phil Viso cc6767e0f6 Removed duplicate sort parameter change handling functions 2019-09-13 08:29:56 -05:00
Phil Viso 8a6e3c9f37 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
# Conflicts:
#	Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
Maurice Parker 5985b00480 Inject the Accounts folder name so that it can be in different locations between the iOS and Mac Apps. 2019-09-12 10:59:26 -05:00
Maurice Parker 57542592cb Correct which view should become the first responder. Issue #1014 2019-09-11 17:47:02 -05:00
Brent Simmons 3b501e9f4e Merge branch 'mac-release' 2019-09-10 20:28:42 -07:00
Brent Simmons 7ad0b6b604 Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923. 2019-09-10 20:28:16 -07:00
Maurice Parker 8dda681409 Add accessibility labels to Sidebar, Timeline, and Article. Issue #934 2019-09-10 11:09:17 -05:00
Phil Viso 045bc61684 Renamed Sort By menu item to Sort Articles By 2019-09-08 17:12:18 -05:00
Phil Viso 32d6678fdd Added group by feed menu item 2019-09-08 17:09:26 -05:00
Maurice Parker 0961753357
Merge pull request #998 from hisaac/mac-release
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
Isaac Halvorson 8b635fc04c Add command arrow key shortcuts to sidebar shortcuts plist 2019-09-08 12:54:26 -05:00
Maurice Parker e61efbe47a Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS 2019-09-08 09:43:51 -05:00
Brent Simmons 0d25f2331a Merge branch 'mac-release' 2019-09-06 19:28:31 -07:00
Brent Simmons 58c2fad2fd Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976. 2019-09-06 19:28:06 -07:00
Brent Simmons d39d7a0fe4 Merge branch 'mac-release' 2019-09-06 19:12:03 -07:00
Brent Simmons d49b212bc2 Delete unused EvergreenLarge.png. 2019-09-06 19:11:41 -07:00
Maurice Parker a4b01fda35 Merge branch 'mac-release' 2019-09-06 17:03:38 -05:00
Maurice Parker 0e7d971e65 Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995 2019-09-06 16:52:31 -05:00
Daniel Jalkut d79bbefeb8 mac-release targeted version of the fix for #989 2019-09-06 15:40:59 -04:00
Daniel Jalkut f3ce5116e7 Factor out the common build settings from Mac targets into a new shared xcconfig file, which includee the shared marketing version and bundle version for NetNewsWire and any extensions that may be built. 2019-09-06 14:52:03 -04:00
Maurice Parker 546917a866 Merge branch 'mac-release' 2019-09-06 08:38:58 -05:00
Daniel Jalkut 8e01e8e45a Instantiate an RSAppMovementMonitor to track user movement of the application while running. Fixes #897. 2019-09-06 09:13:09 -04:00
Maurice Parker 00b2756526 Merge branch 'mac-release' 2019-09-05 13:15:04 -05:00
Brian Warren ce3ec10c95 Enforcing automatic height for images in the template 2019-09-05 10:59:16 -07:00
Brent Simmons b4e5968025 Merge branch 'mac-release' 2019-09-04 21:33:08 -07:00
Brent Simmons f0d080b0be Remove blank line from near top of About window credits. 2019-09-04 21:04:21 -07:00
Brent Simmons 5ad307411d Bump version to 5.0.1d1 2019-09-04 21:00:59 -07:00
Maurice Parker da8250ac5a Merge branch 'mac-release' 2019-09-04 17:42:30 -05:00
Maurice Parker 7a8d23958b Restrict iframe width to be at most 100% 2019-09-04 17:41:58 -05:00
Maurice Parker dabb78cde4 Merge branch 'mac-release' 2019-09-04 17:20:37 -05:00
Thomas Pritchard d3ad4b52a3 Set a sensible line height for figure captions 2019-09-04 19:58:29 +01:00
Thomas Pritchard 5976923f23 Add figures to Mac detail stylesheet 2019-09-04 19:58:29 +01:00
Maurice Parker fa5840811a Change the view that gets made the first responder so that keyboard shortcuts work again 2019-09-04 03:12:50 -05:00
Maurice Parker 722d486018 Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app 2019-09-04 03:11:55 -05:00
Maurice Parker a59f223043 Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS 2019-09-04 02:40:35 -05:00
Brent Simmons 2ec55e6587 Merge branch 'mac-release' 2019-09-03 22:59:29 -07:00
Brent Simmons 0ba8f3b4e1 Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898. 2019-09-03 22:58:17 -07:00
Brent Simmons 0bfafc2da3 Merge branch 'mac-release' 2019-09-03 22:18:00 -07:00
Brent Simmons cbaad4bdeb Add checkbox to Preferences > General for turning off the unread count in the Dock. 2019-09-03 22:17:31 -07:00
Brent Simmons ed91776097 Merge branch 'mac-release' 2019-09-03 21:24:52 -07:00
Brent Simmons 5efbe6a4f0 Add NNW website link to top of About window text. 2019-09-03 21:24:17 -07:00
Jim Correia c8920ca5a6 Added optional separators in the timeline view.
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
Maurice Parker 1a9acdcc50 Remove TreeController from Delete command as it is no longer used there 2019-09-01 14:56:27 -05:00
Maurice Parker 6cf1e4539d Merge branch 'mac-release' 2019-09-01 10:51:22 -05:00
Jim Correia e7e77d362c Fix for bug #901 — first web view load flashes white in dark mode
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.

Instead, use a modification of the original solution used for iOS:

    - wrap the web view in a box with an appropriate background color
    - hide the web view at creation
    - show the web view after* the first load

This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.

[*] Showing the view immediately after the first load still causes the flash
    to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
    but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
Maurice Parker ecec048716 Merge branch 'mac-release' 2019-08-31 18:31:10 -05:00
Jim Correia cdfdc06142 Only enable "Open in Browser" when a single article is selected.
Fixes bug #921.
2019-08-31 16:02:21 -07:00
Maurice Parker 3baca1d7c0 Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire 2019-08-30 11:47:16 -05:00
Maurice Parker ea1f21797c Merge branch 'mac-release' 2019-08-30 11:28:16 -05:00
Kiel Gillard f27b7029de Explicity identify the addable account types, allowing for a contingent list given factors such as macOS API availability. 2019-08-30 15:17:25 +10:00
Brent Simmons 29efae42fd Update Apple events privacy statement to refer to article instead of news item. 2019-08-28 21:40:56 -07:00
Brent Simmons d468961d81 Update version and build number. 2019-08-28 21:40:21 -07:00