5 Commits

Author	SHA1	Message	Date
Brent Simmons	57af7526da	Revise Feedly tests to use MainThreadOperationQueue; get them building again. They don’t pass, but at least they build.	2020-01-15 22:10:06 -08:00
Tim Ekl	44e920b18b	Don't explicitly name error variables ... Following the resolution of #1512, start using the implicit `error` variable inside `catch` blocks instead of explicitly declaring `e` everywhere.	2020-01-02 13:31:06 -08:00
Tim Ekl	5ac18b14a7	Add missing expectations to send statuses tests ... f82be27666 flipped around calls to `selectPendingCount(_:)` so that it respected the new async nature of the method; however, it neglected to add enough XCTestExpectations to keep the test methods running through the callbacks. Add those here.	2020-01-01 13:39:17 -08:00
Tim Ekl	f82be27666	Resolve errors in Feedly statuses operation tests ... Add `error` parameters to completion blocks which now pass them. Assert these errors are always nil in the existing tests. Flip calls to `selectPendingCount()` so they are async, with a completion block that asserts about the results instead of asserting about the return value. Since the closure takes a Result, unwrap it in a do/catch block at each site; `XCTAssertNoThrow` doesn't help us bubble a value out from `Result.get()`, and I'd rather not use `try!` here. There might be a stylistic discussion to be had about this unwrapping, though.	2019-12-31 15:52:54 -06:00
Kiel Gillard	4f70cb6040	Improves test coverage in Feedly. Adds callbacks to SyncDatabase. Content is paged from Feedly. Unread status is set before articles are ingested.	2019-11-02 10:29:34 +11:00