Maurice Parker
c47480614c
Fix regression where marking all as unread wouldn't take you back to the sidebar
2021-04-12 21:09:34 -05:00
Maurice Parker
991297165b
Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993
2021-04-12 19:42:05 -05:00
Maurice Parker
c95daa208f
Add completion callbacks so that we can ensure that unreads have been marked before determining the next unread. Fixes #2993
2021-04-12 19:41:01 -05:00
Stuart Breckenridge
0fa30a9404
removes force unwrapping
2021-04-10 20:29:33 +08:00
Stuart Breckenridge
4e517a6db4
Disable Reader View
...
This commit:
- adds a `isFeedProvider: Bool` property to `WebFeed`
- if `isFeedProvider` is `true`, the article extractor is disabled on the inspector, hidden from the context menu, and the toolbar button is disabled. Additionally, if `isFeedProvider` is `true`, `isArticleExtractorAlwaysOn` returns `false` and cannot be set to `true`.
2021-04-09 07:47:14 +08:00
Maurice Parker
cc6449ed2a
Merge branch 'ios-candidate' into main
2021-04-03 11:10:04 -05:00
Maurice Parker
ea6cece955
Merge branch 'mac-release' into main
2021-04-03 09:30:42 -05:00
Maurice Parker
d2245b629b
Add locale to date formatter
2021-03-29 18:55:58 -05:00
Maurice Parker
ce0d5590f1
Send out an name change notification if the feed name changes. Fixes #2939
2021-03-29 18:55:46 -05:00
Maurice Parker
afbe25a26c
Add locale to date formatter
2021-03-29 18:53:49 -05:00
Maurice Parker
bfb6b3719e
Send out an name change notification if the feed name changes. Fixes #2939
2021-03-29 14:48:48 -05:00
Maurice Parker
022e4ae153
Fail when trying to add a feed that isn't parsable. Fixes #2921
2021-03-27 19:29:26 -05:00
Maurice Parker
c35dabbc55
Change so that we don't join with the articles table when finding starred or unread article ids. Fixes #2915
2021-03-27 19:27:23 -05:00
Maurice Parker
01682e3cfd
Fail when trying to add a feed that isn't parsable. Fixes #2921
2021-03-27 19:18:22 -05:00
Maurice Parker
e73b174473
Change so that we don't join with the articles table when finding starred or unread article ids. Fixes #2915
2021-03-27 19:12:30 -05:00
Maurice Parker
ab5421f533
Merge branch 'mac-release' into main
2021-03-27 17:21:49 -05:00
Maurice Parker
b5eff641d0
Change so that we don't validate and change unread counts for unread limit queries
2021-03-25 16:07:22 -05:00
Maurice Parker
34de76009b
Update to latest RSCore
2021-03-24 16:50:35 -05:00
Maurice Parker
064463e892
Update to the latest RSCore. Fixes #2914
2021-03-24 16:42:53 -05:00
Stuart Breckenridge
7f702abc8a
fixes build error
2021-03-24 20:06:48 +08:00
Maurice Parker
9c761c80df
Add an optional limit parameter to the smart feeds. Fixes #2627
2021-03-24 05:43:07 -05:00
Kiel Gillard 🤪
7e791a2e7d
Feedly API is no longer returning the feed values for deleted feeds, so make the response (which we ignore anyway), optional. Fixes #2897
2021-03-23 10:17:59 -05:00
Kiel Gillard 🤪
488c4f42ef
Feedly API is no longer returning the feed values for deleted feeds, so make the response (which we ignore anyway), optional. Fixes #2897
2021-03-23 17:06:42 +11:00
Maurice Parker
b71c962684
Add the feed even if we can't find a viable feed in a page that the FeedFinder selected. Fixes #2888
2021-03-19 11:13:26 -05:00
Maurice Parker
81c0422205
Add a webfeed even if we couldn't find it using the FeedFinder. Fixes #2888
2021-03-15 19:56:05 -05:00
Maurice Parker
52f11ff538
Add validateFeed parameter to createWebFeed
2021-03-15 18:01:12 -05:00
Maurice Parker
5fd4dae3e6
Remove batch update commands that were interfering with the Sidebar getting rebuilt
2021-03-15 17:49:33 -05:00
Rene Hexel
45d26bee12
Update Account/Sources/Account/Feedly/FeedlyAccountDelegateError.swift
...
Reword slightly as per review.
Co-authored-by: Jed Fox <git@jedfox.com>
2021-03-14 06:01:37 +10:00
Rene Hexel
8e10d45903
Provide additional help to users with persistent Feedly authorization issues.
2021-03-13 06:54:06 +10:00
Maurice Parker
7297fddec9
Reduce block size to reduce the number of times CloudKit has to tell us to split our number of records
2021-03-11 19:24:06 -06:00
Maurice Parker
7a17c1e8aa
Validate server data before accessing it using a subscript. Fixes #2861
2021-03-09 04:48:03 -06:00
Maurice Parker
3132a2c779
Validate server data before accessing it using a subscript. Fixes #2861
2021-03-09 04:47:15 -06:00
Maurice Parker
64e5a09ac6
Return to main queue after getting notified of the dispatch group completion. Fixes #2863
2021-03-09 04:24:55 -06:00
Maurice Parker
2dd475e71d
Return to main queue after getting notified of the dispatch group completion. Fixes #2863
2021-03-09 04:23:19 -06:00
Maurice Parker
bb99e6f69c
Simplify the compression logic
2021-02-24 15:34:05 -06:00
Maurice Parker
8a9a9910cc
Simplify the compression logic
2021-02-24 15:33:24 -06:00
Maurice Parker
42930371b8
Compress html and text content
2021-02-24 15:15:08 -06:00
Maurice Parker
a51bcc2f0e
Compress html and text content
2021-02-24 15:14:38 -06:00
Fábio Oliveira
d05594dafb
Fix Unit Tests
...
- Adopt new fields from SecretsProvider in FeedlyTestSecrets
-Fix call to Account init that was expecting an optional
- Linked `Articles` and `RSCore` libraries to the Unit Tests target
- Small change to order of imports for consistency
2021-02-24 01:13:47 +01:00
Maurice Parker
e3d51635b8
Modify CloudKit add logic so that we don't wait to sync the statuses before completing the process. Fixes #2827
2021-02-23 18:00:15 -06:00
Maurice Parker
145161ed8a
Modify CloudKit add logic so that we don't wait to sync the statuses before completing the process. Fixes #2827
2021-02-23 17:59:19 -06:00
Maurice Parker
828ca7ed2a
Correctly clear the progress bar when a feed provider isn't able to find a feed
2021-02-13 16:25:55 -06:00
Maurice Parker
b47a1fac61
Correctly clear the progress bar when a feed provider isn't able to find a feed
2021-02-13 16:25:17 -06:00
Maurice Parker
b9b68bb48c
Correctly clear the progress bar for not found feeds and already subscribed feeds
2021-02-13 16:15:17 -06:00
Maurice Parker
e36e4ac5bc
Correctly clear the progress bar for not found feeds and already subscribed feeds
2021-02-13 16:14:44 -06:00
Maurice Parker
00c947fd05
Merge pull request #2790 from stuartbreckenridge/future-proofing
...
: class changed to : AnyObject for protocols
2021-02-10 16:38:12 -06:00
Maurice Parker
c063880c48
Upgraded to production releases of RS libraries
2021-02-10 16:19:26 -06:00
Maurice Parker
9b35e4a6b1
Update to the latest RSCore
2021-02-08 13:08:02 -06:00
Maurice Parker
91ce7ff189
Update to the latest RSCore
2021-02-07 20:26:30 -06:00
Stuart Breckenridge
1e578828e9
: class chnaged to : AnyObject for protocols
2021-02-06 07:06:45 +08:00
Maurice Parker
c61ae997e2
Fix completed task count so that the progress bar clears when a feed is unparsable
2021-02-01 18:02:31 -06:00
Maurice Parker
21d1a32597
Delete unused code
2021-02-01 14:26:19 -06:00
Maurice Parker
bc7341ec80
Don't clear progress when an error happens because it might be part of a folder move. Fixes #2764
2021-01-26 18:02:09 -06:00
Maurice Parker
50ebfbe51c
Return correct error message for failed feed adds. Fixes #2759
2021-01-24 12:59:42 -06:00
Maurice Parker
38640b9245
Exclude Inoreader tags when syncing folders/tags. Fixes #2762
2021-01-24 12:40:15 -06:00
Maurice Parker
ff90751127
Delete dead code
2021-01-22 17:10:37 -06:00
Maurice Parker
8503582308
Clear conditional get and do full downloads of feeds that are restored. Fixes #2747
2021-01-19 20:56:59 -06:00
Maurice Parker
2c65d3c296
Escape plus sign for post http body. Fixes #2736
2021-01-19 15:00:25 -06:00
Maurice Parker
653279d0f9
Rename file since it isn't an RSWeb extension
2021-01-19 11:26:52 -06:00
Maurice Parker
4510ca8287
Handle scenario where all feeds are in folders and they all need to be removed from the account. Fixes #2741
2021-01-18 19:07:35 -06:00
Maurice Parker
6b0bdf8ca0
Only send statuses on quit and have a 2 second timeout. Fixes #2726
2021-01-18 17:48:07 -06:00
Maurice Parker
de93658fc2
Merge pull request #2731 from jbennett/2545-fw-better-status-refresh
...
Retrieving the unread and starred items should only return the item id
2021-01-18 15:46:28 -06:00
Jonathan Bennett
a66759a065
DRY up feed id code
...
only the filter really changes
2021-01-14 11:03:16 -05:00
Jonathan Bennett
86541d4e32
remove unused functions
2021-01-14 11:03:08 -05:00
Jonathan Bennett
e36edf47d4
only retrieve the feed IDs
...
WIP fix for #2545
2021-01-14 11:02:46 -05:00
Jonathan Bennett
5b80eb742c
add support for restoring webfeeds
2021-01-14 00:50:48 -05:00
Maurice Parker
9db9489caa
Return the screen name as the avatar when the url is www.twitter.com
2021-01-08 11:44:20 -06:00
Maurice Parker
fb6e51124f
Made internal packages dynamic and removed Asset catalog from the share extension. Fixes #2680
2020-12-21 10:55:00 -06:00
Maurice Parker
2c5cd72f09
Hardcode the twitter icon path for Mentions and Searches since we can't download it from the homepage. Fixes #2678
2020-12-19 11:12:25 -06:00
Maurice Parker
614f0412a1
Change Reddit to ignore timeouts as errors
2020-12-19 02:01:42 -06:00
Maurice Parker
110d68e4b2
Change CloudKit error handling so that we still try to sync, even if we get some feed errors.
2020-12-18 16:13:26 -06:00
Maurice Parker
e66cc89ed7
Enhance Reddit error to have better instructions and include the original error text.
2020-12-18 16:12:49 -06:00
Maurice Parker
d40d695d69
Stop processing the send status records if we don't have anymore in a valid state yet.
2020-12-16 10:26:25 -06:00
Maurice Parker
25a9731996
Enhance Feed Provider error handling. Fixes #2672
2020-12-15 21:39:19 -06:00
Maurice Parker
38f56f66b4
Change fix for CloudKit crashing bug in case this was causing syncing problems
2020-12-15 11:21:18 -06:00
Maurice Parker
bcd4d4e076
Fix crashing bug that can happen if a CloudKit record gets into an invalid state.
2020-12-13 12:01:55 -06:00
Maurice Parker
b0ae2255d1
Ensure that database status inserts are complete before continuing processing.
2020-12-10 17:38:57 -06:00
Maurice Parker
ea407fd8da
Ensure that database status inserts are complete before continuing processing. Fixes #2659
2020-12-10 17:28:19 -06:00
Maurice Parker
9790b7840d
Make sure we call the completion if we need to exit early.
2020-12-10 17:22:25 -06:00
Maurice Parker
fce8070ae7
Enhanced error handling.
2020-12-10 17:12:04 -06:00
Maurice Parker
2fbbdce46c
Don't use the SINCE parameter except for the main Twitter timeline to help with missing Tweets.
2020-12-10 15:44:54 -06:00
Maurice Parker
f5c0a29650
Restrict types of accounts that can be added based on Developer build flag. Issue #2663
2020-12-10 14:21:22 -06:00
Maurice Parker
08e772cbd1
Move account to feed sync outside of folder to feed sync since it was stripping feeds before they had a chance to get used.
2020-12-09 16:27:52 -06:00
Maurice Parker
c150d19b4e
Fix so that feeds won't get added locally when CloudKit errors and allow the removal of corrupted Feeds when found.
2020-12-08 13:28:50 -06:00
Maurice Parker
9ee16d3534
Don't use a back ground queue for doing dictionary lookups. Fixes #2656
2020-12-08 00:48:24 -06:00
Anh Do
a8f8e5f955
Remove refreshStories from refreshAll process
2020-11-29 22:23:57 -05:00
Maurice Parker
970e68da35
Remove extraneous complete task functions that were throwing off the progress indicator. Fixes #2543
2020-11-20 16:00:31 -06:00
Maurice Parker
1c23f02803
Move common CloudKit classes to RSCore
2020-11-20 10:17:40 -06:00
Maurice Parker
8db9f073bc
Remove Reddit's custom external_url handling
2020-11-20 02:34:41 -06:00
Jonathan Bennett
c594878cf5
Throw an error if encoding fails
2020-11-12 23:09:36 -05:00
Jonathan Bennett
21c2787f90
Handle +’s in the query items
...
+’s in query items can be treated as spaces by services. We want to encode them properly (via URLComponents.enhancedPercentEncodedQuery)
This private entension might be worth moving into RSWeb.
Fixes #2544
2020-11-12 03:44:54 -05:00
Jonathan Bennett
3bb61ea6c6
Mark lastArticleFetchEndTime for article fetch
...
Fixes #2557
2020-11-11 21:31:59 -05:00
Maurice Parker
153e2dd006
Add special handling for plus sign when encoding URL query parameters. Fixes #2542
2020-11-08 12:17:21 -06:00
Maurice Parker
1a3d2987f0
Back date the Feedbin since parameter to pick up updates done within 24 hours of the original post. Fixes #2549
2020-11-05 11:36:20 -06:00
Maurice Parker
38dbfa6f4a
Correct found order merge
2020-11-01 20:46:56 -06:00
Maurice Parker
aa73b24291
Take order on the page into consideration when searching for the best feed identifier
2020-11-01 20:31:53 -06:00
Maurice Parker
7c4c2de7a0
Make folder restores work for Reader API
2020-11-01 14:15:44 -06:00
Maurice Parker
2229811df0
Encode names so that the plus sign will work when renaming folders and feeds
2020-11-01 11:35:26 -06:00
Maurice Parker
bf534d979c
Update externalID for the folder when changing its name
2020-11-01 10:55:07 -06:00
Maurice Parker
ea1537118c
Change the number of articles we retrieve to 150
2020-10-31 21:02:49 -05:00