Commit Graph

1132 Commits

Author SHA1 Message Date
Maurice Parker 7d8feba24b Remove file coordinator usage from account files. Issue #1821 2020-03-03 11:39:04 -08:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker 2ae021960b Move account files to the documents directory and out of the shared container. Issue #1784 2020-02-12 16:21:48 -08:00
Nate Weaver 4ac8107f27 Don't unwrap now-non-optionals, and unwrap now-explicit optionals 2020-02-08 18:22:35 -06:00
Brent Simmons c679d92e09 Make the Feedly tests build again — fix references to addOperation. 2020-02-05 22:37:43 -08:00
Brent Simmons 01fc60916e Move the operation queue from Account to ArticlesDatabase, which is the rightful owner. 2020-02-05 22:17:32 -08:00
Brent Simmons d40eaed1f5 Begin moving the MainThreadOperationQueue from Account to ArticlesDatabase. 2020-02-05 21:23:23 -08:00
Brent Simmons 2d33de1205 Fix references to addOperation, which is now just add. 2020-02-05 21:18:29 -08:00
Maurice Parker 2017a2138f Change to only send the unread counts init notification once during program load. Issue #1772 2020-02-03 10:28:34 -08:00
Brent Simmons 0b2ec6473a Call the correct fetchUnreadCounts methd. 2020-02-01 15:16:24 -08:00
Brent Simmons 3f4c84e442 Use the new FetchUnreadCountsForFeedsOperation. 2020-02-01 15:01:47 -08:00
Brent Simmons 9628b3021b Create FetchUnreadCountsForFeedsOperation. 2020-02-01 15:00:59 -08:00
Brent Simmons 30cf8c6a08 Add, as a micro-optimization, a custom hash function for FeedIdentifier. 2020-02-01 15:00:36 -08:00
Kiel Gillard b87882a919 Log failures attempting to add new feeds to a Feedly account to help debug #1691 2020-01-31 17:00:30 +11:00
Kiel Gillard e5e7163f8e Improve the test coverage and add some documentation. 2020-01-31 07:55:50 +11:00
Kiel Gillard a339b05bf8 Santizes right to left div elements from Feedly content. 2020-01-31 07:55:50 +11:00
Brent Simmons dc4850b777 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-29 23:09:44 -08:00
Brent Simmons 35adaa7a8c Fetch the unread count for just one feed when that’s all that’s needed. Helps performance. 2020-01-29 23:09:38 -08:00
Brent Simmons 99fcfbfef5 Create FetchFeedUnreadCountOperation to fetch the unread count for a single feed. 2020-01-29 22:47:01 -08:00
Brent Simmons 26efb8895c Close the resultSet in FetchAllUnreadCountsOperation. 2020-01-29 22:45:55 -08:00
Maurice Parker b53cbfcf2c Make sure completion handler is called when there are no active accounts. Issue #1727 2020-01-28 16:24:35 -07:00
Brent Simmons dc9243dcc7 Make fetching all unread counts an operation. Cancel it when the account is suspending. Turning things like this into operations goes to fixing the dreaded 0xdead10cc crashes. 2020-01-27 23:00:48 -08:00
Nate Weaver b9bba7b614 Update RSWeb 2020-01-27 23:02:01 -06:00
Brent Simmons e61d2620de Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-27 19:55:14 -08:00
Brent Simmons 5d38e79f38 Add FetchAllUnreadCountsOperation. Not using it yet, but we will be. 2020-01-27 19:55:10 -08:00
Maurice Parker 118ecd01b0 Fix option set bug in AccountBehaviors. 2020-01-27 20:05:07 -07:00
Brent Simmons 61ccf6fa1f Replace use of Dictionary(uniqueKeysWithValues) with a separate function that can handle duplicate keys without crashing. Fix #1671. 2020-01-21 22:03:33 -08:00
Kiel Gillard fb69a2bc54 Fix the logging of Feedly errors. #1628. 2020-01-21 18:31:41 +11:00
Brent Simmons bca3c4216c Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-19 22:25:13 -08:00
Brent Simmons 70b57b9d4d Disable files with failing Feedly tests. This is meant to be temporary. 2020-01-19 22:25:06 -08:00
Brent Simmons f9f4d70868 Make Feedly tests build again. 2020-01-19 22:19:54 -08:00
Maurice Parker 531c40a059 Escape special XML characters for external folder id. Issue #1659 2020-01-19 22:52:45 -07:00
Brent Simmons f76385ce64 Merge branch 'ios-candidate' of https://github.com/Ranchero-Software/NetNewsWire into ios-candidate 2020-01-19 16:55:46 -08:00
Brent Simmons a2bcdb1cfd Fix the progress indicator bug I had introduced in working on FeedlyOperation. Make sure FeedlyOperation calls downloadProgress.completeTask(), and make sure that all paths lead there. 2020-01-19 16:55:39 -08:00
Maurice Parker 53ba0bc9ac Fix so that Feedbin correctly stores the perma link in the correct field. 2020-01-19 17:15:21 -07:00
Brent Simmons 6181f416a4 Revise FeedlyOperation to work with MainThreadOperation properly. We’re still using inheritance — FeedlyOperation is a base class. I tried and failed to come up with a better solution. Everything other solution resulted in a lot of boilerplate code being replicated. 2020-01-19 14:19:06 -08:00
Nate Weaver 7ee1f99962 Updates for Data+RSCore changes 2020-01-18 19:18:58 -06:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Kiel Gillard 912a3acb35 Subscribing to a Feedly feed only downloads the first page worth of content, not each and every page. Maybe related to #1408. 2020-01-17 17:16:52 +11:00
Brent Simmons e2e9a66bc5
Merge pull request #1635 from kielgillard/ios-candidate
Let Feedly users add to the uncategorized collection/folder.
2020-01-16 22:01:47 -08:00
Kiel Gillard 02cfc384c4 Makes the Feedly models immutable because they are used to represent API responses only and it improves a developer's ability to reason about how they're used in the codebase. Fixes #1629. 2020-01-17 16:47:21 +11:00
Kiel Gillard c18575ea85 Let Feedly users add to the uncategorized collection/folder. 2020-01-17 15:25:57 +11:00
Maurice Parker fb8d77fff1
Merge pull request #1631 from kielgillard/feedly-fix-tests-post-operations-surgery
Fix test failures by cancelling operations with the queue.
2020-01-16 13:45:36 -08:00
Kiel Gillard f14ba07740 Fix test failures by cancelling operations with the queue. It seems operations no longer can cancel themselves. 2020-01-17 08:27:20 +11:00
Maurice Parker 4f36ec3b11 Add Update Credetials button to the error dialog when a Feedbin credentials error happens. Issue #1441 2020-01-16 13:50:30 -07:00
Maurice Parker 61b788a1de Provide user friendly account error for 403 status code (FORBIDDEN) 2020-01-16 12:17:47 -07:00
Brent Simmons 80542bee12 Add missing calls to super.run() in FeedlyOperation subclasses. 2020-01-15 22:51:00 -08:00
Brent Simmons 57af7526da Revise Feedly tests to use MainThreadOperationQueue; get them building again. They don’t pass, but at least they build. 2020-01-15 22:10:06 -08:00
Brent Simmons 39db00c022 Use MainThreadOperationQueue with Feedly syncing. 2020-01-15 21:30:37 -08:00
Nate Weaver 6eac3781ba Update to latest RSCore
Update use of OMPLString().
2020-01-13 22:20:57 -06:00