Commit Graph

222 Commits

Author SHA1 Message Date
Maurice Parker
bc7341ec80 Don't clear progress when an error happens because it might be part of a folder move. Fixes #2764 2021-01-26 18:02:09 -06:00
Maurice Parker
50ebfbe51c Return correct error message for failed feed adds. Fixes #2759 2021-01-24 12:59:42 -06:00
Maurice Parker
38640b9245 Exclude Inoreader tags when syncing folders/tags. Fixes #2762 2021-01-24 12:40:15 -06:00
Maurice Parker
ff90751127 Delete dead code 2021-01-22 17:10:37 -06:00
Maurice Parker
8503582308 Clear conditional get and do full downloads of feeds that are restored. Fixes #2747 2021-01-19 20:56:59 -06:00
Maurice Parker
2c65d3c296 Escape plus sign for post http body. Fixes #2736 2021-01-19 15:00:25 -06:00
Maurice Parker
653279d0f9 Rename file since it isn't an RSWeb extension 2021-01-19 11:26:52 -06:00
Maurice Parker
4510ca8287 Handle scenario where all feeds are in folders and they all need to be removed from the account. Fixes #2741 2021-01-18 19:07:35 -06:00
Maurice Parker
6b0bdf8ca0 Only send statuses on quit and have a 2 second timeout. Fixes #2726 2021-01-18 17:48:07 -06:00
Maurice Parker
de93658fc2
Merge pull request #2731 from jbennett/2545-fw-better-status-refresh
Retrieving the unread and starred items should only return the item id
2021-01-18 15:46:28 -06:00
Jonathan Bennett
a66759a065 DRY up feed id code
only the filter really changes
2021-01-14 11:03:16 -05:00
Jonathan Bennett
86541d4e32 remove unused functions 2021-01-14 11:03:08 -05:00
Jonathan Bennett
e36edf47d4 only retrieve the feed IDs
WIP fix for #2545
2021-01-14 11:02:46 -05:00
Jonathan Bennett
5b80eb742c add support for restoring webfeeds 2021-01-14 00:50:48 -05:00
Maurice Parker
9db9489caa Return the screen name as the avatar when the url is www.twitter.com 2021-01-08 11:44:20 -06:00
Maurice Parker
fb6e51124f Made internal packages dynamic and removed Asset catalog from the share extension. Fixes #2680 2020-12-21 10:55:00 -06:00
Maurice Parker
2c5cd72f09 Hardcode the twitter icon path for Mentions and Searches since we can't download it from the homepage. Fixes #2678 2020-12-19 11:12:25 -06:00
Maurice Parker
614f0412a1 Change Reddit to ignore timeouts as errors 2020-12-19 02:01:42 -06:00
Maurice Parker
110d68e4b2 Change CloudKit error handling so that we still try to sync, even if we get some feed errors. 2020-12-18 16:13:26 -06:00
Maurice Parker
e66cc89ed7 Enhance Reddit error to have better instructions and include the original error text. 2020-12-18 16:12:49 -06:00
Maurice Parker
d40d695d69 Stop processing the send status records if we don't have anymore in a valid state yet. 2020-12-16 10:26:25 -06:00
Maurice Parker
25a9731996 Enhance Feed Provider error handling. Fixes #2672 2020-12-15 21:39:19 -06:00
Maurice Parker
38f56f66b4 Change fix for CloudKit crashing bug in case this was causing syncing problems 2020-12-15 11:21:18 -06:00
Maurice Parker
bcd4d4e076 Fix crashing bug that can happen if a CloudKit record gets into an invalid state. 2020-12-13 12:01:55 -06:00
Maurice Parker
b0ae2255d1 Ensure that database status inserts are complete before continuing processing. 2020-12-10 17:38:57 -06:00
Maurice Parker
ea407fd8da Ensure that database status inserts are complete before continuing processing. Fixes #2659 2020-12-10 17:28:19 -06:00
Maurice Parker
9790b7840d Make sure we call the completion if we need to exit early. 2020-12-10 17:22:25 -06:00
Maurice Parker
fce8070ae7 Enhanced error handling. 2020-12-10 17:12:04 -06:00
Maurice Parker
2fbbdce46c Don't use the SINCE parameter except for the main Twitter timeline to help with missing Tweets. 2020-12-10 15:44:54 -06:00
Maurice Parker
f5c0a29650 Restrict types of accounts that can be added based on Developer build flag. Issue #2663 2020-12-10 14:21:22 -06:00
Maurice Parker
08e772cbd1 Move account to feed sync outside of folder to feed sync since it was stripping feeds before they had a chance to get used. 2020-12-09 16:27:52 -06:00
Maurice Parker
c150d19b4e Fix so that feeds won't get added locally when CloudKit errors and allow the removal of corrupted Feeds when found. 2020-12-08 13:28:50 -06:00
Maurice Parker
9ee16d3534 Don't use a back ground queue for doing dictionary lookups. Fixes #2656 2020-12-08 00:48:24 -06:00
Anh Do
a8f8e5f955
Remove refreshStories from refreshAll process 2020-11-29 22:23:57 -05:00
Maurice Parker
970e68da35 Remove extraneous complete task functions that were throwing off the progress indicator. Fixes #2543 2020-11-20 16:00:31 -06:00
Maurice Parker
1c23f02803 Move common CloudKit classes to RSCore 2020-11-20 10:17:40 -06:00
Maurice Parker
8db9f073bc Remove Reddit's custom external_url handling 2020-11-20 02:34:41 -06:00
Jonathan Bennett
c594878cf5 Throw an error if encoding fails 2020-11-12 23:09:36 -05:00
Jonathan Bennett
21c2787f90 Handle +’s in the query items
+’s in query items can be treated as spaces by services. We want to encode them properly (via URLComponents.enhancedPercentEncodedQuery)

This private entension might be worth moving into RSWeb.

Fixes #2544
2020-11-12 03:44:54 -05:00
Jonathan Bennett
3bb61ea6c6 Mark lastArticleFetchEndTime for article fetch
Fixes #2557
2020-11-11 21:31:59 -05:00
Maurice Parker
153e2dd006 Add special handling for plus sign when encoding URL query parameters. Fixes #2542 2020-11-08 12:17:21 -06:00
Maurice Parker
1a3d2987f0 Back date the Feedbin since parameter to pick up updates done within 24 hours of the original post. Fixes #2549 2020-11-05 11:36:20 -06:00
Maurice Parker
38dbfa6f4a Correct found order merge 2020-11-01 20:46:56 -06:00
Maurice Parker
aa73b24291 Take order on the page into consideration when searching for the best feed identifier 2020-11-01 20:31:53 -06:00
Maurice Parker
7c4c2de7a0 Make folder restores work for Reader API 2020-11-01 14:15:44 -06:00
Maurice Parker
2229811df0 Encode names so that the plus sign will work when renaming folders and feeds 2020-11-01 11:35:26 -06:00
Maurice Parker
bf534d979c Update externalID for the folder when changing its name 2020-11-01 10:55:07 -06:00
Maurice Parker
ea1537118c Change the number of articles we retrieve to 150 2020-10-31 21:02:49 -05:00
Maurice Parker
100a596d02 Make sure all the read and starred statuses are recorded before retrieving the missing articles 2020-10-31 21:01:58 -05:00
Maurice Parker
cbb481c3f7 Don't allow a feed to be in more than one folder for Reader API accounts 2020-10-31 17:26:43 -05:00
Maurice Parker
51d74eaf45 Fix which feeds get removed from the root folder during sync 2020-10-31 13:35:01 -05:00
Maurice Parker
2d2814e1db Change how we identify folders so that it works with more services 2020-10-31 13:20:14 -05:00
Maurice Parker
1c67cbb6f4 Fix refresh progress indicator for Reader API 2020-10-31 13:04:49 -05:00
Maurice Parker
295bca326a Combine all account sync changes into a single batch update to prevent the sidebar from jumping around 2020-10-31 12:52:15 -05:00
Maurice Parker
1760d38777 Rewrite folder management for Reader API 2020-10-31 12:47:12 -05:00
Maurice Parker
04b1667293 Merge branch 'mac-release' into main 2020-10-31 10:25:11 -05:00
Maurice Parker
7361c71d2b Don't allow zooming on animated gifs because zooming doesn't support them 2020-10-30 19:07:32 -05:00
Maurice Parker
6f42628428 Treat animated gifs different from regular video 2020-10-30 17:09:01 -05:00
Maurice Parker
5338cd88fe Automatically loop and play Twitter animated gifs without video controls 2020-10-30 16:43:32 -05:00
Maurice Parker
549b35ffdf Clear webbed metadata when deleting an iCloud webfeed 2020-10-30 15:10:40 -05:00
Maurice Parker
ba03f0bc07 Adjust parameters to deal with Reddit's recent, stricter parameter checks 2020-10-30 14:29:08 -05:00
Maurice Parker
7c91a1df3a Change NetNewsWire News URL to use the XML version since some sync services don't understand JSON. 2020-10-29 17:52:58 -05:00
Maurice Parker
0499952b45 Rewrote the article syncing code to be more efficient and handle large datasets 2020-10-28 19:03:41 -05:00
Maurice Parker
aecf90f9f8 Don't chunk entries at the caller level because it is already done in the delegate 2020-10-28 16:16:15 -05:00
Maurice Parker
0d5b3ea48b Change the article fetch strategy so that we only fetch 200 at a time and continue fetching until we have them all 2020-10-26 19:56:01 -05:00
Maurice Parker
cc269a8089 Tweak item query parameters to be more correct 2020-10-26 16:59:12 -05:00
Maurice Parker
4f4301e780 Add continuation value to be used for paging 2020-10-26 11:26:15 -05:00
Maurice Parker
a8ca544345 Change to use enum value 2020-10-26 11:25:51 -05:00
Maurice Parker
a7b0ff8c89 Clear the progress when a feed isn't found. 2020-10-26 10:36:13 -05:00
Maurice Parker
54c9f64614 Fix status sending bug 2020-10-25 20:33:29 -05:00
Maurice Parker
6a0040ff7a Don't set the Feed URL because we determine that at runtime 2020-10-25 19:56:52 -05:00
Maurice Parker
01d352aa15 Change to use correct delegate errors. 2020-10-25 19:53:36 -05:00
Maurice Parker
7ed311ebba Make itemRefs an optional value since it isn't always returned by Inoreader 2020-10-25 19:52:19 -05:00
Maurice Parker
d0a9d64062 Fix entry fetching identifiers 2020-10-25 19:36:47 -05:00
Maurice Parker
63326e1f92 Filter out any recommended feeds that might be json 2020-10-25 18:06:51 -05:00
Maurice Parker
7e32c9f551 Correctly delete last feed in a folder. 2020-10-25 17:44:43 -05:00
Maurice Parker
f1ab7115b0 Fix initial article fetch after adding a feed. 2020-10-25 17:36:41 -05:00
Maurice Parker
3e82eb477b Add AppId and AppKey to quick add 2020-10-25 17:19:41 -05:00
Maurice Parker
c30daa382f Make remove folder code actually delete a server tag. 2020-10-25 17:15:24 -05:00
Maurice Parker
1b53b8778d Change how tags are determined so that it works with Inoreader 2020-10-25 16:55:28 -05:00
Maurice Parker
71c52993ce Clear any locally edited name when a server rename happens 2020-10-25 16:41:59 -05:00
Maurice Parker
7fe25dd1ec Make folders work for the old reader. 2020-10-25 16:40:06 -05:00
Maurice Parker
1c208cd4ba Accommodate The Old Reader's unusual item ids when syncing article status. 2020-10-25 16:10:10 -05:00
Maurice Parker
071af20304 Account for The Older Reader's different use of item id's 2020-10-25 15:50:57 -05:00
Maurice Parker
f7771fc509 Rework add feed process so that it is compatible with more services 2020-10-25 15:21:02 -05:00
Maurice Parker
cba900d4e4 Remove synchronous sync database status insert function. 2020-10-25 12:32:12 -05:00
Maurice Parker
45f5776b7e Fix BazQux feed adds since they we always deleting themselves. 2020-10-24 21:51:14 -05:00
Maurice Parker
7db18d2366 Remove unnecessary string creation 2020-10-24 21:39:15 -05:00
Maurice Parker
3e9f208dff Getting the feed URL from the feed ID if it isn't supplied. 2020-10-24 21:37:18 -05:00
Maurice Parker
a273398317 Don't force unwrap Stream ID 2020-10-24 21:25:20 -05:00
Maurice Parker
8af61ea6ad Add Inoreader AppID and Key compatibility 2020-10-24 21:25:00 -05:00
Maurice Parker
ecbd7d2f55 Enable adding accounts for the Reader API services. 2020-10-24 20:42:34 -05:00
Maurice Parker
1ab5323a43 Call completion handler when done updating statuses. 2020-10-24 20:40:06 -05:00
Maurice Parker
1917eb1007 Add various api base urls for Reader API 2020-10-24 19:38:47 -05:00
Maurice Parker
ec66c08f9a Make status marking asynchronous. 2020-10-24 17:17:46 -05:00
Maurice Parker
fa08b7d2e0 Prevent Twitter avatar image zooming on quoted Tweets. 2020-10-24 14:33:40 -05:00
Maurice Parker
bc2a475936 Add Inoreader, BazQux, and The Old Reader assets 2020-10-24 14:18:01 -05:00
Maurice Parker
7d940fed31 Use dedicated serial parsing queue instead of global queue to prevent unnecessary thread creation. 2020-10-23 12:52:03 -05:00
Maurice Parker
642eb1ae33 Formatting cleanup 2020-10-21 17:57:27 -05:00
Maurice Parker
4ad3da30e1 Show correct error for already subscribed error. 2020-10-21 14:57:54 -05:00
Maurice Parker
86edb9aa33 Add more network activity indication. Fixes #780 2020-10-21 14:28:19 -05:00
Maurice Parker
884a83f6ba Correct delete and restore of web feeds and folders for Reader API. Fixes #779 2020-10-20 19:19:10 -05:00
Maurice Parker
bab8a84df1 Check pending database while syncing to prevent statuses from shifting back. Fixes #1519 2020-10-20 18:22:53 -05:00
Maurice Parker
006d02a824 Fix since query parameter so that we don't pull all the data all the time. 2020-10-19 20:44:16 -05:00
Maurice Parker
a95484852e Force pull all the subscriptions if we don't recognize a folder name. Issue #1074 2020-10-19 19:32:56 -05:00
Maurice Parker
23ea156cc0 Fix the ReaderAPI so that it updates name and folder when creating a subscription 2020-10-19 16:20:55 -05:00
Maurice Parker
4284ea26c8 Merge branch 'mac-release' into main 2020-10-18 16:37:00 -05:00
Maurice Parker
97a762a450 Modify QoS to be different between iOS and macOS. 2020-10-09 22:01:04 -05:00
Maurice Parker
e4b27a27c5 Change so that we don't try to sync if the network is unavailable. Issue #2262 2020-10-06 19:42:34 -05:00
Maurice Parker
f8cef842c9 Change QoS for CloudKit to default to make sure it always runs. 2020-09-26 15:54:32 -05:00
Maurice Parker
26ce2af966 Change CloudKit operations to use a more appropriate QOS to improve UI responsiveness. 2020-09-15 16:19:57 -05:00
Maurice Parker
56d6bc91e3 Suffix .json on micro.blog feed finds that return a 404. Issue #329 2020-08-15 10:42:01 -05:00
Maurice Parker
b9ccd5aabb Make folder sort case insensitive. Issue #2201 2020-08-15 07:55:49 -05:00
Maurice Parker
139df9ad51 Initial support for Twitter lists 2020-08-14 19:31:54 -05:00
Maurice Parker
58f6a3e179 Update the Twitter User layout 2020-08-13 11:27:21 -05:00
Maurice Parker
ad48042e42 Use an operation queue to renew the Reddit access token so that we don't do it multiple times in a refresh cycle 2020-08-12 19:10:41 -05:00
Maurice Parker
01bab76cbb Change parsing dispatch queues to a more appropriate qos 2020-08-04 13:47:31 -05:00
Maurice Parker
482c18ac93 Update Account tests so that they work with Swift Packages and the most recent code changes 2020-08-04 12:43:29 -05:00
Maurice Parker
37cfccede6 Use simple module name for dependencies instead of the fully qualified version 2020-07-30 20:43:18 -05:00
Maurice Parker
b724658528 Refactor how we do Secrets to work with the new Swift Package structure 2020-07-30 17:40:45 -05:00
Maurice Parker
fa8b293ace Delete commented dependencies 2020-07-30 10:54:18 -05:00
Maurice Parker
66991a85e6 Convert Account into a Swift Package 2020-07-30 07:27:14 -05:00