cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
9c6d47eaa1
Merge branch 'pr/1033'
2019-09-20 17:51:27 -05:00
1bcc1eda44
Implement disallowing feeds in the root folder for specified accounts
2019-09-20 15:37:10 -05:00
af0d6c9022
Implement AccountBehaviors so that we don't have to keep adding boolean flags to account
2019-09-20 11:34:31 -05:00
567d762ea4
Fix button animation resets
2019-09-19 17:30:54 -05:00
76056e4fef
Add menu and keyboard shortcut to Reader
2019-09-19 17:25:36 -05:00
6a7d1df423
Change image references to use AppAsserts per our standard
2019-09-19 15:44:31 -05:00
d3a5bdf6d3
Merge branch 'mac-release'
2019-09-19 11:59:01 -05:00
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
0b6683d073
Render with evaluateJavaScript.
...
Replaced loadHTMLString based rendering for improved performance.
2019-09-18 22:03:23 -07:00
3b5a6f2576
Don't allow the article extraction button to toggle if it isn't working.
2019-09-18 20:03:01 -05:00
8cd6f107e5
Add basic Article Content extraction
2019-09-18 18:15:55 -05:00
786a4e48c4
Merge branch 'mac-release'
2019-09-17 15:01:01 -05:00
0c89bc43c1
Use a bridging header for the Web Inspector API instead of KVC
2019-09-17 06:55:55 -05:00
4f405009f5
Use a selector instead of a block for the notification observation
2019-09-17 05:04:05 -05:00
e39fa31bf7
Add a menu item to the Debug menu to enable the Web Inspector
...
Just enables the "Inspect Element" item in a WKWebView's contextual menu at the moment.
2019-09-17 05:04:05 -05:00
b075226685
Merge mac-release.
2019-09-16 22:32:08 -07:00
66d9333999
Make minor code formatting changes so that TimelineViewController matches our current thinking. Also delete some commented-out and unused code.
2019-09-16 22:27:17 -07:00
d16acfcca8
Merge branch 'mac-release'
2019-09-16 22:10:17 -07:00
f7c9cc1dbd
Remove no-longer needed machinery for updating the timeline on dark-mode/light-mode appearance changes.
2019-09-16 22:09:58 -07:00
1ece325112
Merge mac-release.
2019-09-16 20:09:04 -07:00
a05fd61085
Merge branch 'imagecache' into mac-release
2019-09-16 20:07:31 -07:00
a225d52ba3
Use the new TimelineAvatarView instead of an NSImageView in TimelineTableCellView.
2019-09-16 20:01:30 -07:00
506b621e5d
Draw the avatar background in TimelineAvatarView only if the icon is too short vertically.
2019-09-16 20:00:32 -07:00
444771dfae
Merge branch 'mac-release'
2019-09-16 18:16:13 -05:00
1d7cbe5596
Fix super wide div's. Issue #1010
2019-09-16 18:12:56 -05:00
8a2d1f5f6a
Create TimelineAvatarView, which draws the background for images that need it.
2019-09-15 23:02:13 -07:00
cc6767e0f6
Removed duplicate sort parameter change handling functions
2019-09-13 08:29:56 -05:00
8a6e3c9f37
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire into GroupArticlesByFeed
...
# Conflicts:
# Mac/MainWindow/Timeline/TimelineViewController.swift
2019-09-13 08:23:31 -05:00
57542592cb
Correct which view should become the first responder. Issue #1014
2019-09-11 17:47:02 -05:00
3b501e9f4e
Merge branch 'mac-release'
2019-09-10 20:28:42 -07:00
7ad0b6b604
Always update the unread count in the timeline after doing a sync fetch after representedObjects changes. Reload visible cells whenever showFeedNames changes. Fix #923 .
2019-09-10 20:28:16 -07:00
8dda681409
Add accessibility labels to Sidebar, Timeline, and Article. Issue #934
2019-09-10 11:09:17 -05:00
32d6678fdd
Added group by feed menu item
2019-09-08 17:09:26 -05:00
0961753357
Merge pull request #998 from hisaac/mac-release
...
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 13:02:58 -05:00
8b635fc04c
Add command arrow key shortcuts to sidebar shortcuts plist
2019-09-08 12:54:26 -05:00
e61efbe47a
Split AccountsDidChange notification into both add and delete notifications and automatically expanded new accounts on iOS
2019-09-08 09:43:51 -05:00
0d25f2331a
Merge branch 'mac-release'
2019-09-06 19:28:31 -07:00
58c2fad2fd
Stop blocking links containing the string “feedburner” — there are legitimate cases where that string appears. Fix #976 .
2019-09-06 19:28:06 -07:00
a4b01fda35
Merge branch 'mac-release'
2019-09-06 17:03:38 -05:00
0e7d971e65
Queue a reload of all visible cells anytime a favicon is downloaded. Issue #995
2019-09-06 16:52:31 -05:00
00b2756526
Merge branch 'mac-release'
2019-09-05 13:15:04 -05:00
ce3ec10c95
Enforcing automatic height for images in the template
2019-09-05 10:59:16 -07:00
da8250ac5a
Merge branch 'mac-release'
2019-09-04 17:42:30 -05:00
7a8d23958b
Restrict iframe width to be at most 100%
2019-09-04 17:41:58 -05:00
dabb78cde4
Merge branch 'mac-release'
2019-09-04 17:20:37 -05:00
d3ad4b52a3
Set a sensible line height for figure captions
2019-09-04 19:58:29 +01:00
5976923f23
Add figures to Mac detail stylesheet
2019-09-04 19:58:29 +01:00
fa5840811a
Change the view that gets made the first responder so that keyboard shortcuts work again
2019-09-04 03:12:50 -05:00
722d486018
Move keyboard config files to Shared location in repo as they will now be used in the iOS app as well as the Mac app
2019-09-04 03:11:55 -05:00
a59f223043
Moved FetchRequestOperation and FetchRequestQueue to Shared section of the repo since they are used by both Mac and iOS
2019-09-04 02:40:35 -05:00
2ec55e6587
Merge branch 'mac-release'
2019-09-03 22:59:29 -07:00
0ba8f3b4e1
Call the completion block once and only once from FetchRequestOperation. This is a probable fix for #898 .
2019-09-03 22:58:17 -07:00
ed91776097
Merge branch 'mac-release'
2019-09-03 21:24:52 -07:00
c8920ca5a6
Added optional separators in the timeline view.
...
The timeline now optionally includes "Mail style" separators (behind a
hidden default — "CorreiaSeparators" — which defaults to NO).
2019-09-02 09:13:21 -07:00
1a9acdcc50
Remove TreeController from Delete command as it is no longer used there
2019-09-01 14:56:27 -05:00
6cf1e4539d
Merge branch 'mac-release'
2019-09-01 10:51:22 -05:00
e7e77d362c
Fix for bug #901 — first web view load flashes white in dark mode
...
The fix used for iOS (keep a queue of preloaded web views) isn't appropriate
for macOS since the first view is used immediately. That approach would
solve the flash of white when first searching, but not the flash of white
when launching the application.
Instead, use a modification of the original solution used for iOS:
- wrap the web view in a box with an appropriate background color
- hide the web view at creation
- show the web view after* the first load
This doesn't suffer the latency problem that the same solution on iOS had
because the first load is always local, "No Selection" HTML.
[*] Showing the view immediately after the first load still causes the flash
to white. Waiting 0.05 seconds avoids this. That's a fairly terrible hack,
but I don't have a better solution at present.
2019-08-31 22:14:56 -07:00
ecec048716
Merge branch 'mac-release'
2019-08-31 18:31:10 -05:00
cdfdc06142
Only enable "Open in Browser" when a single article is selected.
...
Fixes bug #921 .
2019-08-31 16:02:21 -07:00
3c86bf0614
Merge pull request #871 from mbernson/master
...
Simplify sharing delegate logic
2019-08-27 11:13:00 -05:00
8de9b355c7
Merge branch 'mac-release'
2019-08-26 12:54:53 -05:00
1a3e2784ae
Optimize table cell reloading when feed images are made available
2019-08-26 12:54:23 -05:00
f8c01107d5
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-08-24 15:01:40 -05:00
ea55aa5bef
Leverage new avatarImage function from ArticleUtilities to reduce code duplication between macOS and iOS
2019-08-24 15:01:28 -05:00
ed56376d03
Merge branch 'mac-candidate'
2019-08-23 18:55:09 -07:00
3447ebcec0
Reload data after a batch update. Fix #872 .
2019-08-23 15:52:07 -07:00
9214e3d65e
Simplify sharing item subject logic
2019-08-23 13:05:20 +02:00
1ab0f7c25c
Merge mac-candidate.
2019-08-21 21:44:07 -07:00
849830f494
Refetch articles for smart feeds and folders, if selected, when a feed or folder is deleted. Fix #838 .
2019-08-21 21:41:56 -07:00
f513741ddb
Start work on filtering timeline so that articles from deleted feeds never show up.
2019-08-21 13:23:46 -07:00
7b3c08f521
Merge branch 'mac-candidate'
2019-08-13 21:07:59 -07:00
2bbd135c9e
Update appropriate counts in the sidebar when the timeline’s unread count changes. Fix #829 .
2019-08-13 21:07:39 -07:00
fc0fc2055e
Get the unread count from the timeline, instead of the database, only for the Today feed and only if it’s selected and it’s the only node selected.
2019-08-13 20:29:04 -07:00
cf1b3843ee
Add a SmartFeedType to smart feeds so the sidebar can tell them apart.
2019-08-13 20:28:28 -07:00
62258683c8
Add Ryan’s word-wrap change to mac-candidate.
2019-08-13 20:07:42 -07:00
6eb27abc13
Break long words or URLs to prevent horizontal overflow
2019-08-13 09:27:36 +09:00
c8f5a24b95
Use proper quotes in timeline contextual menu
2019-08-13 07:41:14 +09:00
34326863ea
Merge branch 'mac-candidate'
2019-07-28 16:01:12 -07:00
887f8e0b53
Check to see if the timeline already has the expected representedObjects when the sidebar selection (apparently) has changed. If so, then don’t set the representedObjects again, and don’t knock the user out of search mode if searching.
2019-07-28 16:00:43 -07:00
2fcadf9748
Merge branch 'mac-candidate'
2019-07-28 15:31:45 -07:00
2441de960f
Skip reloading the sidebar after the tree controller rebuilds when the rebuilt version is the same as the previous version. This saves some cycles, and it’s part of fixing #791 .
2019-07-28 15:31:17 -07:00
d8f1dcf23e
Merge branch 'mac-candidate'
2019-07-27 22:53:53 -07:00
44ec6a026d
Get the unread count from the timeline for the currently selected node in the sidebar. This ensures that transients in the timeline are accounted for. (The database query for the unread count wouldn’t necessarily match.)
2019-07-27 22:53:27 -07:00
05faea53c4
Remove reference to NSCalendarDayChanged — it’s no longer necessary to update the Today feed unread count when the day changes.
2019-07-27 19:52:05 -07:00
314fd970d1
Merge branch 'mac-candidate'
2019-07-27 19:49:46 -07:00
8acab45cf9
Make formatting changes to SidebarViewController.swift so it conforms to current formatting thinking.
2019-07-27 19:49:33 -07:00
58a7e1bc7d
Merge branch 'mac-candidate'
2019-07-27 15:44:34 -07:00
a41f7d8e68
Remove some unneeded drawing. This makes resizing the timeline faster.
2019-07-27 15:44:13 -07:00
125512f551
Merge branch 'mac-candidate'
2019-07-26 08:06:59 -05:00
8b0c8156df
Remove refresh at midnight for Today smartfeed
2019-07-26 08:06:08 -05:00
3999c7b3c5
Merge branch 'mac-candidate'
2019-07-05 22:42:01 -07:00
7a204ad6ed
Run database fetches async, in the timeline, when appropriate — for instance, when All Unread is selected and new articles come in.
2019-07-05 20:06:31 -07:00
5f045706e4
Removed usaged of UIApplication.present
2019-06-27 14:21:07 -05:00
74f84dc000
Restrict OPML import for Account types that don't support it
2019-06-19 17:50:32 -05:00
6f16a2715e
Skip downloading featured images, since we’re not displaying them anywhere.
2019-06-17 21:47:17 -07:00
40b9be6709
center smaller avatars on a solid color background image to make all avatars a consistent size
2019-06-14 15:33:13 -05:00
6527ac852c
Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752
2019-06-13 14:50:41 -05:00
93fbbd4cc3
Make sure that FeedFinder and InitialDownloader are running on the main thread.
2019-06-10 08:21:03 -05:00
45f6d8043a
Add ellipsis where needed in import/export OPML sheets. Fix #731 .
2019-06-09 20:18:10 -07:00
4a4fa6ed0e
Fix crashing bug by not using an NSFont as a key in a Swift dictionary. Fix #734 .
2019-06-09 16:03:08 -07:00
88b2775076
Make sure that an account doesn't try persist to the disk in the time that it is logically deleted and when it is actually deallocated
2019-05-31 08:05:26 -05:00
beacad1aeb
Validate folder drop to make sure no folders with the same name are already in the target account
2019-05-30 17:57:06 -05:00
a8f090656d
Handle when a feed in a folder being copied/moved already is subscribed in target account
2019-05-30 14:44:13 -05:00
30c21bb125
Enable folders to be dropped in a move or copy between accounts
2019-05-30 14:36:21 -05:00
1352dda8aa
Modify Feedbin feed deletes so that they emulate how the local account feed deletes work.
2019-05-30 10:12:34 -05:00
51284b5aa4
Rename deleteFeed to removeFeed to be more consistent with other API's
2019-05-29 21:04:44 -05:00
f4bc17c8f1
Refactor addFeed and removeFeed usages to be more consistent
2019-05-29 20:47:52 -05:00
5e3fcfd955
Correct how feeds were deleted so that only the feed in the correct container was deleted
2019-05-29 17:56:26 -05:00
bead6ae123
Remove now unnecessary call to account structureDidChange in drop
2019-05-29 17:14:50 -05:00
fa6b6a4769
Corrected move BatchUpdate usage to make move animation smoother
2019-05-29 17:08:41 -05:00
b1bd8d2d90
Enable folder dragging between accounts
2019-05-29 15:43:33 -05:00
8fc6e81ddf
Update the Today timeline and unread count when the day changes. Issue #627
2019-05-29 10:24:30 -05:00
0648053417
Enforce tag specific drop validation (can't copy to the account level)
2019-05-28 17:42:19 -05:00
83652c40de
Handle scenario where moved/copied feed already exists somewhere else in account
2019-05-28 16:46:16 -05:00
01d5a95241
Remove redundant private keyword usage
2019-05-28 16:31:03 -05:00
112702020b
Enable same account copying.
2019-05-28 13:11:29 -05:00
78c19bda43
Remove restriction on only moving and copying between local accounts.
2019-05-28 11:09:47 -05:00
b3c4c8de59
Correct how feeds were copied and moved between accounts to eliminate shared objects.
2019-05-28 10:59:06 -05:00
493abbb609
Refactor create feed functionality to increase code reuse and encapsulation
2019-05-28 09:45:02 -05:00
c7b61f7d87
Enable copy between local accounts.
2019-05-27 18:01:24 -05:00
659c9e5271
Allow dragged feeds between local accounts only
2019-05-27 15:11:16 -05:00
bfe41438fc
Make default exported OPML file name Subscriptions-[accountName].opml. Fix #683 .
2019-05-26 22:17:19 -07:00
9f6b2bc63f
Revise layout and add explanation for the import OPML choose-account sheet.
2019-05-26 16:29:46 -07:00
810e5b9aee
Tweak layout and add explanation text for OPML export sheet.
2019-05-26 16:12:38 -07:00
c422b4b82c
Merge branch 'master' of https://github.com/brentsimmons/NetNewsWire
2019-05-22 10:08:01 -05:00
43f8e9880c
Change to mark all as unread for the selected article feed. Issue #657
2019-05-22 10:07:00 -05:00
e05eb6e60c
Use == instead of === when comparing feeds in the sidebar — you might have duplicate feeds. (Duplicate feeds are totally allowed.)
2019-05-21 22:23:26 -07:00
98a262e34b
Update pseudo feed timeline when and account is deleted.
2019-05-21 16:47:32 -05:00
918eb746d5
Update pseudo feeds when account states change. Issues #645 , #663 , & #664 .
2019-05-21 16:36:47 -05:00
46cd477ee0
Make unread indicator white for selected and emphasized rows in timeline. Issue #655
2019-05-21 16:08:16 -05:00
4667035e61
Remember last OPML export account, suggest account name for OPML export file name, allow export of inactive accounts. Issue #659 & Issue #652
2019-05-21 15:15:26 -05:00
0da916fa68
Add Mark All as Read contextual menu item. Issue #657
2019-05-21 14:57:22 -05:00
af19b6dee0
Remember last selected account on OPML import. Issue #661
2019-05-21 14:56:41 -05:00
8816de4a0e
Fix issue where new Feeds added to a folder also got left in the account container.
2019-05-21 10:26:11 -05:00
fb33008b36
Remember account selection for Add Feed and Add Folder dialogs. Issue #651 & Issue #654
2019-05-21 09:36:33 -05:00
e6680a23b9
Make move animation smoother by wrapping in a BatchUpdate
2019-05-21 09:03:28 -05:00
3207ebf6a5
Implement default timeline avatar. Issue #641
2019-05-21 05:42:40 -05:00
74953601dd
Increase the duration of TimelineViewController’s database fetch queue from 0.5 to 2.0. This will still allow updates to appear in a timely way, but will help prevent fetching too often during a refresh.
2019-05-19 22:26:08 -07:00
4d27e5a338
Simplify representedObjectsContainsAnyPseudoFeed.
2019-05-19 20:49:24 -07:00
80e1888244
Rename AccountsDidChangeNotification to AccountsDidChange to match other notification names.
2019-05-19 15:51:08 -05:00
07ac60cec3
Remove showAddFolderWindow and showAddFeedWindow functions from MainWindowController so that validations will run on AppDelegate.
2019-05-19 15:27:58 -05:00
86578775e0
Move menu validations to the app delegate.
2019-05-19 10:21:42 -05:00
eb5c1a49f7
Disable adding a new folder if there are no active accounts
2019-05-19 09:14:40 -05:00
5ded56fc28
Fixed a crash that occurs when trying to add a new feed with no active accounts
2019-05-19 09:10:19 -05:00
e98d28c770
Show favicon in the timeline, even though they look weird because they’re small. They’re still better than nothing.
2019-05-18 12:21:35 -07:00
36c6c70ba2
Scale avatar images down — they might be up to twice as large as expected.
2019-05-17 23:02:48 -07:00
3d253ce6d9
Align avatars to top in timeline. Fix #643 .
2019-05-16 22:32:09 -07:00
b759237fc1
Fix issue where moving from account to folder and the network is unavailable caused feeds to be lost.
2019-05-16 11:19:44 -05:00
fb79309f95
Change import and export OPML so that they don't prompt to select an account if only one is active
2019-05-14 19:40:38 -05:00
51730d9b1c
Set scaling to .scaleNone in the avatar image view in the timeline, since we’re pre-scaling the images.
2019-05-13 22:23:06 -07:00
5abe73331a
Make TimelineTableView and TimelineTableRowView opaque in the interest of speeding up rendering during scrolling.
2019-05-13 21:42:47 -07:00
52b1ef2350
Place avatars on the left in the timeline.
2019-05-12 20:42:52 -07:00
6f92cd1a73
Refactor to differentiate between loading the Subscriptions.opml file and importing an external OPML file as they now need separate behaviors
2019-05-11 12:26:23 -05:00
fe70723eb4
Use best feed specifier code to determine which Feedbin option to use when creating a feed
2019-05-10 10:14:24 -05:00
23b43ecc07
Add undo for feeds
2019-05-09 16:09:21 -05:00
cda8acc66c
Add the ability to move feeds between folders for Feedbin
2019-05-09 13:31:18 -05:00
50d3a5799c
added subscription delete
2019-05-09 07:25:45 -05:00
06626f10a7
Add feed rename
2019-05-08 17:55:53 -05:00
43d32b1281
Add create Feedbin feed
2019-05-08 17:41:19 -05:00
7f9055fe78
Add download subscriptions and faviconURLs
2019-05-07 10:51:41 -05:00
b7e2df1a68
Add Folder rename for Feedbin
2019-05-06 10:53:20 -05:00
eb89ee7128
Expand new or newly active accounts so that they don't look broken
2019-05-02 06:45:56 -05:00
636468bbf0
Implement active account processing functionality
2019-05-02 06:01:30 -05:00
133398c240
Prevent dragging between accounts.
2019-05-01 17:49:25 -05:00
78e98e4c03
Make single non-local drops work with multiple accounts
2019-05-01 17:33:08 -05:00
73f035c5b7
Make OPML import and export respect multiple accounts
2019-05-01 16:04:56 -05:00
f5dbe7117e
Delete dead code
2019-05-01 14:56:26 -05:00
6ede5b7c3d
Enable add feed for multiple accounts
2019-05-01 14:03:59 -05:00
f4180424e1
Add multiple local accounts
2019-05-01 12:37:13 -05:00
4bc7611721
Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts
2019-05-01 05:53:18 -05:00
23c69a9223
Make RefreshInterval shared code
...
Back out inadvertent macOS changes
2019-04-23 08:47:58 -05:00
e81defb934
Implement detail next and prev article buttons.
2019-04-21 17:42:26 -05:00
c5a891234d
implement model controller pattern
2019-04-21 13:57:23 -05:00
b01b45cf9c
Renamed to DeleteCommand and implemented delete undo for iOS.
2019-04-18 08:54:48 -05:00
7083b5064b
Refactored the TreeDelegates to be shared code.
2019-04-18 04:56:15 -05:00
8526db8b4c
Added initial POC version of NetNewsWire for iOS to use as a starting point for the actual app.
2019-04-15 15:03:05 -05:00
6c8481d805
Work around WKWebView latency that happens when specifying baseURL. Instead, make it nil, and add a base href tag to the actual HTML.
2019-04-14 12:54:17 -07:00
70312aa75c
Major folder and project tree restructuring.
2019-04-13 16:18:54 -07:00
Ben Ubois
Maurice Parker
Nate Weaver
Brent Simmons
Phil Viso
Isaac Halvorson
Brian Warren
Thomas Pritchard
Jim Correia
Mathijs Bernson
Ryan Dotson