Commit Graph

191 Commits

Author SHA1 Message Date
Maurice Parker b69f936cb1 Change the Mark All As Read confirmation back to an Alert. Fixes #2968 2021-04-03 11:02:15 -05:00
Maurice Parker 3c2c17df0d Fix threading issue 2021-03-25 16:28:15 -05:00
Stuart Breckenridge 0a10544905
Fixes context menu logic
Prevents both a menu and action being attached to the `markAllAsRead` button. This caused issues on iPad where the popover would show instead of the menu. When the user changes the preference the toolbar is now rebuilt.

This commit also fixes the widget building on M1 where SwiftGen is available.
2021-02-04 08:19:35 +08:00
Stuart Breckenridge 6eba67c158
Adds context menus to mark all as read 2021-02-01 08:12:20 +08:00
Maurice Parker 5927c77a04 Convert iOS smart feed icons back to symbol images so that they show up as white when selected. 2020-12-06 16:01:43 -06:00
Maurice Parker a80fc871c4 Add separators to iOS context menus 2020-11-13 05:23:04 -06:00
Maurice Parker 0b170b7ff5 Merge branch 'ios-release' into main 2020-10-18 19:59:11 -05:00
Maurice Parker d1b8ac06af Ensure that the snapshot has items in it before testing section zero. 2020-10-17 20:06:53 -05:00
Maurice Parker e2de38647a Don't crash on early calls to update the toolbar 2020-08-09 20:13:37 -05:00
Maurice Parker a63466f7b3 Add and remove buttons instead of hiding them since our hiding trick doesn't work on iOS 14 2020-08-07 15:20:20 -05:00
Stuart Breckenridge f92b219cdc NetNewsWire-iOS AppDefaults is now a singleton 2020-07-02 10:47:45 +08:00
Maurice Parker 403b859c31 Verify that the section exists before accessing it so that we don't crash on the new SDK 2020-06-28 03:14:53 -05:00
Maurice Parker 95f6f80583 Merge branch 'ios-release' 2020-06-15 17:40:06 -05:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Stuart Breckenridge 98c8ea6d9f
disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Maurice Parker 7d8e49a2ee Merge branch 'ios-release' 2020-05-18 03:05:59 -05:00
Maurice Parker 7deac7f3c3
Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Stuart Breckenridge a9e8cec90e
Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5
Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee
move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e
adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge 58575331dd
Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker fda9be2e41 Update the progress bar when it comes into view so that it is always current 2020-05-10 10:00:04 -05:00
Maurice Parker 1778a270d6 Show byline in timeline for single feed timelines when available. 2020-04-18 07:53:56 -05:00
Brent Simmons 6d9eda442f Remove userDeleted support. The read-items filter seems to fill the need to hide things. We’re simplifying the backend by removing this unused feature. 2020-04-12 17:12:36 -07:00
Maurice Parker bd75df7294 Add pointer interaction for timeline header button. Issue #1943 2020-03-24 16:42:46 -05:00
Maurice Parker 97226f543b Assign keyboard shortcuts to filters and change clean up shortcut. Issue #1842 2020-03-22 10:18:07 -05:00
Maurice Parker 8a75defee9 Set row height when table is empty and set to automatic when articles are present. Issue #1919 2020-03-18 16:06:05 -05:00
Maurice Parker 1d26bc8c70
Revert "Set proper cell height for empty article array" 2020-03-18 15:55:33 -05:00
Flowinho 2ade0140bc Set proper cell height for empty article array
Contains work related to #1800

This one took me a while to figure out since they amount of articles is tied to the coordinator.

- Fixed violation of single responsibility principle inside “resetEstimatedRowHeight()” by removing the applicance of tableViewRowHeight and instead return the correctly calculated rowHeight.
- Removed prototype strings from inside the function to a static struct to be able to switch parameters for this function more easy (might be useful later / in testing). Function looks cleaner.

Greetings from southern germany!
2020-03-15 22:31:54 +01:00
Maurice Parker 833c336f2f Only show the timeline next read button when the root split view controller is collapsed. Issue #1822 2020-03-13 16:03:42 -05:00
Maurice Parker 9007ed4b06 Changed so that Feeds and Timeline clear read items if necessary on manual refresh commands. Issues #1834, #1856, and #1845 2020-03-11 14:47:00 -06:00
Maurice Parker 0e72811429 Implement mark as unread window for accounts that need it. Issue #1407 2020-02-18 13:49:29 -08:00
Maurice Parker 03c1ed2625 Make handling of programmatic feed selection when filtered or collapsed more consistent. Issues #1788 and #1792 2020-02-17 17:40:40 -08:00
Martin Hartl 83241cc329 Don’t show “Go to feed” action if already inside feed 2020-02-02 21:44:54 +01:00
Maurice Parker 6ac6136612 Make animations individually selectable and no longer animate navigation selections. Issue #1439 2020-01-27 21:57:52 -07:00
Maurice Parker deab8f8c6c Change to stop recycling the article view controller when switching panel modes on the iPad. Issue #1570 2020-01-21 11:05:47 -07:00
Maurice Parker d68eccc55e Exit search if Go To Feed is selected. Issue #1557 2020-01-15 17:53:12 -07:00
Brent Simmons 2df78f3cf1
Merge pull request #1605 from hartlco/1590-sharing-item-to-omnifocus-adds-extra-newline
Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things
2020-01-11 11:17:30 -08:00
Maurice Parker 21cf8415d2 Add confirmation for Mark As Read actions. Issue #1603 2020-01-11 11:30:16 -07:00
Martin Hartl c739d77817 Provide dedicated TitleActivityItemSource when sharing to Omnifocus and Things 2020-01-11 09:12:41 +01:00
Maurice Parker e93b916c50 Implement Refresh to Clear Articles option. Issue #1601 2020-01-10 18:14:21 -07:00
Maurice Parker edd299a36d Indicate that the header is a button when it is tappable. Issue #1583 2020-01-09 17:22:37 -07:00
Maurice Parker 3115abc72e Enhance accessibility for toggle toolbar buttons. Issue #1581 2020-01-09 14:38:25 -07:00
Maurice Parker b468bcfe58
Revert "Previewing articles" 2020-01-07 16:36:32 -07:00
Mihael Cholakov 593a802d79 Merge branch 'upstream-ios-candidate' into previewing-articles 2020-01-07 09:47:00 +02:00
Maurice Parker 746d061dcf Refresh UI (including progress indicator) on Timeline when coming out of suspend. 2020-01-06 21:23:39 -07:00
Maurice Parker c0f76d0dbb Change Mark All as Read icon. Issue #1526 2020-01-06 18:07:04 -07:00
Mihael Cholakov 36230d930e Context menu now previews selected article 2020-01-06 14:52:18 +02:00
Maurice Parker 5cd163e1e4 Add refresh indicator to the Timeline. Issue #15 2020-01-03 14:23:37 -07:00