Merge pull request #3223 from Wevah/favicon-fix

Fix favicons when a feed's homepage URL has non-ASCII in its path
This commit is contained in:
Maurice Parker 2021-07-20 13:10:16 -05:00 committed by GitHub
commit f4b99d0198
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions

View File

@ -200,7 +200,7 @@ private extension FaviconDownloader {
func findFaviconURLs(with homePageURL: String, _ completion: @escaping ([String]?) -> Void) {
guard let url = URL(string: homePageURL) else {
guard let url = URL(unicodeString: homePageURL) else {
completion(nil)
return
}

View File

@ -42,7 +42,7 @@ struct FaviconURLFinder {
/// - urls: An array of favicon URLs as strings.
static func findFaviconURLs(with homePageURL: String, _ completion: @escaping (_ urls: [String]?) -> Void) {
guard let _ = URL(string: homePageURL) else {
guard let _ = URL(unicodeString: homePageURL) else {
completion(nil)
return
}

View File

@ -15,7 +15,7 @@ struct HTMLMetadataDownloader {
static let serialDispatchQueue = DispatchQueue(label: "HTMLMetadataDownloader")
static func downloadMetadata(for url: String, _ completion: @escaping (RSHTMLMetadata?) -> Void) {
guard let actualURL = URL(string: url) else {
guard let actualURL = URL(unicodeString: url) else {
completion(nil)
return
}