From eb7ac0f076949edf3ac5a9736799f251fc759175 Mon Sep 17 00:00:00 2001 From: Rizwan Mohamed Ibrahim Date: Fri, 29 May 2020 15:44:32 +0530 Subject: [PATCH] fix open in app browser for mac and iOS --- Mac/MainWindow/MainWindowController.swift | 5 +++++ Shared/Resources/GlobalKeyboardShortcuts.plist | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Mac/MainWindow/MainWindowController.swift b/Mac/MainWindow/MainWindowController.swift index 4e2a74f88..0a862d4ea 100644 --- a/Mac/MainWindow/MainWindowController.swift +++ b/Mac/MainWindow/MainWindowController.swift @@ -273,6 +273,11 @@ class MainWindowController : NSWindowController, NSUserInterfaceValidations { openArticleInBrowser(sender) } + @objc func openFeedInAppBrowser(_ sender: Any?) { + // There is no In-App Browser for mac - so we use safari + openArticleInBrowser(sender) + } + @IBAction func openInBrowserUsingOppositeOfSettings(_ sender: Any?) { if let link = currentLink { Browser.open(link, inBackground: !AppDefaults.openInBrowserInBackground) diff --git a/Shared/Resources/GlobalKeyboardShortcuts.plist b/Shared/Resources/GlobalKeyboardShortcuts.plist index 7dab14cf5..ed8bc7e4d 100644 --- a/Shared/Resources/GlobalKeyboardShortcuts.plist +++ b/Shared/Resources/GlobalKeyboardShortcuts.plist @@ -110,7 +110,7 @@ key [return] action - openInBrowser: + openFeedInAppBrowser: key