FreshRSS/NetNewsWire
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add two missing expectation fulfillments

Browse Source 
It looks like two tests in FeedlySetStarredArticlesOperationTests
created but never referenced XCTestExpectation instances. Based on the
other nearby tests, add a call to `fulfill()` inside the associated
completion block after the rest of our test assertions are done.
This commit is contained in:
Tim Ekl 2019-12-31 19:41:32 -06:00
parent 6c10774c4a
commit e4c84bc501
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Frameworks/Account/AccountTests/Feedly/FeedlySetStarredArticlesOperationTests.swift
View File

@ -257,6 +257,7 @@ class FeedlySetStarredArticlesOperationTests: XCTestCase {
.map { $0.articleID }) .map { $0.articleID })
XCTAssertEqual(idsOfStarredArticles, remainingStarredIds) XCTAssertEqual(idsOfStarredArticles, remainingStarredIds)
fetchIdsExpectation.fulfill()
} catch let e { } catch let e {
XCTFail("Error checking articles IDs: \(e)") XCTFail("Error checking articles IDs: \(e)")
} }
@ -315,6 +316,7 @@ class FeedlySetStarredArticlesOperationTests: XCTestCase {
.map { $0.articleID }) .map { $0.articleID })
XCTAssertEqual(idsOfStarredArticles, remainingStarredIds) XCTAssertEqual(idsOfStarredArticles, remainingStarredIds)
fetchIdsExpectation.fulfill()
} catch let e { } catch let e {
XCTFail("Error checking articles IDs: \(e)") XCTFail("Error checking articles IDs: \(e)")
} }