mirror of
https://github.com/Ranchero-Software/NetNewsWire.git
synced 2025-01-09 16:32:46 +01:00
Fixes close button icon distortion
This bug was caused by an inaccessible property of UIButton. Since the button was setup in IB using a system button with a custom icon, it’s imageView property is only accessible in code. The “view” content-mode in IB is misleading here, as it affects the UIButton.view NOT UIButton.ImageView. - Set content-mode of the buttons imageview to scaleAspectFit.
This commit is contained in:
parent
feacda1c3b
commit
da64f65c7b
@ -10,6 +10,8 @@ import UIKit
|
|||||||
|
|
||||||
class ImageViewController: UIViewController {
|
class ImageViewController: UIViewController {
|
||||||
|
|
||||||
|
|
||||||
|
@IBOutlet weak var closeButton: UIButton!
|
||||||
@IBOutlet weak var shareButton: UIButton!
|
@IBOutlet weak var shareButton: UIButton!
|
||||||
@IBOutlet weak var imageScrollView: ImageScrollView!
|
@IBOutlet weak var imageScrollView: ImageScrollView!
|
||||||
@IBOutlet weak var titleLabel: UILabel!
|
@IBOutlet weak var titleLabel: UILabel!
|
||||||
@ -26,6 +28,8 @@ class ImageViewController: UIViewController {
|
|||||||
override func viewDidLoad() {
|
override func viewDidLoad() {
|
||||||
super.viewDidLoad()
|
super.viewDidLoad()
|
||||||
|
|
||||||
|
closeButton.imageView?.contentMode = .scaleAspectFit
|
||||||
|
|
||||||
imageScrollView.setup()
|
imageScrollView.setup()
|
||||||
imageScrollView.imageScrollViewDelegate = self
|
imageScrollView.imageScrollViewDelegate = self
|
||||||
imageScrollView.imageContentMode = .aspectFit
|
imageScrollView.imageContentMode = .aspectFit
|
||||||
@ -58,6 +62,9 @@ class ImageViewController: UIViewController {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@IBAction func done(_ sender: Any) {
|
@IBAction func done(_ sender: Any) {
|
||||||
|
if let button = sender as? UIButton {
|
||||||
|
print(button.frame.size)
|
||||||
|
}
|
||||||
dismiss(animated: true)
|
dismiss(animated: true)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -265,14 +265,16 @@
|
|||||||
<action selector="share:" destination="vO9-a3-Dnu" eventType="touchUpInside" id="m8y-Gs-YF1"/>
|
<action selector="share:" destination="vO9-a3-Dnu" eventType="touchUpInside" id="m8y-Gs-YF1"/>
|
||||||
</connections>
|
</connections>
|
||||||
</button>
|
</button>
|
||||||
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="cXR-ll-xBx">
|
<button opaque="NO" clipsSubviews="YES" contentMode="center" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="cXR-ll-xBx">
|
||||||
<rect key="frame" x="8" y="44" width="44" height="44"/>
|
<rect key="frame" x="8" y="44" width="44" height="44"/>
|
||||||
<constraints>
|
<constraints>
|
||||||
<constraint firstAttribute="height" constant="44" id="6kc-Gw-KbZ"/>
|
<constraint firstAttribute="height" constant="44" id="6kc-Gw-KbZ"/>
|
||||||
<constraint firstAttribute="width" constant="44" id="cBq-gs-WzN"/>
|
<constraint firstAttribute="width" constant="44" id="cBq-gs-WzN"/>
|
||||||
</constraints>
|
</constraints>
|
||||||
<color key="tintColor" name="primaryAccentColor"/>
|
<color key="tintColor" name="primaryAccentColor"/>
|
||||||
<state key="normal" image="multiply.circle.fill" catalog="system"/>
|
<state key="normal" image="multiply.circle.fill" catalog="system">
|
||||||
|
<preferredSymbolConfiguration key="preferredSymbolConfiguration" scale="large" weight="regular"/>
|
||||||
|
</state>
|
||||||
<connections>
|
<connections>
|
||||||
<action selector="done:" destination="vO9-a3-Dnu" eventType="touchUpInside" id="tgd-ov-4Ft"/>
|
<action selector="done:" destination="vO9-a3-Dnu" eventType="touchUpInside" id="tgd-ov-4Ft"/>
|
||||||
</connections>
|
</connections>
|
||||||
@ -300,6 +302,7 @@
|
|||||||
<viewLayoutGuide key="safeArea" id="mbY-02-GFL"/>
|
<viewLayoutGuide key="safeArea" id="mbY-02-GFL"/>
|
||||||
</view>
|
</view>
|
||||||
<connections>
|
<connections>
|
||||||
|
<outlet property="closeButton" destination="cXR-ll-xBx" id="sDG-49-joi"/>
|
||||||
<outlet property="imageScrollView" destination="msG-pz-EKk" id="dGi-M6-dcO"/>
|
<outlet property="imageScrollView" destination="msG-pz-EKk" id="dGi-M6-dcO"/>
|
||||||
<outlet property="shareButton" destination="RmY-a3-hUg" id="Z54-ah-WAI"/>
|
<outlet property="shareButton" destination="RmY-a3-hUg" id="Z54-ah-WAI"/>
|
||||||
<outlet property="titleBackground" destination="bHh-pW-oTS" id="o2K-cY-90c"/>
|
<outlet property="titleBackground" destination="bHh-pW-oTS" id="o2K-cY-90c"/>
|
||||||
|
Loading…
Reference in New Issue
Block a user