Make the Star toolbar button image static — don’t reflect what the command will do, since that’s opposite of state, and people get confused. Fix #451.

This commit is contained in:
Brent Simmons 2018-12-05 21:31:06 -08:00
parent 06f07593a7
commit ceb061f616
1 changed files with 3 additions and 3 deletions

View File

@ -521,9 +521,9 @@ private extension MainWindowController {
if let toolbarItem = item as? NSToolbarItem {
toolbarItem.toolTip = commandName
if let button = toolbarItem.view as? NSButton {
button.image = NSImage(named: starring ? .star : .unstar)
}
// if let button = toolbarItem.view as? NSButton {
// button.image = NSImage(named: starring ? .star : .unstar)
// }
}
if let menuItem = item as? NSMenuItem {