Remove synchronous sync database status insert function.

Account/Sources/Account/CloudKit/CloudKitAccountDelegate.swift

@@ -407,13 +407,13 @@ final class CloudKitAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account, showProgress: false) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

Account/Sources/Account/CloudKit/CloudKitArticlesZoneDelegate.swift

@@ -148,8 +148,9 @@ private extension CloudKitArticlesZoneDelegate {
 								return
 							}
 							let syncStatuses = deletes.map { SyncStatus(articleID: $0.articleID, key: .deleted, flag: true) }
-							try? self.database.insertStatuses(syncStatuses)
+							self.database.insertStatuses(syncStatuses) { _ in
 								group.leave()
+							}
 						case .failure(let databaseError):
 							errorOccurred = true
 							os_log(.error, log: self.log, "Error occurred while storing articles: %@", databaseError.localizedDescription)

Account/Sources/Account/FeedWrangler/FeedWranglerAccountDelegate.swift

@@ -443,13 +443,13 @@ final class FeedWranglerAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

Account/Sources/Account/Feedbin/FeedbinAccountDelegate.swift

@@ -542,13 +542,13 @@ final class FeedbinAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

Account/Sources/Account/Feedly/FeedlyAccountDelegate.swift

@@ -495,13 +495,13 @@ final class FeedlyAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

Account/Sources/Account/NewsBlur/NewsBlurAccountDelegate.swift

@@ -581,13 +581,13 @@ final class NewsBlurAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

Account/Sources/Account/ReaderAPI/ReaderAPIAccountDelegate.swift

@@ -472,13 +472,13 @@ final class ReaderAPIAccountDelegate: AccountDelegate {
 					return SyncStatus(articleID: article.articleID, key: SyncStatus.Key(statusKey), flag: flag)
 				}
 
-				try? self.database.insertStatuses(syncStatuses)
+				self.database.insertStatuses(syncStatuses) { _ in
-
 					self.database.selectPendingCount { result in
 						if let count = try? result.get(), count > 100 {
 							self.sendArticleStatus(for: account) { _ in }
 						}
 					}
+				}
 			case .failure(let error):
 				os_log(.error, log: self.log, "Error marking article status: %@", error.localizedDescription)
 			}

SyncDatabase/Sources/SyncDatabase/SyncDatabase.swift

@@ -32,10 +32,6 @@ public struct SyncDatabase {
 
 	// MARK: - API
 
-	public func insertStatuses(_ statuses: [SyncStatus]) throws {
-		try syncStatusTable.insertStatuses(statuses)
-	}
-	
 	public func insertStatuses(_ statuses: [SyncStatus], completion: @escaping DatabaseCompletionBlock) {
 		syncStatusTable.insertStatuses(statuses, completion: completion)
 	}

SyncDatabase/Sources/SyncDatabase/SyncStatusTable.swift

@@ -153,23 +153,6 @@ struct SyncStatusTable: DatabaseTable {
 		}
 	}
 	
-	func insertStatuses(_ statuses: [SyncStatus]) throws {
-		var error: DatabaseError?
-		queue.runInTransactionSync { databaseResult in
-			switch databaseResult {
-			case .success(let database):
-				let statusArray = statuses.map { $0.databaseDictionary() }
-				self.insertRows(statusArray, insertType: .orReplace, in: database)
-			case .failure(let databaseError):
-				error = databaseError
-			}
-		}
-		
-		if let error = error {
-			throw error
-		}
-	}
-
     func insertStatuses(_ statuses: [SyncStatus], completion: @escaping DatabaseCompletionBlock) {
 		queue.runInTransaction { databaseResult in
 
@@ -181,9 +164,9 @@ struct SyncStatusTable: DatabaseTable {
 			switch databaseResult {
 			case .success(let database):
 				makeDatabaseCall(database)
-				completion(nil)
+				callCompletion(completion, nil)
 			case .failure(let databaseError):
-				completion(databaseError)
+				callCompletion(completion, databaseError)
 			}
 		}
 	}