Fix Lint issues.

This commit is contained in:
Brent Simmons 2025-01-22 22:06:36 -08:00
parent cbea8acd9a
commit aea89148ff
8 changed files with 91 additions and 98 deletions

View File

@ -13,7 +13,7 @@ let package = Package(
.library(
name: "RSDatabaseObjC",
type: .dynamic,
targets: ["RSDatabaseObjC"]),
targets: ["RSDatabaseObjC"])
],
dependencies: [
],
@ -29,6 +29,6 @@ let package = Package(
),
.testTarget(
name: "RSDatabaseTests",
dependencies: ["RSDatabase"]),
dependencies: ["RSDatabase"])
]
)

View File

@ -152,7 +152,7 @@ public final class DatabaseQueue {
/// Use this to create tables, indexes, etc.
public func runCreateStatements(_ statements: String) throws {
precondition(Thread.isMainThread)
var error: DatabaseError? = nil
var error: DatabaseError?
runInDatabaseSync { result in
switch result {
case .success(let database):
@ -236,8 +236,7 @@ private extension DatabaseQueue {
autoreleasepool {
if _isSuspended {
databaseBlock(.failure(.isSuspended))
}
else {
} else {
if useTransaction {
database.beginTransaction()
}
@ -256,4 +255,3 @@ private extension DatabaseQueue {
database.setShouldCacheStatements(true)
}
}

View File

@ -50,12 +50,12 @@ public extension DatabaseTable {
func updateRowsWithValue(_ value: Any, valueKey: String, whereKey: String, matches: [Any], database: FMDatabase) {
let _ = database.rs_updateRows(withValue: value, valueKey: valueKey, whereKey: whereKey, inValues: matches, tableName: self.name)
_ = database.rs_updateRows(withValue: value, valueKey: valueKey, whereKey: whereKey, inValues: matches, tableName: self.name)
}
func updateRowsWithDictionary(_ dictionary: DatabaseDictionary, whereKey: String, matches: Any, database: FMDatabase) {
let _ = database.rs_updateRows(with: dictionary, whereKey: whereKey, equalsValue: matches, tableName: self.name)
_ = database.rs_updateRows(with: dictionary, whereKey: whereKey, equalsValue: matches, tableName: self.name)
}
// MARK: Saving
@ -63,7 +63,7 @@ public extension DatabaseTable {
func insertRows(_ dictionaries: [DatabaseDictionary], insertType: RSDatabaseInsertType, in database: FMDatabase) {
for oneDictionary in dictionaries {
let _ = database.rs_insertRow(with: oneDictionary, insertType: insertType, tableName: self.name)
_ = database.rs_insertRow(with: oneDictionary, insertType: insertType, tableName: self.name)
}
}
@ -136,4 +136,3 @@ public extension FMResultSet {
return Set(compactMap(completion))
}
}

View File

@ -64,8 +64,7 @@ public final class DatabaseLookupTable {
for object in objects {
if let relatedObjects = object.relatedObjectsWithName(relationshipName), !relatedObjects.isEmpty {
objectsWithRelationships += [object]
}
else {
} else {
objectsWithNoRelationships += [object]
}
}
@ -107,7 +106,7 @@ private extension DatabaseLookupTable {
let sql = "delete from \(name) where \(objectIDKey)=? and \(relatedObjectIDKey) in \(placeholders)"
let parameters: [Any] = [objectID] + Array(relatedObjectIDs)
let _ = database.executeUpdate(sql, withArgumentsIn: parameters)
_ = database.executeUpdate(sql, withArgumentsIn: parameters)
}
// MARK: Saving/Updating
@ -180,7 +179,7 @@ private extension DatabaseLookupTable {
for relatedObjectID in relatedObjectIDs {
let d: [NSObject: Any] = [(objectIDKey as NSString): objectID, (relatedObjectIDKey as NSString): relatedObjectID]
let _ = database.rs_insertRow(with: d, insertType: .orIgnore, tableName: name)
_ = database.rs_insertRow(with: d, insertType: .orIgnore, tableName: name)
}
}
@ -226,4 +225,3 @@ private extension DatabaseLookupTable {
return LookupValue(objectID: objectID, relatedObjectID: relatedObjectID)
}
}

View File

@ -39,8 +39,7 @@ public extension DatabaseRelatedObjectsTable {
for databaseID in databaseIDs {
if let cachedObject = cache[databaseID] {
cachedObjects += [cachedObject]
}
else {
} else {
databaseIDsToFetch.insert(databaseID)
}
}

View File

@ -28,8 +28,7 @@ struct RelatedObjectIDsMap {
let relatedObjectID: String = lookupValue.relatedObjectID
if d[objectID] == nil {
d[objectID] = Set([relatedObjectID])
}
else {
} else {
d[objectID]!.insert(relatedObjectID)
}
}