From 9ee16d35340b842890c0b83289e2e077c75ccef3 Mon Sep 17 00:00:00 2001
From: Maurice Parker <mo@vincode.io>
Date: Tue, 8 Dec 2020 00:48:24 -0600
Subject: [PATCH] Don't use a back ground queue for doing dictionary lookups. 
 Fixes #2656

---
 .../CloudKit/CloudKitArticlesZone.swift       | 55 +++++++++----------
 1 file changed, 26 insertions(+), 29 deletions(-)

diff --git a/Account/Sources/Account/CloudKit/CloudKitArticlesZone.swift b/Account/Sources/Account/CloudKit/CloudKitArticlesZone.swift
index cb33b8f62..f085654ab 100644
--- a/Account/Sources/Account/CloudKit/CloudKitArticlesZone.swift
+++ b/Account/Sources/Account/CloudKit/CloudKitArticlesZone.swift
@@ -115,38 +115,35 @@ final class CloudKitArticlesZone: CloudKitZone {
 		var newRecords = [CKRecord]()
 		var deleteRecordIDs = [CKRecord.ID]()
 		
-		DispatchQueue.global(qos: .utility).async {
-			
-			for statusUpdate in statusUpdates {
-				switch statusUpdate.record {
-				case .all:
-					modifyRecords.append(self.makeStatusRecord(statusUpdate))
-					modifyRecords.append(self.makeArticleRecord(statusUpdate.article!))
-				case .new:
-					newRecords.append(self.makeStatusRecord(statusUpdate))
-					newRecords.append(self.makeArticleRecord(statusUpdate.article!))
-				case .delete:
-					deleteRecordIDs.append(CKRecord.ID(recordName: self.statusID(statusUpdate.articleID), zoneID: Self.zoneID))
-				case .statusOnly:
-					modifyRecords.append(self.makeStatusRecord(statusUpdate))
-					deleteRecordIDs.append(CKRecord.ID(recordName: self.articleID(statusUpdate.articleID), zoneID: Self.zoneID))
-				}
+		for statusUpdate in statusUpdates {
+			switch statusUpdate.record {
+			case .all:
+				modifyRecords.append(self.makeStatusRecord(statusUpdate))
+				modifyRecords.append(self.makeArticleRecord(statusUpdate.article!))
+			case .new:
+				newRecords.append(self.makeStatusRecord(statusUpdate))
+				newRecords.append(self.makeArticleRecord(statusUpdate.article!))
+			case .delete:
+				deleteRecordIDs.append(CKRecord.ID(recordName: self.statusID(statusUpdate.articleID), zoneID: Self.zoneID))
+			case .statusOnly:
+				modifyRecords.append(self.makeStatusRecord(statusUpdate))
+				deleteRecordIDs.append(CKRecord.ID(recordName: self.articleID(statusUpdate.articleID), zoneID: Self.zoneID))
 			}
-			
-			self.modify(recordsToSave: modifyRecords, recordIDsToDelete: deleteRecordIDs) { result in
-				switch result {
-				case .success:
-					self.saveIfNew(newRecords) { result in
-						switch result {
-						case .success:
-							completion(.success(()))
-						case .failure(let error):
-							completion(.failure(error))
-						}
+		}
+		
+		self.modify(recordsToSave: modifyRecords, recordIDsToDelete: deleteRecordIDs) { result in
+			switch result {
+			case .success:
+				self.saveIfNew(newRecords) { result in
+					switch result {
+					case .success:
+						completion(.success(()))
+					case .failure(let error):
+						completion(.failure(error))
 					}
-				case .failure(let error):
-					self.handleModifyArticlesError(error, statusUpdates: statusUpdates, completion: completion)
 				}
+			case .failure(let error):
+				self.handleModifyArticlesError(error, statusUpdates: statusUpdates, completion: completion)
 			}
 		}
 	}