FreshRSS
/
NetNewsWire
mirror of https://github.com/Ranchero-Software/NetNewsWire.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only let one process renew the access token at a time for Reddit

This commit is contained in:
Maurice Parker 2020-07-21 18:20:13 -05:00
parent cf8c6f5e8e
commit 9d4f34bb7c
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Frameworks/Account/FeedProvider/Reddit/RedditFeedProvider.swift
View File

@ -50,6 +50,7 @@ public final class RedditFeedProvider: FeedProvider {
public var username: String?
private var refreshingAuthToken = false
private var oauthToken: String
private var oauthRefreshToken: String
@ -410,27 +411,37 @@ private extension RedditFeedProvider {
func handleFailure(error: OAuthSwiftError, completion: @escaping (Error?) -> Void) {
if case .tokenExpired = error {
if refreshingAuthToken {
DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
completion(nil)
}
}
refreshingAuthToken = true
os_log(.debug, log: self.log, "Access token expired, attempting to renew...")
oauthSwift?.renewAccessToken(withRefreshToken: oauthRefreshToken) { [weak self] result in
guard let strongSelf = self, let username = strongSelf.username else {
guard let self = self, let username = self.username else {
completion(nil)
return
}
switch result {
case .success(let tokenSuccess):
strongSelf.oauthToken = tokenSuccess.credential.oauthToken
strongSelf.oauthRefreshToken = tokenSuccess.credential.oauthRefreshToken
self.oauthToken = tokenSuccess.credential.oauthToken
self.oauthRefreshToken = tokenSuccess.credential.oauthRefreshToken
do {
try Self.storeCredentials(username: username, oauthToken: strongSelf.oauthToken, oauthRefreshToken: strongSelf.oauthRefreshToken)
os_log(.debug, log: strongSelf.log, "Access token renewed.")
try Self.storeCredentials(username: username, oauthToken: self.oauthToken, oauthRefreshToken: self.oauthRefreshToken)
os_log(.debug, log: self.log, "Access token renewed.")
} catch {
self.refreshingAuthToken = false
completion(error)
return
}
self.refreshingAuthToken = false
completion(nil)
case .failure(let oathError):
self.refreshingAuthToken = false
completion(oathError)
}
}