Merge pull request #836 from nostodnayr/master

Use proper quotes in timeline contextual menu
This commit is contained in:
Brent Simmons 2019-08-12 15:49:52 -07:00 committed by GitHub
commit 9bbd94d09a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -248,7 +248,7 @@ private extension TimelineViewController {
} }
func selectFeedInSidebarMenuItem(_ feed: Feed) -> NSMenuItem { func selectFeedInSidebarMenuItem(_ feed: Feed) -> NSMenuItem {
let localizedMenuText = NSLocalizedString("Select \"%@\" in Sidebar", comment: "Command") let localizedMenuText = NSLocalizedString("Select “%@” in Sidebar", comment: "Command")
let formattedMenuText = NSString.localizedStringWithFormat(localizedMenuText as NSString, feed.nameForDisplay) let formattedMenuText = NSString.localizedStringWithFormat(localizedMenuText as NSString, feed.nameForDisplay)
return menuItem(formattedMenuText as String, #selector(selectFeedInSidebarFromContextualMenu(_:)), feed) return menuItem(formattedMenuText as String, #selector(selectFeedInSidebarFromContextualMenu(_:)), feed)
} }
@ -260,7 +260,7 @@ private extension TimelineViewController {
return nil return nil
} }
let localizedMenuText = NSLocalizedString("Mark All as Read in \"%@\"", comment: "Command") let localizedMenuText = NSLocalizedString("Mark All as Read in “%@”", comment: "Command")
let menuText = NSString.localizedStringWithFormat(localizedMenuText as NSString, feed.nameForDisplay) as String let menuText = NSString.localizedStringWithFormat(localizedMenuText as NSString, feed.nameForDisplay) as String
return menuItem(menuText, #selector(markAllInFeedAsRead(_:)), articles) return menuItem(menuText, #selector(markAllInFeedAsRead(_:)), articles)