Change so that we only send 300 markers per request. Fixes #3711

This commit is contained in:
Maurice Parker 2022-10-28 15:53:26 -05:00
parent 6baee15007
commit 948b02d0ac

View File

@ -7,6 +7,7 @@
// //
import Foundation import Foundation
import RSCore
import RSWeb import RSWeb
import Secrets import Secrets
@ -820,33 +821,48 @@ extension FeedlyAPICaller: FeedlyMarkArticlesService {
fatalError("\(components) does not produce a valid URL.") fatalError("\(components) does not produce a valid URL.")
} }
var request = URLRequest(url: url) let articleIdChunks = Array(articleIds).chunked(into: 300)
request.httpMethod = "POST" let dispatchGroup = DispatchGroup()
request.addValue("application/json", forHTTPHeaderField: HTTPRequestHeader.contentType) var groupError: Error? = nil
request.addValue("application/json", forHTTPHeaderField: "Accept-Type")
request.addValue("OAuth \(accessToken)", forHTTPHeaderField: HTTPRequestHeader.authorization)
do { for articleIdChunk in articleIdChunks {
let body = MarkerEntriesBody(action: action.actionValue, entryIds: Array(articleIds))
let encoder = JSONEncoder() var request = URLRequest(url: url)
let data = try encoder.encode(body) request.httpMethod = "POST"
request.httpBody = data request.addValue("application/json", forHTTPHeaderField: HTTPRequestHeader.contentType)
} catch { request.addValue("application/json", forHTTPHeaderField: "Accept-Type")
return DispatchQueue.main.async { request.addValue("OAuth \(accessToken)", forHTTPHeaderField: HTTPRequestHeader.authorization)
completion(.failure(error))
do {
let body = MarkerEntriesBody(action: action.actionValue, entryIds: Array(articleIdChunk))
let encoder = JSONEncoder()
let data = try encoder.encode(body)
request.httpBody = data
} catch {
return DispatchQueue.main.async {
completion(.failure(error))
}
}
dispatchGroup.enter()
send(request: request, resultType: String.self, dateDecoding: .millisecondsSince1970, keyDecoding: .convertFromSnakeCase) { result in
switch result {
case .success(let (httpResponse, _)):
if httpResponse.statusCode != 200 {
groupError = URLError(.cannotDecodeContentData)
}
case .failure(let error):
groupError = error
}
dispatchGroup.leave()
} }
} }
send(request: request, resultType: String.self, dateDecoding: .millisecondsSince1970, keyDecoding: .convertFromSnakeCase) { result in dispatchGroup.notify(queue: .main) {
switch result { if let groupError = groupError {
case .success(let (httpResponse, _)): completion(.failure(groupError))
if httpResponse.statusCode == 200 { } else {
completion(.success(())) completion(.success(()))
} else {
completion(.failure(URLError(.cannotDecodeContentData)))
}
case .failure(let error):
completion(.failure(error))
} }
} }
} }