From f4cc6b1a09964261e845b1f528d815bc89fbe899 Mon Sep 17 00:00:00 2001 From: Marvin Scholz Date: Tue, 26 Dec 2017 01:56:17 +0100 Subject: [PATCH 1/3] Use more semantic HTML for tables --- .../KeyboardShortcuts/KeyboardShortcuts.html | 68 +++++++++++-------- 1 file changed, 40 insertions(+), 28 deletions(-) diff --git a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html index a606de66b..0835ca83a 100644 --- a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html +++ b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html @@ -15,14 +15,23 @@ table { width: 100%; line-height: 2.0em; + border-collapse: collapse; + margin-top: 1.0em; } - .tableTitleRow { - font-weight: bold; + table tr:nth-child(odd) { + background-color: #F0F0F0; + } + table tr td:first-child { + width: 60%; + } + table td { + padding: 0; + } + table caption { + text-align: left; + font-weight: bold; font-style: italic; } - .backgroundColorRow { - background-color: #F0F0F0; - } @@ -34,33 +43,36 @@

This way you can go through all your news via the space bar.

- +
+ - - - - - - - - - - - - + + + + + + + + + + + +
Everywhere…
Everywhere…
Scroll or go to next unreadspace bar
Go to next unread+
Mark as readr
Mark all as readk
Mark older articles as reado
Mark all as read, go to next unreadl (lowercase L)
Mark as unread, go to next unreadm
Mark as unreadu
Open in browserb or return or enter
Previous subscriptiona
Next subscriptionz
Scroll or go to next unreadspace bar
Go to next unread+
Mark as readr
Mark all as readk
Mark older articles as reado
Mark all as read, go to next unreadl (lowercase L)
Mark as unread, go to next unreadm
Mark as unreadu
Open in browserb or return or enter
Previous subscriptiona
Next subscriptionz
- 
-Left sidebar only… -Collapse, or option-leftArrow -Expand. or option-rightArrow -Collapse All (except for group items); or option-cmd-leftArrow -Expand All' or option-cmd-rightArrow -Move focus to headlinesrightArrow + + - - - + + + + + +
Left sidebar only…
 
Timeline only…
Move focus to subscriptionsleftArrow
Collapse, or option-leftArrow
Expand. or option-rightArrow
Collapse All (except for group items); or option-cmd-leftArrow
Expand All' or option-cmd-rightArrow
Move focus to headlinesrightArrow
+ + + +
Timeline only…
Move focus to subscriptionsleftArrow
From 99a6f45e48d2bff226155f48ece74502d9cfa635 Mon Sep 17 00:00:00 2001 From: Marvin Scholz Date: Tue, 26 Dec 2017 02:31:11 +0100 Subject: [PATCH 2/3] Use kbd element for shortcut keys and style accordingly --- .../KeyboardShortcuts/KeyboardShortcuts.html | 43 +++++++++++-------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html index 0835ca83a..a7443e303 100644 --- a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html +++ b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html @@ -32,6 +32,15 @@ font-weight: bold; font-style: italic; } + kbd { + font-family: monospace, -apple-system; + background: #FFF; + padding: 2px; + margin: 0 4px 0 2px; + border: solid #333 1px; + border-radius: 3px; + box-shadow: 2px 2px 0px 0px rgba(0,0,0,0.75); + } @@ -46,33 +55,33 @@ - - - - - - - - - - - + + + + + + + + + + +
Everywhere…
Scroll or go to next unreadspace bar
Go to next unread+
Mark as readr
Mark all as readk
Mark older articles as reado
Mark all as read, go to next unreadl (lowercase L)
Mark as unread, go to next unreadm
Mark as unreadu
Open in browserb or return or enter
Previous subscriptiona
Next subscriptionz
Scroll or go to next unreadspace
Go to next unread+
Mark as readr
Mark all as readk
Mark older articles as reado
Mark all as read, go to next unreadl (lowercase L)
Mark as unread, go to next unreadm
Mark as unreadu
Open in browserb or ⏎ or Enter
Previous subscriptiona
Next subscriptionz
- - - - - + + + + +
Left sidebar only…
Collapse, or option-leftArrow
Expand. or option-rightArrow
Collapse All (except for group items); or option-cmd-leftArrow
Expand All' or option-cmd-rightArrow
Move focus to headlinesrightArrow
Collapse, or ⌥+←
Expand. or ⌥+→
Collapse All (except for group items); or ⌥+⌘+←
Expand All' or ⌥+⌘+→
Move focus to headlines→
- +
Timeline only…
Move focus to subscriptionsleftArrow
Move focus to subscriptions←
From 9f27022c06999ec6f41a3e41680773de8f0c0bb0 Mon Sep 17 00:00:00 2001 From: Marvin Scholz Date: Tue, 26 Dec 2017 02:31:43 +0100 Subject: [PATCH 3/3] Remove shortcut explanation that should be obvious with new styling --- Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html index a7443e303..7459e2c69 100644 --- a/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html +++ b/Evergreen/Resources/KeyboardShortcuts/KeyboardShortcuts.html @@ -60,7 +60,7 @@ Mark as readr Mark all as readk Mark older articles as reado - Mark all as read, go to next unreadl (lowercase L) + Mark all as read, go to next unreadl Mark as unread, go to next unreadm Mark as unreadu Open in browserb or ⏎ or Enter