Merge pull request #3163 from stuartbreckenridge/main

Password Updates

Mac/Preferences/Accounts/AccountsFeedWranglerWindowController.swift

@@ -41,7 +41,7 @@ class AccountsFeedWranglerWindowController: NSWindowController {
 			actionButton.title = NSLocalizedString("Create", comment: "Create")
 			signInTextField.stringValue = NSLocalizedString("Sign in to your Feed Wrangler account.", comment: "SignIn")
 		}
-
+		enableAutofill()
 		usernameTextField.becomeFirstResponder()
 	}
 	
@@ -126,4 +126,12 @@ class AccountsFeedWranglerWindowController: NSWindowController {
 		NSWorkspace.shared.open(URL(string: "https://feedwrangler.net/users/new")!)
 	}
 	
+	// MARK: Autofill
+	func enableAutofill() {
+		if #available(macOS 11, *) {
+			usernameTextField.contentType = .username
+			passwordTextField.contentType = .password
+		}
+	}
+	
 }

Mac/Preferences/Accounts/AccountsFeedbinWindowController.swift

@@ -41,7 +41,9 @@ class AccountsFeedbinWindowController: NSWindowController {
 			actionButton.title = NSLocalizedString("Create", comment: "Add Account")
 			signInTextField.stringValue = NSLocalizedString("Sign in to your Feedbin account.", comment: "SignIn")
 		}
-
+		
+		enableAutofill()
+		
 		usernameTextField.becomeFirstResponder()
 	}
 	
@@ -129,5 +131,12 @@ class AccountsFeedbinWindowController: NSWindowController {
 		NSWorkspace.shared.open(URL(string: "https://feedbin.com/signup")!)
 	}
 	
-    
+	// MARK: Autofill
+	func enableAutofill() {
+		if #available(macOS 11, *) {
+			usernameTextField.contentType = .username
+			passwordTextField.contentType = .password
+		}
+	}
+	
 }

Mac/Preferences/Accounts/AccountsNewsBlurWindowController.swift

@@ -41,7 +41,7 @@ class AccountsNewsBlurWindowController: NSWindowController {
 			actionButton.title = NSLocalizedString("Create", comment: "Create")
 			signInTextField.stringValue = NSLocalizedString("Sign in to your NewsBlur account.", comment: "SignIn")
 		}
-
+		enableAutofill()
 		usernameTextField.becomeFirstResponder()
 	}
 
@@ -127,4 +127,12 @@ class AccountsNewsBlurWindowController: NSWindowController {
 		NSWorkspace.shared.open(URL(string: "https://newsblur.com")!)
 	}
 	
+	// MARK: Autofill
+	func enableAutofill() {
+		if #available(macOS 11, *) {
+			usernameTextField.contentType = .username
+			passwordTextField.contentType = .password
+		}
+	}
+	
 }

Mac/Preferences/Accounts/AccountsReaderAPIWindowController.swift

@@ -72,6 +72,7 @@ class AccountsReaderAPIWindowController: NSWindowController {
 			actionButton.title = NSLocalizedString("Create", comment: "Create")
 		}
 		
+		enableAutofill()
 		usernameTextField.becomeFirstResponder()
 	}
 	
@@ -194,5 +195,12 @@ class AccountsReaderAPIWindowController: NSWindowController {
 		}
 	}
 	
+	// MARK: Autofill
+	func enableAutofill() {
+		if #available(macOS 11, *) {
+			usernameTextField.contentType = .username
+			passwordTextField.contentType = .password
+		}
+	}
     
 }

iOS/Account/FeedWranglerAccountViewController.swift

@@ -158,7 +158,7 @@ class FeedWranglerAccountViewController: UITableViewController {
 	}
 	
 	@IBAction func retrievePasswordDetailsFrom1Password(_ sender: Any) {
-		OnePasswordExtension.shared().findLogin(forURLString: "feedwrangler.com", for: self, sender: nil) { [self] loginDictionary, error in
+		OnePasswordExtension.shared().findLogin(forURLString: "feedwrangler.com", for: self, sender: sender) { [self] loginDictionary, error in
 			if let loginDictionary = loginDictionary {
 				emailTextField.text = loginDictionary[AppExtensionUsernameKey] as? String
 				passwordTextField.text = loginDictionary[AppExtensionPasswordKey] as? String

iOS/Account/FeedbinAccountViewController.swift

@@ -81,7 +81,7 @@ class FeedbinAccountViewController: UITableViewController {
 	}
 	
 	@IBAction func retrievePasswordDetailsFrom1Password(_ sender: Any) {
-		OnePasswordExtension.shared().findLogin(forURLString: "feedbin.com", for: self, sender: nil) { [self] loginDictionary, error in
+		OnePasswordExtension.shared().findLogin(forURLString: "feedbin.com", for: self, sender: self) { [self] loginDictionary, error in
 			if let loginDictionary = loginDictionary {
 				emailTextField.text = loginDictionary[AppExtensionUsernameKey] as? String
 				passwordTextField.text = loginDictionary[AppExtensionPasswordKey] as? String

iOS/Account/NewsBlurAccountViewController.swift

@@ -159,7 +159,7 @@ class NewsBlurAccountViewController: UITableViewController {
 	}
 	
 	@IBAction func retrievePasswordDetailsFrom1Password(_ sender: Any) {
-		OnePasswordExtension.shared().findLogin(forURLString: "newsblur.com", for: self, sender: nil) { [self] loginDictionary, error in
+		OnePasswordExtension.shared().findLogin(forURLString: "newsblur.com", for: self, sender: sender) { [self] loginDictionary, error in
 			if let loginDictionary = loginDictionary {
 				usernameTextField.text = loginDictionary[AppExtensionUsernameKey] as? String
 				passwordTextField.text = loginDictionary[AppExtensionPasswordKey] as? String

iOS/Account/ReaderAPIAccountViewController.swift

@@ -284,7 +284,7 @@ class ReaderAPIAccountViewController: UITableViewController {
 				url = ""
 		}
 		
-		OnePasswordExtension.shared().findLogin(forURLString: url, for: self, sender: nil) { [self] loginDictionary, error in
+		OnePasswordExtension.shared().findLogin(forURLString: url, for: self, sender: sender) { [self] loginDictionary, error in
 			if let loginDictionary = loginDictionary {
 				usernameTextField.text = loginDictionary[AppExtensionUsernameKey] as? String
 				passwordTextField.text = loginDictionary[AppExtensionPasswordKey] as? String

xcconfig/NetNewsWire_iOSapp_target.xcconfig

@@ -42,6 +42,5 @@ CODE_SIGN_ENTITLEMENTS = iOS/Resources/NetNewsWire$(DEVELOPER_ENTITLEMENTS).enti
 PRODUCT_BUNDLE_IDENTIFIER = $(ORGANIZATION_IDENTIFIER).NetNewsWire.iOS
 PRODUCT_NAME = NetNewsWire
 CLANG_ENABLE_MODULES = YES
-LD_RUNPATH_SEARCH_PATHS = ("$(inherited)","@executable_path/Frameworks",)
 SWIFT_OBJC_BRIDGING_HEADER = iOS/Resources/NetNewsWire-iOS-Bridging-Header.h
 SWIFT_VERSION = 5.0