FreshRSS/NetNewsWire
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make Article a class, which boosts performance by not having to init/destroy Article all time.

Browse Source
This commit is contained in:
Brent Simmons 2024-09-29 10:36:34 -07:00
parent 7689326d56
commit 75e525380b
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Modules/Articles/Sources/Articles/Article.swift
View File

@ -10,7 +10,7 @@ import Foundation
public typealias ArticleSetBlock = (Set<Article>) -> Void
public struct Article: Hashable, Sendable {
public final class Article: Hashable, Sendable {
public let articleID: String // Unique database ID (possibly sync service ID)
public let accountID: String
@ -83,7 +83,6 @@ public extension Set where Element == Article {
func contains(accountID: String, articleID: String) -> Bool {
return contains(where: { $0.accountID == accountID && $0.articleID == articleID})
}
}
public extension Array where Element == Article {

4
Modules/ArticlesDatabase/Sources/ArticlesDatabase/Extensions/Article+Database.swift
View File

@ -14,7 +14,7 @@ import FMDB
extension Article {
init?(accountID: String, row: FMResultSet, status: ArticleStatus) {
convenience init?(accountID: String, row: FMResultSet, status: ArticleStatus) {
guard let articleID = row.string(forColumn: DatabaseKey.articleID) else {
assertionFailure("Expected articleID.")
return nil
@ -41,7 +41,7 @@ extension Article {
self.init(accountID: accountID, articleID: articleID, feedID: feedID, uniqueID: uniqueID, title: title, contentHTML: contentHTML, contentText: contentText, url: url, externalURL: externalURL, summary: summary, imageURL: imageURL, datePublished: datePublished, dateModified: dateModified, authors: nil, status: status)
}
init(parsedItem: ParsedItem, maximumDateAllowed: Date, accountID: String, feedID: String, status: ArticleStatus) {
convenience init(parsedItem: ParsedItem, maximumDateAllowed: Date, accountID: String, feedID: String, status: ArticleStatus) {
let authors = Author.authorsWithParsedAuthors(parsedItem.authors)
// Deal with future datePublished and dateModified dates.