From 6797766352c93e511c334fc2aebab0f1310fe702 Mon Sep 17 00:00:00 2001 From: Brent Simmons Date: Sun, 29 Sep 2024 11:56:44 -0700 Subject: [PATCH] =?UTF-8?q?Change=20assertionFailure=20to=20log.=20(It?= =?UTF-8?q?=E2=80=99s=20not=20really=20an=20error=20=E2=80=94=C2=A0it?= =?UTF-8?q?=E2=80=99s=20just=20a=20thing=20that=20can=20happen.)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Modules/Parser/Sources/Parser/HTMLParser/HTMLLinkParser.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Modules/Parser/Sources/Parser/HTMLParser/HTMLLinkParser.swift b/Modules/Parser/Sources/Parser/HTMLParser/HTMLLinkParser.swift index d084860d4..baedb6ce7 100644 --- a/Modules/Parser/Sources/Parser/HTMLParser/HTMLLinkParser.swift +++ b/Modules/Parser/Sources/Parser/HTMLParser/HTMLLinkParser.swift @@ -7,10 +7,12 @@ import Foundation import FoundationExtras +import os public final class HTMLLinkParser { public private(set) var links = [HTMLLink]() + nonisolated(unsafe) private static let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, category: "HTMLLinkParser") private let parserData: ParserData private let baseURL: URL? @@ -61,7 +63,7 @@ extension HTMLLinkParser: SAXHTMLParserDelegate { } guard let baseURL, let absoluteURL = URL(string: href, relativeTo: baseURL) else { - assertionFailure("Expected to create URL") + Self.logger.info("Expected to create URL but got nil with \(href)") return nil }