From 6527ac852c7b61b136bc2c7a3d8474d641c597b4 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Thu, 13 Jun 2019 14:50:41 -0500 Subject: [PATCH] Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 --- Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift b/Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift index 935b97458..a42a522b9 100644 --- a/Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift +++ b/Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift @@ -327,9 +327,10 @@ private extension SidebarOutlineDataSource { BatchUpdate.shared.start() source.account?.moveFeed(feed, from: source, to: destination) { result in + BatchUpdate.shared.end() switch result { case .success: - BatchUpdate.shared.end() + break case .failure(let error): NSApplication.shared.presentError(error) } @@ -389,6 +390,7 @@ private extension SidebarOutlineDataSource { } } case .failure(let error): + BatchUpdate.shared.end() NSApplication.shared.presentError(error) } } @@ -409,6 +411,7 @@ private extension SidebarOutlineDataSource { } } case .failure(let error): + BatchUpdate.shared.end() NSApplication.shared.presentError(error) } }