From 108da4ccf458d7bd0b90f1cc52ba8b1e2e3eacb6 Mon Sep 17 00:00:00 2001 From: Rizwan Mohamed Ibrahim Date: Tue, 21 Apr 2020 21:35:26 +0530 Subject: [PATCH 1/2] Fix buttons a11y label for close and share button for image vc Image View Controller buttons both close and share don't have correct a11y label. This will add the localised label --- iOS/Article/ImageViewController.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iOS/Article/ImageViewController.swift b/iOS/Article/ImageViewController.swift index 79285d4fb..91d8a17d9 100644 --- a/iOS/Article/ImageViewController.swift +++ b/iOS/Article/ImageViewController.swift @@ -29,6 +29,8 @@ class ImageViewController: UIViewController { super.viewDidLoad() closeButton.imageView?.contentMode = .scaleAspectFit + closeButton.accessibilityLabel = NSLocalizedString("Close", comment: "Close") + shareButton.accessibilityLabel = NSLocalizedString("Share", comment: "Share") imageScrollView.setup() imageScrollView.imageScrollViewDelegate = self From 2454b807bb496d60c091b11605c1e5e2e98ae547 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Tue, 21 Apr 2020 20:23:46 -0500 Subject: [PATCH 2/2] Always update the status sync timer when returning to the foreground. Issue #2005 --- iOS/AppDelegate.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iOS/AppDelegate.swift b/iOS/AppDelegate.swift index e6f25a9ce..0dd99bad3 100644 --- a/iOS/AppDelegate.swift +++ b/iOS/AppDelegate.swift @@ -157,13 +157,13 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD func prepareAccountsForForeground() { extensionFeedAddRequestFile.resume() - + syncTimer?.update() + if let lastRefresh = AppDefaults.lastRefresh { if Date() > lastRefresh.addingTimeInterval(15 * 60) { AccountManager.shared.refreshAll(errorHandler: ErrorHandler.log) } else { AccountManager.shared.syncArticleStatusAll() - syncTimer?.update() } } else { AccountManager.shared.refreshAll(errorHandler: ErrorHandler.log)