Fix concurrency warning.

Account/Sources/Account/CloudKit/CloudKitArticlesZoneDelegate.swift

@@ -24,7 +24,6 @@ final class CloudKitArticlesZoneDelegate: CloudKitZoneDelegate {
 	weak var account: Account?
 	var database: SyncDatabase
 	weak var articlesZone: CloudKitArticlesZone?
-	var compressionQueue = DispatchQueue(label: "Articles Zone Delegate Compression Queue")
 
 	init(account: Account, database: SyncDatabase, articlesZone: CloudKitArticlesZone) {
 		self.account = account
@@ -42,13 +41,13 @@ final class CloudKitArticlesZoneDelegate: CloudKitZoneDelegate {
 
 				await self.delete(recordKeys: deleted, pendingStarredStatusArticleIDs: pendingStarredStatusArticleIDs)
 
-				self.update(records: changed,
+				try await self.update(records: changed,
 							pendingReadStatusArticleIDs: pendingReadStatusArticleIDs,
-							pendingStarredStatusArticleIDs: pendingStarredStatusArticleIDs,
+							pendingStarredStatusArticleIDs: pendingStarredStatusArticleIDs)
-							completion: completion)
+				completion(.success(()))
 
 			} catch {
-				os_log(.error, log: self.log, "Error occurred getting pending status records: %@", error.localizedDescription)
+				os_log(.error, log: self.log, "Error in CloudKitArticlesZoneDelegate.cloudKitDidModify: %@", error.localizedDescription)
 				completion(.failure(CloudKitZoneError.unknown))
 			}
 		}
@@ -71,7 +70,7 @@ private extension CloudKitArticlesZoneDelegate {
 		try? await account?.delete(articleIDs: deletableArticleIDs)
 	}
 
-	@MainActor func update(records: [CKRecord], pendingReadStatusArticleIDs: Set<String>, pendingStarredStatusArticleIDs: Set<String>, completion: @escaping (Result<Void, Error>) -> Void) {
+	@MainActor private func update(records: [CKRecord], pendingReadStatusArticleIDs: Set<String>, pendingStarredStatusArticleIDs: Set<String>) async throws {
 
 		let receivedUnreadArticleIDs = Set(records.filter({ $0[CloudKitArticlesZone.CloudKitArticleStatus.Fields.read] == "0" }).map({ stripPrefix($0.externalID) }))
 		let receivedReadArticleIDs =  Set(records.filter({ $0[CloudKitArticlesZone.CloudKitArticleStatus.Fields.read] == "1" }).map({ stripPrefix($0.externalID) }))
@@ -83,8 +82,6 @@ private extension CloudKitArticlesZoneDelegate {
 		let updateableUnstarredArticleIDs = receivedUnstarredArticleIDs.subtracting(pendingStarredStatusArticleIDs)
 		let updateableStarredArticleIDs = receivedStarredArticleIDs.subtracting(pendingStarredStatusArticleIDs)
 
-		Task { @MainActor in
-
 		var errorOccurred = false
 
 		do {
@@ -115,47 +112,28 @@ private extension CloudKitArticlesZoneDelegate {
 			os_log(.error, log: self.log, "Error occurred while storing starred statuses: %@", error.localizedDescription)
 		}
 
-			let group = DispatchGroup()
+		let parsedItems = await Self.makeParsedItems(records)
-			group.enter()
-
-			compressionQueue.async {
-				let parsedItems = records.compactMap { Self.makeParsedItem($0) }
 		let feedIDsAndItems = Dictionary(grouping: parsedItems, by: { item in item.feedURL } ).mapValues { Set($0) }
 
-				Task { @MainActor in
 		for (feedID, parsedItems) in feedIDsAndItems {
-						group.enter()
 
 			do {
-
 				let articleChanges = try await self.account?.update(feedID: feedID, with: parsedItems, deleteOlder: false)
-
 				guard let deletes = articleChanges?.deletedArticles, !deletes.isEmpty else {
-								group.leave()
+					continue
-								return
 				}
 
 				let syncStatuses = deletes.map { SyncStatus(articleID: $0.articleID, key: .deleted, flag: true) }
 				try? await self.database.insertStatuses(syncStatuses)
-							group.leave()
 
 			} catch {
 				errorOccurred = true
 				os_log(.error, log: self.log, "Error occurred while storing articles: %@", error.localizedDescription)
-							group.leave()
-						}
-					}
-					group.leave()
 			}
 		}
 
-			group.notify(queue: DispatchQueue.main) {
 		if errorOccurred {
-					completion(.failure(CloudKitZoneError.unknown))
+			throw CloudKitZoneError.unknown
-				} else {
-					completion(.success(()))
-				}
-			}
 		}
 	}
 
@@ -163,6 +141,16 @@ private extension CloudKitArticlesZoneDelegate {
 		return String(externalID[externalID.index(externalID.startIndex, offsetBy: 2)..<externalID.endIndex])
 	}
 
+	private static func makeParsedItems(_ articleRecords: [CKRecord]) async -> Set<ParsedItem> {
+
+		let task = Task.detached { () -> Set<ParsedItem> in
+			let parsedItems = articleRecords.compactMap { makeParsedItem($0) }
+			return Set(parsedItems)
+		}
+
+		return await task.value
+	}
+
 	static func makeParsedItem(_ articleRecord: CKRecord) -> ParsedItem? {
 		guard articleRecord.recordType == CloudKitArticlesZone.CloudKitArticle.recordType else {
 			return nil